René's URL Explorer Experiment


Title: fs: guarantee order of callbacks in ws.close by mcollina · Pull Request #18002 · nodejs/node · GitHub

Open Graph Title: fs: guarantee order of callbacks in ws.close by mcollina · Pull Request #18002 · nodejs/node

X Title: fs: guarantee order of callbacks in ws.close by mcollina · Pull Request #18002 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refactor WriteStream.prototype.close and WriteStream.prototype._destroy to always call the callback passed to close in order. Protects from calling .close() without a callback. Fixes: #17951 See: #...

X Description: Refactor WriteStream.prototype.close and WriteStream.prototype._destroy to always call the callback passed to close in order. Protects from calling .close() without a callback. Fixes: #17951 See: #...

Opengraph URL: https://github.com/nodejs/node/pull/18002

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6df10f55-92f7-1b01-df89-9109ce32d199
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1B0:162B2:683A8BA:9319DAA:6A4FF4D1
html-safe-nonce41fa2ea7e32eb982df5f00dee2b44a1712dc7bbf94dc2029ed1a671ecaf52304
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUIwOjE2MkIyOjY4M0E4QkE6OTMxOURBQTo2QTRGRjREMSIsInZpc2l0b3JfaWQiOiIzODU4NDM5OTQyOTQzMjc0MTkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdf800840cf9f586790f21cd2d7c9529c0b837a496788f49e36a5df6a18a255a2
hovercard-subject-tagpull_request:161303891
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/18002/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/15d1285ec0ba4fae6d9d8a090a0e408bea397ab65883313456df46864417cc18/nodejs/node/pull/18002
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/15d1285ec0ba4fae6d9d8a090a0e408bea397ab65883313456df46864417cc18/nodejs/node/pull/18002
og:image:altRefactor WriteStream.prototype.close and WriteStream.prototype._destroy to always call the callback passed to close in order. Protects from calling .close() without a callback. Fixes: #17951 See: #...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemcollina
hostnamegithub.com
expected-hostnamegithub.com
None3bd0ff5d28a87b4801a63fb38c2a21a91b0a700dca159dc9416aeae05771b899
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release67a336083e4dcb40224dc2c01cd4c7ed413bdb09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/18002#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18002
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18002
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/18002
Reloadhttps://github.com/nodejs/node/pull/18002
Reloadhttps://github.com/nodejs/node/pull/18002
Please reload this pagehttps://github.com/nodejs/node/pull/18002
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/18002
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 976 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mcollinahttps://github.com/mcollina
nodejs:masterhttps://github.com/nodejs/node/tree/master
mcollina:fix-17951https://github.com/mcollina/node/tree/fix-17951
Conversationhttps://github.com/nodejs/node/pull/18002
Commits1 (1)https://github.com/nodejs/node/pull/18002/commits
Checkshttps://github.com/nodejs/node/pull/18002/checks
Files changedhttps://github.com/nodejs/node/pull/18002/files
fs: guarantee order of callbacks in ws.closehttps://github.com/nodejs/node/pull/18002#top
mcollinahttps://github.com/mcollina
nodejs:masterhttps://github.com/nodejs/node/tree/master
mcollina:fix-17951https://github.com/mcollina/node/tree/fix-17951
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 5, 2018https://github.com/nodejs/node/pull/18002#issue-286239275
#17951https://github.com/nodejs/node/issues/17951
#15407https://github.com/nodejs/node/pull/15407
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/18002
https://github.com/mcollina
mcollinahttps://github.com/mcollina
bnoordhuishttps://github.com/bnoordhuis
January 5, 2018 09:46https://github.com/nodejs/node/pull/18002#event-1410985091
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Jan 5, 2018https://github.com/nodejs/node/pull/18002#event-1410985173
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 5, 2018https://github.com/nodejs/node/pull/18002#issuecomment-355514580
#17951https://github.com/nodejs/node/issues/17951
#15407https://github.com/nodejs/node/pull/15407
Please reload this pagehttps://github.com/nodejs/node/pull/18002
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 5, 2018https://github.com/nodejs/node/pull/18002#issuecomment-355514830
https://ci.nodejs.org/job/node-test-pull-request/12413/https://ci.nodejs.org/job/node-test-pull-request/12413/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1188/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1188/
Please reload this pagehttps://github.com/nodejs/node/pull/18002
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 5, 2018 https://github.com/nodejs/node/pull/18002#pullrequestreview-86871515
View reviewed changes https://github.com/nodejs/node/pull/18002/files
lib/fs.jshttps://github.com/nodejs/node/pull/18002/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
bnoordhuishttps://github.com/bnoordhuis
Jan 5, 2018https://github.com/nodejs/node/pull/18002#discussion_r159851192
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18002
mcollinahttps://github.com/mcollina
Jan 5, 2018https://github.com/nodejs/node/pull/18002#discussion_r159856980
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18002
https://github.com/mcollina
mcollinahttps://github.com/mcollina
force-pushedhttps://github.com/nodejs/node/compare/09d3ae0d1bf165e15d4e242842582087567b3cab..955621349a74095a72e91b1d39115be6d554061d
09d3ae0https://github.com/nodejs/node/commit/09d3ae0d1bf165e15d4e242842582087567b3cab
9556213https://github.com/nodejs/node/commit/955621349a74095a72e91b1d39115be6d554061d
Compare https://github.com/nodejs/node/compare/09d3ae0d1bf165e15d4e242842582087567b3cab..955621349a74095a72e91b1d39115be6d554061d
January 5, 2018 11:28https://github.com/nodejs/node/pull/18002#event-1411127300
https://github.com/mcollina
fs: guarantee order of callbacks in ws.closehttps://github.com/nodejs/node/pull/18002/commits/0a4854dbec67e5a40c7a2de3ce7b26fc8ec84b39
0a4854dhttps://github.com/nodejs/node/pull/18002/commits/0a4854dbec67e5a40c7a2de3ce7b26fc8ec84b39
nodejs#17951https://github.com/nodejs/node/issues/17951
nodejs#15407https://github.com/nodejs/node/pull/15407
https://github.com/mcollina
mcollinahttps://github.com/mcollina
force-pushedhttps://github.com/nodejs/node/compare/955621349a74095a72e91b1d39115be6d554061d..0a4854dbec67e5a40c7a2de3ce7b26fc8ec84b39
9556213https://github.com/nodejs/node/commit/955621349a74095a72e91b1d39115be6d554061d
0a4854dhttps://github.com/nodejs/node/commit/0a4854dbec67e5a40c7a2de3ce7b26fc8ec84b39
Compare https://github.com/nodejs/node/compare/955621349a74095a72e91b1d39115be6d554061d..0a4854dbec67e5a40c7a2de3ce7b26fc8ec84b39
January 5, 2018 11:29https://github.com/nodejs/node/pull/18002#event-1411128394
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 5, 2018 https://github.com/nodejs/node/pull/18002#pullrequestreview-86953828
View reviewed changes https://github.com/nodejs/node/pull/18002/files/0a4854dbec67e5a40c7a2de3ce7b26fc8ec84b39
https://github.com/mcollina
mcollinahttps://github.com/mcollina
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Jan 8, 2018https://github.com/nodejs/node/pull/18002#event-1413246246
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 8, 2018https://github.com/nodejs/node/pull/18002#issuecomment-355913467
acf56behttps://github.com/nodejs/node/commit/acf56be536ee67e3696f3c2b097cfd176d3d76c6
Please reload this pagehttps://github.com/nodejs/node/pull/18002
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 8, 2018https://github.com/nodejs/node/pull/18002#event-1413246602
https://github.com/mcollina
mcollinahttps://github.com/mcollina
January 8, 2018 09:08https://github.com/nodejs/node/pull/18002#event-1413246673
mcollinahttps://github.com/mcollina
Jan 8, 2018 https://github.com/nodejs/node/pull/18002#ref-commit-acf56be
https://github.com/mcollina
fs: guarantee order of callbacks in ws.closehttps://github.com/nodejs/node/commit/acf56be536ee67e3696f3c2b097cfd176d3d76c6
acf56behttps://github.com/nodejs/node/commit/acf56be536ee67e3696f3c2b097cfd176d3d76c6
#17951https://github.com/nodejs/node/issues/17951
#15407https://github.com/nodejs/node/pull/15407
#18002https://github.com/nodejs/node/pull/18002
#17951https://github.com/nodejs/node/issues/17951
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 9, 2018https://github.com/nodejs/node/pull/18002#issuecomment-356405649
@MylesBorinshttps://github.com/MylesBorins
Please reload this pagehttps://github.com/nodejs/node/pull/18002
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018https://github.com/nodejs/node/pull/18002#issuecomment-356415459
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/18002
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018 https://github.com/nodejs/node/pull/18002#ref-commit-4dc53f5
https://github.com/mcollina
https://github.com/MylesBorins
fs: guarantee order of callbacks in ws.closehttps://github.com/nodejs/node/commit/4dc53f5c94590e228eb576f16969eddd158720e4
4dc53f5https://github.com/nodejs/node/commit/4dc53f5c94590e228eb576f16969eddd158720e4
#17951https://github.com/nodejs/node/issues/17951
#15407https://github.com/nodejs/node/pull/15407
#18002https://github.com/nodejs/node/pull/18002
#17951https://github.com/nodejs/node/issues/17951
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 9, 2018https://github.com/nodejs/node/pull/18002#issuecomment-356418942
Please reload this pagehttps://github.com/nodejs/node/pull/18002
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 10, 2018 https://github.com/nodejs/node/pull/18002#ref-pullrequest-287276543
v9.4.0 proposal #18069 https://github.com/nodejs/node/pull/18069
MylesBorinshttps://github.com/MylesBorins
Jan 10, 2018 https://github.com/nodejs/node/pull/18002#ref-commit-f148556
https://github.com/mcollina
https://github.com/MylesBorins
fs: guarantee order of callbacks in ws.closehttps://github.com/nodejs/node/commit/f1485565efe79ea154afdfd3eaa68eae28160805
f148556https://github.com/nodejs/node/commit/f1485565efe79ea154afdfd3eaa68eae28160805
#17951https://github.com/nodejs/node/issues/17951
#15407https://github.com/nodejs/node/pull/15407
#18002https://github.com/nodejs/node/pull/18002
#17951https://github.com/nodejs/node/issues/17951
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 17, 2018 https://github.com/nodejs/node/pull/18002#ref-pullrequest-289455243
Do not rely on Node.js internals gulpjs/vinyl-fs#296 https://github.com/gulpjs/vinyl-fs/pull/296
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18002
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/18002/files/09d3ae0d1bf165e15d4e242842582087567b3cab
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/18002/files/0a4854dbec67e5a40c7a2de3ce7b26fc8ec84b39
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
createWriteStream on Ubuntu not using default autoClose option https://github.com/nodejs/node/issues/17951
Please reload this pagehttps://github.com/nodejs/node/pull/18002
https://github.com/mcollina
https://github.com/MylesBorins
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.