René's URL Explorer Experiment


Title: lib: remove queue implementation from JSStreamWrap by addaleax · Pull Request #17918 · nodejs/node · GitHub

Open Graph Title: lib: remove queue implementation from JSStreamWrap by addaleax · Pull Request #17918 · nodejs/node

X Title: lib: remove queue implementation from JSStreamWrap by addaleax · Pull Request #17918 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The streams implementation generally ensures that only one write() call is active at a time. JSStreamWrap instances still kept queue of write reqeuests in spite of that; refactor it away. Also, fol...

X Description: The streams implementation generally ensures that only one write() call is active at a time. JSStreamWrap instances still kept queue of write reqeuests in spite of that; refactor it away. Also, fol...

Opengraph URL: https://github.com/nodejs/node/pull/17918

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:767411f9-ecae-c2ba-7b0d-938367ccb7a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC516:497D6:F3E142:14B29DE:6A5204E9
html-safe-nonce2433da017bbeb21ba99f7a0545d4303045c5f558ecba6be14f4afc22e06a39d9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTE2OjQ5N0Q2OkYzRTE0MjoxNEIyOURFOjZBNTIwNEU5IiwidmlzaXRvcl9pZCI6IjI0MzE2NzI5ODk5OTA5MTMyNTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0d5c5a5df376ad67086a349cbab3fbe15f68f085093be870631755dd1ca04672
hovercard-subject-tagpull_request:160558831
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17918/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/35c5787fb1e9ce2a80a003cbeb2549cf87be5330b9483c98efe5116a5145224b/nodejs/node/pull/17918
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/35c5787fb1e9ce2a80a003cbeb2549cf87be5330b9483c98efe5116a5145224b/nodejs/node/pull/17918
og:image:altThe streams implementation generally ensures that only one write() call is active at a time. JSStreamWrap instances still kept queue of write reqeuests in spite of that; refactor it away. Also, fol...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17918#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17918
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17918
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17918
Reloadhttps://github.com/nodejs/node/pull/17918
Reloadhttps://github.com/nodejs/node/pull/17918
Please reload this pagehttps://github.com/nodejs/node/pull/17918
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17918
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 983 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:wrap-js-stream-simplifyhttps://github.com/addaleax/node/tree/wrap-js-stream-simplify
Conversationhttps://github.com/nodejs/node/pull/17918
Commits4 (4)https://github.com/nodejs/node/pull/17918/commits
Checkshttps://github.com/nodejs/node/pull/17918/checks
Files changedhttps://github.com/nodejs/node/pull/17918/files
lib: remove queue implementation from JSStreamWraphttps://github.com/nodejs/node/pull/17918#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:wrap-js-stream-simplifyhttps://github.com/addaleax/node/tree/wrap-js-stream-simplify
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 29, 2017https://github.com/nodejs/node/pull/17918#issue-285152684
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Dec 29, 2017https://github.com/nodejs/node/pull/17918#event-1404853347
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 29, 2017 https://github.com/nodejs/node/pull/17918#pullrequestreview-86008881
View reviewed changes https://github.com/nodejs/node/pull/17918/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/17918#pullrequestreview-86008881
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
lib/internal/wrap_js_stream.jshttps://github.com/nodejs/node/pull/17918/files#diff-3518af36a680cae951d903344cc542f93c0eea6cae2a4f8f3dab33b2a26a854c
bnoordhuishttps://github.com/bnoordhuis
Dec 29, 2017https://github.com/nodejs/node/pull/17918#discussion_r159102619
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
addaleaxhttps://github.com/addaleax
Dec 29, 2017https://github.com/nodejs/node/pull/17918#discussion_r159103616
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
lib/internal/wrap_js_stream.jshttps://github.com/nodejs/node/pull/17918/files#diff-3518af36a680cae951d903344cc542f93c0eea6cae2a4f8f3dab33b2a26a854c
bnoordhuishttps://github.com/bnoordhuis
Dec 29, 2017https://github.com/nodejs/node/pull/17918#discussion_r159102728
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
addaleaxhttps://github.com/addaleax
Dec 29, 2017https://github.com/nodejs/node/pull/17918#discussion_r159103689
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
lib/internal/wrap_js_stream.jshttps://github.com/nodejs/node/pull/17918/files#diff-3518af36a680cae951d903344cc542f93c0eea6cae2a4f8f3dab33b2a26a854c
bnoordhuishttps://github.com/bnoordhuis
Dec 29, 2017https://github.com/nodejs/node/pull/17918#discussion_r159102952
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
addaleaxhttps://github.com/addaleax
Dec 29, 2017https://github.com/nodejs/node/pull/17918#discussion_r159103617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
bnoordhuishttps://github.com/bnoordhuis
Dec 29, 2017https://github.com/nodejs/node/pull/17918#discussion_r159104630
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
addaleaxhttps://github.com/addaleax
Dec 29, 2017https://github.com/nodejs/node/pull/17918#discussion_r159104756
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
bnoordhuishttps://github.com/bnoordhuis
Dec 29, 2017https://github.com/nodejs/node/pull/17918#discussion_r159104989
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 29, 2017 https://github.com/nodejs/node/pull/17918#pullrequestreview-86011148
View reviewed changes https://github.com/nodejs/node/pull/17918/files
lib/internal/wrap_js_stream.jshttps://github.com/nodejs/node/pull/17918/files#diff-3518af36a680cae951d903344cc542f93c0eea6cae2a4f8f3dab33b2a26a854c
jasnellhttps://github.com/jasnell
Dec 29, 2017https://github.com/nodejs/node/pull/17918#discussion_r159104601
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
addaleaxhttps://github.com/addaleax
Dec 29, 2017https://github.com/nodejs/node/pull/17918#discussion_r159104947
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 29, 2017 https://github.com/nodejs/node/pull/17918#pullrequestreview-86011256
View reviewed changes https://github.com/nodejs/node/pull/17918/files
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Dec 29, 2017 https://github.com/nodejs/node/pull/17918#pullrequestreview-86013516
View reviewed changes https://github.com/nodejs/node/pull/17918/files
https://github.com/JungMinu
JungMinuhttps://github.com/JungMinu
Dec 30, 2017 https://github.com/nodejs/node/pull/17918#pullrequestreview-86027605
View reviewed changes https://github.com/nodejs/node/pull/17918/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 30, 2017 https://github.com/nodejs/node/pull/17918#pullrequestreview-86034191
View reviewed changes https://github.com/nodejs/node/pull/17918/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 2, 2018https://github.com/nodejs/node/pull/17918#issuecomment-354784862
https://ci.nodejs.org/job/node-test-commit/15175/https://ci.nodejs.org/job/node-test-commit/15175/
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 2, 2018https://github.com/nodejs/node/pull/17918#event-1406358843
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jan 3, 2018 https://github.com/nodejs/node/pull/17918#pullrequestreview-86286166
View reviewed changes https://github.com/nodejs/node/pull/17918/files
https://github.com/billouboq
billouboqhttps://github.com/billouboq
Jan 3, 2018 https://github.com/nodejs/node/pull/17918#pullrequestreview-86067693
View reviewed changes https://github.com/nodejs/node/pull/17918/files
lib/internal/wrap_js_stream.jshttps://github.com/nodejs/node/pull/17918/files#diff-3518af36a680cae951d903344cc542f93c0eea6cae2a4f8f3dab33b2a26a854c
billouboqhttps://github.com/billouboq
Jan 1, 2018https://github.com/nodejs/node/pull/17918#discussion_r159161741
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
addaleaxhttps://github.com/addaleax
Jan 4, 2018https://github.com/nodejs/node/pull/17918#discussion_r159737880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@billouboqhttps://github.com/billouboq
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 3, 2018 https://github.com/nodejs/node/pull/17918#pullrequestreview-86392937
View reviewed changes https://github.com/nodejs/node/pull/17918/files
lib/internal/wrap_js_stream.jshttps://github.com/nodejs/node/pull/17918/files#diff-3518af36a680cae951d903344cc542f93c0eea6cae2a4f8f3dab33b2a26a854c
mcollinahttps://github.com/mcollina
Jan 3, 2018https://github.com/nodejs/node/pull/17918#discussion_r159444587
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
lib/internal/wrap_js_stream.jshttps://github.com/nodejs/node/pull/17918/files#diff-3518af36a680cae951d903344cc542f93c0eea6cae2a4f8f3dab33b2a26a854c
mcollinahttps://github.com/mcollina
Jan 3, 2018https://github.com/nodejs/node/pull/17918#discussion_r159444722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
lib/internal/wrap_js_stream.jshttps://github.com/nodejs/node/pull/17918/files#diff-3518af36a680cae951d903344cc542f93c0eea6cae2a4f8f3dab33b2a26a854c
mcollinahttps://github.com/mcollina
Jan 3, 2018https://github.com/nodejs/node/pull/17918#discussion_r159444957
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 3, 2018https://github.com/nodejs/node/pull/17918#event-1408255091
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 3, 2018https://github.com/nodejs/node/pull/17918#issuecomment-355082969
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/17918
addaleaxhttps://github.com/addaleax
January 4, 2018 20:38https://github.com/nodejs/node/pull/17918#commits-pushed-904e18a
https://github.com/addaleax
lib: remove queue implementation from JSStreamWraphttps://github.com/nodejs/node/pull/17918/commits/904e18ab96201093ff483ad86cf4d2dbb7dea768
904e18ahttps://github.com/nodejs/node/pull/17918/commits/904e18ab96201093ff483ad86cf4d2dbb7dea768
https://github.com/addaleax
[squash] bnoordhuis commentshttps://github.com/nodejs/node/pull/17918/commits/0cf413bdf41616e5af700b417f867e3290cf4838
0cf413bhttps://github.com/nodejs/node/pull/17918/commits/0cf413bdf41616e5af700b417f867e3290cf4838
https://github.com/addaleax
[squash] jasnell commenthttps://github.com/nodejs/node/pull/17918/commits/51e7ecc96db27c0ebb342eab04e7cf0d520a639d
51e7ecchttps://github.com/nodejs/node/pull/17918/commits/51e7ecc96db27c0ebb342eab04e7cf0d520a639d
https://github.com/addaleax
[squash] move away from for-const-of loophttps://github.com/nodejs/node/pull/17918/commits/a17b0d97fc5a88298886a53b49d63032eca645a0
a17b0d9https://github.com/nodejs/node/pull/17918/commits/a17b0d97fc5a88298886a53b49d63032eca645a0
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/4be705eb42fe5b2fb2efe1b126a9dbbf25e17a31..a17b0d97fc5a88298886a53b49d63032eca645a0
4be705ehttps://github.com/nodejs/node/commit/4be705eb42fe5b2fb2efe1b126a9dbbf25e17a31
a17b0d9https://github.com/nodejs/node/commit/a17b0d97fc5a88298886a53b49d63032eca645a0
Compare https://github.com/nodejs/node/compare/4be705eb42fe5b2fb2efe1b126a9dbbf25e17a31..a17b0d97fc5a88298886a53b49d63032eca645a0
January 4, 2018 20:35https://github.com/nodejs/node/pull/17918#event-1410249780
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 4, 2018https://github.com/nodejs/node/pull/17918#issuecomment-355392687
@mcollinahttps://github.com/mcollina
#17983https://github.com/nodejs/node/pull/17983
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 5, 2018https://github.com/nodejs/node/pull/17918#issuecomment-355519922
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 5, 2018 https://github.com/nodejs/node/pull/17918#pullrequestreview-86863707
View reviewed changes https://github.com/nodejs/node/pull/17918/files/a17b0d97fc5a88298886a53b49d63032eca645a0
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/17918#pullrequestreview-86863707
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 5, 2018https://github.com/nodejs/node/pull/17918#issuecomment-355609986
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 5, 2018https://github.com/nodejs/node/pull/17918#issuecomment-355657149
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 5, 2018https://github.com/nodejs/node/pull/17918#issuecomment-355677624
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 6, 2018https://github.com/nodejs/node/pull/17918#issuecomment-355737037
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 6, 2018https://github.com/nodejs/node/pull/17918#issuecomment-355740671
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Jan 7, 2018https://github.com/nodejs/node/pull/17918#event-1412857824
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Jan 7, 2018https://github.com/nodejs/node/pull/17918#event-1412857827
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 7, 2018https://github.com/nodejs/node/pull/17918#issuecomment-355850381
b171adchttps://github.com/nodejs/node/commit/b171adc4d12e96f7b72155ea54a78dd1c8e5823f
#17938 (comment)https://github.com/nodejs/node/pull/17938#issuecomment-354683850
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 7, 2018https://github.com/nodejs/node/pull/17918#event-1412860975
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
January 7, 2018 20:32https://github.com/nodejs/node/pull/17918#event-1412861008
addaleaxhttps://github.com/addaleax
Jan 7, 2018 https://github.com/nodejs/node/pull/17918#ref-commit-b171adc
https://github.com/addaleax
lib: remove queue implementation from JSStreamWraphttps://github.com/nodejs/node/commit/b171adc4d12e96f7b72155ea54a78dd1c8e5823f
b171adchttps://github.com/nodejs/node/commit/b171adc4d12e96f7b72155ea54a78dd1c8e5823f
#17918https://github.com/nodejs/node/pull/17918
MylesBorinshttps://github.com/MylesBorins
Jan 8, 2018 https://github.com/nodejs/node/pull/17918#ref-commit-bd744b1
https://github.com/addaleax
https://github.com/MylesBorins
lib: remove queue implementation from JSStreamWraphttps://github.com/nodejs/node/commit/bd744b13143f49bcf08627ad618ed8b2a5f7afd7
bd744b1https://github.com/nodejs/node/commit/bd744b13143f49bcf08627ad618ed8b2a5f7afd7
#17918https://github.com/nodejs/node/pull/17918
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018 https://github.com/nodejs/node/pull/17918#ref-commit-f55a5e8
https://github.com/addaleax
https://github.com/MylesBorins
lib: remove queue implementation from JSStreamWraphttps://github.com/nodejs/node/commit/f55a5e876289aa5d9b9e7b392c33b118e51abce4
f55a5e8https://github.com/nodejs/node/commit/f55a5e876289aa5d9b9e7b392c33b118e51abce4
#17918https://github.com/nodejs/node/pull/17918
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v9.x
Jan 9, 2018https://github.com/nodejs/node/pull/17918#event-1415334700
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018https://github.com/nodejs/node/pull/17918#issuecomment-356241385
#18050https://github.com/nodejs/node/pull/18050
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 10, 2018https://github.com/nodejs/node/pull/17918#issuecomment-356641208
@MylesBorinshttps://github.com/MylesBorins
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backport-requested-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v9.x
Jan 10, 2018https://github.com/nodejs/node/pull/17918#event-1417936552
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 10, 2018https://github.com/nodejs/node/pull/17918#issuecomment-356673249
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/17918
evanlucashttps://github.com/evanlucas
Jan 22, 2018 https://github.com/nodejs/node/pull/17918#ref-commit-32719fb
https://github.com/addaleax
https://github.com/evanlucas
lib: remove queue implementation from JSStreamWraphttps://github.com/nodejs/node/commit/32719fbb82b0be57c5b6c41442d90911544e88cc
32719fbhttps://github.com/nodejs/node/commit/32719fbb82b0be57c5b6c41442d90911544e88cc
#17918https://github.com/nodejs/node/pull/17918
evanlucashttps://github.com/evanlucas
Jan 30, 2018 https://github.com/nodejs/node/pull/17918#ref-commit-8f8e747
https://github.com/addaleax
https://github.com/evanlucas
lib: remove queue implementation from JSStreamWraphttps://github.com/nodejs/node/commit/8f8e7479cbbb23d5a9c23e759d2a38973476ea8b
8f8e747https://github.com/nodejs/node/commit/8f8e7479cbbb23d5a9c23e759d2a38973476ea8b
#17918https://github.com/nodejs/node/pull/17918
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Jan 30, 2018 https://github.com/nodejs/node/pull/17918#ref-pullrequest-292910934
v9.5.0 release proposal #18464 https://github.com/nodejs/node/pull/18464
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17918
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/17918/files/d5af6200759f071ecd1a7e059014fa31461c1fbe
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/17918/files/a17b0d97fc5a88298886a53b49d63032eca645a0
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/17918/files/3ce1b58e295b99cb96a46cc95fa75510bbf6d0b8
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/17918/files/4be705eb42fe5b2fb2efe1b126a9dbbf25e17a31
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/17918/files/4be705eb42fe5b2fb2efe1b126a9dbbf25e17a31
https://github.com/JungMinu
JungMinu https://github.com/JungMinu
https://github.com/nodejs/node/pull/17918/files/4be705eb42fe5b2fb2efe1b126a9dbbf25e17a31
https://github.com/billouboq
billouboq https://github.com/billouboq
https://github.com/nodejs/node/pull/17918/files/4be705eb42fe5b2fb2efe1b126a9dbbf25e17a31
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/17918/files/4be705eb42fe5b2fb2efe1b126a9dbbf25e17a31
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/17918
https://github.com/addaleax
https://github.com/mcollina
https://github.com/bnoordhuis
https://github.com/joyeecheung
https://github.com/MylesBorins
https://github.com/jasnell
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/JungMinu
https://github.com/billouboq
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.