René's URL Explorer Experiment


Title: build: avoid passing empty strings to build flags by jbergstroem · Pull Request #1789 · nodejs/node · GitHub

Open Graph Title: build: avoid passing empty strings to build flags by jbergstroem · Pull Request #1789 · nodejs/node

X Title: build: avoid passing empty strings to build flags by jbergstroem · Pull Request #1789 · nodejs/node

Description: While checking the return values from icu-i18n, we didn't validate the content (enough) before passing it to the build system. Also make cflags parsing more robust by avoiding empty strings. The re...

Open Graph Description: While checking the return values from icu-i18n, we didn't validate the content (enough) before passing it to the build system. Also make cflags parsing more robust by avoiding empty strings. Th...

X Description: While checking the return values from icu-i18n, we didn't validate the content (enough) before passing it to the build system. Also make cflags parsing more robust by avoiding empty strings...

Opengraph URL: https://github.com/nodejs/node/pull/1789

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c8919612-ef80-3fe3-53df-3d0a2849e86c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id949C:2E5741:2F5131:3D4627:696B3C68
html-safe-nonce1fb8ae731a2ee69d130aa637d2a0a6d0b7fe47ad25abe6d03bd8e0301589f9be
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDlDOjJFNTc0MToyRjUxMzE6M0Q0NjI3OjY5NkIzQzY4IiwidmlzaXRvcl9pZCI6IjMxOTA1NTU4NjgyMjIxNDM1OTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd233c979f9295893053fff234f37afaffddcdfa15369702fcfcc381dbfce54c9
hovercard-subject-tagpull_request:36115070
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1789/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ee440c5a2e46ad614dca5422588b8452d6af50c545922e91d325915ae1dc8877/nodejs/node/pull/1789
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ee440c5a2e46ad614dca5422588b8452d6af50c545922e91d325915ae1dc8877/nodejs/node/pull/1789
og:image:altWhile checking the return values from icu-i18n, we didn't validate the content (enough) before passing it to the build system. Also make cflags parsing more robust by avoiding empty strings. Th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejbergstroem
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1789#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1789
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1789
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1789
Reloadhttps://github.com/nodejs/node/pull/1789
Reloadhttps://github.com/nodejs/node/pull/1789
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/1789
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/1789
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/1789#issue-comment-box
jbergstroemhttps://github.com/jbergstroem
nodejs:masterhttps://github.com/nodejs/node/tree/master
jbergstroem:fix/issue1787https://github.com/jbergstroem/node/tree/fix/issue1787
build: avoid passing empty strings to build flags https://github.com/nodejs/node/pull/1789#top
jbergstroemhttps://github.com/jbergstroem
nodejs:masterhttps://github.com/nodejs/node/tree/master
jbergstroem:fix/issue1787https://github.com/jbergstroem/node/tree/fix/issue1787
Conversation 12 https://github.com/nodejs/node/pull/1789
Commits 2 https://github.com/nodejs/node/pull/1789/commits
Checks 0 https://github.com/nodejs/node/pull/1789/checks
Files changed https://github.com/nodejs/node/pull/1789/files
Please reload this pagehttps://github.com/nodejs/node/pull/1789
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
May 25, 2015https://github.com/nodejs/node/pull/1789#issue-80369902
#1787https://github.com/nodejs/node/issues/1787
@bnoordhuishttps://github.com/bnoordhuis
@alferpalhttps://github.com/alferpal
Please reload this pagehttps://github.com/nodejs/node/pull/1789
https://github.com/jbergstroem
build: avoid passing empty strings to build flagshttps://github.com/nodejs/node/pull/1789/commits/bf3d0174b21ea9cf765fa053ed11f51cc8c73225
bf3d017https://github.com/nodejs/node/pull/1789/commits/bf3d0174b21ea9cf765fa053ed11f51cc8c73225
nodejs#1787https://github.com/nodejs/node/issues/1787
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
May 25, 2015https://github.com/nodejs/node/pull/1789#event-312755648
bnoordhuishttps://github.com/bnoordhuis
May 25, 2015 https://github.com/nodejs/node/pull/1789#discussion-diff-30971833
View reviewed changes https://github.com/nodejs/node/pull/1789/files/bf3d0174b21ea9cf765fa053ed11f51cc8c73225#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
configurehttps://github.com/nodejs/node/pull/1789/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
bnoordhuishttps://github.com/bnoordhuis
May 25, 2015https://github.com/nodejs/node/pull/1789#discussion_r30971833
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1789
bnoordhuishttps://github.com/bnoordhuis
May 25, 2015https://github.com/nodejs/node/pull/1789#discussion_r30971921
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1789
jbergstroemhttps://github.com/jbergstroem
May 25, 2015https://github.com/nodejs/node/pull/1789#discussion_r30978051
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1789
jbergstroemhttps://github.com/jbergstroem
May 26, 2015https://github.com/nodejs/node/pull/1789#discussion_r31088632
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/1789
bnoordhuishttps://github.com/bnoordhuis
May 27, 2015https://github.com/nodejs/node/pull/1789#discussion_r31144964
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1789
jbergstroemhttps://github.com/jbergstroem
May 30, 2015https://github.com/nodejs/node/pull/1789#discussion_r31378012
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1789
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
May 27, 2015 https://github.com/nodejs/node/pull/1789#ref-pullrequest-81265857
Release proposal: v2.2.0 #1808 https://github.com/nodejs/node/pull/1808
https://github.com/rvagg
rvagghttps://github.com/rvagg
May 30, 2015https://github.com/nodejs/node/pull/1789#issuecomment-106982207
Please reload this pagehttps://github.com/nodejs/node/pull/1789
https://github.com/jbergstroem
fix: rewrite cflags parsing and fix include_dir for i18nhttps://github.com/nodejs/node/pull/1789/commits/38a128cbbdeee57ba1959d729d524b4ca9752c75
38a128chttps://github.com/nodejs/node/pull/1789/commits/38a128cbbdeee57ba1959d729d524b4ca9752c75
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
May 31, 2015https://github.com/nodejs/node/pull/1789#issuecomment-107132181
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/1789
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 31, 2015https://github.com/nodejs/node/pull/1789#issuecomment-107213978
Please reload this pagehttps://github.com/nodejs/node/pull/1789
thefourtheyehttps://github.com/thefourtheye
May 31, 2015 https://github.com/nodejs/node/pull/1789#discussion-diff-31392588
View reviewed changes https://github.com/nodejs/node/pull/1789/files/38a128cbbdeee57ba1959d729d524b4ca9752c75#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
configurehttps://github.com/nodejs/node/pull/1789/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
thefourtheyehttps://github.com/thefourtheye
May 31, 2015https://github.com/nodejs/node/pull/1789#discussion_r31392588
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1789
jbergstroemhttps://github.com/jbergstroem
May 31, 2015https://github.com/nodejs/node/pull/1789#discussion_r31394590
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@thefourtheyehttps://github.com/thefourtheye
Please reload this pagehttps://github.com/nodejs/node/pull/1789
jbergstroemhttps://github.com/jbergstroem
May 31, 2015 https://github.com/nodejs/node/pull/1789#ref-commit-c5a1009
https://github.com/jbergstroem
build: avoid passing empty strings to build flagshttps://github.com/nodejs/node/commit/c5a1009903e98bc087a53d5a12fed4b1c23582fb
c5a1009https://github.com/nodejs/node/commit/c5a1009903e98bc087a53d5a12fed4b1c23582fb
#1787https://github.com/nodejs/node/issues/1787
#1789https://github.com/nodejs/node/pull/1789
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
May 31, 2015https://github.com/nodejs/node/pull/1789#issuecomment-107249195
c5a1009https://github.com/nodejs/node/commit/c5a1009903e98bc087a53d5a12fed4b1c23582fb
Please reload this pagehttps://github.com/nodejs/node/pull/1789
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
May 31, 2015https://github.com/nodejs/node/pull/1789#event-318273738
https://github.com/rvagg
rvagghttps://github.com/rvagg
Jun 1, 2015 https://github.com/nodejs/node/pull/1789#ref-pullrequest-83245213
Release proposal: v2.2.1 #1856 https://github.com/nodejs/node/pull/1856
andrewdeandradehttps://github.com/andrewdeandrade
Jun 3, 2015 https://github.com/nodejs/node/pull/1789#ref-commit-bbc1d87
https://github.com/jbergstroem
https://github.com/andrewdeandrade
build: avoid passing empty strings to build flagshttps://github.com/andrewdeandrade/node/commit/bbc1d879df7a7860a5257ab87976d899d076ac52
bbc1d87https://github.com/andrewdeandrade/node/commit/bbc1d879df7a7860a5257ab87976d899d076ac52
nodejs/node#1787https://github.com/nodejs/node/issues/1787
nodejs/node#1789https://github.com/nodejs/node/pull/1789
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1789
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
iojs 2.1.0 & pkg-config output issues https://github.com/nodejs/node/issues/1787
Please reload this pagehttps://github.com/nodejs/node/pull/1789
https://github.com/jbergstroem
https://github.com/rvagg
https://github.com/bnoordhuis
https://github.com/thefourtheye
https://github.com/Fishrock123
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.