| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3b2088fe-abb4-6b01-cf5b-b784610c2daf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8B3A:2F3F69:CBB78:11DF37:696A5C9A |
| html-safe-nonce | 9f7aea0a788ac51400093fe84960ba8dfaa94530cf6111e6f687fe8e03e1815b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjNBOjJGM0Y2OTpDQkI3ODoxMURGMzc6Njk2QTVDOUEiLCJ2aXNpdG9yX2lkIjoiMTc4OTY2NTc2NjgxMDQ3NTY3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7b105b74c367608665c5a3b6bce7f13ef62ce82cd5be2df7288dd81dbb6f1ae9 |
| hovercard-subject-tag | pull_request:36103833 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1785/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ffcce557a699aec04bea4a8d89e725479e872a54097601cead99a666d8b00bcd/nodejs/node/pull/1785 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ffcce557a699aec04bea4a8d89e725479e872a54097601cead99a666d8b00bcd/nodejs/node/pull/1785 |
| og:image:alt | This is a fix for #728.
I ran the events benchmarks to compare this with master and there seems to be a significant performance drop for some cases (though I'm not sure of how I should compare ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | targos |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/1785#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1785 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1785 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/1785 |
| Reload | https://github.com/nodejs/node/pull/1785 |
| Reload | https://github.com/nodejs/node/pull/1785 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/1785#issue-comment-box |
| targos | https://github.com/targos |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| targos:fix-728 | https://github.com/targos/node/tree/fix-728 |
|
EventEmitter: use a Map to store event listeners
| https://github.com/nodejs/node/pull/1785#top |
| targos | https://github.com/targos |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| targos:fix-728 | https://github.com/targos/node/tree/fix-728 |
|
Conversation
42
| https://github.com/nodejs/node/pull/1785 |
|
Commits
1
| https://github.com/nodejs/node/pull/1785/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/1785/checks |
|
Files changed
| https://github.com/nodejs/node/pull/1785/files |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/targos |
| targos | https://github.com/targos |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#issue-80185500 |
| #728 | https://github.com/nodejs/node/issues/728 |
| 5909434 | https://github.com/nodejs/node/commit/59094341a0eb0bc2074d9c34f965fefdea2bdcef |
| 7912000 | https://github.com/nodejs/node/commit/79120003fb3c333cf87eef0687d9fca27c548ddb |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/petkaantonov |
| petkaantonov | https://github.com/petkaantonov |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105026849 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| mscdex | https://github.com/mscdex |
|
May 24, 2015
| https://github.com/nodejs/node/pull/1785#discussion-diff-30953209 |
| View reviewed changes
| https://github.com/nodejs/node/pull/1785/files/c5f60d1fbf8340b23fcb87062088152cab74ec8b#diff-1fd696295b3ae3f444c5c6839a11f89a91e2a42edeb5827e54e86b8acc3e6fe7 |
| lib/_stream_readable.js | https://github.com/nodejs/node/pull/1785/files#diff-1fd696295b3ae3f444c5c6839a11f89a91e2a42edeb5827e54e86b8acc3e6fe7 |
| mscdex | https://github.com/mscdex |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r30953209 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #914 | https://github.com/nodejs/node/pull/914 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| ChALkeR | https://github.com/ChALkeR |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r30953268 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| mscdex | https://github.com/mscdex |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r30953285 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| ChALkeR | https://github.com/ChALkeR |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r30953295 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/mscdex/dicer/blob/master/lib/Dicer.js#L91 | https://github.com/mscdex/dicer/blob/master/lib/Dicer.js#L91 |
| https://github.com/mscdex/busboy/blob/master/lib/types/multipart.js#L183 | https://github.com/mscdex/busboy/blob/master/lib/types/multipart.js#L183 |
| https://github.com/unshiftio/ultron/blob/master/index.js#L79 | https://github.com/unshiftio/ultron/blob/master/index.js#L79 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| mscdex | https://github.com/mscdex |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r30953335 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ChALkeR | https://github.com/ChALkeR |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| ChALkeR | https://github.com/ChALkeR |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r30953375 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| ChALkeR | https://github.com/ChALkeR |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r30953395 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105026993 |
| @petkaantonov | https://github.com/petkaantonov |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/petkaantonov |
| petkaantonov | https://github.com/petkaantonov |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105027033 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| mscdex | https://github.com/mscdex |
|
May 24, 2015
| https://github.com/nodejs/node/pull/1785#discussion-diff-30953240 |
| View reviewed changes
| https://github.com/nodejs/node/pull/1785/files/c5f60d1fbf8340b23fcb87062088152cab74ec8b#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9 |
| lib/events.js | https://github.com/nodejs/node/pull/1785/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9 |
| mscdex | https://github.com/mscdex |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r30953240 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| targos | https://github.com/targos |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r30953488 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| ca75072 | https://github.com/nodejs/node/commit/ca7507253a1d32e2c54452b22ec020af7e6225a4 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105027199 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| mscdex | https://github.com/mscdex |
|
May 24, 2015
| https://github.com/nodejs/node/pull/1785#discussion-diff-30953262 |
| View reviewed changes
| https://github.com/nodejs/node/pull/1785/files/c5f60d1fbf8340b23fcb87062088152cab74ec8b#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a |
| src/node.cc | https://github.com/nodejs/node/pull/1785/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a |
| mscdex | https://github.com/mscdex |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r30953262 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| targos | https://github.com/targos |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r30953280 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| brendanashworth | https://github.com/brendanashworth |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r30954088 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| NativeWeakMap | http://brendanashworth.github.io/v8-docs/classv8_1_1_native_weak_map.html |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| targos | https://github.com/targos |
| May 27, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r31171160 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| v8/v8@395fa8b | https://github.com/v8/v8/commit/395fa8ba2439f7e768376f7512553d66b67d1c87 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105027642 |
| @petkaantonov | https://github.com/petkaantonov |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/yosuke-furukawa |
| yosuke-furukawa | https://github.com/yosuke-furukawa |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105033093 |
| https://code.google.com/p/v8/issues/detail?id=4014 | https://code.google.com/p/v8/issues/detail?id=4014 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
events
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#event-312611134 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105041217 |
| @yosuke-furukawa | https://github.com/yosuke-furukawa |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/yosuke-furukawa |
| yosuke-furukawa | https://github.com/yosuke-furukawa |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105042719 |
| @ChALkeR | https://github.com/ChALkeR |
| @petkaantonov | https://github.com/petkaantonov |
| https://github.com/nodejs/io.js/blob/master/benchmark/common.js#L225 | https://github.com/nodejs/io.js/blob/master/benchmark/common.js#L225 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105043190 |
| @yosuke-furukawa | https://github.com/yosuke-furukawa |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105045594 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 24, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105046297 |
| @yosuke-furukawa | https://github.com/yosuke-furukawa |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/chrisdickinson |
| chrisdickinson | https://github.com/chrisdickinson |
| May 25, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105080716 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| May 25, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105223952 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| May 25, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105239763 |
| @ChALkeR | https://github.com/ChALkeR |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| May 25, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105243599 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| May 26, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105344755 |
| @ChALkeR | https://github.com/ChALkeR |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/chrisdickinson |
| chrisdickinson | https://github.com/chrisdickinson |
| May 26, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105349863 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/0921fb94a4f0f8ae0c93df2720caca3c4a4964bb..66518a0235e4608f49516af764329988c6c48468 |
| 0921fb9 | https://github.com/nodejs/node/commit/0921fb94a4f0f8ae0c93df2720caca3c4a4964bb |
| 66518a0 | https://github.com/nodejs/node/commit/66518a0235e4608f49516af764329988c6c48468 |
|
Compare
| https://github.com/nodejs/node/compare/0921fb94a4f0f8ae0c93df2720caca3c4a4964bb..66518a0235e4608f49516af764329988c6c48468 |
| May 27, 2015 08:39 | https://github.com/nodejs/node/pull/1785#event-314639138 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
future
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afuture |
| May 27, 2015 | https://github.com/nodejs/node/pull/1785#event-315081887 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| May 27, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-105992958 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/Qard |
| Qard | https://github.com/Qard |
| May 27, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-106049705 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
May 27, 2015
| https://github.com/nodejs/node/pull/1785#ref-issue-81625158 |
|
EventEmitter API
#1817
| https://github.com/nodejs/node/issues/1817 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| force-pushed | https://github.com/nodejs/node/compare/311c3e4371ee520a977a7e895c280f326cb85732..b9267189a58e48e587faec78a5e83b6bbfc72581 |
| 311c3e4 | https://github.com/nodejs/node/commit/311c3e4371ee520a977a7e895c280f326cb85732 |
| b926718 | https://github.com/nodejs/node/commit/b9267189a58e48e587faec78a5e83b6bbfc72581 |
|
Compare
| https://github.com/nodejs/node/compare/311c3e4371ee520a977a7e895c280f326cb85732..b9267189a58e48e587faec78a5e83b6bbfc72581 |
| June 2, 2015 17:25 | https://github.com/nodejs/node/pull/1785#event-320249151 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| force-pushed | https://github.com/nodejs/node/compare/9d211351bd96fe023ab2e4d73f8b62e5eceb67c7..628a3ab0930c8500483aa72a340e503cda41cf0b |
| 9d21135 | https://github.com/nodejs/node/commit/9d211351bd96fe023ab2e4d73f8b62e5eceb67c7 |
| 628a3ab | https://github.com/nodejs/node/commit/628a3ab0930c8500483aa72a340e503cda41cf0b |
|
Compare
| https://github.com/nodejs/node/compare/9d211351bd96fe023ab2e4d73f8b62e5eceb67c7..628a3ab0930c8500483aa72a340e503cda41cf0b |
| June 25, 2015 09:18 | https://github.com/nodejs/node/pull/1785#event-339839134 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| force-pushed | https://github.com/nodejs/node/compare/bffb20424cf236dd5291f8d627e80968e492b1ba..eb35968de7a040d737f3280e9fed0b6edf566b2b |
| bffb204 | https://github.com/nodejs/node/commit/bffb20424cf236dd5291f8d627e80968e492b1ba |
| eb35968 | https://github.com/nodejs/node/commit/eb35968de7a040d737f3280e9fed0b6edf566b2b |
|
Compare
| https://github.com/nodejs/node/compare/bffb20424cf236dd5291f8d627e80968e492b1ba..eb35968de7a040d737f3280e9fed0b6edf566b2b |
| July 22, 2015 21:21 | https://github.com/nodejs/node/pull/1785#event-362764391 |
| https://github.com/vkurchatkin |
| vkurchatkin | https://github.com/vkurchatkin |
|
Aug 11, 2015
| https://github.com/nodejs/node/pull/1785#ref-pullrequest-100384259 |
|
events: handle inherited properties properly
#2350
| https://github.com/nodejs/node/pull/2350 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 27, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-135239436 |
| @ChALkeR | https://github.com/ChALkeR |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| thefourtheye | https://github.com/thefourtheye |
|
Aug 27, 2015
| https://github.com/nodejs/node/pull/1785#discussion-diff-38059419 |
| View reviewed changes
| https://github.com/nodejs/node/pull/1785/files/66518a0235e4608f49516af764329988c6c48468#diff-56dcf507f2fd323adac75f3390949514190e95a6467b0db6e25d4855e2f1d203 |
| lib/internal/symbols.js | https://github.com/nodejs/node/pull/1785/files#diff-56dcf507f2fd323adac75f3390949514190e95a6467b0db6e25d4855e2f1d203 |
| thefourtheye | https://github.com/thefourtheye |
| Aug 27, 2015 | https://github.com/nodejs/node/pull/1785#discussion_r38059419 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
|
| https://github.com/targos |
| events: use a Map to store listeners | https://github.com/nodejs/node/pull/1785/commits/d84a953e2ee9edc3c004147c32831b3530bc15e4 |
| d84a953 | https://github.com/nodejs/node/pull/1785/commits/d84a953e2ee9edc3c004147c32831b3530bc15e4 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/66518a0235e4608f49516af764329988c6c48468..d84a953e2ee9edc3c004147c32831b3530bc15e4 |
| 66518a0 | https://github.com/nodejs/node/commit/66518a0235e4608f49516af764329988c6c48468 |
| d84a953 | https://github.com/nodejs/node/commit/d84a953e2ee9edc3c004147c32831b3530bc15e4 |
|
Compare
| https://github.com/nodejs/node/compare/66518a0235e4608f49516af764329988c6c48468..d84a953e2ee9edc3c004147c32831b3530bc15e4 |
| August 27, 2015 18:03 | https://github.com/nodejs/node/pull/1785#event-394297178 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Aug 27, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-135508675 |
| @jasnell | https://github.com/jasnell |
| 5303709 | https://github.com/nodejs/node/commit/53037095077f0bacae2d153d645b7e9445f408aa |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Aug 27, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-135509005 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Aug 27, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-135509749 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| force-pushed | https://github.com/nodejs/node/compare/11c25c28e266dd89ce6744ed7a23f2576c1bb103..ba02bd02e91773be161e03a9ed67745fba8f22db |
| 11c25c2 | https://github.com/nodejs/node/commit/11c25c28e266dd89ce6744ed7a23f2576c1bb103 |
| ba02bd0 | https://github.com/nodejs/node/commit/ba02bd02e91773be161e03a9ed67745fba8f22db |
|
Compare
| https://github.com/nodejs/node/compare/11c25c28e266dd89ce6744ed7a23f2576c1bb103..ba02bd02e91773be161e03a9ed67745fba8f22db |
| September 6, 2015 11:55 | https://github.com/nodejs/node/pull/1785#event-402153140 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 22, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-150090703 |
| @targos | https://github.com/targos |
| @thefourtheye | https://github.com/thefourtheye |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Oct 22, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-150145515 |
| @thefourtheye | https://github.com/thefourtheye |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Oct 22, 2015 | https://github.com/nodejs/node/pull/1785#event-442390262 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Oct 22, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-150149045 |
| @targos | https://github.com/targos |
| #2350 | https://github.com/nodejs/node/pull/2350 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Oct 22, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-150150804 |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Nov 15, 2015 | https://github.com/nodejs/node/pull/1785#issuecomment-156779953 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
| https://github.com/targos |
| targos | https://github.com/targos |
| June 1, 2017 09:06 | https://github.com/nodejs/node/pull/1785#event-1105649487 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 16, 2017
| https://github.com/nodejs/node/pull/1785#ref-pullrequest-274571370 |
|
[WIP] events: use Map for events and limit copying
#17074
| https://github.com/nodejs/node/pull/17074 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1785 |
|
events
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents |
| Please reload this page | https://github.com/nodejs/node/pull/1785 |
|
| https://github.com/targos |
|
| https://github.com/petkaantonov |
|
| https://github.com/ChALkeR |
|
| https://github.com/yosuke-furukawa |
|
| https://github.com/Fishrock123 |
|
| https://github.com/chrisdickinson |
|
| https://github.com/mscdex |
|
| https://github.com/sam-github |
|
| https://github.com/Qard |
|
| https://github.com/jasnell |
|
| https://github.com/thefourtheye |
|
| https://github.com/brendanashworth |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |