René's URL Explorer Experiment


Title: tests: fix test-require-deps-deprecation for already installed deps by Tiriel · Pull Request #17848 · nodejs/node · GitHub

Open Graph Title: tests: fix test-require-deps-deprecation for already installed deps by Tiriel · Pull Request #17848 · nodejs/node

X Title: tests: fix test-require-deps-deprecation for already installed deps by Tiriel · Pull Request #17848 · nodejs/node

Description: Merry christmas! Test test-require-deps-deprecation.js was failing when user already had node installed with acorn in require.resolve range. Modified test to acknowledge the possibility and throw o...

Open Graph Description: Merry christmas! Test test-require-deps-deprecation.js was failing when user already had node installed with acorn in require.resolve range. Modified test to acknowledge the possibility and throw o...

X Description: Merry christmas! Test test-require-deps-deprecation.js was failing when user already had node installed with acorn in require.resolve range. Modified test to acknowledge the possibility and throw o...

Opengraph URL: https://github.com/nodejs/node/pull/17848

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:94dbf796-61a9-a9b9-6eb3-557f73fe3d6f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0DC:3651F6:BBD40A:F4C8FB:696AFCEA
html-safe-nonce9396ea7f1dc068f6807b77a7085ad301598ea3d46e094d953df6604608a7c283
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMERDOjM2NTFGNjpCQkQ0MEE6RjRDOEZCOjY5NkFGQ0VBIiwidmlzaXRvcl9pZCI6IjU0Mjc1OTU1ODg3MDgwMDcxNDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3d2655f232e9ca877d7342fea264119c0e2a51bc5564986569794e67145f4653
hovercard-subject-tagpull_request:159992224
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17848/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b5486619bcbf1da67017cd9d09d482d9104e9d614493e4b872be03a0f222eae1/nodejs/node/pull/17848
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b5486619bcbf1da67017cd9d09d482d9104e9d614493e4b872be03a0f222eae1/nodejs/node/pull/17848
og:image:altMerry christmas! Test test-require-deps-deprecation.js was failing when user already had node installed with acorn in require.resolve range. Modified test to acknowledge the possibility and throw o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTiriel
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17848#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17848
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17848
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17848
Reloadhttps://github.com/nodejs/node/pull/17848
Reloadhttps://github.com/nodejs/node/pull/17848
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17848
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/17848
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/17848#issue-comment-box
Tirielhttps://github.com/Tiriel
nodejs:masterhttps://github.com/nodejs/node/tree/master
Tiriel:test-missing-errorhttps://github.com/Tiriel/node/tree/test-missing-error
tests: fix test-require-deps-deprecation for already installed deps https://github.com/nodejs/node/pull/17848#top
Tirielhttps://github.com/Tiriel
nodejs:masterhttps://github.com/nodejs/node/tree/master
Tiriel:test-missing-errorhttps://github.com/Tiriel/node/tree/test-missing-error
Conversation 27 https://github.com/nodejs/node/pull/17848
Commits 2 https://github.com/nodejs/node/pull/17848/commits
Checks 0 https://github.com/nodejs/node/pull/17848/checks
Files changed https://github.com/nodejs/node/pull/17848/files
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Tiriel
Tirielhttps://github.com/Tiriel
Dec 24, 2017https://github.com/nodejs/node/pull/17848#issue-284349781
#17148https://github.com/nodejs/node/issues/17148
#17148 (comment)https://github.com/nodejs/node/issues/17148#issuecomment-346167296
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Dec 24, 2017https://github.com/nodejs/node/pull/17848#event-1400582018
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Dec 24, 2017 https://github.com/nodejs/node/pull/17848#pullrequestreview-85436280
View reviewed changes https://github.com/nodejs/node/pull/17848/files
test/parallel/test-require-deps-deprecation.jshttps://github.com/nodejs/node/pull/17848/files#diff-2c771850d77f19577edc26b132c1c2b4f2942c8e055fea5cd3b27de97b8bc2e2
TimothyGuhttps://github.com/TimothyGu
Dec 24, 2017https://github.com/nodejs/node/pull/17848#discussion_r158596343
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17848
Tirielhttps://github.com/Tiriel
Dec 24, 2017https://github.com/nodejs/node/pull/17848#discussion_r158597909
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17848
TimothyGuhttps://github.com/TimothyGu
Dec 24, 2017https://github.com/nodejs/node/pull/17848#discussion_r158599586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17848
test/parallel/test-require-deps-deprecation.jshttps://github.com/nodejs/node/pull/17848/files#diff-2c771850d77f19577edc26b132c1c2b4f2942c8e055fea5cd3b27de97b8bc2e2
TimothyGuhttps://github.com/TimothyGu
Dec 24, 2017https://github.com/nodejs/node/pull/17848#discussion_r158596353
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17848
Tirielhttps://github.com/Tiriel
Dec 24, 2017https://github.com/nodejs/node/pull/17848#discussion_r158597877
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17848
test/parallel/test-require-deps-deprecation.jshttps://github.com/nodejs/node/pull/17848/files#diff-2c771850d77f19577edc26b132c1c2b4f2942c8e055fea5cd3b27de97b8bc2e2
TimothyGuhttps://github.com/TimothyGu
Dec 24, 2017https://github.com/nodejs/node/pull/17848#discussion_r158596386
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17848
Tirielhttps://github.com/Tiriel
Dec 24, 2017https://github.com/nodejs/node/pull/17848#discussion_r158597896
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/Tiriel
Tirielhttps://github.com/Tiriel
force-pushedhttps://github.com/nodejs/node/compare/3c3ffe8b4708076a291b8b75d41fe480d1e35d49..39768723de217242479faf14d0bd8963abd8fee1
3c3ffe8https://github.com/nodejs/node/commit/3c3ffe8b4708076a291b8b75d41fe480d1e35d49
3976872https://github.com/nodejs/node/commit/39768723de217242479faf14d0bd8963abd8fee1
Compare https://github.com/nodejs/node/compare/3c3ffe8b4708076a291b8b75d41fe480d1e35d49..39768723de217242479faf14d0bd8963abd8fee1
December 24, 2017 12:56https://github.com/nodejs/node/pull/17848#event-1400633057
https://github.com/Tiriel
Tirielhttps://github.com/Tiriel
Dec 24, 2017https://github.com/nodejs/node/pull/17848#issuecomment-353783061
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 24, 2017 https://github.com/nodejs/node/pull/17848#pullrequestreview-85443721
View reviewed changes https://github.com/nodejs/node/pull/17848/files
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 24, 2017 https://github.com/nodejs/node/pull/17848#pullrequestreview-85445552
View reviewed changes https://github.com/nodejs/node/pull/17848/files
test/parallel/test-require-deps-deprecation.jshttps://github.com/nodejs/node/pull/17848/files#diff-2c771850d77f19577edc26b132c1c2b4f2942c8e055fea5cd3b27de97b8bc2e2
Trotthttps://github.com/Trott
Dec 24, 2017https://github.com/nodejs/node/pull/17848#discussion_r158606229
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17848
Tirielhttps://github.com/Tiriel
Dec 25, 2017https://github.com/nodejs/node/pull/17848#discussion_r158628312
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 24, 2017 https://github.com/nodejs/node/pull/17848#pullrequestreview-85445633
View reviewed changes https://github.com/nodejs/node/pull/17848/files
test/parallel/test-require-deps-deprecation.jshttps://github.com/nodejs/node/pull/17848/files#diff-2c771850d77f19577edc26b132c1c2b4f2942c8e055fea5cd3b27de97b8bc2e2
Trotthttps://github.com/Trott
Dec 24, 2017https://github.com/nodejs/node/pull/17848#discussion_r158606316
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 24, 2017 https://github.com/nodejs/node/pull/17848#pullrequestreview-85445637
View reviewed changes https://github.com/nodejs/node/pull/17848/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/17848#pullrequestreview-85445637
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 24, 2017https://github.com/nodejs/node/pull/17848#issuecomment-353794499
https://ci.nodejs.org/job/node-test-pull-request/12287/https://ci.nodejs.org/job/node-test-pull-request/12287/
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/Tiriel
tests: fix test-require-deps-deprecation for already installed depshttps://github.com/nodejs/node/pull/17848/commits/518b1330050400257f1a11cb7a05e131b9b36721
518b133https://github.com/nodejs/node/pull/17848/commits/518b1330050400257f1a11cb7a05e131b9b36721
nodejs#17148https://github.com/nodejs/node/issues/17148
nodejs#17148 (comment)https://github.com/nodejs/node/issues/17148#issuecomment-346167296
https://github.com/Tiriel
Tirielhttps://github.com/Tiriel
force-pushedhttps://github.com/nodejs/node/compare/39768723de217242479faf14d0bd8963abd8fee1..ea3c32e512ecd8271a8aef2d2411fe1ab4f02656
3976872https://github.com/nodejs/node/commit/39768723de217242479faf14d0bd8963abd8fee1
ea3c32ehttps://github.com/nodejs/node/commit/ea3c32e512ecd8271a8aef2d2411fe1ab4f02656
Compare https://github.com/nodejs/node/compare/39768723de217242479faf14d0bd8963abd8fee1..ea3c32e512ecd8271a8aef2d2411fe1ab4f02656
December 25, 2017 07:55https://github.com/nodejs/node/pull/17848#event-1400920014
https://github.com/Tiriel
Tirielhttps://github.com/Tiriel
Dec 25, 2017https://github.com/nodejs/node/pull/17848#issuecomment-353846546
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Dec 25, 2017 https://github.com/nodejs/node/pull/17848#pullrequestreview-85477813
View reviewed changes https://github.com/nodejs/node/pull/17848/files
test/parallel/test-require-deps-deprecation.jshttps://github.com/nodejs/node/pull/17848/files#diff-2c771850d77f19577edc26b132c1c2b4f2942c8e055fea5cd3b27de97b8bc2e2
TimothyGuhttps://github.com/TimothyGu
Dec 25, 2017https://github.com/nodejs/node/pull/17848#discussion_r158635957
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17848
test/parallel/test-require-deps-deprecation.jshttps://github.com/nodejs/node/pull/17848/files#diff-2c771850d77f19577edc26b132c1c2b4f2942c8e055fea5cd3b27de97b8bc2e2
TimothyGuhttps://github.com/TimothyGu
Dec 25, 2017https://github.com/nodejs/node/pull/17848#discussion_r158636015
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/Tiriel
tests: fix error messagehttps://github.com/nodejs/node/pull/17848/commits/398246f76590120e15ce66d33c3e197890956dd0
398246fhttps://github.com/nodejs/node/pull/17848/commits/398246f76590120e15ce66d33c3e197890956dd0
nodejs#17148https://github.com/nodejs/node/issues/17148
nodejs#17148 (comment)https://github.com/nodejs/node/issues/17148#issuecomment-346167296
https://github.com/Tiriel
Tirielhttps://github.com/Tiriel
force-pushedhttps://github.com/nodejs/node/compare/ea3c32e512ecd8271a8aef2d2411fe1ab4f02656..398246f76590120e15ce66d33c3e197890956dd0
ea3c32ehttps://github.com/nodejs/node/commit/ea3c32e512ecd8271a8aef2d2411fe1ab4f02656
398246fhttps://github.com/nodejs/node/commit/398246f76590120e15ce66d33c3e197890956dd0
Compare https://github.com/nodejs/node/compare/ea3c32e512ecd8271a8aef2d2411fe1ab4f02656..398246f76590120e15ce66d33c3e197890956dd0
December 27, 2017 08:52https://github.com/nodejs/node/pull/17848#event-1402269178
https://github.com/Tiriel
Tirielhttps://github.com/Tiriel
Dec 27, 2017https://github.com/nodejs/node/pull/17848#issuecomment-354078968
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Dec 27, 2017 https://github.com/nodejs/node/pull/17848#pullrequestreview-85653894
View reviewed changes https://github.com/nodejs/node/pull/17848/files/398246f76590120e15ce66d33c3e197890956dd0
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/17848#pullrequestreview-85653894
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 27, 2017 https://github.com/nodejs/node/pull/17848#pullrequestreview-85678918
View reviewed changes https://github.com/nodejs/node/pull/17848/files/398246f76590120e15ce66d33c3e197890956dd0
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 28, 2017https://github.com/nodejs/node/pull/17848#issuecomment-354322214
https://ci.nodejs.org/job/node-test-pull-request/12330/https://ci.nodejs.org/job/node-test-pull-request/12330/
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/Tiriel
Tirielhttps://github.com/Tiriel
Dec 29, 2017https://github.com/nodejs/node/pull/17848#issuecomment-354415921
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 29, 2017https://github.com/nodejs/node/pull/17848#issuecomment-354459592
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/maclover7
maclover7https://github.com/maclover7
Jan 2, 2018https://github.com/nodejs/node/pull/17848#issuecomment-354899242
https://ci.nodejs.org/job/node-test-pull-request/12380/https://ci.nodejs.org/job/node-test-pull-request/12380/
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 3, 2018https://github.com/nodejs/node/pull/17848#event-1407192962
apapirovskihttps://github.com/apapirovski
Jan 3, 2018 https://github.com/nodejs/node/pull/17848#ref-commit-30892c8
https://github.com/Tiriel
https://github.com/apapirovski
test: fix require-deps-deprecation for installed depshttps://github.com/nodejs/node/commit/30892c8fb432ac8ee33eae1144bcce704906a855
30892c8https://github.com/nodejs/node/commit/30892c8fb432ac8ee33eae1144bcce704906a855
#17848https://github.com/nodejs/node/pull/17848
#17148https://github.com/nodejs/node/issues/17148
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Jan 3, 2018https://github.com/nodejs/node/pull/17848#issuecomment-355096720
30892c8https://github.com/nodejs/node/commit/30892c8fb432ac8ee33eae1144bcce704906a855
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Jan 3, 2018https://github.com/nodejs/node/pull/17848#event-1408347286
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018https://github.com/nodejs/node/pull/17848#issuecomment-356451489
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v9.x
Jan 9, 2018https://github.com/nodejs/node/pull/17848#event-1416722758
https://github.com/Tiriel
Tirielhttps://github.com/Tiriel
Jan 10, 2018https://github.com/nodejs/node/pull/17848#issuecomment-356544201
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/targos
targoshttps://github.com/targos
Jan 10, 2018https://github.com/nodejs/node/pull/17848#issuecomment-356546284
@Tirielhttps://github.com/Tiriel
https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.mdhttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/Tiriel
Tirielhttps://github.com/Tiriel
Jan 10, 2018https://github.com/nodejs/node/pull/17848#issuecomment-356547116
Please reload this pagehttps://github.com/nodejs/node/pull/17848
Tirielhttps://github.com/Tiriel
Jan 10, 2018 https://github.com/nodejs/node/pull/17848#ref-commit-c341f93
https://github.com/Tiriel
test: fix require-deps-deprecation for installed depshttps://github.com/Tiriel/node/commit/c341f9308debb85507d84acde9851091b5c5549d
c341f93https://github.com/Tiriel/node/commit/c341f9308debb85507d84acde9851091b5c5549d
nodejs#17848https://github.com/nodejs/node/pull/17848
nodejs#17148https://github.com/nodejs/node/issues/17148
https://github.com/Tiriel
Tirielhttps://github.com/Tiriel
Jan 10, 2018 https://github.com/nodejs/node/pull/17848#ref-pullrequest-287423550
[v9.x backport] test: fix require-deps-deprecation for installed deps #18077 https://github.com/nodejs/node/pull/18077
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 13, 2018https://github.com/nodejs/node/pull/17848#event-1423132407
MylesBorinshttps://github.com/MylesBorins
Feb 20, 2018 https://github.com/nodejs/node/pull/17848#ref-commit-b5752ee
https://github.com/Tiriel
https://github.com/MylesBorins
test: fix require-deps-deprecation for installed depshttps://github.com/nodejs/node/commit/b5752ee6a4f3d76837e62f2f0d552cf01f1668a1
b5752eehttps://github.com/nodejs/node/commit/b5752ee6a4f3d76837e62f2f0d552cf01f1668a1
#18077https://github.com/nodejs/node/pull/18077
#17848https://github.com/nodejs/node/pull/17848
#17148https://github.com/nodejs/node/issues/17148
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backported-to-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v9.x
backport-requested-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v9.x
Feb 20, 2018https://github.com/nodejs/node/pull/17848#event-1483413841
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 21, 2018 https://github.com/nodejs/node/pull/17848#ref-pullrequest-299038228
v9.6.0 proposal #18902 https://github.com/nodejs/node/pull/18902
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17848
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/17848/files/398246f76590120e15ce66d33c3e197890956dd0
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/17848/files/39768723de217242479faf14d0bd8963abd8fee1
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/17848/files/39768723de217242479faf14d0bd8963abd8fee1
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/17848/files/398246f76590120e15ce66d33c3e197890956dd0
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
test: missing expected exception in parallel/test-require-deps-deprecation.js https://github.com/nodejs/node/issues/17148
Please reload this pagehttps://github.com/nodejs/node/pull/17848
https://github.com/Tiriel
https://github.com/Trott
https://github.com/jasnell
https://github.com/maclover7
https://github.com/apapirovski
https://github.com/MylesBorins
https://github.com/targos
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.