René's URL Explorer Experiment


Title: http2: convert Http2Settings to an AsyncWrap by jasnell · Pull Request #17763 · nodejs/node · GitHub

Open Graph Title: http2: convert Http2Settings to an AsyncWrap by jasnell · Pull Request #17763 · nodejs/node

X Title: http2: convert Http2Settings to an AsyncWrap by jasnell · Pull Request #17763 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Make Http2Settings an AsyncWrap. Refs: #17746 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Aff...

X Description: Make Http2Settings an AsyncWrap. Refs: #17746 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Aff...

Opengraph URL: https://github.com/nodejs/node/pull/17763

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8e45280b-9dbd-7bfa-bf62-16010bfdc632
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED9C:251B89:AEBC3AE:B2431B5:6A50C444
html-safe-nonce0f848a3dd39ff172024d027b10554cffa16f539279ea31dca060c504511abc6f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDlDOjI1MUI4OTpBRUJDM0FFOkIyNDMxQjU6NkE1MEM0NDQiLCJ2aXNpdG9yX2lkIjoiMTQwMjI4OTUzMjM4OTM0NDMyNCIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9
visitor-hmac06e91321dac72da697544655df9733792a50f606cfd72446cf88fa8f51e220ba
hovercard-subject-tagpull_request:159271612
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17763/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f3ca9e84dfa11cb09230b1732922a4f02205733b6a93736a0d8d59fa6e38888c/nodejs/node/pull/17763
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f3ca9e84dfa11cb09230b1732922a4f02205733b6a93736a0d8d59fa6e38888c/nodejs/node/pull/17763
og:image:altMake Http2Settings an AsyncWrap. Refs: #17746 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Aff...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release08e79d53fc070870d5b168356afebb1e286a2ffe
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17763#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17763
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17763
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17763
Reloadhttps://github.com/nodejs/node/pull/17763
Reloadhttps://github.com/nodejs/node/pull/17763
Please reload this pagehttps://github.com/nodejs/node/pull/17763
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17763
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 979 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:http2-settings-async-reqhttps://github.com/jasnell/node/tree/http2-settings-async-req
Conversationhttps://github.com/nodejs/node/pull/17763
Commits1 (1)https://github.com/nodejs/node/pull/17763/commits
Checkshttps://github.com/nodejs/node/pull/17763/checks
Files changedhttps://github.com/nodejs/node/pull/17763/files
http2: convert Http2Settings to an AsyncWraphttps://github.com/nodejs/node/pull/17763#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:http2-settings-async-reqhttps://github.com/jasnell/node/tree/http2-settings-async-req
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 19, 2017https://github.com/nodejs/node/pull/17763#issue-283369227
#17746https://github.com/nodejs/node/issues/17746
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17763
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Dec 19, 2017https://github.com/nodejs/node/pull/17763#event-1394967573
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 19, 2017 https://github.com/nodejs/node/pull/17763#ref-issue-283068119
[Tracking Issue]: Some http2 todos #17746 https://github.com/nodejs/node/issues/17746
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 21, 2017https://github.com/nodejs/node/pull/17763#issuecomment-353446218
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/17763
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/6596369add452fb490d1861c06eddac36f1800ec..2ca60ac829ebead4029ea3436283e8a9014eb194
6596369https://github.com/nodejs/node/commit/6596369add452fb490d1861c06eddac36f1800ec
2ca60achttps://github.com/nodejs/node/commit/2ca60ac829ebead4029ea3436283e8a9014eb194
Compare https://github.com/nodejs/node/compare/6596369add452fb490d1861c06eddac36f1800ec..2ca60ac829ebead4029ea3436283e8a9014eb194
December 21, 2017 20:11https://github.com/nodejs/node/pull/17763#event-1398621151
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 21, 2017https://github.com/nodejs/node/pull/17763#issuecomment-353446731
https://ci.nodejs.org/job/node-test-pull-request/12251/https://ci.nodejs.org/job/node-test-pull-request/12251/
Please reload this pagehttps://github.com/nodejs/node/pull/17763
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 21, 2017 https://github.com/nodejs/node/pull/17763#pullrequestreview-85173231
View reviewed changes https://github.com/nodejs/node/pull/17763/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/17763#pullrequestreview-85173231
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17763
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 21, 2017 https://github.com/nodejs/node/pull/17763#pullrequestreview-85173437
View reviewed changes https://github.com/nodejs/node/pull/17763/files
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/17763/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
mcollinahttps://github.com/mcollina
Dec 21, 2017https://github.com/nodejs/node/pull/17763#discussion_r158370810
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17763
jasnellhttps://github.com/jasnell
Dec 21, 2017https://github.com/nodejs/node/pull/17763#discussion_r158377932
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17763
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 22, 2017https://github.com/nodejs/node/pull/17763#issuecomment-353641980
https://ci.nodejs.org/job/node-test-pull-request/12263/https://ci.nodejs.org/job/node-test-pull-request/12263/
Please reload this pagehttps://github.com/nodejs/node/pull/17763
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/2f4808b190636c8fe4355628491b87f33f25978f..880bbee9c955fb152e105709948327e06bab23c5
2f4808bhttps://github.com/nodejs/node/commit/2f4808b190636c8fe4355628491b87f33f25978f
880bbeehttps://github.com/nodejs/node/commit/880bbee9c955fb152e105709948327e06bab23c5
Compare https://github.com/nodejs/node/compare/2f4808b190636c8fe4355628491b87f33f25978f..880bbee9c955fb152e105709948327e06bab23c5
December 22, 2017 18:01https://github.com/nodejs/node/pull/17763#event-1399936930
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 22, 2017https://github.com/nodejs/node/pull/17763#issuecomment-353650440
https://ci.nodejs.org/job/node-test-pull-request/12264/https://ci.nodejs.org/job/node-test-pull-request/12264/
Please reload this pagehttps://github.com/nodejs/node/pull/17763
https://github.com/jasnell
http2: convert Http2Settings to an AsyncWraphttps://github.com/nodejs/node/pull/17763/commits/788c8470d9e86115a766042cf60562b66f90a0c0
788c847https://github.com/nodejs/node/pull/17763/commits/788c8470d9e86115a766042cf60562b66f90a0c0
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/bc4a14a870eca5258d2e457510f6195055e3d53c..788c8470d9e86115a766042cf60562b66f90a0c0
bc4a14ahttps://github.com/nodejs/node/commit/bc4a14a870eca5258d2e457510f6195055e3d53c
788c847https://github.com/nodejs/node/commit/788c8470d9e86115a766042cf60562b66f90a0c0
Compare https://github.com/nodejs/node/compare/bc4a14a870eca5258d2e457510f6195055e3d53c..788c8470d9e86115a766042cf60562b66f90a0c0
December 22, 2017 20:10https://github.com/nodejs/node/pull/17763#event-1400078009
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 22, 2017https://github.com/nodejs/node/pull/17763#issuecomment-353667425
https://ci.nodejs.org/job/node-test-pull-request/12268/https://ci.nodejs.org/job/node-test-pull-request/12268/
Please reload this pagehttps://github.com/nodejs/node/pull/17763
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 22, 2017https://github.com/nodejs/node/pull/17763#issuecomment-353673025
Please reload this pagehttps://github.com/nodejs/node/pull/17763
jasnellhttps://github.com/jasnell
Dec 22, 2017 https://github.com/nodejs/node/pull/17763#ref-commit-bbaea12
https://github.com/jasnell
http2: convert Http2Settings to an AsyncWraphttps://github.com/nodejs/node/commit/bbaea1236f9a788fcb3f76113dd0c3bae83a551b
bbaea12https://github.com/nodejs/node/commit/bbaea1236f9a788fcb3f76113dd0c3bae83a551b
#17763https://github.com/nodejs/node/pull/17763
#17746https://github.com/nodejs/node/issues/17746
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 22, 2017https://github.com/nodejs/node/pull/17763#issuecomment-353678401
Please reload this pagehttps://github.com/nodejs/node/pull/17763
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 22, 2017https://github.com/nodejs/node/pull/17763#event-1400149740
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018 https://github.com/nodejs/node/pull/17763#ref-commit-293c2f9
https://github.com/jasnell
https://github.com/MylesBorins
http2: convert Http2Settings to an AsyncWraphttps://github.com/jasnell/node/commit/293c2f90de4332a6e28143a8a78196d59a2ea76f
293c2f9https://github.com/jasnell/node/commit/293c2f90de4332a6e28143a8a78196d59a2ea76f
nodejs#17763https://github.com/nodejs/node/pull/17763
nodejs#17746https://github.com/nodejs/node/issues/17746
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018 https://github.com/nodejs/node/pull/17763#ref-commit-098edcb
https://github.com/jasnell
https://github.com/MylesBorins
http2: convert Http2Settings to an AsyncWraphttps://github.com/nodejs/node/commit/098edcb19645304285b9c903ec67a691eec4cee0
098edcbhttps://github.com/nodejs/node/commit/098edcb19645304285b9c903ec67a691eec4cee0
#18050https://github.com/nodejs/node/pull/18050
#17763https://github.com/nodejs/node/pull/17763
#17746https://github.com/nodejs/node/issues/17746
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 10, 2018 https://github.com/nodejs/node/pull/17763#ref-pullrequest-287276543
v9.4.0 proposal #18069 https://github.com/nodejs/node/pull/18069
MylesBorinshttps://github.com/MylesBorins
Jan 10, 2018 https://github.com/nodejs/node/pull/17763#ref-commit-3a6b2ad
https://github.com/jasnell
https://github.com/MylesBorins
http2: convert Http2Settings to an AsyncWraphttps://github.com/nodejs/node/commit/3a6b2ad19a5d164a071e8eb21798d2f65119eec8
3a6b2adhttps://github.com/nodejs/node/commit/3a6b2ad19a5d164a071e8eb21798d2f65119eec8
#18050https://github.com/nodejs/node/pull/18050
#17763https://github.com/nodejs/node/pull/17763
#17746https://github.com/nodejs/node/issues/17746
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Jan 19, 2018https://github.com/nodejs/node/pull/17763#event-1433046480
kjinhttps://github.com/kjin
May 1, 2018 https://github.com/nodejs/node/pull/17763#ref-commit-f68325c
https://github.com/jasnell
https://github.com/kjin
http2: convert Http2Settings to an AsyncWraphttps://github.com/kjin/node/commit/f68325c29ef19d479225a92c11e0b7641b1ac64a
f68325chttps://github.com/kjin/node/commit/f68325c29ef19d479225a92c11e0b7641b1ac64a
nodejs#18050https://github.com/nodejs/node/pull/18050
nodejs#17763https://github.com/nodejs/node/pull/17763
nodejs#17746https://github.com/nodejs/node/issues/17746
MylesBorinshttps://github.com/MylesBorins
May 2, 2018 https://github.com/nodejs/node/pull/17763#ref-commit-0463221
https://github.com/jasnell
https://github.com/MylesBorins
http2: convert Http2Settings to an AsyncWraphttps://github.com/nodejs/node/commit/04632214c19edc23e7effe0d4d19f9855f2703de
0463221https://github.com/nodejs/node/commit/04632214c19edc23e7effe0d4d19f9855f2703de
#18050https://github.com/nodejs/node/pull/18050
#20456https://github.com/nodejs/node/pull/20456
#17763https://github.com/nodejs/node/pull/17763
#17746https://github.com/nodejs/node/issues/17746
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 2, 2018 https://github.com/nodejs/node/pull/17763#ref-pullrequest-319669485
v8.11.2 proposal #20478 https://github.com/nodejs/node/pull/20478
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17763
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/17763/files/2ca60ac829ebead4029ea3436283e8a9014eb194
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/17763
https://github.com/jasnell
https://github.com/mcollina
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.