René's URL Explorer Experiment


Title: napi: fixed memory leak in napi_async_init()/napi_async_destroy() by alnyan · Pull Request #17714 · nodejs/node · GitHub

Open Graph Title: napi: fixed memory leak in napi_async_init()/napi_async_destroy() by alnyan · Pull Request #17714 · nodejs/node

X Title: napi: fixed memory leak in napi_async_init()/napi_async_destroy() by alnyan · Pull Request #17714 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This patch fixes memory leak related to async_context not being freed in napi_async_destroy() after being allocated in napi_async_init() Checklist make -j4 test (UNIX), or vcbuild test (Windows) ...

X Description: This patch fixes memory leak related to async_context not being freed in napi_async_destroy() after being allocated in napi_async_init() Checklist make -j4 test (UNIX), or vcbuild test (Windows) ...

Opengraph URL: https://github.com/nodejs/node/pull/17714

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:abda1923-4e15-b0bd-3e09-72f9b4d7c12f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB914:141904:84210A:ADEAE3:6A517E49
html-safe-nonce24ad34e365453d4918b7f811f3441f1aba16ac919201ffd908115ca3e937b6f7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTE0OjE0MTkwNDo4NDIxMEE6QURFQUUzOjZBNTE3RTQ5IiwidmlzaXRvcl9pZCI6IjExODc1NzY2NDgzMTQyMjQyMDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf156bda50d5f0629f6985d5ef8ad050cb16e43b454833f8c67e423d55805a889
hovercard-subject-tagpull_request:158779907
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17714/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b8a81989ca74bdbef77b0a4a8491f342d57939d485a5716124cadf21f1833d89/nodejs/node/pull/17714
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b8a81989ca74bdbef77b0a4a8491f342d57939d485a5716124cadf21f1833d89/nodejs/node/pull/17714
og:image:altThis patch fixes memory leak related to async_context not being freed in napi_async_destroy() after being allocated in napi_async_init() Checklist make -j4 test (UNIX), or vcbuild test (Windows) ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealnyan
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released01c62704ef24df49056c63892a149b775e1353d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17714#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17714
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17714
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17714
Reloadhttps://github.com/nodejs/node/pull/17714
Reloadhttps://github.com/nodejs/node/pull/17714
Please reload this pagehttps://github.com/nodejs/node/pull/17714
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17714
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 981 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
alnyanhttps://github.com/alnyan
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/17714
Commits1 (1)https://github.com/nodejs/node/pull/17714/commits
Checkshttps://github.com/nodejs/node/pull/17714/checks
Files changedhttps://github.com/nodejs/node/pull/17714/files
napi: fixed memory leak in napi_async_init()/napi_async_destroy()https://github.com/nodejs/node/pull/17714#top
alnyanhttps://github.com/alnyan
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/alnyan
alnyanhttps://github.com/alnyan
Dec 17, 2017https://github.com/nodejs/node/pull/17714#issue-282684164
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17714
napi: fixed memory leak in napi_async_init()/napi_async_destroy()https://github.com/nodejs/node/pull/17714/commits/87cb1f53a57797132ce7a61fe23c7fde5ea21cfd
87cb1f5https://github.com/nodejs/node/pull/17714/commits/87cb1f53a57797132ce7a61fe23c7fde5ea21cfd
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Dec 17, 2017https://github.com/nodejs/node/pull/17714#event-1391027875
https://github.com/aqrln
aqrlnhttps://github.com/aqrln
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
Dec 17, 2017https://github.com/nodejs/node/pull/17714#event-1391028004
https://github.com/aqrln
aqrlnhttps://github.com/aqrln
Dec 17, 2017 https://github.com/nodejs/node/pull/17714#pullrequestreview-83996617
View reviewed changes https://github.com/nodejs/node/pull/17714/files/87cb1f53a57797132ce7a61fe23c7fde5ea21cfd
https://github.com/aqrln
aqrlnhttps://github.com/aqrln
Dec 17, 2017https://github.com/nodejs/node/pull/17714#issuecomment-352245947
https://ci.nodejs.org/job/node-test-pull-request/12156/https://ci.nodejs.org/job/node-test-pull-request/12156/
Please reload this pagehttps://github.com/nodejs/node/pull/17714
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 17, 2017 https://github.com/nodejs/node/pull/17714#pullrequestreview-84002915
View reviewed changes https://github.com/nodejs/node/pull/17714/files/87cb1f53a57797132ce7a61fe23c7fde5ea21cfd
https://github.com/aqrln
aqrlnhttps://github.com/aqrln
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Dec 17, 2017https://github.com/nodejs/node/pull/17714#event-1391114583
https://github.com/aqrln
aqrlnhttps://github.com/aqrln
Dec 17, 2017https://github.com/nodejs/node/pull/17714#issuecomment-352265321
Please reload this pagehttps://github.com/nodejs/node/pull/17714
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 17, 2017 https://github.com/nodejs/node/pull/17714#pullrequestreview-84005750
View reviewed changes https://github.com/nodejs/node/pull/17714/files/87cb1f53a57797132ce7a61fe23c7fde5ea21cfd
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Dec 17, 2017 https://github.com/nodejs/node/pull/17714#pullrequestreview-84006200
View reviewed changes https://github.com/nodejs/node/pull/17714/files/87cb1f53a57797132ce7a61fe23c7fde5ea21cfd
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 18, 2017 https://github.com/nodejs/node/pull/17714#pullrequestreview-84192611
View reviewed changes https://github.com/nodejs/node/pull/17714/files/87cb1f53a57797132ce7a61fe23c7fde5ea21cfd
aqrlnhttps://github.com/aqrln
Dec 18, 2017 https://github.com/nodejs/node/pull/17714#ref-commit-69938b1
https://github.com/aqrln
n-api: fix memory leak in napi_async_destroy()https://github.com/aqrln/node/commit/69938b1b602ba55f77e870710ff3ce3051a0cc13
69938b1https://github.com/aqrln/node/commit/69938b1b602ba55f77e870710ff3ce3051a0cc13
nodejs#17714https://github.com/nodejs/node/pull/17714
aqrlnhttps://github.com/aqrln
Dec 18, 2017 https://github.com/nodejs/node/pull/17714#ref-commit-94e2951
https://github.com/aqrln
n-api: fix memory leak in napi_async_destroy()https://github.com/nodejs/node/commit/94e29510d93811ff0792260a6c2ec3f72f43558c
94e2951https://github.com/nodejs/node/commit/94e29510d93811ff0792260a6c2ec3f72f43558c
#17714https://github.com/nodejs/node/pull/17714
https://github.com/aqrln
aqrlnhttps://github.com/aqrln
Dec 18, 2017https://github.com/nodejs/node/pull/17714#issuecomment-352534713
94e2951https://github.com/nodejs/node/commit/94e29510d93811ff0792260a6c2ec3f72f43558c
Please reload this pagehttps://github.com/nodejs/node/pull/17714
https://github.com/aqrln
aqrlnhttps://github.com/aqrln
Dec 18, 2017https://github.com/nodejs/node/pull/17714#event-1392796088
MylesBorinshttps://github.com/MylesBorins
Jan 8, 2018 https://github.com/nodejs/node/pull/17714#ref-commit-e54a836
https://github.com/MylesBorins
n-api: fix memory leak in napi_async_destroy()https://github.com/nodejs/node/commit/e54a836c1e1a57972756312a2beccaa01f4e80b8
e54a836https://github.com/nodejs/node/commit/e54a836c1e1a57972756312a2beccaa01f4e80b8
#17714https://github.com/nodejs/node/pull/17714
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018 https://github.com/nodejs/node/pull/17714#ref-commit-79a2833
https://github.com/MylesBorins
n-api: fix memory leak in napi_async_destroy()https://github.com/nodejs/node/commit/79a283307a3a8b03a75745f6050ff11693f03708
79a2833https://github.com/nodejs/node/commit/79a283307a3a8b03a75745f6050ff11693f03708
#17714https://github.com/nodejs/node/pull/17714
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 10, 2018 https://github.com/nodejs/node/pull/17714#ref-pullrequest-287276543
v9.4.0 proposal #18069 https://github.com/nodejs/node/pull/18069
https://github.com/AndreasMadsen
AndreasMadsenhttps://github.com/AndreasMadsen
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Jan 16, 2018https://github.com/nodejs/node/pull/17714#event-1425746455
gabrielschulhofhttps://github.com/gabrielschulhof
Apr 12, 2018 https://github.com/nodejs/node/pull/17714#ref-commit-bba1442
n-api: fix memory leak in napi_async_destroy()https://github.com/gabrielschulhof/node/commit/bba1442ffd1c9aaabc5cf910547dd8c61640a154
bba1442https://github.com/gabrielschulhof/node/commit/bba1442ffd1c9aaabc5cf910547dd8c61640a154
nodejs#17714https://github.com/nodejs/node/pull/17714
gabrielschulhofhttps://github.com/gabrielschulhof
Apr 16, 2018 https://github.com/nodejs/node/pull/17714#ref-commit-825468f
n-api: fix memory leak in napi_async_destroy()https://github.com/gabrielschulhof/node/commit/825468fa7cbc382472a25dca533c5140cb4f2a36
825468fhttps://github.com/gabrielschulhof/node/commit/825468fa7cbc382472a25dca533c5140cb4f2a36
nodejs#17714https://github.com/nodejs/node/pull/17714
MylesBorinshttps://github.com/MylesBorins
Apr 16, 2018 https://github.com/nodejs/node/pull/17714#ref-commit-65ea7ab
https://github.com/MylesBorins
n-api: fix memory leak in napi_async_destroy()https://github.com/nodejs/node/commit/65ea7abd55c06f43bf3e26adfb28961c82dc7d84
65ea7abhttps://github.com/nodejs/node/commit/65ea7abd55c06f43bf3e26adfb28961c82dc7d84
#19447https://github.com/nodejs/node/pull/19447
#17714https://github.com/nodejs/node/pull/17714
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 16, 2018 https://github.com/nodejs/node/pull/17714#ref-pullrequest-313968187
v6.14.2 proposal #19996 https://github.com/nodejs/node/pull/19996
MylesBorinshttps://github.com/MylesBorins
May 1, 2018 https://github.com/nodejs/node/pull/17714#ref-commit-a744535
https://github.com/MylesBorins
n-api: fix memory leak in napi_async_destroy()https://github.com/nodejs/node/commit/a744535f99efebd407b63f1681e8331261f30634
a744535https://github.com/nodejs/node/commit/a744535f99efebd407b63f1681e8331261f30634
#19265https://github.com/nodejs/node/pull/19265
#17714https://github.com/nodejs/node/pull/17714
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 2, 2018 https://github.com/nodejs/node/pull/17714#ref-pullrequest-319669485
v8.11.2 proposal #20478 https://github.com/nodejs/node/pull/20478
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Sep 19, 2019https://github.com/nodejs/node/pull/17714#event-2648205575
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17714
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/17714/files/87cb1f53a57797132ce7a61fe23c7fde5ea21cfd
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/17714/files/87cb1f53a57797132ce7a61fe23c7fde5ea21cfd
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/17714/files/87cb1f53a57797132ce7a61fe23c7fde5ea21cfd
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/17714/files/87cb1f53a57797132ce7a61fe23c7fde5ea21cfd
https://github.com/aqrln
aqrln https://github.com/aqrln
https://github.com/nodejs/node/pull/17714/files/87cb1f53a57797132ce7a61fe23c7fde5ea21cfd
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/17714
https://github.com/alnyan
https://github.com/aqrln
https://github.com/jasnell
https://github.com/addaleax
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/AndreasMadsen
https://github.com/BethGriggs
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.