| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:020e53f7-0fb4-0796-9103-7fb006e621fc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D496:634F7:45599:543FE:6991EF25 |
| html-safe-nonce | 2b724ae5a2105911057764577d931192fafb9ccb5537dcd019c46658463dc878 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDk2OjYzNEY3OjQ1NTk5OjU0M0ZFOjY5OTFFRjI1IiwidmlzaXRvcl9pZCI6IjcwNTE1MzM2MTk2NjAxODk0NzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f4a8b2abbde9fc2277b20e7562e1760b7564dd7a7950b2433e4f407d763b4a55 |
| hovercard-subject-tag | pull_request:157970783 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17638/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/52da2d6353da3885cd9558633a715386d3aea7dc55b2bdc28623852ac1a4870b/nodejs/node/pull/17638 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/52da2d6353da3885cd9558633a715386d3aea7dc55b2bdc28623852ac1a4870b/nodejs/node/pull/17638 |
| og:image:alt | We change the awkward "Node.js style callback" phrasing to the
more informative "error-first style callback," which is more
in line with its usage
Refs: #17593 (comment)
Checkl... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lossycache |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17638#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17638 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17638 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17638 |
| Reload | https://github.com/nodejs/node/pull/17638 |
| Reload | https://github.com/nodejs/node/pull/17638 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
715
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| lossycache | https://github.com/lossycache |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lossycache:doc-error-first-callback | https://github.com/lossycache/node/tree/doc-error-first-callback |
| Conversation | https://github.com/nodejs/node/pull/17638 |
| Commits4 (4) | https://github.com/nodejs/node/pull/17638/commits |
| Checks | https://github.com/nodejs/node/pull/17638/checks |
| Files changed | https://github.com/nodejs/node/pull/17638/files |
| doc: change Node.js style to error-first style | https://github.com/nodejs/node/pull/17638#top |
| lossycache | https://github.com/lossycache |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lossycache:doc-error-first-callback | https://github.com/lossycache/node/tree/doc-error-first-callback |
|
| https://github.com/lossycache |
| lossycache | https://github.com/lossycache |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17638#issue-281579027 |
| #17593 (comment) | https://github.com/nodejs/node/pull/17593#discussion_r155963767 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17638#event-1384674354 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 13, 2017
| https://github.com/nodejs/node/pull/17638#pullrequestreview-83025319 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17638/files |
| https://github.com/lossycache |
| lossycache | https://github.com/lossycache |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17638#issuecomment-351238569 |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Dec 13, 2017
| https://github.com/nodejs/node/pull/17638#pullrequestreview-83026882 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17638/files |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17638#event-1384701035 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
|
Dec 13, 2017
| https://github.com/nodejs/node/pull/17638#pullrequestreview-83029629 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17638/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 13, 2017
| https://github.com/nodejs/node/pull/17638#pullrequestreview-83032991 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17638/files |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/17638#pullrequestreview-83032991 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 13, 2017
| https://github.com/nodejs/node/pull/17638#pullrequestreview-83033372 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17638/files |
| doc/api/errors.md | https://github.com/nodejs/node/pull/17638/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| Trott | https://github.com/Trott |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17638#discussion_r156539291 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://en.wikipedia.org/wiki/Wikipedia:Manual_of_Style/Text_formatting#Words_as_words | https://en.wikipedia.org/wiki/Wikipedia:Manual_of_Style/Text_formatting#Words_as_words |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| lossycache | https://github.com/lossycache |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17638#discussion_r156551465 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17638#issuecomment-351245810 |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Dec 13, 2017
| https://github.com/nodejs/node/pull/17638#pullrequestreview-83058954 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17638/files |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17638#issuecomment-351304343 |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| https://ci.nodejs.org/job/node-test-pull-request-lite/17/ | https://ci.nodejs.org/job/node-test-pull-request-lite/17/ |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 13, 2017
| https://github.com/nodejs/node/pull/17638#pullrequestreview-83166707 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17638/files |
| BridgeAR | https://github.com/BridgeAR |
| https://github.com/nodejs/node/pull/17638#pullrequestreview-83166707 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/17638/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| BridgeAR | https://github.com/BridgeAR |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17638#discussion_r156655302 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| Trott | https://github.com/Trott |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17638#discussion_r156663216 |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| lossycache | https://github.com/lossycache |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17638#discussion_r156750188 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Dec 13, 2017
| https://github.com/nodejs/node/pull/17638#pullrequestreview-83179930 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17638/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Dec 13, 2017
| https://github.com/nodejs/node/pull/17638#pullrequestreview-83244321 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17638/files |
| lossycache | https://github.com/lossycache |
| December 13, 2017 18:56 | https://github.com/nodejs/node/pull/17638#commits-pushed-324b87b |
|
| https://github.com/lossycache |
| doc: change Node.js style to error-first style | https://github.com/nodejs/node/pull/17638/commits/324b87b208b80325e71612e7665cd1c1a04ffbbe |
| 324b87b | https://github.com/nodejs/node/pull/17638/commits/324b87b208b80325e71612e7665cd1c1a04ffbbe |
| nodejs#17593 (comment) | https://github.com/nodejs/node/pull/17593#discussion_r155963767 |
|
| https://github.com/lossycache |
| doc: remove style, update callbackify | https://github.com/nodejs/node/pull/17638/commits/5fc61ad1a1d33de85c0d5d8449a28e78ba34e262 |
| 5fc61ad | https://github.com/nodejs/node/pull/17638/commits/5fc61ad1a1d33de85c0d5d8449a28e78ba34e262 |
|
| https://github.com/lossycache |
| doc: remove style from errors.md | https://github.com/nodejs/node/pull/17638/commits/1f288e1cf78d107d1a6413eb0721223be231cfe0 |
| 1f288e1 | https://github.com/nodejs/node/pull/17638/commits/1f288e1cf78d107d1a6413eb0721223be231cfe0 |
|
| https://github.com/lossycache |
| doc: retain old phrasing | https://github.com/nodejs/node/pull/17638/commits/9f13040eabd4ec8493a30c6cfd6a76cc2af9603d |
| 9f13040 | https://github.com/nodejs/node/pull/17638/commits/9f13040eabd4ec8493a30c6cfd6a76cc2af9603d |
| https://github.com/lossycache |
| lossycache | https://github.com/lossycache |
| force-pushed | https://github.com/nodejs/node/compare/5db6ae541c81a2617758adcbf1e460d5f12e28fb..9f13040eabd4ec8493a30c6cfd6a76cc2af9603d |
| 5db6ae5 | https://github.com/nodejs/node/commit/5db6ae541c81a2617758adcbf1e460d5f12e28fb |
| 9f13040 | https://github.com/nodejs/node/commit/9f13040eabd4ec8493a30c6cfd6a76cc2af9603d |
|
Compare
| https://github.com/nodejs/node/compare/5db6ae541c81a2617758adcbf1e460d5f12e28fb..9f13040eabd4ec8493a30c6cfd6a76cc2af9603d |
| December 13, 2017 18:57 | https://github.com/nodejs/node/pull/17638#event-1386263301 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 14, 2017 | https://github.com/nodejs/node/pull/17638#issuecomment-351738422 |
| https://ci.nodejs.org/job/node-test-pull-request-lite/19/ | https://ci.nodejs.org/job/node-test-pull-request-lite/19/ |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Dec 14, 2017
| https://github.com/nodejs/node/pull/17638#pullrequestreview-83584388 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17638/files/9f13040eabd4ec8493a30c6cfd6a76cc2af9603d |
| apapirovski | https://github.com/apapirovski |
|
Dec 17, 2017
| https://github.com/nodejs/node/pull/17638#ref-commit-3db136a |
|
| https://github.com/lossycache |
|
| https://github.com/apapirovski |
| doc: change "Node.js style cb" to "error-first cb" | https://github.com/nodejs/node/commit/3db136a74a34d610a0bea26f7da46ea2f33d96db |
| 3db136a | https://github.com/nodejs/node/commit/3db136a74a34d610a0bea26f7da46ea2f33d96db |
| #17638 | https://github.com/nodejs/node/pull/17638 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 17, 2017 | https://github.com/nodejs/node/pull/17638#issuecomment-352274859 |
| 3db136a | https://github.com/nodejs/node/commit/3db136a74a34d610a0bea26f7da46ea2f33d96db |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 17, 2017 | https://github.com/nodejs/node/pull/17638#event-1391160729 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 8, 2018
| https://github.com/nodejs/node/pull/17638#ref-commit-e97c858 |
|
| https://github.com/lossycache |
|
| https://github.com/MylesBorins |
| doc: change "Node.js style cb" to "error-first cb" | https://github.com/nodejs/node/commit/e97c858b25481f385277e6ea2ea7d66397889f9a |
| e97c858 | https://github.com/nodejs/node/commit/e97c858b25481f385277e6ea2ea7d66397889f9a |
| #17638 | https://github.com/nodejs/node/pull/17638 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 9, 2018
| https://github.com/nodejs/node/pull/17638#ref-commit-e059bc5 |
|
| https://github.com/lossycache |
|
| https://github.com/MylesBorins |
| doc: change "Node.js style cb" to "error-first cb" | https://github.com/nodejs/node/commit/e059bc5503dab30ae8636abc3e906f8c2976d380 |
| e059bc5 | https://github.com/nodejs/node/commit/e059bc5503dab30ae8636abc3e906f8c2976d380 |
| #17638 | https://github.com/nodejs/node/pull/17638 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 10, 2018
| https://github.com/nodejs/node/pull/17638#ref-pullrequest-287276543 |
|
v9.4.0 proposal
#18069
| https://github.com/nodejs/node/pull/18069 |
| boingoing | https://github.com/boingoing |
|
Jan 18, 2018
| https://github.com/nodejs/node/pull/17638#ref-commit-51c237a |
|
| https://github.com/lossycache |
|
| https://github.com/boingoing |
| doc: change "Node.js style cb" to "error-first cb" | https://github.com/nodejs/node-chakracore/commit/51c237a950a94aa2783c2ef8bfa49d73ddda0605 |
| 51c237a | https://github.com/nodejs/node-chakracore/commit/51c237a950a94aa2783c2ef8bfa49d73ddda0605 |
| nodejs/node#17638 | https://github.com/nodejs/node/pull/17638 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Jan 23, 2018 | https://github.com/nodejs/node/pull/17638#event-1436688000 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 23, 2018
| https://github.com/nodejs/node/pull/17638#ref-commit-6215004 |
|
| https://github.com/lossycache |
|
| https://github.com/MylesBorins |
| doc: change "Node.js style cb" to "error-first cb" | https://github.com/nodejs/node/commit/6215004c3a59522cb3e592f0816fdaa0024c7a5f |
| 6215004 | https://github.com/nodejs/node/commit/6215004c3a59522cb3e592f0816fdaa0024c7a5f |
| #17638 | https://github.com/nodejs/node/pull/17638 |
| gibfahn | https://github.com/gibfahn |
|
Jan 24, 2018
| https://github.com/nodejs/node/pull/17638#ref-commit-7601bb0 |
|
| https://github.com/lossycache |
|
| https://github.com/gibfahn |
| doc: change "Node.js style cb" to "error-first cb" | https://github.com/nodejs/node/commit/7601bb0ba003dc9a817bd154af49f4f54b599e23 |
| 7601bb0 | https://github.com/nodejs/node/commit/7601bb0ba003dc9a817bd154af49f4f54b599e23 |
| #17638 | https://github.com/nodejs/node/pull/17638 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17638 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/17638/files/5db6ae541c81a2617758adcbf1e460d5f12e28fb |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/17638/files/d6fa14bec99eaa2c1ab1a163e5ee1663f038f5bc |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/17638/files/5db6ae541c81a2617758adcbf1e460d5f12e28fb |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/17638/files/5db6ae541c81a2617758adcbf1e460d5f12e28fb |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/17638/files/5db6ae541c81a2617758adcbf1e460d5f12e28fb |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/17638/files/5db6ae541c81a2617758adcbf1e460d5f12e28fb |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
| https://github.com/nodejs/node/pull/17638/files/9f13040eabd4ec8493a30c6cfd6a76cc2af9603d |
|
| https://github.com/maclover7 |
|
maclover7
| https://github.com/maclover7 |
|
| https://github.com/nodejs/node/pull/17638/files/d6fa14bec99eaa2c1ab1a163e5ee1663f038f5bc |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/17638/files/d6fa14bec99eaa2c1ab1a163e5ee1663f038f5bc |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Please reload this page | https://github.com/nodejs/node/pull/17638 |
|
| https://github.com/lossycache |
|
| https://github.com/maclover7 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/apapirovski |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/Fishrock123 |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |