| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:374d7492-a05d-386b-b3a3-31dbf36577d3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9CC8:13BA54:AF5CE20:B2BF90D:6A50BCCD |
| html-safe-nonce | 97e27555a5db0b716274a9ece28144c07f77606fb7f1daef79ae4b6ab9818a73 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0M4OjEzQkE1NDpBRjVDRTIwOkIyQkY5MEQ6NkE1MEJDQ0QiLCJ2aXNpdG9yX2lkIjoiODA0NDE0NzQ4ODU5MDk3MDA2MSIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9 |
| visitor-hmac | 4d61877806447cd6b353e3527e2e99d455ea7767fa53f553e0c16f6806ef8fb5 |
| hovercard-subject-tag | pull_request:157696678 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17620/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/16cec4fe97abf7fb9856022118c4fbe895aef62d6aefa226ee6e882dd7e4230b/nodejs/node/pull/17620 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/16cec4fe97abf7fb9856022118c4fbe895aef62d6aefa226ee6e882dd7e4230b/nodejs/node/pull/17620 |
| og:image:alt | Fixes #16617
This is my stab at adding ref and unref on ClientHttp2Session instances. It seems mostly straightforward, but there were a few questions I had in mind about this code change:
Should C... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kjin |
| hostname | github.com |
| expected-hostname | github.com |
| None | 72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 08e79d53fc070870d5b168356afebb1e286a2ffe |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17620#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17620 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17620 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17620 |
| Reload | https://github.com/nodejs/node/pull/17620 |
| Reload | https://github.com/nodejs/node/pull/17620 |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
979
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| kjin | https://github.com/kjin |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| kjin:http2-client-session-ref | https://github.com/kjin/node/tree/http2-client-session-ref |
| Conversation | https://github.com/nodejs/node/pull/17620 |
| Commits6 (6) | https://github.com/nodejs/node/pull/17620/commits |
| Checks | https://github.com/nodejs/node/pull/17620/checks |
| Files changed | https://github.com/nodejs/node/pull/17620/files |
| http2: implement ref() and unref() on sessions | https://github.com/nodejs/node/pull/17620#top |
| kjin | https://github.com/kjin |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| kjin:http2-client-session-ref | https://github.com/kjin/node/tree/http2-client-session-ref |
|
| https://github.com/kjin |
| kjin | https://github.com/kjin |
| Dec 11, 2017 | https://github.com/nodejs/node/pull/17620#issue-281200506 |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| #16617 | https://github.com/nodejs/node/issues/16617 |
| this comment | https://github.com/nodejs/node/issues/16617#issuecomment-340571382 |
| @addaleax | https://github.com/addaleax |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
| Dec 11, 2017 | https://github.com/nodejs/node/pull/17620#event-1382509736 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Dec 11, 2017
| https://github.com/nodejs/node/pull/17620#pullrequestreview-82674209 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17620/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/17620#pullrequestreview-82674209 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| this comment | https://github.com/nodejs/node/issues/16617#issuecomment-340571382 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| doc/api/http2.md | https://github.com/nodejs/node/pull/17620/files#diff-f63531002261f56a8c6723723d2b7e6d05ea9ec8d433195fdf7c47728f6e3700 |
| addaleax | https://github.com/addaleax |
| Dec 11, 2017 | https://github.com/nodejs/node/pull/17620#discussion_r156230599 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| lib/internal/http2/core.js | https://github.com/nodejs/node/pull/17620/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639 |
| addaleax | https://github.com/addaleax |
| Dec 11, 2017 | https://github.com/nodejs/node/pull/17620#discussion_r156231350 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/kjin |
| kjin | https://github.com/kjin |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17620#issuecomment-350920099 |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17620#issuecomment-350921123 |
| @kjin | https://github.com/kjin |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/kjin |
| kjin | https://github.com/kjin |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17620#issuecomment-350923118 |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/kjin |
| kjin | https://github.com/kjin |
| force-pushed | https://github.com/nodejs/node/compare/826acba2742301731781a550fa2e5c40597b434f..8714f6ffed5a519d6424007937c26601d58c36dd |
| 826acba | https://github.com/nodejs/node/commit/826acba2742301731781a550fa2e5c40597b434f |
| 8714f6f | https://github.com/nodejs/node/commit/8714f6ffed5a519d6424007937c26601d58c36dd |
|
Compare
| https://github.com/nodejs/node/compare/826acba2742301731781a550fa2e5c40597b434f..8714f6ffed5a519d6424007937c26601d58c36dd |
| December 12, 2017 19:28 | https://github.com/nodejs/node/pull/17620#event-1384258351 |
| https://github.com/kjin |
| kjin | https://github.com/kjin |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17620#issuecomment-351167035 |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/kjin |
| kjin | https://github.com/kjin |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17620#event-1384264785 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17620#issuecomment-351232065 |
| #17406 | https://github.com/nodejs/node/pull/17406 |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17620#issuecomment-351317060 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Dec 13, 2017
| https://github.com/nodejs/node/pull/17620#pullrequestreview-83090431 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17620/files |
| lib/internal/http2/core.js | https://github.com/nodejs/node/pull/17620/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639 |
| addaleax | https://github.com/addaleax |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17620#discussion_r156589673 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| kjin | https://github.com/kjin |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17620#discussion_r156738984 |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17620#issuecomment-351319251 |
| @TimothyGu | https://github.com/TimothyGu |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| kjin | https://github.com/kjin |
| December 20, 2017 13:47 | https://github.com/nodejs/node/pull/17620#commits-pushed-41b9978 |
|
| https://github.com/kjin |
| http2: implement ref() and unref() on client sessions | https://github.com/nodejs/node/pull/17620/commits/41b9978841b336535d9526589ee4583a6ab68b1a |
| 41b9978 | https://github.com/nodejs/node/pull/17620/commits/41b9978841b336535d9526589ee4583a6ab68b1a |
|
| https://github.com/kjin |
| address comments | https://github.com/nodejs/node/pull/17620/commits/34f36bb5d5bc2592d4bef052e05e9cda579d6fdf |
| 34f36bb | https://github.com/nodejs/node/pull/17620/commits/34f36bb5d5bc2592d4bef052e05e9cda579d6fdf |
| https://github.com/kjin |
| kjin | https://github.com/kjin |
| force-pushed | https://github.com/nodejs/node/compare/f6016548fe8d9473b9bec97c063dbebc8bf08777..03461262109a6108b827b991fa1b13800e456447 |
| f601654 | https://github.com/nodejs/node/commit/f6016548fe8d9473b9bec97c063dbebc8bf08777 |
| 0346126 | https://github.com/nodejs/node/commit/03461262109a6108b827b991fa1b13800e456447 |
|
Compare
| https://github.com/nodejs/node/compare/f6016548fe8d9473b9bec97c063dbebc8bf08777..03461262109a6108b827b991fa1b13800e456447 |
| December 20, 2017 21:51 | https://github.com/nodejs/node/pull/17620#event-1396957692 |
| kjin | https://github.com/kjin |
| December 20, 2017 13:53 | https://github.com/nodejs/node/pull/17620#commits-pushed-d8c9017 |
|
| https://github.com/kjin |
| make unref a property of http2session | https://github.com/nodejs/node/pull/17620/commits/d8c901768c2382a6ccd646a9cd292beebea81c71 |
| d8c9017 | https://github.com/nodejs/node/pull/17620/commits/d8c901768c2382a6ccd646a9cd292beebea81c71 |
|
| https://github.com/kjin |
| fix lint | https://github.com/nodejs/node/pull/17620/commits/55b9fc4c8b3ae96ad998031d1762b8e8cf614374 |
| 55b9fc4 | https://github.com/nodejs/node/pull/17620/commits/55b9fc4c8b3ae96ad998031d1762b8e8cf614374 |
|
| https://github.com/kjin |
| check ref/unref on _handle in net.socket | https://github.com/nodejs/node/pull/17620/commits/c64f6b1fc826b9b8546d7dab30e571de8b3fd00c |
| c64f6b1 | https://github.com/nodejs/node/pull/17620/commits/c64f6b1fc826b9b8546d7dab30e571de8b3fd00c |
| https://github.com/kjin |
| kjin | https://github.com/kjin |
| force-pushed | https://github.com/nodejs/node/compare/03461262109a6108b827b991fa1b13800e456447..c64f6b1fc826b9b8546d7dab30e571de8b3fd00c |
| 0346126 | https://github.com/nodejs/node/commit/03461262109a6108b827b991fa1b13800e456447 |
| c64f6b1 | https://github.com/nodejs/node/commit/c64f6b1fc826b9b8546d7dab30e571de8b3fd00c |
|
Compare
| https://github.com/nodejs/node/compare/03461262109a6108b827b991fa1b13800e456447..c64f6b1fc826b9b8546d7dab30e571de8b3fd00c |
| December 20, 2017 21:53 | https://github.com/nodejs/node/pull/17620#event-1396961381 |
| https://github.com/kjin |
| kjin | https://github.com/kjin |
| Dec 20, 2017 | https://github.com/nodejs/node/pull/17620#issuecomment-353194806 |
| @jasnell | https://github.com/jasnell |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17620#pullrequestreview-84920762 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17620/files/c64f6b1fc826b9b8546d7dab30e571de8b3fd00c |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Dec 21, 2017
| https://github.com/nodejs/node/pull/17620#pullrequestreview-85181960 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17620/files |
| https://github.com/kjin |
| kjin | https://github.com/kjin |
| force-pushed | https://github.com/nodejs/node/compare/79739eb0c2c394f513316674e34fb12547ae3ac2..f29e6a7826905433d31949c5e190ef609d3e13a4 |
| 79739eb | https://github.com/nodejs/node/commit/79739eb0c2c394f513316674e34fb12547ae3ac2 |
| f29e6a7 | https://github.com/nodejs/node/commit/f29e6a7826905433d31949c5e190ef609d3e13a4 |
|
Compare
| https://github.com/nodejs/node/compare/79739eb0c2c394f513316674e34fb12547ae3ac2..f29e6a7826905433d31949c5e190ef609d3e13a4 |
| December 21, 2017 21:08 | https://github.com/nodejs/node/pull/17620#event-1398697896 |
|
| https://github.com/kjin |
| redo test to use duplex pair instead of PassThrough | https://github.com/nodejs/node/pull/17620/commits/b3d25136150e8ad3073ef1a9e0cfdd0ccff82b51 |
| b3d2513 | https://github.com/nodejs/node/pull/17620/commits/b3d25136150e8ad3073ef1a9e0cfdd0ccff82b51 |
| https://github.com/kjin |
| kjin | https://github.com/kjin |
| force-pushed | https://github.com/nodejs/node/compare/f29e6a7826905433d31949c5e190ef609d3e13a4..b3d25136150e8ad3073ef1a9e0cfdd0ccff82b51 |
| f29e6a7 | https://github.com/nodejs/node/commit/f29e6a7826905433d31949c5e190ef609d3e13a4 |
| b3d2513 | https://github.com/nodejs/node/commit/b3d25136150e8ad3073ef1a9e0cfdd0ccff82b51 |
|
Compare
| https://github.com/nodejs/node/compare/f29e6a7826905433d31949c5e190ef609d3e13a4..b3d25136150e8ad3073ef1a9e0cfdd0ccff82b51 |
| December 21, 2017 21:19 | https://github.com/nodejs/node/pull/17620#event-1398711834 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Dec 22, 2017 | https://github.com/nodejs/node/pull/17620#issuecomment-353686261 |
| https://ci.nodejs.org/job/node-test-pull-request/12269/ | https://ci.nodejs.org/job/node-test-pull-request/12269/ |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 27, 2017 | https://github.com/nodejs/node/pull/17620#event-1402890445 |
| jasnell | https://github.com/jasnell |
|
Dec 28, 2017
| https://github.com/nodejs/node/pull/17620#ref-commit-120ea9b |
|
| https://github.com/kjin |
|
| https://github.com/jasnell |
| http2: implement ref() and unref() on client sessions | https://github.com/nodejs/node/commit/120ea9b5c480c985dc77846a150008f6092c08d0 |
| 120ea9b | https://github.com/nodejs/node/commit/120ea9b5c480c985dc77846a150008f6092c08d0 |
| #17620 | https://github.com/nodejs/node/pull/17620 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Dec 28, 2017 | https://github.com/nodejs/node/pull/17620#issuecomment-354328383 |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Dec 28, 2017 | https://github.com/nodejs/node/pull/17620#event-1403832986 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 29, 2017 | https://github.com/nodejs/node/pull/17620#event-1404416686 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 9, 2018
| https://github.com/nodejs/node/pull/17620#ref-commit-afa4a7c |
|
| https://github.com/kjin |
|
| https://github.com/MylesBorins |
| http2: implement ref() and unref() on client sessions | https://github.com/jasnell/node/commit/afa4a7c0d2ca9da9ca0907b0ca1f5bc99e430f99 |
| afa4a7c | https://github.com/jasnell/node/commit/afa4a7c0d2ca9da9ca0907b0ca1f5bc99e430f99 |
| nodejs#17620 | https://github.com/nodejs/node/pull/17620 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 9, 2018
| https://github.com/nodejs/node/pull/17620#ref-commit-e640e34 |
|
| https://github.com/kjin |
|
| https://github.com/MylesBorins |
| http2: implement ref() and unref() on client sessions | https://github.com/nodejs/node/commit/e640e34a774e9da4025616ff17c91fbc3664b6c1 |
| e640e34 | https://github.com/nodejs/node/commit/e640e34a774e9da4025616ff17c91fbc3664b6c1 |
| #18050 | https://github.com/nodejs/node/pull/18050 |
| #17620 | https://github.com/nodejs/node/pull/17620 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 10, 2018
| https://github.com/nodejs/node/pull/17620#ref-pullrequest-287276543 |
|
v9.4.0 proposal
#18069
| https://github.com/nodejs/node/pull/18069 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 10, 2018
| https://github.com/nodejs/node/pull/17620#ref-commit-1b7ce1e |
|
| https://github.com/kjin |
|
| https://github.com/MylesBorins |
| http2: implement ref() and unref() on client sessions | https://github.com/nodejs/node/commit/1b7ce1ea024f639e8a0863e0fc76902143237f60 |
| 1b7ce1e | https://github.com/nodejs/node/commit/1b7ce1ea024f639e8a0863e0fc76902143237f60 |
| #18050 | https://github.com/nodejs/node/pull/18050 |
| #17620 | https://github.com/nodejs/node/pull/17620 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Apr 12, 2018 | https://github.com/nodejs/node/pull/17620#issuecomment-380872130 |
| @gibfahn | https://github.com/gibfahn |
| @kjin | https://github.com/kjin |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Apr 12, 2018 | https://github.com/nodejs/node/pull/17620#issuecomment-380895621 |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| https://github.com/kjin |
| kjin | https://github.com/kjin |
| Apr 12, 2018 | https://github.com/nodejs/node/pull/17620#issuecomment-380910290 |
| @gibfahn | https://github.com/gibfahn |
| #17406 | https://github.com/nodejs/node/pull/17406 |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
| kjin | https://github.com/kjin |
|
May 1, 2018
| https://github.com/nodejs/node/pull/17620#ref-commit-3bf3eb8 |
|
| https://github.com/kjin |
| http2: implement ref() and unref() on client sessions | https://github.com/kjin/node/commit/3bf3eb828d247677f7dc97b559c99dd33113c595 |
| 3bf3eb8 | https://github.com/kjin/node/commit/3bf3eb828d247677f7dc97b559c99dd33113c595 |
| nodejs#18050 | https://github.com/nodejs/node/pull/18050 |
| nodejs#17620 | https://github.com/nodejs/node/pull/17620 |
| MylesBorins | https://github.com/MylesBorins |
|
May 2, 2018
| https://github.com/nodejs/node/pull/17620#ref-commit-72b42de |
|
| https://github.com/kjin |
|
| https://github.com/MylesBorins |
| http2: implement ref() and unref() on client sessions | https://github.com/nodejs/node/commit/72b42de33a78b1a23721f5295fe36274d15bf688 |
| 72b42de | https://github.com/nodejs/node/commit/72b42de33a78b1a23721f5295fe36274d15bf688 |
| #18050 | https://github.com/nodejs/node/pull/18050 |
| #20456 | https://github.com/nodejs/node/pull/20456 |
| #17620 | https://github.com/nodejs/node/pull/17620 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
May 2, 2018
| https://github.com/nodejs/node/pull/17620#ref-pullrequest-319669485 |
|
v8.11.2 proposal
#20478
| https://github.com/nodejs/node/pull/20478 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17620 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/17620/files/c64f6b1fc826b9b8546d7dab30e571de8b3fd00c |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/17620/files/79739eb0c2c394f513316674e34fb12547ae3ac2 |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
|
http2: implement ref() and unref() on client sessions
| https://github.com/nodejs/node/issues/16617 |
| Please reload this page | https://github.com/nodejs/node/pull/17620 |
|
| https://github.com/kjin |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/TimothyGu |
|
| https://github.com/ofrobots |
|
| https://github.com/gibfahn |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |