René's URL Explorer Experiment


Title: doc: note that randomBytes throws when passed null by tniessen · Pull Request #17594 · nodejs/node · GitHub

Open Graph Title: doc: note that randomBytes throws when passed null by tniessen · Pull Request #17594 · nodejs/node

X Title: doc: note that randomBytes throws when passed null by tniessen · Pull Request #17594 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: As discussed in the issue below, it might be helpful to document this change, which was introduced in #16454. Fixes: #16778 Checklist documentation is changed or added commit message follows c...

X Description: As discussed in the issue below, it might be helpful to document this change, which was introduced in #16454. Fixes: #16778 Checklist documentation is changed or added commit message follows c...

Opengraph URL: https://github.com/nodejs/node/pull/17594

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1e4b62c9-9aef-aa80-7e83-4e2e2f3785cc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96B4:1587FA:ADB130:E6BD46:6AED3714
html-safe-nonce153d9e97a9470e537c34616345864b2966c48e2629e78e6f9f449773ed95e64c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkI0OjE1ODdGQTpBREIxMzA6RTZCRDQ2OjZBRUQzNzE0IiwidmlzaXRvcl9pZCI6IjU3MDA3ODEzNjAxNjcwNzM1NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5760f69bdc07cc51fb0fea1cf40210d6c36d8811f7cc18fda4a44766855fb67b
hovercard-subject-tagpull_request:157448009
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17594/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8c17345d5b37bdfe82981bd5d667f98ebb3df09ea571c233467c57c5f95794c6/nodejs/node/pull/17594
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c17345d5b37bdfe82981bd5d667f98ebb3df09ea571c233467c57c5f95794c6/nodejs/node/pull/17594
og:image:altAs discussed in the issue below, it might be helpful to document this change, which was introduced in #16454. Fixes: #16778 Checklist documentation is changed or added commit message follows c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None26c92a9388ddfad3fa88d132b5d5f0b4747030233dcc4e5efb05f1cbae152184
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec629ad99c254d306375fc8354d04321c2c362236
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17594#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17594
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17594
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17594
Reloadhttps://github.com/nodejs/node/pull/17594
Reloadhttps://github.com/nodejs/node/pull/17594
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:doc-random-bytes-callback-null-throwshttps://github.com/tniessen/node/tree/doc-random-bytes-callback-null-throws
Conversationhttps://github.com/nodejs/node/pull/17594
Commits1 (1)https://github.com/nodejs/node/pull/17594/commits
Checkshttps://github.com/nodejs/node/pull/17594/checks
Files changedhttps://github.com/nodejs/node/pull/17594/files
doc: note that randomBytes throws when passed nullhttps://github.com/nodejs/node/pull/17594#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:doc-random-bytes-callback-null-throwshttps://github.com/tniessen/node/tree/doc-random-bytes-callback-null-throws
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Dec 10, 2017https://github.com/nodejs/node/pull/17594#issue-280841002
#16454https://github.com/nodejs/node/pull/16454
#16778https://github.com/nodejs/node/issues/16778
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17594
https://github.com/tniessen
doc: note that randomBytes throws when passed nullhttps://github.com/nodejs/node/pull/17594/commits/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
0da22bdhttps://github.com/nodejs/node/pull/17594/commits/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
nodejs#16778https://github.com/nodejs/node/issues/16778
https://github.com/tniessen
tniessenhttps://github.com/tniessen
jasnellhttps://github.com/jasnell
joyeecheunghttps://github.com/joyeecheung
December 10, 2017 20:17https://github.com/nodejs/node/pull/17594#event-1380490848
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Dec 10, 2017https://github.com/nodejs/node/pull/17594#event-1380490881
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 10, 2017 https://github.com/nodejs/node/pull/17594#pullrequestreview-82361206
View reviewed changes https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 10, 2017 https://github.com/nodejs/node/pull/17594#pullrequestreview-82366022
View reviewed changes https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 11, 2017 https://github.com/nodejs/node/pull/17594#pullrequestreview-82375144
View reviewed changes https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 11, 2017 https://github.com/nodejs/node/pull/17594#pullrequestreview-82386733
View reviewed changes https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 12, 2017 https://github.com/nodejs/node/pull/17594#pullrequestreview-82761385
View reviewed changes https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 12, 2017 https://github.com/nodejs/node/pull/17594#pullrequestreview-82761908
View reviewed changes https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 12, 2017 https://github.com/nodejs/node/pull/17594#pullrequestreview-82850255
View reviewed changes https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 12, 2017https://github.com/nodejs/node/pull/17594#issuecomment-351069570
https://ci.nodejs.org/job/node-test-pull-request-lite/14/https://ci.nodejs.org/job/node-test-pull-request-lite/14/
Please reload this pagehttps://github.com/nodejs/node/pull/17594
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 12, 2017https://github.com/nodejs/node/pull/17594#event-1384002237
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 12, 2017https://github.com/nodejs/node/pull/17594#issuecomment-351155799
Please reload this pagehttps://github.com/nodejs/node/pull/17594
2c77cabhttps://github.com/nodejs/node/commit/2c77cab4402ffcfc47367b14e0008258a70fd469
Please reload this pagehttps://github.com/nodejs/node/pull/17594
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 12, 2017https://github.com/nodejs/node/pull/17594#event-1384212136
BridgeARhttps://github.com/BridgeAR
Dec 12, 2017 https://github.com/nodejs/node/pull/17594#ref-commit-2c77cab
https://github.com/tniessen
https://github.com/BridgeAR
doc: note that randomBytes throws when passed nullhttps://github.com/BridgeAR/node/commit/2c77cab4402ffcfc47367b14e0008258a70fd469
2c77cabhttps://github.com/BridgeAR/node/commit/2c77cab4402ffcfc47367b14e0008258a70fd469
nodejs#16778https://github.com/nodejs/node/issues/16778
nodejs#17594https://github.com/nodejs/node/pull/17594
nodejs#16778https://github.com/nodejs/node/issues/16778
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 13, 2017https://github.com/nodejs/node/pull/17594#event-1384945775
MylesBorinshttps://github.com/MylesBorins
Jan 8, 2018 https://github.com/nodejs/node/pull/17594#ref-commit-d70e6dc
https://github.com/tniessen
https://github.com/MylesBorins
doc: note that randomBytes throws when passed nullhttps://github.com/nodejs/node/commit/d70e6dc850a953e59e9f24abc59e375d1696461c
d70e6dchttps://github.com/nodejs/node/commit/d70e6dc850a953e59e9f24abc59e375d1696461c
#16778https://github.com/nodejs/node/issues/16778
#17594https://github.com/nodejs/node/pull/17594
#16778https://github.com/nodejs/node/issues/16778
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 10, 2018 https://github.com/nodejs/node/pull/17594#ref-pullrequest-287276543
v9.4.0 proposal #18069 https://github.com/nodejs/node/pull/18069
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Jan 22, 2018https://github.com/nodejs/node/pull/17594#event-1434646459
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17594
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
https://github.com/maclover7
maclover7 https://github.com/maclover7
https://github.com/nodejs/node/pull/17594/files/0da22bd79fe6ff9e94823ed716c4b1546e46e4d8
Please reload this pagehttps://github.com/nodejs/node/pull/17594
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Possible regression with crypto.randomBytes(size, null) https://github.com/nodejs/node/issues/16778
Please reload this pagehttps://github.com/nodejs/node/pull/17594
https://github.com/tniessen
https://github.com/maclover7
https://github.com/BridgeAR
https://github.com/apapirovski
https://github.com/danbev
https://github.com/Trott
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/MylesBorins
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.