| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:20d37e0e-efc6-fa6d-9045-7dbb44b4d684 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9BD4:145B41:6606A:83923:6991CE31 |
| html-safe-nonce | fbb01bf6af6f57f444878efe72b0ebcbb428622c548d9ee8ec38cf4d291f685a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkQ0OjE0NUI0MTo2NjA2QTo4MzkyMzo2OTkxQ0UzMSIsInZpc2l0b3JfaWQiOiIxMTA0NDk3NTI4MjMyMDcwNzA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | be8e58b46a301403590ceeff62c383119e03f8f7d313d5e68d284598565b5980 |
| hovercard-subject-tag | pull_request:157444370 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17593/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/43b2bf11dfea69d4e77ead0776d4c087d9d245b8f6f367b95b224267c1d975b1/nodejs/node/pull/17593 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/43b2bf11dfea69d4e77ead0776d4c087d9d245b8f6f367b95b224267c1d975b1/nodejs/node/pull/17593 |
| og:image:alt | Currently the documentation states that promisify() will result in
undefined behavior if bad arguments are passed. This is not necessarily
the case, since the behavior is well defined, but just not... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lossycache |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17593#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17593 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17593 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17593 |
| Reload | https://github.com/nodejs/node/pull/17593 |
| Reload | https://github.com/nodejs/node/pull/17593 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
713
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| lossycache | https://github.com/lossycache |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lossycache:doc-promisify-update | https://github.com/lossycache/node/tree/doc-promisify-update |
| Conversation | https://github.com/nodejs/node/pull/17593 |
| Commits3 (3) | https://github.com/nodejs/node/pull/17593/commits |
| Checks | https://github.com/nodejs/node/pull/17593/checks |
| Files changed | https://github.com/nodejs/node/pull/17593/files |
| doc: update promisify() docs with behavior when bad arguments are passed | https://github.com/nodejs/node/pull/17593#top |
| lossycache | https://github.com/lossycache |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lossycache:doc-promisify-update | https://github.com/lossycache/node/tree/doc-promisify-update |
|
| https://github.com/lossycache |
| lossycache | https://github.com/lossycache |
| Dec 10, 2017 | https://github.com/nodejs/node/pull/17593#issue-280833475 |
| #17569 | https://github.com/nodejs/node/issues/17569 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Dec 10, 2017 | https://github.com/nodejs/node/pull/17593#event-1380462159 |
| https://github.com/lossycache |
| lossycache | https://github.com/lossycache |
| Dec 10, 2017 | https://github.com/nodejs/node/pull/17593#event-1380468711 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
Dec 10, 2017
| https://github.com/nodejs/node/pull/17593#pullrequestreview-82360407 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17593/files |
| apapirovski | https://github.com/apapirovski |
| https://github.com/nodejs/node/pull/17593#pullrequestreview-82360407 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| doc/api/util.md | https://github.com/nodejs/node/pull/17593/files#diff-ca3b15ffa821a7666a735ddf0ec6f2d8f1d839b4d14ccd09e5af4e0e6443ca0e |
| apapirovski | https://github.com/apapirovski |
| Dec 10, 2017 | https://github.com/nodejs/node/pull/17593#discussion_r155958145 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| doc/api/util.md | https://github.com/nodejs/node/pull/17593/files#diff-ca3b15ffa821a7666a735ddf0ec6f2d8f1d839b4d14ccd09e5af4e0e6443ca0e |
| apapirovski | https://github.com/apapirovski |
| Dec 10, 2017 | https://github.com/nodejs/node/pull/17593#discussion_r155958154 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 10, 2017
| https://github.com/nodejs/node/pull/17593#pullrequestreview-82366219 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17593/files |
| doc/api/util.md | https://github.com/nodejs/node/pull/17593/files#diff-ca3b15ffa821a7666a735ddf0ec6f2d8f1d839b4d14ccd09e5af4e0e6443ca0e |
| Trott | https://github.com/Trott |
| Dec 10, 2017 | https://github.com/nodejs/node/pull/17593#discussion_r155963767 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| lpinca | https://github.com/lpinca |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17593#discussion_r156306620 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 10, 2017
| https://github.com/nodejs/node/pull/17593#pullrequestreview-82366236 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17593/files |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/17593#pullrequestreview-82366236 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 11, 2017
| https://github.com/nodejs/node/pull/17593#pullrequestreview-82386869 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17593/files |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Dec 11, 2017
| https://github.com/nodejs/node/pull/17593#pullrequestreview-82422883 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17593/files |
| benjamingr | https://github.com/benjamingr |
| https://github.com/nodejs/node/pull/17593#pullrequestreview-82422883 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
|
Dec 11, 2017
| https://github.com/nodejs/node/pull/17593#pullrequestreview-82638742 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17593/files |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| Dec 11, 2017 | https://github.com/nodejs/node/pull/17593#issuecomment-350859098 |
| https://ci.nodejs.org/job/node-test-pull-request-lite/12/ | https://ci.nodejs.org/job/node-test-pull-request-lite/12/ |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17593#pullrequestreview-82694705 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17593/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17593#pullrequestreview-82760445 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17593/files |
| doc/api/util.md | https://github.com/nodejs/node/pull/17593/files#diff-ca3b15ffa821a7666a735ddf0ec6f2d8f1d839b4d14ccd09e5af4e0e6443ca0e |
| lpinca | https://github.com/lpinca |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17593#discussion_r156306620 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| lossycache | https://github.com/lossycache |
| December 12, 2017 09:24 | https://github.com/nodejs/node/pull/17593#commits-pushed-2067648 |
|
| https://github.com/lossycache |
| doc: update promisify docs with behavior when bad arguments are passed | https://github.com/nodejs/node/pull/17593/commits/206764839f987cf5204b277d49bef19b0e18d69c |
| 2067648 | https://github.com/nodejs/node/pull/17593/commits/206764839f987cf5204b277d49bef19b0e18d69c |
| nodejs#17569 (comment) | https://github.com/nodejs/node/issues/17569#issuecomment-350534501 |
|
| https://github.com/lossycache |
| doc: use 'Node.js style' callback | https://github.com/nodejs/node/pull/17593/commits/1c272f9ca679e739c5e2a82cdd27a86ce6ae690d |
| 1c272f9 | https://github.com/nodejs/node/pull/17593/commits/1c272f9ca679e739c5e2a82cdd27a86ce6ae690d |
|
| https://github.com/lossycache |
| doc: fix line length and wording | https://github.com/nodejs/node/pull/17593/commits/e2155742dbbcc2ae3f88a3ea772fb7e6cb16c531 |
| e215574 | https://github.com/nodejs/node/pull/17593/commits/e2155742dbbcc2ae3f88a3ea772fb7e6cb16c531 |
| https://github.com/lossycache |
| lossycache | https://github.com/lossycache |
| force-pushed | https://github.com/nodejs/node/compare/dee6aba27ef5ff99fcc91357ed823455eda66b55..e2155742dbbcc2ae3f88a3ea772fb7e6cb16c531 |
| dee6aba | https://github.com/nodejs/node/commit/dee6aba27ef5ff99fcc91357ed823455eda66b55 |
| e215574 | https://github.com/nodejs/node/commit/e2155742dbbcc2ae3f88a3ea772fb7e6cb16c531 |
|
Compare
| https://github.com/nodejs/node/compare/dee6aba27ef5ff99fcc91357ed823455eda66b55..e2155742dbbcc2ae3f88a3ea772fb7e6cb16c531 |
| December 12, 2017 09:28 | https://github.com/nodejs/node/pull/17593#event-1383130177 |
| https://github.com/lossycache |
| lossycache | https://github.com/lossycache |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17593#issuecomment-350994897 |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17593#event-1384003630 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17593#issuecomment-351119407 |
| https://ci.nodejs.org/job/node-test-pull-request-lite/15/ | https://ci.nodejs.org/job/node-test-pull-request-lite/15/ |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17593#ref-commit-031d01b |
|
| https://github.com/lossycache |
|
| https://github.com/BridgeAR |
| doc: clearify promisify behavior for bad arguments | https://github.com/BridgeAR/node/commit/031d01bba5856ca9ebeb0646b902723b3cd4d9a3 |
| 031d01b | https://github.com/BridgeAR/node/commit/031d01bba5856ca9ebeb0646b902723b3cd4d9a3 |
| nodejs#17593 | https://github.com/nodejs/node/pull/17593 |
| nodejs#17569 | https://github.com/nodejs/node/issues/17569 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17593#issuecomment-351154909 |
| 031d01b | https://github.com/nodejs/node/commit/031d01bba5856ca9ebeb0646b902723b3cd4d9a3 |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17593#event-1384207889 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17593#issuecomment-351155488 |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| https://github.com/lossycache |
| lossycache | https://github.com/lossycache |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17593#issuecomment-351157962 |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17593#issuecomment-351158959 |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
| https://github.com/lossycache |
| lossycache | https://github.com/lossycache |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17593#ref-pullrequest-281579027 |
|
doc: change Node.js style to error-first style
#17638
| https://github.com/nodejs/node/pull/17638 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/17593#event-1384945925 |
| lossycache | https://github.com/lossycache |
|
Dec 13, 2017
| https://github.com/nodejs/node/pull/17593#ref-commit-324b87b |
|
| https://github.com/lossycache |
| doc: change Node.js style to error-first style | https://github.com/lossycache/node/commit/324b87b208b80325e71612e7665cd1c1a04ffbbe |
| 324b87b | https://github.com/lossycache/node/commit/324b87b208b80325e71612e7665cd1c1a04ffbbe |
| nodejs#17593 (comment) | https://github.com/nodejs/node/pull/17593#discussion_r155963767 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 8, 2018
| https://github.com/nodejs/node/pull/17593#ref-commit-da44821 |
|
| https://github.com/lossycache |
|
| https://github.com/MylesBorins |
| doc: clearify promisify behavior for bad arguments | https://github.com/nodejs/node/commit/da448216cc57204da135048069cf8c1367555ae4 |
| da44821 | https://github.com/nodejs/node/commit/da448216cc57204da135048069cf8c1367555ae4 |
| #17593 | https://github.com/nodejs/node/pull/17593 |
| #17569 | https://github.com/nodejs/node/issues/17569 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 10, 2018
| https://github.com/nodejs/node/pull/17593#ref-pullrequest-287276543 |
|
v9.4.0 proposal
#18069
| https://github.com/nodejs/node/pull/18069 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 22, 2018
| https://github.com/nodejs/node/pull/17593#ref-commit-24e7753 |
|
| https://github.com/lossycache |
|
| https://github.com/MylesBorins |
| doc: clearify promisify behavior for bad arguments | https://github.com/nodejs/node/commit/24e7753400ac65f45aa97ed5303a07267eb94045 |
| 24e7753 | https://github.com/nodejs/node/commit/24e7753400ac65f45aa97ed5303a07267eb94045 |
| #17593 | https://github.com/nodejs/node/pull/17593 |
| #17569 | https://github.com/nodejs/node/issues/17569 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Jan 22, 2018 | https://github.com/nodejs/node/pull/17593#event-1434645910 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17593 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/17593/files/dee6aba27ef5ff99fcc91357ed823455eda66b55 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/17593/files/dee6aba27ef5ff99fcc91357ed823455eda66b55 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/17593/files/dee6aba27ef5ff99fcc91357ed823455eda66b55 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/17593/files/dee6aba27ef5ff99fcc91357ed823455eda66b55 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/17593/files/dee6aba27ef5ff99fcc91357ed823455eda66b55 |
|
| https://github.com/apapirovski |
|
apapirovski
| https://github.com/apapirovski |
|
| https://github.com/nodejs/node/pull/17593/files/948b703dd73754c8dcce953d411e3c0e46b68264 |
|
| https://github.com/maclover7 |
|
maclover7
| https://github.com/maclover7 |
|
| https://github.com/nodejs/node/pull/17593/files/dee6aba27ef5ff99fcc91357ed823455eda66b55 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Please reload this page | https://github.com/nodejs/node/pull/17593 |
|
| https://github.com/lossycache |
|
| https://github.com/maclover7 |
|
| https://github.com/apapirovski |
|
| https://github.com/BridgeAR |
|
| https://github.com/Trott |
|
| https://github.com/benjamingr |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |