| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:34d1d1d0-fb2d-4684-62c3-1f2cfbee1044 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC5A:111866:1470735:1AD50B2:6A51B557 |
| html-safe-nonce | 598f8369bb8b2fc6dab36678ae6c7c0563afc5e0dce07769bdfdbae69ec63255 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzVBOjExMTg2NjoxNDcwNzM1OjFBRDUwQjI6NkE1MUI1NTciLCJ2aXNpdG9yX2lkIjoiMTQxNzE0MzAwMjQ3Mjc1NjU2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7774e24a600accd46ec134d03afbf231a822bf63557ce760ea07f445c4021e68 |
| hovercard-subject-tag | pull_request:157284543 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17549/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a904320c9a8a85d493a18e911297663c18d5ac0dfee24d13aa9faa0f6c2e6fb7/nodejs/node/pull/17549 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a904320c9a8a85d493a18e911297663c18d5ac0dfee24d13aa9faa0f6c2e6fb7/nodejs/node/pull/17549 |
| og:image:alt | Lint and some other minor fixes. Files modified :
test/parallel/test-assert.js
test/parallel/test-whatwg-url-setters.js
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mithunsasidharan |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17549#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17549 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17549 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17549 |
| Reload | https://github.com/nodejs/node/pull/17549 |
| Reload | https://github.com/nodejs/node/pull/17549 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
983
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mithunsasidharan | https://github.com/mithunsasidharan |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/17549 |
| Commits1 (1) | https://github.com/nodejs/node/pull/17549/commits |
| Checks | https://github.com/nodejs/node/pull/17549/checks |
| Files changed | https://github.com/nodejs/node/pull/17549/files |
| test : lint and few minor fixes | https://github.com/nodejs/node/pull/17549#top |
| mithunsasidharan | https://github.com/mithunsasidharan |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17549#issue-280547985 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
|
| https://github.com/mithunsasidharan |
| test : lint and minor fixes | https://github.com/nodejs/node/pull/17549/commits/b88c5fd2a461b508168a9acc6a5830f25a38e9b0 |
| b88c5fd | https://github.com/nodejs/node/pull/17549/commits/b88c5fd2a461b508168a9acc6a5830f25a38e9b0 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17549#event-1379152147 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
Dec 8, 2017
| https://github.com/nodejs/node/pull/17549#pullrequestreview-82214368 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17549/files/b88c5fd2a461b508168a9acc6a5830f25a38e9b0 |
| apapirovski | https://github.com/apapirovski |
| https://github.com/nodejs/node/pull/17549#pullrequestreview-82214368 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @mithunsasidharan | https://github.com/mithunsasidharan |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-350323975 |
| @apapirovski | https://github.com/apapirovski |
| here | https://github.com/nodejs/code-and-learn/issues/72#issuecomment-345667395 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-350325654 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| @mithunsasidharan | https://github.com/mithunsasidharan |
| https://coverage.nodejs.org/ | https://coverage.nodejs.org/ |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-350327375 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-350327448 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17549#event-1379263222 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-350330037 |
| https://github.com/nodejs/node/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 | https://github.com/nodejs/node/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
| https://github.com/nodejs/node/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22+ | https://github.com/nodejs/node/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22+ |
| https://coverage.nodejs.org/ | https://coverage.nodejs.org/ |
| https://coverage.nodejs.org/coverage-06e1b0386196f8f8/index.html | https://coverage.nodejs.org/coverage-06e1b0386196f8f8/index.html |
| https://coverage.nodejs.org/coverage-06e1b0386196f8f8/root/internal/util.js.html | https://coverage.nodejs.org/coverage-06e1b0386196f8f8/root/internal/util.js.html |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| December 8, 2017 18:02 | https://github.com/nodejs/node/pull/17549#event-1379281103 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-350331091 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-350332472 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| #16497 | https://github.com/nodejs/node/pull/16497 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-350333463 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-350334194 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-350335041 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-351122032 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| @apapirovski | https://github.com/apapirovski |
| https://github.com/nodejs/node/blob/master/lib/util.js#L61 | https://github.com/nodejs/node/blob/master/lib/util.js#L61 |
| https://github.com/nodejs/node/blob/master/test/parallel/test-util-promisify.js#L7 | https://github.com/nodejs/node/blob/master/test/parallel/test-util-promisify.js#L7 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-351122783 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-351172086 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-351173469 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-351179994 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-351180634 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-351181889 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-351182179 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-351187847 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17549#issuecomment-351189524 |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17549 |
|
| https://github.com/apapirovski |
|
apapirovski
| https://github.com/apapirovski |
|
| https://github.com/nodejs/node/pull/17549/files/b88c5fd2a461b508168a9acc6a5830f25a38e9b0 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/17549 |
|
| https://github.com/mithunsasidharan |
|
| https://github.com/apapirovski |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |