| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2e9bceb9-4f35-ccf6-2a96-c7f07f92edfd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C13A:2C3E22:6403AB:8187DA:696AE7E9 |
| html-safe-nonce | 14f158466f09de9b1b6f0d93fb224503ad775d65b6a14dc6c6ec666d3964c876 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTNBOjJDM0UyMjo2NDAzQUI6ODE4N0RBOjY5NkFFN0U5IiwidmlzaXRvcl9pZCI6IjI0NzAzNTUwODg5NDExODA5MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 149f3c776af7a601273ae4d05c07f53e96c1b2e723eb7acf1b32c2284ca22ac0 |
| hovercard-subject-tag | pull_request:157218704 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17545/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/eae226a3a7da1b73674838b5d153bcc217d9d7c0b33e144c3ca0c3c7681df85b/nodejs/node/pull/17545 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/eae226a3a7da1b73674838b5d153bcc217d9d7c0b33e144c3ca0c3c7681df85b/nodejs/node/pull/17545 |
| og:image:alt | Adds note that accessing the fd of the IPC channel in any other way than process.send, or using the IPC channel with child processes that is not Node.js is undefined.
This adds to what was done in ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bzoz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3d84d50b3c75fa36755c3cf392edbc09e626f979 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17545#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17545 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17545 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17545 |
| Reload | https://github.com/nodejs/node/pull/17545 |
| Reload | https://github.com/nodejs/node/pull/17545 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/17545#issue-comment-box |
| bzoz | https://github.com/bzoz |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| JaneaSystems:bartek-ipc-write-undefined | https://github.com/JaneaSystems/node/tree/bartek-ipc-write-undefined |
|
doc: mark accessing IPC channel fd as undefined
| https://github.com/nodejs/node/pull/17545#top |
| bzoz | https://github.com/bzoz |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| JaneaSystems:bartek-ipc-write-undefined | https://github.com/JaneaSystems/node/tree/bartek-ipc-write-undefined |
|
Conversation
24
| https://github.com/nodejs/node/pull/17545 |
|
Commits
1
| https://github.com/nodejs/node/pull/17545/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/17545/checks |
|
Files changed
| https://github.com/nodejs/node/pull/17545/files |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17545#issue-280455354 |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| #17460 | https://github.com/nodejs/node/pull/17460 |
| #16491 | https://github.com/nodejs/node/issues/16491 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17545#event-1378649934 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
|
Dec 8, 2017
| https://github.com/nodejs/node/pull/17545#ref-issue-268410349 |
|
Accidentally writing garbage to the IPC channel blows up parent in debug build
#16491
| https://github.com/nodejs/node/issues/16491 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
|
Dec 8, 2017
| https://github.com/nodejs/node/pull/17545#pullrequestreview-82128620 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17545/files |
| doc/api/child_process.md | https://github.com/nodejs/node/pull/17545/files#diff-fb4d08d898bf0f72e95ea3627f5838fdf1c4b5adc303cd7c8f526da13e57faf5 |
| seishun | https://github.com/seishun |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17545#discussion_r155755740 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| Trott | https://github.com/Trott |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17545#discussion_r155860523 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| sam-github | https://github.com/sam-github |
| Dec 9, 2017 | https://github.com/nodejs/node/pull/17545#discussion_r155914698 |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| mcollina | https://github.com/mcollina |
| Dec 21, 2017 | https://github.com/nodejs/node/pull/17545#discussion_r158287793 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| jasnell | https://github.com/jasnell |
| Jan 31, 2018 | https://github.com/nodejs/node/pull/17545#discussion_r165164090 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17545#issuecomment-350240519 |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17545#issuecomment-350241950 |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17545#issuecomment-350256429 |
| #16491 | https://github.com/nodejs/node/issues/16491 |
| commit here | https://github.com/janeasystems/node/commit/7157c64b4f16e589b433a822c4962cb59c03c72b |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728 |
| b7405ab | https://github.com/nodejs/node/commit/b7405ab011606373ae7bf28e4bf0b4c912fc2117 |
| 7f086dd | https://github.com/nodejs/node/commit/7f086dd6016d9f85b1bc01680addfa53fadd2728 |
|
Compare
| https://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728 |
| December 8, 2017 16:38 | https://github.com/nodejs/node/pull/17545#event-1379146483 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17545#issuecomment-350355954 |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17545#issuecomment-351208043 |
| @bzoz | https://github.com/bzoz |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| force-pushed | https://github.com/nodejs/node/compare/4a60a683f006a9fcbcbc977cda55a27434932685..1eb495472f754fd0f8a3220020f65f8dc9b7367e |
| 4a60a68 | https://github.com/nodejs/node/commit/4a60a683f006a9fcbcbc977cda55a27434932685 |
| 1eb4954 | https://github.com/nodejs/node/commit/1eb495472f754fd0f8a3220020f65f8dc9b7367e |
|
Compare
| https://github.com/nodejs/node/compare/4a60a683f006a9fcbcbc977cda55a27434932685..1eb495472f754fd0f8a3220020f65f8dc9b7367e |
| December 21, 2017 11:10 | https://github.com/nodejs/node/pull/17545#event-1397785482 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Dec 21, 2017 | https://github.com/nodejs/node/pull/17545#issuecomment-353329693 |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Dec 21, 2017 | https://github.com/nodejs/node/pull/17545#issuecomment-353333408 |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 21, 2017 | https://github.com/nodejs/node/pull/17545#issuecomment-353338189 |
| @bzoz | https://github.com/bzoz |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Dec 21, 2017 | https://github.com/nodejs/node/pull/17545#issuecomment-353344671 |
| @bnoordhuis | https://github.com/bnoordhuis |
| #16491 (comment) | https://github.com/nodejs/node/issues/16491#issuecomment-339626628 |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Dec 21, 2017 | https://github.com/nodejs/node/pull/17545#issuecomment-353356844 |
| @seishun | https://github.com/seishun |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 21, 2017 | https://github.com/nodejs/node/pull/17545#issuecomment-353359031 |
| @bzoz | https://github.com/bzoz |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Dec 21, 2017 | https://github.com/nodejs/node/pull/17545#issuecomment-353359196 |
| @bzoz | https://github.com/bzoz |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Dec 21, 2017 | https://github.com/nodejs/node/pull/17545#issuecomment-353365247 |
| @BridgeAR | https://github.com/BridgeAR |
| @seishun | https://github.com/seishun |
| this one | https://github.com/libuv/libuv/blob/fd049399aa4ed8495928e375466970d98cb42e17/src/win/pipe.c#L1593 |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Jan 5, 2018 | https://github.com/nodejs/node/pull/17545#issuecomment-355452370 |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| force-pushed | https://github.com/nodejs/node/compare/bb5575aa75fd3071724d5eccde39a3041e1af57a..993b7164933addab4021efe52d1e736976685d7c |
| bb5575a | https://github.com/nodejs/node/commit/bb5575aa75fd3071724d5eccde39a3041e1af57a |
| 993b716 | https://github.com/nodejs/node/commit/993b7164933addab4021efe52d1e736976685d7c |
|
Compare
| https://github.com/nodejs/node/compare/bb5575aa75fd3071724d5eccde39a3041e1af57a..993b7164933addab4021efe52d1e736976685d7c |
| January 26, 2018 22:02 | https://github.com/nodejs/node/pull/17545#event-1444448566 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/993b7164933addab4021efe52d1e736976685d7c..082f9525d92532867bc7172acebdf9b89a715dab |
| 993b716 | https://github.com/nodejs/node/commit/993b7164933addab4021efe52d1e736976685d7c |
| 082f952 | https://github.com/nodejs/node/commit/082f9525d92532867bc7172acebdf9b89a715dab |
|
Compare
| https://github.com/nodejs/node/compare/993b7164933addab4021efe52d1e736976685d7c..082f9525d92532867bc7172acebdf9b89a715dab |
| January 26, 2018 22:36 | https://github.com/nodejs/node/pull/17545#event-1444493630 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
tsc-review
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-review |
| Jan 31, 2018 | https://github.com/nodejs/node/pull/17545#event-1449910161 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| January 31, 2018 02:42 | https://github.com/nodejs/node/pull/17545#event-1449910205 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
tsc-agenda
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-agenda |
| Feb 7, 2018 | https://github.com/nodejs/node/pull/17545#event-1461556190 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| addaleax | https://github.com/addaleax |
| jasnell | https://github.com/jasnell |
| joyeecheung | https://github.com/joyeecheung |
| mcollina | https://github.com/mcollina |
| seishun | https://github.com/seishun |
| February 7, 2018 03:41 | https://github.com/nodejs/node/pull/17545#event-1461556491 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Feb 12, 2018
| https://github.com/nodejs/node/pull/17545#ref-issue-296385662 |
|
Node.js Foundation Technical Steering Committee (TSC) Meeting 2018-02-14
nodejs/TSC#491
| https://github.com/nodejs/TSC/issues/491 |
|
| https://github.com/bzoz |
| doc: mark accessing IPC channel fd as undefined | https://github.com/nodejs/node/pull/17545/commits/6346c4278c440674be5ef5c0b0d9b60436589c56 |
| 6346c42 | https://github.com/nodejs/node/pull/17545/commits/6346c4278c440674be5ef5c0b0d9b60436589c56 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| force-pushed | https://github.com/nodejs/node/compare/1eb495472f754fd0f8a3220020f65f8dc9b7367e..6346c4278c440674be5ef5c0b0d9b60436589c56 |
| 1eb4954 | https://github.com/nodejs/node/commit/1eb495472f754fd0f8a3220020f65f8dc9b7367e |
| 6346c42 | https://github.com/nodejs/node/commit/6346c4278c440674be5ef5c0b0d9b60436589c56 |
|
Compare
| https://github.com/nodejs/node/compare/1eb495472f754fd0f8a3220020f65f8dc9b7367e..6346c4278c440674be5ef5c0b0d9b60436589c56 |
| February 15, 2018 10:03 | https://github.com/nodejs/node/pull/17545#event-1475518106 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Feb 15, 2018 | https://github.com/nodejs/node/pull/17545#issuecomment-365879758 |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Feb 15, 2018
| https://github.com/nodejs/node/pull/17545#pullrequestreview-96809184 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17545/files/6346c4278c440674be5ef5c0b0d9b60436589c56 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/17545#pullrequestreview-96809184 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 15, 2018
| https://github.com/nodejs/node/pull/17545#pullrequestreview-96884103 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17545/files/6346c4278c440674be5ef5c0b0d9b60436589c56 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Feb 15, 2018
| https://github.com/nodejs/node/pull/17545#pullrequestreview-96888578 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17545/files/6346c4278c440674be5ef5c0b0d9b60436589c56 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
tsc-agenda
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-agenda |
|
tsc-review
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-review |
| Feb 16, 2018 | https://github.com/nodejs/node/pull/17545#event-1478891280 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Feb 16, 2018 | https://github.com/nodejs/node/pull/17545#issuecomment-366392128 |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Feb 17, 2018 | https://github.com/nodejs/node/pull/17545#issuecomment-366444179 |
| https://ci.nodejs.org/job/node-test-commit-light/290/ | https://ci.nodejs.org/job/node-test-commit-light/290/ |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Feb 17, 2018 | https://github.com/nodejs/node/pull/17545#issuecomment-366444748 |
| ea1a076 | https://github.com/nodejs/node/commit/ea1a07656ee6dcbbde5de9f228ae075a9eeb6fad |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
| BridgeAR | https://github.com/BridgeAR |
|
Feb 17, 2018
| https://github.com/nodejs/node/pull/17545#ref-commit-ea1a076 |
|
| https://github.com/bzoz |
|
| https://github.com/BridgeAR |
| doc: mark accessing IPC channel fd as undefined | https://github.com/BridgeAR/node/commit/ea1a07656ee6dcbbde5de9f228ae075a9eeb6fad |
| ea1a076 | https://github.com/BridgeAR/node/commit/ea1a07656ee6dcbbde5de9f228ae075a9eeb6fad |
| nodejs#17545 | https://github.com/nodejs/node/pull/17545 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Feb 17, 2018 | https://github.com/nodejs/node/pull/17545#event-1479151897 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 21, 2018
| https://github.com/nodejs/node/pull/17545#ref-commit-f5806c2 |
|
| https://github.com/bzoz |
|
| https://github.com/MylesBorins |
| doc: mark accessing IPC channel fd as undefined | https://github.com/nodejs/node/commit/f5806c2bb110d5becb283072c6a5a445c76078a3 |
| f5806c2 | https://github.com/nodejs/node/commit/f5806c2bb110d5becb283072c6a5a445c76078a3 |
| #17545 | https://github.com/nodejs/node/pull/17545 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 21, 2018
| https://github.com/nodejs/node/pull/17545#ref-pullrequest-299038228 |
|
v9.6.0 proposal
#18902
| https://github.com/nodejs/node/pull/18902 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 21, 2018
| https://github.com/nodejs/node/pull/17545#ref-commit-253c030 |
|
| https://github.com/bzoz |
|
| https://github.com/MylesBorins |
| doc: mark accessing IPC channel fd as undefined | https://github.com/nodejs/node/commit/253c030dacfc31ec9b44a2bd5dace22bb06160fd |
| 253c030 | https://github.com/nodejs/node/commit/253c030dacfc31ec9b44a2bd5dace22bb06160fd |
| #17545 | https://github.com/nodejs/node/pull/17545 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 21, 2018
| https://github.com/nodejs/node/pull/17545#ref-commit-33271e6 |
|
| https://github.com/bzoz |
|
| https://github.com/MylesBorins |
| doc: mark accessing IPC channel fd as undefined | https://github.com/nodejs/node/commit/33271e60f3079e12a04b78842fa1ba4383feac61 |
| 33271e6 | https://github.com/nodejs/node/commit/33271e60f3079e12a04b78842fa1ba4383feac61 |
| #17545 | https://github.com/nodejs/node/pull/17545 |
| MayaLekova | https://github.com/MayaLekova |
|
May 8, 2018
| https://github.com/nodejs/node/pull/17545#ref-commit-3873854 |
|
| https://github.com/bzoz |
|
| https://github.com/MayaLekova |
| doc: mark accessing IPC channel fd as undefined | https://github.com/MayaLekova/node/commit/387385431db67cbe74b754103a8c6a38af34884d |
| 3873854 | https://github.com/MayaLekova/node/commit/387385431db67cbe74b754103a8c6a38af34884d |
| nodejs#17545 | https://github.com/nodejs/node/pull/17545 |
| MylesBorins | https://github.com/MylesBorins |
|
Aug 7, 2018
| https://github.com/nodejs/node/pull/17545#ref-commit-2a31098 |
|
| https://github.com/bzoz |
|
| https://github.com/MylesBorins |
| doc: mark accessing IPC channel fd as undefined | https://github.com/nodejs/node/commit/2a31098b50c66de784d8972c854bc58d45a4e3fb |
| 2a31098 | https://github.com/nodejs/node/commit/2a31098b50c66de784d8972c854bc58d45a4e3fb |
| #17545 | https://github.com/nodejs/node/pull/17545 |
| MylesBorins | https://github.com/MylesBorins |
|
Aug 7, 2018
| https://github.com/nodejs/node/pull/17545#ref-commit-6d9444d |
|
| https://github.com/bzoz |
|
| https://github.com/MylesBorins |
| doc: mark accessing IPC channel fd as undefined | https://github.com/nodejs/node/commit/6d9444d0a2e27be5a71c63b337adbcf2a998708a |
| 6d9444d | https://github.com/nodejs/node/commit/6d9444d0a2e27be5a71c63b337adbcf2a998708a |
| #17545 | https://github.com/nodejs/node/pull/17545 |
| MylesBorins | https://github.com/MylesBorins |
|
Aug 9, 2018
| https://github.com/nodejs/node/pull/17545#ref-commit-f90b12c |
|
| https://github.com/bzoz |
|
| https://github.com/MylesBorins |
| doc: mark accessing IPC channel fd as undefined | https://github.com/nodejs/node/commit/f90b12c9e7eca809a8b96dc399f541a29c5d0ea1 |
| f90b12c | https://github.com/nodejs/node/commit/f90b12c9e7eca809a8b96dc399f541a29c5d0ea1 |
| #17545 | https://github.com/nodejs/node/pull/17545 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Aug 16, 2018
| https://github.com/nodejs/node/pull/17545#ref-pullrequest-337147468 |
|
v8.12.0 proposal
#21593
| https://github.com/nodejs/node/pull/21593 |
| MylesBorins | https://github.com/MylesBorins |
|
Aug 16, 2018
| https://github.com/nodejs/node/pull/17545#ref-commit-399ba4b |
|
| https://github.com/bzoz |
|
| https://github.com/MylesBorins |
| doc: mark accessing IPC channel fd as undefined | https://github.com/nodejs/node/commit/399ba4b8d84ea34f3d063c31e703b26944834c37 |
| 399ba4b | https://github.com/nodejs/node/commit/399ba4b8d84ea34f3d063c31e703b26944834c37 |
| #17545 | https://github.com/nodejs/node/pull/17545 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17545 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/17545/files/4a60a683f006a9fcbcbc977cda55a27434932685 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/17545/files/6346c4278c440674be5ef5c0b0d9b60436589c56 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/17545/files/6346c4278c440674be5ef5c0b0d9b60436589c56 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/17545/files/6346c4278c440674be5ef5c0b0d9b60436589c56 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/seishun |
|
seishun
| https://github.com/seishun |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/17545/files/4a60a683f006a9fcbcbc977cda55a27434932685 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
Accidentally writing garbage to the IPC channel blows up parent in debug build
| https://github.com/nodejs/node/issues/16491 |
| Please reload this page | https://github.com/nodejs/node/pull/17545 |
|
| https://github.com/bzoz |
|
| https://github.com/seishun |
|
| https://github.com/lpinca |
|
| https://github.com/Trott |
|
| https://github.com/BridgeAR |
|
| https://github.com/sam-github |
|
| https://github.com/mcollina |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |