| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1f9f93ec-d867-dd37-974b-a22030fb7e00 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9714:33952:3FD4243:5A0F27A:6A4FABA2 |
| html-safe-nonce | 77bac963d57ae6373195db98f33940f40e65a7ef51031739e67a14abe2ef2584 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzE0OjMzOTUyOjNGRDQyNDM6NUEwRjI3QTo2QTRGQUJBMiIsInZpc2l0b3JfaWQiOiI2MjQ4OTgxMTM3NDU4MTc4OTc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1357d8c83f6de46adc7725d082eaf0ace8c5a50ea34613462a83cca4d5c5bcb9 |
| hovercard-subject-tag | pull_request:157099655 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17532/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d22a7b1e7870f487ca228f47d9e17bc61eafb1c9a6213af6ab5368446348eeca/nodejs/node/pull/17532 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d22a7b1e7870f487ca228f47d9e17bc61eafb1c9a6213af6ab5368446348eeca/nodejs/node/pull/17532 |
| og:image:alt | 2017-12-08, Version 8.9.3 'Carbon' (LTS), @MylesBorins
This is a security release. All Node.js users should consult the security release summary at https://nodejs.org/en/blog/vulnerability/... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MylesBorins |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17532#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17532 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17532 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17532 |
| Reload | https://github.com/nodejs/node/pull/17532 |
| Reload | https://github.com/nodejs/node/pull/17532 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
972
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| MylesBorins | https://github.com/MylesBorins |
| v8.x | https://github.com/nodejs/node/tree/v8.x |
| v8.9.3-proposal | https://github.com/nodejs/node/tree/v8.9.3-proposal |
| Conversation | https://github.com/nodejs/node/pull/17532 |
| Commits20 (20) | https://github.com/nodejs/node/pull/17532/commits |
| Checks | https://github.com/nodejs/node/pull/17532/checks |
| Files changed | https://github.com/nodejs/node/pull/17532/files |
| v8.9.3 proposal | https://github.com/nodejs/node/pull/17532#top |
| MylesBorins | https://github.com/MylesBorins |
| v8.x | https://github.com/nodejs/node/tree/v8.x |
| v8.9.3-proposal | https://github.com/nodejs/node/tree/v8.9.3-proposal |
|
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 7, 2017 | https://github.com/nodejs/node/pull/17532#issue-280275791 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| @MylesBorins | https://github.com/MylesBorins |
| https://nodejs.org/en/blog/vulnerability/december-2017-security-releases/ | https://nodejs.org/en/blog/vulnerability/december-2017-security-releases/ |
| CVE-2017-15896 | https://github.com/advisories/GHSA-449x-cpjc-795h |
| CVE-2017-15897 | https://github.com/advisories/GHSA-f2j2-5fh3-4jrr |
| CVE-2017-3738 | https://github.com/advisories/GHSA-gj3m-w8pf-46c5 |
| #17428 | https://github.com/nodejs/node/pull/17428 |
| #17526 | https://github.com/nodejs/node/pull/17526 |
| #17428 | https://github.com/nodejs/node/pull/17428 |
| #17526 | https://github.com/nodejs/node/pull/17526 |
| b05ef978d3 | https://github.com/nodejs/node/commit/b05ef978d3 |
| #17428 | https://github.com/nodejs/node/pull/17428 |
| 18652b6860 | https://github.com/nodejs/node/commit/18652b6860 |
| #17526 | https://github.com/nodejs/node/pull/17526 |
| e6c308e237 | https://github.com/nodejs/node/commit/e6c308e237 |
| nodejs/io.js#1836 | https://github.com/nodejs/io.js/pull/1836 |
| a85f94bd59 | https://github.com/nodejs/node/commit/a85f94bd59 |
| iojs/io.js#1389 | https://github.com/iojs/io.js/pull/1389 |
| b5552c854c | https://github.com/nodejs/node/commit/b5552c854c |
| iojs/io.js#1389 | https://github.com/iojs/io.js/pull/1389 |
| afad1f23a2 | https://github.com/nodejs/node/commit/afad1f23a2 |
| #17526 | https://github.com/nodejs/node/pull/17526 |
| 9fdd3bddf5 | https://github.com/nodejs/node/commit/9fdd3bddf5 |
| #17526 | https://github.com/nodejs/node/pull/17526 |
| db09f245bf | https://github.com/nodejs/node/commit/db09f245bf |
| #17428 | https://github.com/nodejs/node/pull/17428 |
| 8979e0d761 | https://github.com/nodejs/node/commit/8979e0d761 |
| #17328 | https://github.com/nodejs/node/pull/17328 |
| 7ceccb1f2a | https://github.com/nodejs/node/commit/7ceccb1f2a |
| #17209 | https://github.com/nodejs/node/pull/17209 |
| 929f387cc8 | https://github.com/nodejs/node/commit/929f387cc8 |
| #17105 | https://github.com/nodejs/node/pull/17105 |
| 2b25ad1f9a | https://github.com/nodejs/node/commit/2b25ad1f9a |
| #16753 | https://github.com/nodejs/node/pull/16753 |
| ba127842c0 | https://github.com/nodejs/node/commit/ba127842c0 |
| #16676 | https://github.com/nodejs/node/pull/16676 |
| 7e663d30c3 | https://github.com/nodejs/node/commit/7e663d30c3 |
| #16669 | https://github.com/nodejs/node/pull/16669 |
| d607718448 | https://github.com/nodejs/node/commit/d607718448 |
| #17328 | https://github.com/nodejs/node/pull/17328 |
| 7d68488524 | https://github.com/nodejs/node/commit/7d68488524 |
| iojs/io.js#1389 | https://github.com/iojs/io.js/pull/1389 |
| 73c2bb5a88 | https://github.com/nodejs/node/commit/73c2bb5a88 |
| #16726 | https://github.com/nodejs/node/pull/16726 |
| 8ffb24bcf9 | https://github.com/nodejs/node/commit/8ffb24bcf9 |
| #16727 | https://github.com/nodejs/node/pull/16727 |
| ab87282a84 | https://github.com/nodejs/node/commit/ab87282a84 |
| #16130 | https://github.com/nodejs/node/pull/16130 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| addaleax | https://github.com/addaleax |
| December 7, 2017 13:18 | https://github.com/nodejs/node/pull/17532#commits-pushed-db09f24 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| doc: warn against filling buffer with invalid data | https://github.com/nodejs/node/pull/17532/commits/db09f245bf0751a9460f2e80a90065a10dfe8c83 |
| db09f24 | https://github.com/nodejs/node/pull/17532/commits/db09f245bf0751a9460f2e80a90065a10dfe8c83 |
| #17428 | https://github.com/nodejs/node/pull/17428 |
| #17467 | https://github.com/nodejs/node/pull/17467 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| buffer: zero-fill buffer allocated with invalid content | https://github.com/nodejs/node/pull/17532/commits/b05ef978d32ef981aaceb717dc06777eb1e77365 |
| b05ef97 | https://github.com/nodejs/node/pull/17532/commits/b05ef978d32ef981aaceb717dc06777eb1e77365 |
| #17427 | https://github.com/nodejs/node/pull/17427 |
| #17428 | https://github.com/nodejs/node/pull/17428 |
| #17467 | https://github.com/nodejs/node/pull/17467 |
| #17427 | https://github.com/nodejs/node/pull/17427 |
| #17423 | https://github.com/nodejs/node/issues/17423 |
|
| https://github.com/shigeki |
|
| https://github.com/MylesBorins |
| deps: upgrade openssl sources to 1.0.2n | https://github.com/nodejs/node/pull/17532/commits/9fdd3bddf56bb71c218406d5e52133b7cc413ef7 |
| 9fdd3bd | https://github.com/nodejs/node/pull/17532/commits/9fdd3bddf56bb71c218406d5e52133b7cc413ef7 |
| #17526 | https://github.com/nodejs/node/pull/17526 |
|
| https://github.com/shigeki |
|
| https://github.com/MylesBorins |
| deps: copy all openssl header files to include dir | https://github.com/nodejs/node/pull/17532/commits/afad1f23a28d759bda2cc0ac05653411eb5bfdbf |
| afad1f2 | https://github.com/nodejs/node/pull/17532/commits/afad1f23a28d759bda2cc0ac05653411eb5bfdbf |
| #17526 | https://github.com/nodejs/node/pull/17526 |
|
| https://github.com/indutny |
|
| https://github.com/MylesBorins |
| deps: fix openssl assembly error on ia32 win32 | https://github.com/nodejs/node/pull/17532/commits/b5552c854c22be658ae998bd7d500bbd125642f1 |
| b5552c8 | https://github.com/nodejs/node/pull/17532/commits/b5552c854c22be658ae998bd7d500bbd125642f1 |
| #589 | https://github.com/nodejs/node/issues/589 |
| #1389 | https://github.com/nodejs/node/pull/1389 |
|
| https://github.com/MylesBorins |
| deps: fix asm build error of openssl in x86_win32 | https://github.com/nodejs/node/pull/17532/commits/a85f94bd5903f5b6a438bc8c70b386cfb527c84a |
| a85f94b | https://github.com/nodejs/node/pull/17532/commits/a85f94bd5903f5b6a438bc8c70b386cfb527c84a |
| https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html | https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html |
| #589 | https://github.com/nodejs/node/issues/589 |
| #1389 | https://github.com/nodejs/node/pull/1389 |
|
| https://github.com/MylesBorins |
| openssl: fix keypress requirement in apps on win32 | https://github.com/nodejs/node/pull/17532/commits/7d68488524ab8445eae9992443b538423403aa37 |
| 7d68488 | https://github.com/nodejs/node/pull/17532/commits/7d68488524ab8445eae9992443b538423403aa37 |
| b910613 | https://github.com/nodejs/node/commit/b910613792dac946b295855963869933a9089044 |
| #589 | https://github.com/nodejs/node/issues/589 |
| #1389 | https://github.com/nodejs/node/pull/1389 |
|
| https://github.com/MylesBorins |
| deps: add -no_rand_screen to openssl s_client | https://github.com/nodejs/node/pull/17532/commits/e6c308e2375ca85fc9b2d109c367b8e6ba90ed12 |
| e6c308e | https://github.com/nodejs/node/pull/17532/commits/e6c308e2375ca85fc9b2d109c367b8e6ba90ed12 |
| #1461 | https://github.com/nodejs/node/issues/1461 |
| #1836 | https://github.com/nodejs/node/pull/1836 |
|
| https://github.com/shigeki |
|
| https://github.com/MylesBorins |
| deps: update openssl asm and asm_obsolete files | https://github.com/nodejs/node/pull/17532/commits/18652b6860f9e0592c49d22df8ef9faf37d55d80 |
| 18652b6 | https://github.com/nodejs/node/pull/17532/commits/18652b6860f9e0592c49d22df8ef9faf37d55d80 |
| #17526 | https://github.com/nodejs/node/pull/17526 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
|
openssl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl |
|
v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x |
| Dec 7, 2017 | https://github.com/nodejs/node/pull/17532#event-1377727913 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/e827446a67ce4dddb75b2ee2201d7dec7088f43c..31c273945d2859f0146e6421a15bc6aedf392d92 |
| e827446 | https://github.com/nodejs/node/commit/e827446a67ce4dddb75b2ee2201d7dec7088f43c |
| 31c2739 | https://github.com/nodejs/node/commit/31c273945d2859f0146e6421a15bc6aedf392d92 |
|
Compare
| https://github.com/nodejs/node/compare/e827446a67ce4dddb75b2ee2201d7dec7088f43c..31c273945d2859f0146e6421a15bc6aedf392d92 |
| December 7, 2017 20:56 | https://github.com/nodejs/node/pull/17532#event-1377728548 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 7, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350092403 |
| https://ci.nodejs.org/job/node-test-pull-request/11954/ | https://ci.nodejs.org/job/node-test-pull-request/11954/ |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1131/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1131/ |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 7, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350094949 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Dec 7, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350097247 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 7, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350098110 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 7, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350100517 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/31c273945d2859f0146e6421a15bc6aedf392d92..77beecd8accf2bdcdd89dc339e9ba31923497b83 |
| 31c2739 | https://github.com/nodejs/node/commit/31c273945d2859f0146e6421a15bc6aedf392d92 |
| 77beecd | https://github.com/nodejs/node/commit/77beecd8accf2bdcdd89dc339e9ba31923497b83 |
|
Compare
| https://github.com/nodejs/node/compare/31c273945d2859f0146e6421a15bc6aedf392d92..77beecd8accf2bdcdd89dc339e9ba31923497b83 |
| December 7, 2017 23:18 | https://github.com/nodejs/node/pull/17532#event-1377937985 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/77beecd8accf2bdcdd89dc339e9ba31923497b83..56fd75b82190ee36874f5f17790570b89eac21a9 |
| 77beecd | https://github.com/nodejs/node/commit/77beecd8accf2bdcdd89dc339e9ba31923497b83 |
| 56fd75b | https://github.com/nodejs/node/commit/56fd75b82190ee36874f5f17790570b89eac21a9 |
|
Compare
| https://github.com/nodejs/node/compare/77beecd8accf2bdcdd89dc339e9ba31923497b83..56fd75b82190ee36874f5f17790570b89eac21a9 |
| December 7, 2017 23:19 | https://github.com/nodejs/node/pull/17532#event-1377939100 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 7, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350125232 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 7, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350126350 |
| https://ci.nodejs.org/job/node-test-pull-request/11963/ | https://ci.nodejs.org/job/node-test-pull-request/11963/ |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1134/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1134/ |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 7, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350126497 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 7, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350127000 |
| @jasnell | https://github.com/jasnell |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 7, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350129418 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/56fd75b82190ee36874f5f17790570b89eac21a9..06b4b6ca42b2571a5b8e9262ef106ebe666df4f9 |
| 56fd75b | https://github.com/nodejs/node/commit/56fd75b82190ee36874f5f17790570b89eac21a9 |
| 06b4b6c | https://github.com/nodejs/node/commit/06b4b6ca42b2571a5b8e9262ef106ebe666df4f9 |
|
Compare
| https://github.com/nodejs/node/compare/56fd75b82190ee36874f5f17790570b89eac21a9..06b4b6ca42b2571a5b8e9262ef106ebe666df4f9 |
| December 7, 2017 23:47 | https://github.com/nodejs/node/pull/17532#event-1377970211 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350153831 |
| @MylesBorins | https://github.com/MylesBorins |
| d607718 | https://github.com/nodejs/node/commit/d60771844874645f307160431b792db1c922eb92 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350159911 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/XadillaX |
| XadillaX | https://github.com/XadillaX |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350160090 |
| #14891 | https://github.com/nodejs/node/pull/14891 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350160812 |
| @XadillaX | https://github.com/XadillaX |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350257081 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| @MylesBorins | https://github.com/MylesBorins |
| #17183 | https://github.com/nodejs/node/pull/17183 |
| #17328 | https://github.com/nodejs/node/pull/17328 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350263253 |
| @apapirovski | https://github.com/apapirovski |
| #17183 | https://github.com/nodejs/node/pull/17183 |
| #17328 | https://github.com/nodejs/node/pull/17328 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350263465 |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/9214a4eaad21adf7e261b4a699d43f33b3eab137..725d6d04f169b288336a0b8890957a112d884ed0 |
| 9214a4e | https://github.com/nodejs/node/commit/9214a4eaad21adf7e261b4a699d43f33b3eab137 |
| 725d6d0 | https://github.com/nodejs/node/commit/725d6d04f169b288336a0b8890957a112d884ed0 |
|
Compare
| https://github.com/nodejs/node/compare/9214a4eaad21adf7e261b4a699d43f33b3eab137..725d6d04f169b288336a0b8890957a112d884ed0 |
| December 8, 2017 13:43 | https://github.com/nodejs/node/pull/17532#event-1378845443 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17532#issuecomment-350266913 |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| 572dcac | https://github.com/nodejs/node/commit/572dcac62923ea9a2d9a718ed23a5cabee6a9ede |
| https://ci.nodejs.org/job/node-test-pull-request/11974/ | https://ci.nodejs.org/job/node-test-pull-request/11974/ |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1138/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1138/ |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
| jasnell | https://github.com/jasnell |
| December 8, 2017 08:54 | https://github.com/nodejs/node/pull/17532#commits-pushed-319beaf |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
| http2: allocate on every chunk send | https://github.com/nodejs/node/pull/17532/commits/319beaf45ba977b63f3348873453c7f7f2498847 |
| 319beaf | https://github.com/nodejs/node/pull/17532/commits/319beaf45ba977b63f3348873453c7f7f2498847 |
| #16669 | https://github.com/nodejs/node/pull/16669 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: add method to compute storage in WriteWrap | https://github.com/nodejs/node/pull/17532/commits/26b43c87ee268e71d9559add01c297891ec69680 |
| 26b43c8 | https://github.com/nodejs/node/pull/17532/commits/26b43c87ee268e71d9559add01c297891ec69680 |
| #16727 | https://github.com/nodejs/node/pull/16727 |
| #16669 | https://github.com/nodejs/node/pull/16669 |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
| http2: refactor multiple internals | https://github.com/nodejs/node/pull/17532/commits/22ee96077530fc84337a6d1af76a1efc208c0549 |
| 22ee960 | https://github.com/nodejs/node/pull/17532/commits/22ee96077530fc84337a6d1af76a1efc208c0549 |
| #16676 | https://github.com/nodejs/node/pull/16676 |
|
| https://github.com/apapirovski |
|
| https://github.com/MylesBorins |
| http2: simplify subsequent rstStream calls | https://github.com/nodejs/node/pull/17532/commits/d7f37cebed8a42dca6a772d8ea84d182676e2eef |
| d7f37ce | https://github.com/nodejs/node/pull/17532/commits/d7f37cebed8a42dca6a772d8ea84d182676e2eef |
| #16753 | https://github.com/nodejs/node/pull/16753 |
|
| https://github.com/davidben |
|
| https://github.com/MylesBorins |
| test: fix flaky test-http2-create-client-connect | https://github.com/nodejs/node/pull/17532/commits/99d775ca07ffe40b08d21d2c9b81caff23d15ba9 |
| 99d775c | https://github.com/nodejs/node/pull/17532/commits/99d775ca07ffe40b08d21d2c9b81caff23d15ba9 |
| #16130 | https://github.com/nodejs/node/pull/16130 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/MylesBorins |
| src: fix -Winconsistent-missing-override warning | https://github.com/nodejs/node/pull/17532/commits/8e8fac29ded6508fbc318d0be14cc6dc18a16ffb |
| 8e8fac2 | https://github.com/nodejs/node/pull/17532/commits/8e8fac29ded6508fbc318d0be14cc6dc18a16ffb |
| 4db1bc8 | https://github.com/nodejs/node/commit/4db1bc8f2052a1cd2bab267e026b5ee330f25aad |
| #16726 | https://github.com/nodejs/node/pull/16726 |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
| http2: major update to internals | https://github.com/nodejs/node/pull/17532/commits/a5e3ba2cb35d1cb94238a70bd4eafa3568b3e9d7 |
| a5e3ba2 | https://github.com/nodejs/node/pull/17532/commits/a5e3ba2cb35d1cb94238a70bd4eafa3568b3e9d7 |
| #17105 | https://github.com/nodejs/node/pull/17105 |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
| http2: general cleanups in core.js | https://github.com/nodejs/node/pull/17532/commits/bd035d75bd36a97a0594317b611c17a732bd3c45 |
| bd035d7 | https://github.com/nodejs/node/pull/17532/commits/bd035d75bd36a97a0594317b611c17a732bd3c45 |
| #17209 | https://github.com/nodejs/node/pull/17209 |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
| http2: use 'close' event instead of 'streamClosed' | https://github.com/nodejs/node/pull/17532/commits/aba3544b50293d609fe6852a4feaf962658dcb83 |
| aba3544 | https://github.com/nodejs/node/pull/17532/commits/aba3544b50293d609fe6852a4feaf962658dcb83 |
| #17328 | https://github.com/nodejs/node/pull/17328 |
| #15303 | https://github.com/nodejs/node/issues/15303 |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
| http2: use correct connect event for TLS Socket | https://github.com/nodejs/node/pull/17532/commits/42f09ed461a5ff63c6630b009903b59bb991781b |
| 42f09ed | https://github.com/nodejs/node/pull/17532/commits/42f09ed461a5ff63c6630b009903b59bb991781b |
| #17328 | https://github.com/nodejs/node/pull/17328 |
| #15303 | https://github.com/nodejs/node/issues/15303 |
|
| https://github.com/MylesBorins |
| 2017-12-08, Version 8.9.3 'Carbon' (LTS) | https://github.com/nodejs/node/pull/17532/commits/8a44289089a08b7b19fa3c4651b5f1f5d1edd71b |
| 8a44289 | https://github.com/nodejs/node/pull/17532/commits/8a44289089a08b7b19fa3c4651b5f1f5d1edd71b |
| https://nodejs.org/en/blog/vulnerability/december-2017-security-releases/ | https://nodejs.org/en/blog/vulnerability/december-2017-security-releases/ |
| CVE-2017-15896 | https://github.com/advisories/GHSA-449x-cpjc-795h |
| CVE-2017-15897 | https://github.com/advisories/GHSA-f2j2-5fh3-4jrr |
| CVE-2017-3738 | https://github.com/advisories/GHSA-gj3m-w8pf-46c5 |
| #17428 | https://github.com/nodejs/node/pull/17428 |
| #17526 | https://github.com/nodejs/node/pull/17526 |
| #17532 | https://github.com/nodejs/node/pull/17532 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/725d6d04f169b288336a0b8890957a112d884ed0..8a44289089a08b7b19fa3c4651b5f1f5d1edd71b |
| 725d6d0 | https://github.com/nodejs/node/commit/725d6d04f169b288336a0b8890957a112d884ed0 |
| 8a44289 | https://github.com/nodejs/node/commit/8a44289089a08b7b19fa3c4651b5f1f5d1edd71b |
|
Compare
| https://github.com/nodejs/node/compare/725d6d04f169b288336a0b8890957a112d884ed0..8a44289089a08b7b19fa3c4651b5f1f5d1edd71b |
| December 8, 2017 13:55 | https://github.com/nodejs/node/pull/17532#event-1378864164 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Dec 8, 2017
| https://github.com/nodejs/node/pull/17532#pullrequestreview-82191096 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17532/files/8a44289089a08b7b19fa3c4651b5f1f5d1edd71b |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| 8a44289 | https://github.com/nodejs/node/commit/8a44289089a08b7b19fa3c4651b5f1f5d1edd71b |
| Dec 8, 2017 | https://github.com/nodejs/node/pull/17532#event-1379073172 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 8, 2017
| https://github.com/nodejs/node/pull/17532#ref-commit-ab46b8e |
|
| https://github.com/MylesBorins |
| Working on v8.9.4 | https://github.com/nodejs/node/commit/ab46b8ebaa13da05513976ec2f33949aef2fae94 |
| ab46b8e | https://github.com/nodejs/node/commit/ab46b8ebaa13da05513976ec2f33949aef2fae94 |
| #17532 | https://github.com/nodejs/node/pull/17532 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 8, 2017
| https://github.com/nodejs/node/pull/17532#ref-commit-2ac4718 |
|
| https://github.com/MylesBorins |
| 2017-12-08, Version 8.9.3 'Carbon' (LTS) | https://github.com/nodejs/node/commit/2ac4718ac4e61545872140f3b8eca496f80b2e8a |
| 2ac4718 | https://github.com/nodejs/node/commit/2ac4718ac4e61545872140f3b8eca496f80b2e8a |
| https://nodejs.org/en/blog/vulnerability/december-2017-security-releases/ | https://nodejs.org/en/blog/vulnerability/december-2017-security-releases/ |
| CVE-2017-15896 | https://github.com/advisories/GHSA-449x-cpjc-795h |
| CVE-2017-15897 | https://github.com/advisories/GHSA-f2j2-5fh3-4jrr |
| CVE-2017-3738 | https://github.com/advisories/GHSA-gj3m-w8pf-46c5 |
| #17428 | https://github.com/nodejs/node/pull/17428 |
| #17526 | https://github.com/nodejs/node/pull/17526 |
| #17532 | https://github.com/nodejs/node/pull/17532 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| December 8, 2017 20:03 | https://github.com/nodejs/node/pull/17532#event-1379461371 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17532#ref-pullrequest-283426801 |
|
v8.9.4 proposal
#17774
| https://github.com/nodejs/node/pull/17774 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17532 |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/17532/files/8a44289089a08b7b19fa3c4651b5f1f5d1edd71b |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
|
openssl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl |
| Please reload this page | https://github.com/nodejs/node/pull/17532 |
|
| https://github.com/MylesBorins |
|
| https://github.com/jasnell |
|
| https://github.com/apapirovski |
|
| https://github.com/addaleax |
|
| https://github.com/XadillaX |
|
| https://github.com/refack |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/shigeki |
|
| https://github.com/indutny |
|
| https://github.com/davidben |
|
| https://github.com/bnoordhuis |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |