René's URL Explorer Experiment


Title: crypto: declare int return type for set_field by danbev · Pull Request #17468 · nodejs/node · GitHub

Open Graph Title: crypto: declare int return type for set_field by danbev · Pull Request #17468 · nodejs/node

X Title: crypto: declare int return type for set_field by danbev · Pull Request #17468 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit updates the set_field function pointer to return an int, and also updates the lambdas with a return statement. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commi...

X Description: This commit updates the set_field function pointer to return an int, and also updates the lambdas with a return statement. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commi...

Opengraph URL: https://github.com/nodejs/node/pull/17468

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d670a58b-2053-97d5-12dd-75d9a5ee5c46
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE462:242264:43FD1F:552A44:69911D59
html-safe-nonce7f8b538fcb9a86cb86bf806b73d0e8ed9ab9083041ff7e74b004443ec15361b7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDYyOjI0MjI2NDo0M0ZEMUY6NTUyQTQ0OjY5OTExRDU5IiwidmlzaXRvcl9pZCI6IjgzNjE5NzgyOTQwMDI4NTExNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac74264523dd22238f62c9dbdc52d48c36ebf9474b22cb4432669e738f1974b46a
hovercard-subject-tagpull_request:156452181
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17468/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/61183d912f5a2824b69cba10cbcc6a0245bf1ec3cd0e925fc875e2ad7df0b245/nodejs/node/pull/17468
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/61183d912f5a2824b69cba10cbcc6a0245bf1ec3cd0e925fc875e2ad7df0b245/nodejs/node/pull/17468
og:image:altThis commit updates the set_field function pointer to return an int, and also updates the lambdas with a return statement. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17468#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17468
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17468
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17468
Reloadhttps://github.com/nodejs/node/pull/17468
Reloadhttps://github.com/nodejs/node/pull/17468
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17468
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:crypto_dh_set0_key_voidhttps://github.com/danbev/node/tree/crypto_dh_set0_key_void
Conversationhttps://github.com/nodejs/node/pull/17468
Commits2 (2)https://github.com/nodejs/node/pull/17468/commits
Checkshttps://github.com/nodejs/node/pull/17468/checks
Files changedhttps://github.com/nodejs/node/pull/17468/files
crypto: declare int return type for set_fieldhttps://github.com/nodejs/node/pull/17468#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:crypto_dh_set0_key_voidhttps://github.com/danbev/node/tree/crypto_dh_set0_key_void
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 5, 2017https://github.com/nodejs/node/pull/17468#issue-279360404
Please reload this pagehttps://github.com/nodejs/node/pull/17468
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17468
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Dec 5, 2017https://github.com/nodejs/node/pull/17468#event-1372543534
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 5, 2017https://github.com/nodejs/node/pull/17468#issuecomment-349292712
https://ci.nodejs.org/job/node-test-pull-request/11886/https://ci.nodejs.org/job/node-test-pull-request/11886/
Please reload this pagehttps://github.com/nodejs/node/pull/17468
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 6, 2017https://github.com/nodejs/node/pull/17468#issuecomment-349489468
Please reload this pagehttps://github.com/nodejs/node/pull/17468
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 6, 2017https://github.com/nodejs/node/pull/17468#issuecomment-349554807
commithttps://github.com/nodejs/node/pull/17468/commits/acbe9e654674e0e3b2de30aff0391db78f5cd1b2
Please reload this pagehttps://github.com/nodejs/node/pull/17468
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 6, 2017 https://github.com/nodejs/node/pull/17468#pullrequestreview-81699696
View reviewed changes https://github.com/nodejs/node/pull/17468/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/17468#pullrequestreview-81699696
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17468
src/node_crypto.cchttps://github.com/nodejs/node/pull/17468/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
bnoordhuishttps://github.com/bnoordhuis
Dec 6, 2017https://github.com/nodejs/node/pull/17468#discussion_r155388121
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17468
danbevhttps://github.com/danbev
Dec 7, 2017https://github.com/nodejs/node/pull/17468#discussion_r155442086
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17468
danbevhttps://github.com/danbev
December 7, 2017 07:50https://github.com/nodejs/node/pull/17468#commits-pushed-1995452
https://github.com/danbev
crypto: declare int return type for set_fieldhttps://github.com/nodejs/node/pull/17468/commits/199545279745089255f60ee3ec7b549e479722ca
1995452https://github.com/nodejs/node/pull/17468/commits/199545279745089255f60ee3ec7b549e479722ca
https://github.com/danbev
squash: add check of return valuehttps://github.com/nodejs/node/pull/17468/commits/0a1bfc14c024ed8c721416d217357c55332472f5
0a1bfc1https://github.com/nodejs/node/pull/17468/commits/0a1bfc14c024ed8c721416d217357c55332472f5
https://github.com/danbev
danbevhttps://github.com/danbev
force-pushedhttps://github.com/nodejs/node/compare/acbe9e654674e0e3b2de30aff0391db78f5cd1b2..0a1bfc14c024ed8c721416d217357c55332472f5
acbe9e6https://github.com/nodejs/node/commit/acbe9e654674e0e3b2de30aff0391db78f5cd1b2
0a1bfc1https://github.com/nodejs/node/commit/0a1bfc14c024ed8c721416d217357c55332472f5
Compare https://github.com/nodejs/node/compare/acbe9e654674e0e3b2de30aff0391db78f5cd1b2..0a1bfc14c024ed8c721416d217357c55332472f5
December 7, 2017 06:55https://github.com/nodejs/node/pull/17468#event-1376305000
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 7, 2017https://github.com/nodejs/node/pull/17468#event-1376305558
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 7, 2017https://github.com/nodejs/node/pull/17468#issuecomment-349880199
https://ci.nodejs.org/job/node-test-pull-request/11937/https://ci.nodejs.org/job/node-test-pull-request/11937/
Please reload this pagehttps://github.com/nodejs/node/pull/17468
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 8, 2017https://github.com/nodejs/node/pull/17468#issuecomment-350183400
abc2801https://github.com/nodejs/node/commit/abc280172f1cdd44c8dbb8285a67322b9e16a414
Please reload this pagehttps://github.com/nodejs/node/pull/17468
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 8, 2017https://github.com/nodejs/node/pull/17468#event-1378282175
danbevhttps://github.com/danbev
Dec 8, 2017 https://github.com/nodejs/node/pull/17468#ref-commit-abc2801
https://github.com/danbev
crypto: declare int return type for set_fieldhttps://github.com/nodejs/node/commit/abc280172f1cdd44c8dbb8285a67322b9e16a414
abc2801https://github.com/nodejs/node/commit/abc280172f1cdd44c8dbb8285a67322b9e16a414
#17468https://github.com/nodejs/node/pull/17468
https://github.com/danbev
danbevhttps://github.com/danbev
December 8, 2017 06:22https://github.com/nodejs/node/pull/17468#event-1378282623
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17468#ref-commit-2edfe98
https://github.com/danbev
https://github.com/MylesBorins
crypto: declare int return type for set_fieldhttps://github.com/nodejs/node/commit/2edfe987634c7cdf7d9c424f15af900786f1b0cd
2edfe98https://github.com/nodejs/node/commit/2edfe987634c7cdf7d9c424f15af900786f1b0cd
#17468https://github.com/nodejs/node/pull/17468
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17468#ref-commit-49402b1
https://github.com/danbev
https://github.com/MylesBorins
crypto: declare int return type for set_fieldhttps://github.com/nodejs/node/commit/49402b12d01bca1dae8e05c0effd96476d779b29
49402b1https://github.com/nodejs/node/commit/49402b12d01bca1dae8e05c0effd96476d779b29
#17468https://github.com/nodejs/node/pull/17468
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17468#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 20, 2017https://github.com/nodejs/node/pull/17468#event-1395250167
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017https://github.com/nodejs/node/pull/17468#issuecomment-352932003
the guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/17468
https://github.com/danbev
danbevhttps://github.com/danbev
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Dec 20, 2017https://github.com/nodejs/node/pull/17468#event-1395569695
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Jan 22, 2018https://github.com/nodejs/node/pull/17468#event-1434635142
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17468
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/17468/files/acbe9e654674e0e3b2de30aff0391db78f5cd1b2
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/17468
https://github.com/danbev
https://github.com/bnoordhuis
https://github.com/gibfahn
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.