René's URL Explorer Experiment


Title: build: fix HAVE_OPENSSL macro for cctest by mmarchini · Pull Request #17461 · nodejs/node · GitHub

Open Graph Title: build: fix HAVE_OPENSSL macro for cctest by mmarchini · Pull Request #17461 · nodejs/node

X Title: build: fix HAVE_OPENSSL macro for cctest by mmarchini · Pull Request #17461 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: I found this bug while writing tests for #14901, because Environment::handle_wrap_queue(), Environment::req_wrap_queue() and Environment::context()weren't working as expected inside C++ tests. ...

X Description: I found this bug while writing tests for #14901, because Environment::handle_wrap_queue(), Environment::req_wrap_queue() and Environment::context()weren't working as expected inside C++ tes...

Opengraph URL: https://github.com/nodejs/node/pull/17461

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6aea7de1-7f98-58e5-be0a-c5e878fec744
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE572:1F4D74:166CD8B:1C28052:699170EC
html-safe-nonce2b8cd76d8e51694a83ae7dcf325f05ea38e6faaac6473e0e958525759699c926
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTcyOjFGNEQ3NDoxNjZDRDhCOjFDMjgwNTI6Njk5MTcwRUMiLCJ2aXNpdG9yX2lkIjoiNzAyMjQyMzcxODYwMjMwNTc3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf070fb13b22b49ee35280255929b37d3983b6f6bfff5df817dfe759502c09571
hovercard-subject-tagpull_request:156309723
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17461/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/88fea855e90070ae3f0c39e250f6ba511b6f53028ec49e146a561a8ac4b63fbc/nodejs/node/pull/17461
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/88fea855e90070ae3f0c39e250f6ba511b6f53028ec49e146a561a8ac4b63fbc/nodejs/node/pull/17461
og:image:altI found this bug while writing tests for #14901, because Environment::handle_wrap_queue(), Environment::req_wrap_queue() and Environment::context()weren't working as expected inside C++ tests. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemmarchini
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17461#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17461
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17461
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17461
Reloadhttps://github.com/nodejs/node/pull/17461
Reloadhttps://github.com/nodejs/node/pull/17461
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17461
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mmarchinihttps://github.com/mmarchini
nodejs:masterhttps://github.com/nodejs/node/tree/master
mmarchini:fix-openssl-cctestshttps://github.com/mmarchini/node/tree/fix-openssl-cctests
Conversationhttps://github.com/nodejs/node/pull/17461
Commits1 (1)https://github.com/nodejs/node/pull/17461/commits
Checkshttps://github.com/nodejs/node/pull/17461/checks
Files changedhttps://github.com/nodejs/node/pull/17461/files
build: fix HAVE_OPENSSL macro for cctesthttps://github.com/nodejs/node/pull/17461#top
mmarchinihttps://github.com/mmarchini
nodejs:masterhttps://github.com/nodejs/node/tree/master
mmarchini:fix-openssl-cctestshttps://github.com/mmarchini/node/tree/fix-openssl-cctests
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Dec 4, 2017https://github.com/nodejs/node/pull/17461#issue-279154737
#14901https://github.com/nodejs/node/pull/14901
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17461
build: fix HAVE_OPENSSL macro for cctesthttps://github.com/nodejs/node/pull/17461/commits/e093ebd84bb51fca276dd96688a7a20d24bec1ec
e093ebdhttps://github.com/nodejs/node/pull/17461/commits/e093ebd84bb51fca276dd96688a7a20d24bec1ec
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Dec 4, 2017https://github.com/nodejs/node/pull/17461#event-1371407638
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Dec 4, 2017 https://github.com/nodejs/node/pull/17461#ref-pullrequest-251042364
src, test: node internals' postmortem metadata #14901 https://github.com/nodejs/node/pull/14901
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 5, 2017 https://github.com/nodejs/node/pull/17461#pullrequestreview-81105929
View reviewed changes https://github.com/nodejs/node/pull/17461/files/e093ebd84bb51fca276dd96688a7a20d24bec1ec
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 5, 2017https://github.com/nodejs/node/pull/17461#issuecomment-349236759
https://ci.nodejs.org/job/node-test-pull-request/11883/https://ci.nodejs.org/job/node-test-pull-request/11883/
Please reload this pagehttps://github.com/nodejs/node/pull/17461
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 5, 2017 https://github.com/nodejs/node/pull/17461#pullrequestreview-81124827
View reviewed changes https://github.com/nodejs/node/pull/17461/files/e093ebd84bb51fca276dd96688a7a20d24bec1ec
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 5, 2017 https://github.com/nodejs/node/pull/17461#pullrequestreview-81260326
View reviewed changes https://github.com/nodejs/node/pull/17461/files/e093ebd84bb51fca276dd96688a7a20d24bec1ec
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 6, 2017 https://github.com/nodejs/node/pull/17461#pullrequestreview-81390975
View reviewed changes https://github.com/nodejs/node/pull/17461/files/e093ebd84bb51fca276dd96688a7a20d24bec1ec
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728
b7405abhttps://github.com/nodejs/node/commit/b7405ab011606373ae7bf28e4bf0b4c912fc2117
7f086ddhttps://github.com/nodejs/node/commit/7f086dd6016d9f85b1bc01680addfa53fadd2728
Compare https://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728
December 8, 2017 16:37https://github.com/nodejs/node/pull/17461#event-1379146185
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 8, 2017https://github.com/nodejs/node/pull/17461#event-1379600677
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 8, 2017 https://github.com/nodejs/node/pull/17461#pullrequestreview-82282771
View reviewed changes https://github.com/nodejs/node/pull/17461/files/e093ebd84bb51fca276dd96688a7a20d24bec1ec
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 9, 2017https://github.com/nodejs/node/pull/17461#issuecomment-350503724
c1689dchttps://github.com/nodejs/node/commit/c1689dc32c75a5c8aa318d52e0a4b814bda9c5ed
Please reload this pagehttps://github.com/nodejs/node/pull/17461
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 9, 2017https://github.com/nodejs/node/pull/17461#event-1380136822
apapirovskihttps://github.com/apapirovski
Dec 9, 2017 https://github.com/nodejs/node/pull/17461#ref-commit-c1689dc
https://github.com/apapirovski
build: define HAVE_OPENSSL macro for cctesthttps://github.com/nodejs/node/commit/c1689dc32c75a5c8aa318d52e0a4b814bda9c5ed
c1689dchttps://github.com/nodejs/node/commit/c1689dc32c75a5c8aa318d52e0a4b814bda9c5ed
#17461https://github.com/nodejs/node/pull/17461
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17461#ref-commit-491db47
https://github.com/MylesBorins
build: define HAVE_OPENSSL macro for cctesthttps://github.com/nodejs/node/commit/491db47bc701e6165aff293476c726bf09554baa
491db47https://github.com/nodejs/node/commit/491db47bc701e6165aff293476c726bf09554baa
#17461https://github.com/nodejs/node/pull/17461
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17461#ref-commit-5d1463a
https://github.com/MylesBorins
build: define HAVE_OPENSSL macro for cctesthttps://github.com/nodejs/node/commit/5d1463a0bc80675515778b397b04c36728765e2e
5d1463ahttps://github.com/nodejs/node/commit/5d1463a0bc80675515778b397b04c36728765e2e
#17461https://github.com/nodejs/node/pull/17461
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17461#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 13, 2017https://github.com/nodejs/node/pull/17461#event-1384948016
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17461#ref-commit-9c93b97
https://github.com/gibfahn
build: define HAVE_OPENSSL macro for cctesthttps://github.com/nodejs/node/commit/9c93b971690f81507fe79e0b452e92812e89e6ca
9c93b97https://github.com/nodejs/node/commit/9c93b971690f81507fe79e0b452e92812e89e6ca
#17461https://github.com/nodejs/node/pull/17461
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
backport-requested-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x
Dec 20, 2017https://github.com/nodejs/node/pull/17461#event-1395270667
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017https://github.com/nodejs/node/pull/17461#issuecomment-352935612
the guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/17461
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17461#ref-pullrequest-283423333
v8.9.4 proposal #17772 https://github.com/nodejs/node/pull/17772
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17461#ref-commit-19c1c71
https://github.com/gibfahn
build: define HAVE_OPENSSL macro for cctesthttps://github.com/nodejs/node/commit/19c1c712281e4a0a98ae9d864cae3fa13df9aa0b
19c1c71https://github.com/nodejs/node/commit/19c1c712281e4a0a98ae9d864cae3fa13df9aa0b
#17461https://github.com/nodejs/node/pull/17461
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17461#ref-pullrequest-283426801
v8.9.4 proposal #17774 https://github.com/nodejs/node/pull/17774
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17461#ref-commit-6ed3306
https://github.com/gibfahn
build: define HAVE_OPENSSL macro for cctesthttps://github.com/nodejs/node/commit/6ed330610a43473fb8976ede30539a57711375b4
6ed3306https://github.com/nodejs/node/commit/6ed330610a43473fb8976ede30539a57711375b4
#17461https://github.com/nodejs/node/pull/17461
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Dec 26, 2017https://github.com/nodejs/node/pull/17461#issuecomment-353983464
Please reload this pagehttps://github.com/nodejs/node/pull/17461
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
backport-requested-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x
Dec 27, 2017https://github.com/nodejs/node/pull/17461#event-1402288931
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17461
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/17461/files/e093ebd84bb51fca276dd96688a7a20d24bec1ec
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/17461/files/e093ebd84bb51fca276dd96688a7a20d24bec1ec
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/17461/files/e093ebd84bb51fca276dd96688a7a20d24bec1ec
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/17461/files/e093ebd84bb51fca276dd96688a7a20d24bec1ec
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/17461/files/e093ebd84bb51fca276dd96688a7a20d24bec1ec
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Please reload this pagehttps://github.com/nodejs/node/pull/17461
https://github.com/mmarchini
https://github.com/joyeecheung
https://github.com/apapirovski
https://github.com/gibfahn
https://github.com/danbev
https://github.com/jasnell
https://github.com/addaleax
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.