René's URL Explorer Experiment


Title: test: replace assert.throws with common.expectsError by Leko · Pull Request #17445 · nodejs/node · GitHub

Open Graph Title: test: replace assert.throws with common.expectsError by Leko · Pull Request #17445 · nodejs/node

X Title: test: replace assert.throws with common.expectsError by Leko · Pull Request #17445 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Replace assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err); in test/addons-napi/test_error/test.js. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes t...

X Description: Replace assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err); in test/addons-napi/test_error/test.js. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes t...

Opengraph URL: https://github.com/nodejs/node/pull/17445

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:99670e63-18bf-2586-149e-cdc973ab676c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idACA4:4BDC4:78E2C:94E9E:69911A87
html-safe-nonce2eb5a370076dccba085801b096ca46e30a5ffb017f7d93ebb9cb5aece9202df0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQ0E0OjRCREM0Ojc4RTJDOjk0RTlFOjY5OTExQTg3IiwidmlzaXRvcl9pZCI6IjEzOTE2OTI1NzY3NDcyMzE4NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac802fb6e435c97e53f5dcd5edcee32c26f102647ab7a4799c351396bf3f67961b
hovercard-subject-tagpull_request:156124300
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17445/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/25be9144558d9ab01afc49be2dcc608cf2cf439232992d6a436db7a7d8f86fda/nodejs/node/pull/17445
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/25be9144558d9ab01afc49be2dcc608cf2cf439232992d6a436db7a7d8f86fda/nodejs/node/pull/17445
og:image:altReplace assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err); in test/addons-napi/test_error/test.js. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameLeko
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17445#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17445
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17445
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17445
Reloadhttps://github.com/nodejs/node/pull/17445
Reloadhttps://github.com/nodejs/node/pull/17445
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17445
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Lekohttps://github.com/Leko
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/17445
Commits1 (1)https://github.com/nodejs/node/pull/17445/commits
Checkshttps://github.com/nodejs/node/pull/17445/checks
Files changedhttps://github.com/nodejs/node/pull/17445/files
test: replace assert.throws with common.expectsErrorhttps://github.com/nodejs/node/pull/17445#top
Lekohttps://github.com/Leko
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/Leko
Lekohttps://github.com/Leko
Dec 4, 2017https://github.com/nodejs/node/pull/17445#issue-278893550
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17445
https://github.com/Leko
test: replace assert.throws with common.expectsErrorhttps://github.com/nodejs/node/pull/17445/commits/979a3aa9c3f6cd385f86744918e3b234e0d1752d
979a3aahttps://github.com/nodejs/node/pull/17445/commits/979a3aa9c3f6cd385f86744918e3b234e0d1752d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Dec 4, 2017https://github.com/nodejs/node/pull/17445#event-1369865599
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 4, 2017 https://github.com/nodejs/node/pull/17445#pullrequestreview-80783546
View reviewed changes https://github.com/nodejs/node/pull/17445/files/979a3aa9c3f6cd385f86744918e3b234e0d1752d
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 4, 2017https://github.com/nodejs/node/pull/17445#issuecomment-348911959
Please reload this pagehttps://github.com/nodejs/node/pull/17445
https://ci.nodejs.org/job/node-test-pull-request/11863/https://ci.nodejs.org/job/node-test-pull-request/11863/
https://ci.nodejs.org/job/node-test-pull-request/11865/https://ci.nodejs.org/job/node-test-pull-request/11865/
Please reload this pagehttps://github.com/nodejs/node/pull/17445
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 4, 2017 https://github.com/nodejs/node/pull/17445#pullrequestreview-80847307
View reviewed changes https://github.com/nodejs/node/pull/17445/files/979a3aa9c3f6cd385f86744918e3b234e0d1752d
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 4, 2017 https://github.com/nodejs/node/pull/17445#pullrequestreview-80859064
View reviewed changes https://github.com/nodejs/node/pull/17445/files/979a3aa9c3f6cd385f86744918e3b234e0d1752d
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 5, 2017 https://github.com/nodejs/node/pull/17445#pullrequestreview-81262961
View reviewed changes https://github.com/nodejs/node/pull/17445/files/979a3aa9c3f6cd385f86744918e3b234e0d1752d
https://github.com/maclover7
maclover7https://github.com/maclover7
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 5, 2017https://github.com/nodejs/node/pull/17445#event-1373502938
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 5, 2017https://github.com/nodejs/node/pull/17445#event-1373801483
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 6, 2017https://github.com/nodejs/node/pull/17445#issuecomment-349486760
Please reload this pagehttps://github.com/nodejs/node/pull/17445
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 6, 2017https://github.com/nodejs/node/pull/17445#issuecomment-349487307
50afd90https://github.com/nodejs/node/commit/50afd901ea74b11352b4bc232c80cccede73f7fb
Please reload this pagehttps://github.com/nodejs/node/pull/17445
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 6, 2017https://github.com/nodejs/node/pull/17445#event-1373828387
maclover7https://github.com/maclover7
Dec 6, 2017 https://github.com/nodejs/node/pull/17445#ref-commit-50afd90
https://github.com/Leko
https://github.com/maclover7
test: replace assert.throws with common.expectsErrorhttps://github.com/nodejs/node/commit/50afd901ea74b11352b4bc232c80cccede73f7fb
50afd90https://github.com/nodejs/node/commit/50afd901ea74b11352b4bc232c80cccede73f7fb
#17445https://github.com/nodejs/node/pull/17445
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 7, 2017https://github.com/nodejs/node/pull/17445#event-1377199519
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17445#ref-commit-03f7ed8
https://github.com/Leko
https://github.com/MylesBorins
test: replace assert.throws with common.expectsErrorhttps://github.com/nodejs/node/commit/03f7ed81a3bdfdf9c1df0b921d085a4d817b1554
03f7ed8https://github.com/nodejs/node/commit/03f7ed81a3bdfdf9c1df0b921d085a4d817b1554
#17445https://github.com/nodejs/node/pull/17445
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17445#ref-commit-0ac87c2
https://github.com/Leko
https://github.com/MylesBorins
test: replace assert.throws with common.expectsErrorhttps://github.com/nodejs/node/commit/0ac87c2525e8173462977b3d7705cfefe714ac4c
0ac87c2https://github.com/nodejs/node/commit/0ac87c2525e8173462977b3d7705cfefe714ac4c
#17445https://github.com/nodejs/node/pull/17445
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17445#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17445#ref-commit-babb288
https://github.com/Leko
https://github.com/gibfahn
test: replace assert.throws with common.expectsErrorhttps://github.com/nodejs/node/commit/babb288560c6f9559089791bad29d5ef4bf3c1ec
babb288https://github.com/nodejs/node/commit/babb288560c6f9559089791bad29d5ef4bf3c1ec
#17445https://github.com/nodejs/node/pull/17445
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
Dec 20, 2017https://github.com/nodejs/node/pull/17445#event-1395232144
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17445#ref-pullrequest-283423333
v8.9.4 proposal #17772 https://github.com/nodejs/node/pull/17772
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17445#ref-commit-e01cd82
https://github.com/Leko
https://github.com/gibfahn
test: replace assert.throws with common.expectsErrorhttps://github.com/nodejs/node/commit/e01cd821f5e54b0aad62fbf43557ecd896d729d5
e01cd82https://github.com/nodejs/node/commit/e01cd821f5e54b0aad62fbf43557ecd896d729d5
#17445https://github.com/nodejs/node/pull/17445
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17445#ref-pullrequest-283426801
v8.9.4 proposal #17774 https://github.com/nodejs/node/pull/17774
gabrielschulhofhttps://github.com/gabrielschulhof
Apr 16, 2018 https://github.com/nodejs/node/pull/17445#ref-commit-3f4ac09
https://github.com/Leko
test: replace assert.throws with common.expectsErrorhttps://github.com/gabrielschulhof/node/commit/3f4ac092d6428470d5f6f4cc41898ffee5ad3292
3f4ac09https://github.com/gabrielschulhof/node/commit/3f4ac092d6428470d5f6f4cc41898ffee5ad3292
nodejs#17445https://github.com/nodejs/node/pull/17445
MylesBorinshttps://github.com/MylesBorins
Apr 16, 2018 https://github.com/nodejs/node/pull/17445#ref-commit-e54b58c
https://github.com/Leko
https://github.com/MylesBorins
test: replace assert.throws with common.expectsErrorhttps://github.com/nodejs/node/commit/e54b58c02447cbe4fd3063d93d1bd651a865450c
e54b58chttps://github.com/nodejs/node/commit/e54b58c02447cbe4fd3063d93d1bd651a865450c
#19447https://github.com/nodejs/node/pull/19447
#17445https://github.com/nodejs/node/pull/17445
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 16, 2018 https://github.com/nodejs/node/pull/17445#ref-pullrequest-313968187
v6.14.2 proposal #19996 https://github.com/nodejs/node/pull/19996
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17445
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/17445/files/979a3aa9c3f6cd385f86744918e3b234e0d1752d
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/17445/files/979a3aa9c3f6cd385f86744918e3b234e0d1752d
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/17445/files/979a3aa9c3f6cd385f86744918e3b234e0d1752d
https://github.com/maclover7
maclover7 https://github.com/maclover7
https://github.com/nodejs/node/pull/17445/files/979a3aa9c3f6cd385f86744918e3b234e0d1752d
https://github.com/maclover7
maclover7 https://github.com/maclover7
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/17445
https://github.com/Leko
https://github.com/lpinca
https://github.com/maclover7
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/addaleax
https://github.com/gibfahn
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.