| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e77db583-dabb-ad99-1308-f51b9253db24 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A7E:221685:B446C4:EF9104:6A518E71 |
| html-safe-nonce | 6109697ad305425c89cb31f4b7af8d0c39e1b8b6dac7378115ddb3eac7705ab6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTdFOjIyMTY4NTpCNDQ2QzQ6RUY5MTA0OjZBNTE4RTcxIiwidmlzaXRvcl9pZCI6IjMxNjY4ODAwMTk5MzE4Mjc4MjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8d13d1f6359aa2640bde17b9b9b2ea56d8faa1016ad9f3095500eb26d1511918 |
| hovercard-subject-tag | pull_request:156088126 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17441/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d2c732a06f5b3ecd3242886bcb057e023dbd2389c6398c9d1afa81e3632379b5/nodejs/node/pull/17441 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d2c732a06f5b3ecd3242886bcb057e023dbd2389c6398c9d1afa81e3632379b5/nodejs/node/pull/17441 |
| og:image:alt | Moved from https://github.com/watilde/remark-preset-lint-node. The source for this preset will now live in the nodejs/node repository.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) pa... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | maclover7 |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17441#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17441 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17441 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17441 |
| Reload | https://github.com/nodejs/node/pull/17441 |
| Reload | https://github.com/nodejs/node/pull/17441 |
| Please reload this page | https://github.com/nodejs/node/pull/17441 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17441 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
981
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| maclover7 | https://github.com/maclover7 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/17441 |
| Commits1 (1) | https://github.com/nodejs/node/pull/17441/commits |
| Checks | https://github.com/nodejs/node/pull/17441/checks |
| Files changed | https://github.com/nodejs/node/pull/17441/files |
| tools: host remark-preset-lint-node in-tree | https://github.com/nodejs/node/pull/17441#top |
| maclover7 | https://github.com/maclover7 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| Dec 3, 2017 | https://github.com/nodejs/node/pull/17441#issue-278834624 |
| https://github.com/watilde/remark-preset-lint-node | https://github.com/watilde/remark-preset-lint-node |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/17441 |
|
| https://github.com/maclover7 |
| tools: host remark-preset-lint-node in-tree | https://github.com/nodejs/node/pull/17441/commits/d55a7ed88a583772c1ec4943ee8532f878fb3297 |
| d55a7ed | https://github.com/nodejs/node/pull/17441/commits/d55a7ed88a583772c1ec4943ee8532f878fb3297 |
| https://github.com/watilde/remark-preset-lint-node | https://github.com/watilde/remark-preset-lint-node |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Dec 3, 2017 | https://github.com/nodejs/node/pull/17441#event-1369567824 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| Trott | https://github.com/Trott |
| watilde | https://github.com/watilde |
| December 3, 2017 23:39 | https://github.com/nodejs/node/pull/17441#event-1369567890 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 4, 2017 | https://github.com/nodejs/node/pull/17441#issuecomment-348855180 |
| Please reload this page | https://github.com/nodejs/node/pull/17441 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| Dec 4, 2017 | https://github.com/nodejs/node/pull/17441#issuecomment-348978151 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/17441 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
|
Dec 6, 2017
| https://github.com/nodejs/node/pull/17441#ref-pullrequest-279768467 |
|
tools,doc: lint for additional strings in docs
#17492
| https://github.com/nodejs/node/pull/17492 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728 |
| b7405ab | https://github.com/nodejs/node/commit/b7405ab011606373ae7bf28e4bf0b4c912fc2117 |
| 7f086dd | https://github.com/nodejs/node/commit/7f086dd6016d9f85b1bc01680addfa53fadd2728 |
|
Compare
| https://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728 |
| December 8, 2017 16:37 | https://github.com/nodejs/node/pull/17441#event-1379146170 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17441#issuecomment-351213402 |
| Please reload this page | https://github.com/nodejs/node/pull/17441 |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/17441#issuecomment-351215106 |
| Please reload this page | https://github.com/nodejs/node/pull/17441 |
| https://github.com/nodejs/node/blob/2e1d092ff18eb0c4274f066ca60c34c85ea71234/tools/remark-preset-lint-node/package.json | https://github.com/nodejs/node/blob/2e1d092ff18eb0c4274f066ca60c34c85ea71234/tools/remark-preset-lint-node/package.json |
| @nodejs | https://github.com/nodejs |
| Please reload this page | https://github.com/nodejs/node/pull/17441 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Dec 15, 2017
| https://github.com/nodejs/node/pull/17441#pullrequestreview-83939848 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17441/files/d55a7ed88a583772c1ec4943ee8532f878fb3297 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/17441#pullrequestreview-83939848 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17441 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| Jan 2, 2018 | https://github.com/nodejs/node/pull/17441#issuecomment-354888486 |
| Please reload this page | https://github.com/nodejs/node/pull/17441 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Jan 3, 2018
| https://github.com/nodejs/node/pull/17441#pullrequestreview-86398347 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17441/files/d55a7ed88a583772c1ec4943ee8532f878fb3297 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 5, 2018
| https://github.com/nodejs/node/pull/17441#pullrequestreview-86809033 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17441/files/d55a7ed88a583772c1ec4943ee8532f878fb3297 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Jan 5, 2018 | https://github.com/nodejs/node/pull/17441#issuecomment-355454671 |
| a9e422e | https://github.com/nodejs/node/commit/a9e422eee2b32bfed38aa78845305aac06720712 |
| Please reload this page | https://github.com/nodejs/node/pull/17441 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Jan 5, 2018 | https://github.com/nodejs/node/pull/17441#event-1410623117 |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 5, 2018
| https://github.com/nodejs/node/pull/17441#ref-commit-a9e422e |
|
| https://github.com/maclover7 |
|
| https://github.com/BridgeAR |
| tools: host remark-preset-lint-node in-tree | https://github.com/BridgeAR/node/commit/a9e422eee2b32bfed38aa78845305aac06720712 |
| a9e422e | https://github.com/BridgeAR/node/commit/a9e422eee2b32bfed38aa78845305aac06720712 |
| https://github.com/watilde/remark-preset-lint-node | https://github.com/watilde/remark-preset-lint-node |
| nodejs#17441 | https://github.com/nodejs/node/pull/17441 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| January 5, 2018 02:42 | https://github.com/nodejs/node/pull/17441#event-1410643968 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 8, 2018
| https://github.com/nodejs/node/pull/17441#ref-commit-253c3e4 |
|
| https://github.com/maclover7 |
|
| https://github.com/MylesBorins |
| tools: host remark-preset-lint-node in-tree | https://github.com/nodejs/node/commit/253c3e4dffcda7ca373c0482d19e8a58a9d56590 |
| 253c3e4 | https://github.com/nodejs/node/commit/253c3e4dffcda7ca373c0482d19e8a58a9d56590 |
| https://github.com/watilde/remark-preset-lint-node | https://github.com/watilde/remark-preset-lint-node |
| #17441 | https://github.com/nodejs/node/pull/17441 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 9, 2018
| https://github.com/nodejs/node/pull/17441#ref-commit-5df84f2 |
|
| https://github.com/maclover7 |
|
| https://github.com/MylesBorins |
| tools: host remark-preset-lint-node in-tree | https://github.com/nodejs/node/commit/5df84f243e1834e9569cdb2ed3d5a897a193fea1 |
| 5df84f2 | https://github.com/nodejs/node/commit/5df84f243e1834e9569cdb2ed3d5a897a193fea1 |
| https://github.com/watilde/remark-preset-lint-node | https://github.com/watilde/remark-preset-lint-node |
| #17441 | https://github.com/nodejs/node/pull/17441 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 9, 2018
| https://github.com/nodejs/node/pull/17441#ref-commit-adc59a3 |
|
| https://github.com/maclover7 |
|
| https://github.com/MylesBorins |
| tools: host remark-preset-lint-node in-tree | https://github.com/nodejs/node/commit/adc59a3e71dec8aa35aed958471b633d4ac6115a |
| adc59a3 | https://github.com/nodejs/node/commit/adc59a3e71dec8aa35aed958471b633d4ac6115a |
| https://github.com/watilde/remark-preset-lint-node | https://github.com/watilde/remark-preset-lint-node |
| #17441 | https://github.com/nodejs/node/pull/17441 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 10, 2018
| https://github.com/nodejs/node/pull/17441#ref-pullrequest-287276543 |
|
v9.4.0 proposal
#18069
| https://github.com/nodejs/node/pull/18069 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Jan 24, 2018 | https://github.com/nodejs/node/pull/17441#event-1439069614 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jan 24, 2018 | https://github.com/nodejs/node/pull/17441#issuecomment-360069818 |
| Please reload this page | https://github.com/nodejs/node/pull/17441 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17441 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/17441/files/d55a7ed88a583772c1ec4943ee8532f878fb3297 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/17441/files/d55a7ed88a583772c1ec4943ee8532f878fb3297 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/17441/files/d55a7ed88a583772c1ec4943ee8532f878fb3297 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/watilde |
|
watilde
| https://github.com/watilde |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/17441 |
|
| https://github.com/maclover7 |
|
| https://github.com/Trott |
|
| https://github.com/BridgeAR |
|
| https://github.com/watilde |
|
| https://github.com/MylesBorins |
|
| https://github.com/mcollina |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |