René's URL Explorer Experiment


Title: events: remove reaches into _events internals by apapirovski · Pull Request #17440 · nodejs/node · GitHub

Open Graph Title: events: remove reaches into _events internals by apapirovski · Pull Request #17440 · nodejs/node

X Title: events: remove reaches into _events internals by apapirovski · Pull Request #17440 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This strips out the harmless bits of #17324 into this standalone PR so they can actually land. Refactoring of the lib & src code to eliminate all deep reaches into the internal _events dictiona...

X Description: This strips out the harmless bits of #17324 into this standalone PR so they can actually land. Refactoring of the lib & src code to eliminate all deep reaches into the internal _events dict...

Opengraph URL: https://github.com/nodejs/node/pull/17440

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1a98c12c-5539-725f-4600-5b1e517f58de
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7CA:2724D:F81FA:130C81:69914C73
html-safe-nonceb6bb0d7e24bffaa8308d83943f26f7531af5656cba795f3cda662a9390181948
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0NBOjI3MjREOkY4MUZBOjEzMEM4MTo2OTkxNEM3MyIsInZpc2l0b3JfaWQiOiIxNjAxODI5NzYxNTc5MDQzOTU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3c9ff1c938660fc171547c94551cb22830712a2356903adec6e96a7d001b5ac7
hovercard-subject-tagpull_request:156062498
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17440/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2958d0175ea08c37f8782ccd8d4cdcd1a24e7047c0e8623f6b909b51b2016734/nodejs/node/pull/17440
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2958d0175ea08c37f8782ccd8d4cdcd1a24e7047c0e8623f6b909b51b2016734/nodejs/node/pull/17440
og:image:altThis strips out the harmless bits of #17324 into this standalone PR so they can actually land. Refactoring of the lib & src code to eliminate all deep reaches into the internal _events dictiona...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameapapirovski
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17440#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17440
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17440
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17440
Reloadhttps://github.com/nodejs/node/pull/17440
Reloadhttps://github.com/nodejs/node/pull/17440
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17440
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
apapirovskihttps://github.com/apapirovski
nodejs:masterhttps://github.com/nodejs/node/tree/master
apapirovski:patch-ee-internals-usagehttps://github.com/apapirovski/node/tree/patch-ee-internals-usage
Conversationhttps://github.com/nodejs/node/pull/17440
Commits4 (4)https://github.com/nodejs/node/pull/17440/commits
Checkshttps://github.com/nodejs/node/pull/17440/checks
Files changedhttps://github.com/nodejs/node/pull/17440/files
events: remove reaches into _events internalshttps://github.com/nodejs/node/pull/17440#top
apapirovskihttps://github.com/apapirovski
nodejs:masterhttps://github.com/nodejs/node/tree/master
apapirovski:patch-ee-internals-usagehttps://github.com/apapirovski/node/tree/patch-ee-internals-usage
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 3, 2017https://github.com/nodejs/node/pull/17440#issue-278781441
Please reload this pagehttps://github.com/nodejs/node/pull/17440
#17324https://github.com/nodejs/node/pull/17324
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Dec 3, 2017https://github.com/nodejs/node/pull/17440#event-1369307158
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
addaleaxhttps://github.com/addaleax
December 3, 2017 14:20https://github.com/nodejs/node/pull/17440#event-1369307165
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Dec 3, 2017https://github.com/nodejs/node/pull/17440#event-1369307194
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 3, 2017 https://github.com/nodejs/node/pull/17440#pullrequestreview-80703074
View reviewed changes https://github.com/nodejs/node/pull/17440/files
lib/events.jshttps://github.com/nodejs/node/pull/17440/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9
lpincahttps://github.com/lpinca
Dec 3, 2017https://github.com/nodejs/node/pull/17440#discussion_r154525761
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
apapirovskihttps://github.com/apapirovski
Dec 3, 2017https://github.com/nodejs/node/pull/17440#discussion_r154525813
Please reload this pagehttps://github.com/nodejs/node/pull/17440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
apapirovskihttps://github.com/apapirovski
Dec 3, 2017https://github.com/nodejs/node/pull/17440#discussion_r154526056
Please reload this pagehttps://github.com/nodejs/node/pull/17440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#6881https://github.com/nodejs/node/pull/6881
@addaleaxhttps://github.com/addaleax
@ChALkeRhttps://github.com/ChALkeR
@Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/17440
lpincahttps://github.com/lpinca
Dec 3, 2017https://github.com/nodejs/node/pull/17440#discussion_r154526076
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
apapirovskihttps://github.com/apapirovski
Dec 3, 2017https://github.com/nodejs/node/pull/17440#discussion_r154526393
Please reload this pagehttps://github.com/nodejs/node/pull/17440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ChALkeRhttps://github.com/ChALkeR
https://github.com/timoxley/overshadow-listeners/blob/master/index.jshttps://github.com/timoxley/overshadow-listeners/blob/master/index.js
https://github.com/unshiftio/ultron/blob/336c789616db9ca3f164f4e5f15ed78f49d528da/index.js#L105-L111https://github.com/unshiftio/ultron/blob/336c789616db9ca3f164f4e5f15ed78f49d528da/index.js#L105-L111
Please reload this pagehttps://github.com/nodejs/node/pull/17440
addaleaxhttps://github.com/addaleax
Dec 3, 2017https://github.com/nodejs/node/pull/17440#discussion_r154532913
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ChALkeRhttps://github.com/ChALkeR
Please reload this pagehttps://github.com/nodejs/node/pull/17440
lpincahttps://github.com/lpinca
Dec 3, 2017https://github.com/nodejs/node/pull/17440#discussion_r154536503
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
mcollinahttps://github.com/mcollina
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155203954
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/17440
lpincahttps://github.com/lpinca
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155216098
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
mcollinahttps://github.com/mcollina
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155219430
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 4, 2017 https://github.com/nodejs/node/pull/17440#ref-issue-278921666
Listeners incorrectly removed primus/ultron#23 https://github.com/primus/ultron/issues/23
https://github.com/jasnell
jasnellhttps://github.com/jasnell
mcollinahttps://github.com/mcollina
December 5, 2017 17:08https://github.com/nodejs/node/pull/17440#event-1373097813
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
force-pushedhttps://github.com/nodejs/node/compare/c71d935beaa303126a4fa6b949faf9b685495e8e..0c953ec0f14887534bb4d88327a62169ca48c3fd
c71d935https://github.com/nodejs/node/commit/c71d935beaa303126a4fa6b949faf9b685495e8e
0c953echttps://github.com/nodejs/node/commit/0c953ec0f14887534bb4d88327a62169ca48c3fd
Compare https://github.com/nodejs/node/compare/c71d935beaa303126a4fa6b949faf9b685495e8e..0c953ec0f14887534bb4d88327a62169ca48c3fd
December 5, 2017 20:23https://github.com/nodejs/node/pull/17440#event-1373461607
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 5, 2017https://github.com/nodejs/node/pull/17440#issuecomment-349429907
https://ci.nodejs.org/job/node-test-pull-request/11897/https://ci.nodejs.org/job/node-test-pull-request/11897/
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 6, 2017 https://github.com/nodejs/node/pull/17440#pullrequestreview-81407888
View reviewed changes https://github.com/nodejs/node/pull/17440/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/17440#pullrequestreview-81407888
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Dec 6, 2017 https://github.com/nodejs/node/pull/17440#pullrequestreview-81409974
View reviewed changes https://github.com/nodejs/node/pull/17440/files
lib/events.jshttps://github.com/nodejs/node/pull/17440/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9
TimothyGuhttps://github.com/TimothyGu
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155140998
Please reload this pagehttps://github.com/nodejs/node/pull/17440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
mcollinahttps://github.com/mcollina
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155202602
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
apapirovskihttps://github.com/apapirovski
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155315288
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
mcollinahttps://github.com/mcollina
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155324577
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 6, 2017 https://github.com/nodejs/node/pull/17440#pullrequestreview-81481058
View reviewed changes https://github.com/nodejs/node/pull/17440/files
lib/events.jshttps://github.com/nodejs/node/pull/17440/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9
mcollinahttps://github.com/mcollina
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155202602
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
src/node.cchttps://github.com/nodejs/node/pull/17440/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
mcollinahttps://github.com/mcollina
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155203082
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
apapirovskihttps://github.com/apapirovski
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155315610
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
lib/vm.jshttps://github.com/nodejs/node/pull/17440/files#diff-c1d48dc599e8281b0be28ab449ea52917f6d4cc0578adb61ae99c631078b1a41
mcollinahttps://github.com/mcollina
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155203316
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
lib/vm.jshttps://github.com/nodejs/node/pull/17440/files#diff-c1d48dc599e8281b0be28ab449ea52917f6d4cc0578adb61ae99c631078b1a41
mcollinahttps://github.com/mcollina
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155203366
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
lib/events.jshttps://github.com/nodejs/node/pull/17440/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9
mcollinahttps://github.com/mcollina
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155203954
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/17440
test/parallel/test-event-emitter-listeners.jshttps://github.com/nodejs/node/pull/17440/files#diff-abbf122721971fbc45b3d341458d98a5bce292d51cbd129847a4ed0fa0d93c27
mcollinahttps://github.com/mcollina
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155204437
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
doc/api/events.mdhttps://github.com/nodejs/node/pull/17440/files#diff-acab04eff9355fc62738fb601b7d1b1974c0d686c4396971dbab1f0432fbaadf
mcollinahttps://github.com/mcollina
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155204665
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
apapirovskihttps://github.com/apapirovski
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155373031
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
mcollinahttps://github.com/mcollina
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155373823
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
apapirovskihttps://github.com/apapirovski
Dec 6, 2017https://github.com/nodejs/node/pull/17440#discussion_r155374180
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
TimothyGuhttps://github.com/TimothyGu
Dec 7, 2017https://github.com/nodejs/node/pull/17440#discussion_r155654606
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728
b7405abhttps://github.com/nodejs/node/commit/b7405ab011606373ae7bf28e4bf0b4c912fc2117
7f086ddhttps://github.com/nodejs/node/commit/7f086dd6016d9f85b1bc01680addfa53fadd2728
Compare https://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728
December 8, 2017 16:37https://github.com/nodejs/node/pull/17440#event-1379146159
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 10, 2017https://github.com/nodejs/node/pull/17440#issuecomment-350520883
https://ci.nodejs.org/job/node-test-commit/14721/https://ci.nodejs.org/job/node-test-commit/14721/
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 10, 2017 https://github.com/nodejs/node/pull/17440#pullrequestreview-82340324
View reviewed changes https://github.com/nodejs/node/pull/17440/files
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 10, 2017https://github.com/nodejs/node/pull/17440#issuecomment-350547733
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 12, 2017https://github.com/nodejs/node/pull/17440#issuecomment-351124668
@mcollinahttps://github.com/mcollina
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 12, 2017https://github.com/nodejs/node/pull/17440#issuecomment-351142096
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 12, 2017https://github.com/nodejs/node/pull/17440#issuecomment-351145846
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 12, 2017 https://github.com/nodejs/node/pull/17440#pullrequestreview-82941146
View reviewed changes https://github.com/nodejs/node/pull/17440/files
doc/api/events.mdhttps://github.com/nodejs/node/pull/17440/files#diff-acab04eff9355fc62738fb601b7d1b1974c0d686c4396971dbab1f0432fbaadf
mcollinahttps://github.com/mcollina
Dec 12, 2017https://github.com/nodejs/node/pull/17440#discussion_r156460564
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
apapirovskihttps://github.com/apapirovski
Dec 12, 2017https://github.com/nodejs/node/pull/17440#discussion_r156461960
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 12, 2017 https://github.com/nodejs/node/pull/17440#pullrequestreview-82941319
View reviewed changes https://github.com/nodejs/node/pull/17440/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/17440#pullrequestreview-82941319
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 12, 2017 https://github.com/nodejs/node/pull/17440#pullrequestreview-83021099
View reviewed changes https://github.com/nodejs/node/pull/17440/files
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Dec 13, 2017 https://github.com/nodejs/node/pull/17440#pullrequestreview-83085139
View reviewed changes https://github.com/nodejs/node/pull/17440/files
doc/api/events.mdhttps://github.com/nodejs/node/pull/17440/files#diff-acab04eff9355fc62738fb601b7d1b1974c0d686c4396971dbab1f0432fbaadf
TimothyGuhttps://github.com/TimothyGu
Dec 13, 2017https://github.com/nodejs/node/pull/17440#discussion_r156585107
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
apapirovskihttps://github.com/apapirovski
Dec 13, 2017https://github.com/nodejs/node/pull/17440#discussion_r156661612
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17440
TimothyGuhttps://github.com/TimothyGu
Dec 13, 2017https://github.com/nodejs/node/pull/17440#discussion_r156732606
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#17657https://github.com/nodejs/node/issues/17657
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Dec 13, 2017 https://github.com/nodejs/node/pull/17440#ref-issue-281838485
Change type annotations for eventName in events API doc to {string|symbol} #17657 https://github.com/nodejs/node/issues/17657
https://github.com/aprilwebster
aprilwebsterhttps://github.com/aprilwebster
Dec 13, 2017 https://github.com/nodejs/node/pull/17440#ref-pullrequest-281930682
doc: change eventName type annotations #17666 https://github.com/nodejs/node/pull/17666
apapirovskihttps://github.com/apapirovski
December 14, 2017 08:22https://github.com/nodejs/node/pull/17440#commits-pushed-707fca2
https://github.com/apapirovski
events: remove reaches into _events internalshttps://github.com/nodejs/node/pull/17440/commits/707fca2487da1e7a362d404c690232c5fcfa35d3
707fca2https://github.com/nodejs/node/pull/17440/commits/707fca2487da1e7a362d404c690232c5fcfa35d3
https://github.com/apapirovski
fixup: address some of mcollina's feedbackhttps://github.com/nodejs/node/pull/17440/commits/a9b213c0a80e61e1ce136a1a5b7cbb50b338f5b3
a9b213chttps://github.com/nodejs/node/pull/17440/commits/a9b213c0a80e61e1ce136a1a5b7cbb50b338f5b3
https://github.com/apapirovski
fixup: example for rawListenershttps://github.com/nodejs/node/pull/17440/commits/db52004af90b7b410fef836f7332f06d85c9a9b3
db52004https://github.com/nodejs/node/pull/17440/commits/db52004af90b7b410fef836f7332f06d85c9a9b3
https://github.com/apapirovski
fixup: add #on examplehttps://github.com/nodejs/node/pull/17440/commits/53aab29ce63a53289059f7ce50d486d4824c540c
53aab29https://github.com/nodejs/node/pull/17440/commits/53aab29ce63a53289059f7ce50d486d4824c540c
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
force-pushedhttps://github.com/nodejs/node/compare/1b0d9cdfb309684f483aa66aba1370e2db8f35c2..53aab29ce63a53289059f7ce50d486d4824c540c
1b0d9cdhttps://github.com/nodejs/node/commit/1b0d9cdfb309684f483aa66aba1370e2db8f35c2
53aab29https://github.com/nodejs/node/commit/53aab29ce63a53289059f7ce50d486d4824c540c
Compare https://github.com/nodejs/node/compare/1b0d9cdfb309684f483aa66aba1370e2db8f35c2..53aab29ce63a53289059f7ce50d486d4824c540c
December 14, 2017 13:22https://github.com/nodejs/node/pull/17440#event-1387668730
apapirovskihttps://github.com/apapirovski
Dec 14, 2017 https://github.com/nodejs/node/pull/17440#ref-commit-decab71
https://github.com/apapirovski
events: remove reaches into _events internalshttps://github.com/nodejs/node/commit/decab712ba14b8ec577025a57b8ab460fd3b8ec5
decab71https://github.com/nodejs/node/commit/decab712ba14b8ec577025a57b8ab460fd3b8ec5
#17440https://github.com/nodejs/node/pull/17440
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 14, 2017https://github.com/nodejs/node/pull/17440#issuecomment-351714440
decab71https://github.com/nodejs/node/commit/decab712ba14b8ec577025a57b8ab460fd3b8ec5
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 14, 2017https://github.com/nodejs/node/pull/17440#event-1387705256
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
December 14, 2017 13:45https://github.com/nodejs/node/pull/17440#event-1387705363
aprilwebsterhttps://github.com/aprilwebster
Dec 14, 2017 https://github.com/nodejs/node/pull/17440#ref-commit-6dbe6d4
https://github.com/aprilwebster
doc: change eventName type annotationshttps://github.com/aprilwebster/node/commit/6dbe6d463d0786652437b9d007f54628f4c1e8ad
6dbe6d4https://github.com/aprilwebster/node/commit/6dbe6d463d0786652437b9d007f54628f4c1e8ad
nodejs#17440https://github.com/nodejs/node/pull/17440
nodejs#17657https://github.com/nodejs/node/issues/17657
MylesBorinshttps://github.com/MylesBorins
Jan 8, 2018 https://github.com/nodejs/node/pull/17440#ref-commit-7008719
https://github.com/apapirovski
https://github.com/MylesBorins
events: remove reaches into _events internalshttps://github.com/nodejs/node/commit/7008719fb6d9ec880ecf5e124f1aa618436e5430
7008719https://github.com/nodejs/node/commit/7008719fb6d9ec880ecf5e124f1aa618436e5430
#17440https://github.com/nodejs/node/pull/17440
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 10, 2018 https://github.com/nodejs/node/pull/17440#ref-pullrequest-287276543
v9.4.0 proposal #18069 https://github.com/nodejs/node/pull/18069
MylesBorinshttps://github.com/MylesBorins
Jan 10, 2018 https://github.com/nodejs/node/pull/17440#ref-commit-074a2cb
https://github.com/MylesBorins
2019-01-10 Version 9.4.0 (Current)https://github.com/nodejs/node/commit/074a2cb3dc5c6e0d4f297e558fae16a5bdce2ff4
074a2cbhttps://github.com/nodejs/node/commit/074a2cb3dc5c6e0d4f297e558fae16a5bdce2ff4
#16972https://github.com/nodejs/node/pull/16972
#17908https://github.com/nodejs/node/pull/17908
#17535https://github.com/nodejs/node/pull/17535
#16591https://github.com/nodejs/node/pull/16591
#17440https://github.com/nodejs/node/pull/17440
#17672https://github.com/nodejs/node/pull/17672
#17967https://github.com/nodejs/node/pull/17967
#17935https://github.com/nodejs/node/pull/17935
#17917https://github.com/nodejs/node/pull/17917
#17906https://github.com/nodejs/node/pull/17906
#17644https://github.com/nodejs/node/pull/17644
#13735https://github.com/nodejs/node/pull/13735
#16591https://github.com/nodejs/node/pull/16591
#12857https://github.com/nodejs/node/pull/12857
#12855https://github.com/nodejs/node/pull/12855
#17609https://github.com/nodejs/node/pull/17609
#16042https://github.com/nodejs/node/pull/16042
https://github.com/starkwanghttps://github.com/starkwang
https://github.com/danbevhttps://github.com/danbev
#18069https://github.com/nodejs/node/pull/18069
MylesBorinshttps://github.com/MylesBorins
Jan 10, 2018 https://github.com/nodejs/node/pull/17440#ref-commit-7aefa40
https://github.com/MylesBorins
2019-01-10 Version 9.4.0 (Current)https://github.com/nodejs/node/commit/7aefa404df93553ce24dc3e40f23dc72ea1852d3
7aefa40https://github.com/nodejs/node/commit/7aefa404df93553ce24dc3e40f23dc72ea1852d3
#16972https://github.com/nodejs/node/pull/16972
#17908https://github.com/nodejs/node/pull/17908
#17535https://github.com/nodejs/node/pull/17535
#16591https://github.com/nodejs/node/pull/16591
#17440https://github.com/nodejs/node/pull/17440
#17672https://github.com/nodejs/node/pull/17672
#17967https://github.com/nodejs/node/pull/17967
#17935https://github.com/nodejs/node/pull/17935
#17917https://github.com/nodejs/node/pull/17917
#17906https://github.com/nodejs/node/pull/17906
#17406https://github.com/nodejs/node/pull/17406
#17644https://github.com/nodejs/node/pull/17644
#13735https://github.com/nodejs/node/pull/13735
#16591https://github.com/nodejs/node/pull/16591
#12857https://github.com/nodejs/node/pull/12857
#12855https://github.com/nodejs/node/pull/12855
#17609https://github.com/nodejs/node/pull/17609
#16042https://github.com/nodejs/node/pull/16042
https://github.com/starkwanghttps://github.com/starkwang
https://github.com/danbevhttps://github.com/danbev
#18069https://github.com/nodejs/node/pull/18069
MylesBorinshttps://github.com/MylesBorins
Jan 10, 2018 https://github.com/nodejs/node/pull/17440#ref-commit-e688175
https://github.com/MylesBorins
2019-01-10 Version 9.4.0 (Current)https://github.com/nodejs/node/commit/e688175c500a556b94191df2c0236b7510654923
https://github.com/nodejs/node/commit/e688175c500a556b94191df2c0236b7510654923#comments
e688175https://github.com/nodejs/node/commit/e688175c500a556b94191df2c0236b7510654923
#16972https://github.com/nodejs/node/pull/16972
#17908https://github.com/nodejs/node/pull/17908
#17535https://github.com/nodejs/node/pull/17535
#16591https://github.com/nodejs/node/pull/16591
#17440https://github.com/nodejs/node/pull/17440
#17672https://github.com/nodejs/node/pull/17672
#17967https://github.com/nodejs/node/pull/17967
#17935https://github.com/nodejs/node/pull/17935
#17917https://github.com/nodejs/node/pull/17917
#17906https://github.com/nodejs/node/pull/17906
#17406https://github.com/nodejs/node/pull/17406
#17644https://github.com/nodejs/node/pull/17644
#13735https://github.com/nodejs/node/pull/13735
#16591https://github.com/nodejs/node/pull/16591
#12857https://github.com/nodejs/node/pull/12857
#12855https://github.com/nodejs/node/pull/12855
#17609https://github.com/nodejs/node/pull/17609
#16042https://github.com/nodejs/node/pull/16042
https://github.com/starkwanghttps://github.com/starkwang
https://github.com/danbevhttps://github.com/danbev
#18069https://github.com/nodejs/node/pull/18069
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Aug 2, 2018https://github.com/nodejs/node/pull/17440#event-1767842337
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17440
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/17440/files/c71d935beaa303126a4fa6b949faf9b685495e8e
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/17440/files/d2b03d899e50b3b4302222b8c580469bd4722f9e
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/17440/files/1b0d9cdfb309684f483aa66aba1370e2db8f35c2
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/17440/files/0c953ec0f14887534bb4d88327a62169ca48c3fd
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/17440/files/20cea917a312eaf8c4a6696ae8c96a70bf983963
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/17440/files/1b0d9cdfb309684f483aa66aba1370e2db8f35c2
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/17440
https://github.com/apapirovski
https://github.com/addaleax
https://github.com/mcollina
https://github.com/jasnell
https://github.com/lpinca
https://github.com/TimothyGu
https://github.com/BridgeAR
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.