René's URL Explorer Experiment


Title: events: remove domain handling from events to domain by vdeturckheim · Pull Request #17403 · nodejs/node · GitHub

Open Graph Title: events: remove domain handling from events to domain by vdeturckheim · Pull Request #17403 · nodejs/node

X Title: events: remove domain handling from events to domain by vdeturckheim · Pull Request #17403 · nodejs/node

Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included (N/A) documentation is changed or added (N/A) commit message follows commit guidelines A...

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included (N/A) documentation is changed or added (N/A) commit message follows commit guidelines A...

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included (N/A) documentation is changed or added (N/A) commit message follows commit guidelines A...

Opengraph URL: https://github.com/nodejs/node/pull/17403

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:61213b62-1dca-0e8d-696c-7ec21f40313c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8172:154180:13EE990:1A21AA9:696B1B32
html-safe-nonce7d960525f66e5f9cbcdfdba2485971a39a1db0247e33a444c4666fd115b77cc6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTcyOjE1NDE4MDoxM0VFOTkwOjFBMjFBQTk6Njk2QjFCMzIiLCJ2aXNpdG9yX2lkIjoiNDg1NzYwODIxMTExMzEyMjYxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace578eaf4f68f52637f81116bf0d17aa9bded69eb1d95885e4d2e3149863825f5
hovercard-subject-tagpull_request:155669473
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17403/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9cbe8360ee8cab08fa15daf1a66160e5f0e3cd853f717a8d6c2f4f9a52e2f1d5/nodejs/node/pull/17403
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9cbe8360ee8cab08fa15daf1a66160e5f0e3cd853f717a8d6c2f4f9a52e2f1d5/nodejs/node/pull/17403
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included (N/A) documentation is changed or added (N/A) commit message follows commit guidelines A...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevdeturckheim
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17403#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17403
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17403
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17403
Reloadhttps://github.com/nodejs/node/pull/17403
Reloadhttps://github.com/nodejs/node/pull/17403
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17403
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/17403
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/17403#issue-comment-box
vdeturckheimhttps://github.com/vdeturckheim
nodejs:masterhttps://github.com/nodejs/node/tree/master
events: remove domain handling from events to domain https://github.com/nodejs/node/pull/17403#top
vdeturckheimhttps://github.com/vdeturckheim
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversation 48 https://github.com/nodejs/node/pull/17403
Commits 1 https://github.com/nodejs/node/pull/17403/commits
Checks 0 https://github.com/nodejs/node/pull/17403/checks
Files changed https://github.com/nodejs/node/pull/17403/files
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/vdeturckheim
vdeturckheimhttps://github.com/vdeturckheim
Nov 30, 2017https://github.com/nodejs/node/pull/17403#issue-278201846
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
#17143https://github.com/nodejs/node/issues/17143
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
domain https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adomain
events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents
Nov 30, 2017https://github.com/nodejs/node/pull/17403#event-1366111245
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Nov 30, 2017 https://github.com/nodejs/node/pull/17403#pullrequestreview-80262409
View reviewed changes https://github.com/nodejs/node/pull/17403/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/17403#pullrequestreview-80262409
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
lib/events.jshttps://github.com/nodejs/node/pull/17403/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9
TimothyGuhttps://github.com/TimothyGu
Nov 30, 2017https://github.com/nodejs/node/pull/17403#discussion_r154143985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
vdeturckheimhttps://github.com/vdeturckheim
Nov 30, 2017https://github.com/nodejs/node/pull/17403#discussion_r154145329
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/pull/17403/files/426afc70832c47f18f9afd9f90f35c1e554c8d3a#diff-0b93f5d72b0d34f5b972b661935344c3R415https://github.com/nodejs/node/pull/17403/files/426afc70832c47f18f9afd9f90f35c1e554c8d3a#diff-0b93f5d72b0d34f5b972b661935344c3R415
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 30, 2017 https://github.com/nodejs/node/pull/17403#pullrequestreview-80263733
View reviewed changes https://github.com/nodejs/node/pull/17403/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/17403#pullrequestreview-80263733
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/vdeturckheim
vdeturckheimhttps://github.com/vdeturckheim
Nov 30, 2017 https://github.com/nodejs/node/pull/17403#pullrequestreview-80264213
View reviewed changes https://github.com/nodejs/node/pull/17403/files
lib/events.jshttps://github.com/nodejs/node/pull/17403/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9
vdeturckheimhttps://github.com/vdeturckheim
Nov 30, 2017https://github.com/nodejs/node/pull/17403#discussion_r154145545
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 30, 2017https://github.com/nodejs/node/pull/17403#issuecomment-348260223
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/vdeturckheim
vdeturckheimhttps://github.com/vdeturckheim
Nov 30, 2017https://github.com/nodejs/node/pull/17403#issuecomment-348260433
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 30, 2017 https://github.com/nodejs/node/pull/17403#pullrequestreview-80266272
View reviewed changes https://github.com/nodejs/node/pull/17403/files
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/17403#pullrequestreview-80266272
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 30, 2017https://github.com/nodejs/node/pull/17403#issuecomment-348262627
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 30, 2017https://github.com/nodejs/node/pull/17403#issuecomment-348262880
https://ci.nodejs.org/job/node-test-commit/14486/https://ci.nodejs.org/job/node-test-commit/14486/
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/AndreasMadsen
AndreasMadsenhttps://github.com/AndreasMadsen
Nov 30, 2017 https://github.com/nodejs/node/pull/17403#ref-issue-275201553
domain migration to async_hooks #17143 https://github.com/nodejs/node/issues/17143
https://github.com/AndreasMadsen
AndreasMadsenhttps://github.com/AndreasMadsen
Nov 30, 2017 https://github.com/nodejs/node/pull/17403#pullrequestreview-80302967
View reviewed changes https://github.com/nodejs/node/pull/17403/files
lib/domain.jshttps://github.com/nodejs/node/pull/17403/files#diff-f7f9af64ce3fbfb8fdb6e52d2452693b71f38e1cbedca80c22e2c7a59c7145e6
AndreasMadsenhttps://github.com/AndreasMadsen
Nov 30, 2017https://github.com/nodejs/node/pull/17403#discussion_r154178015
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
vdeturckheimhttps://github.com/vdeturckheim
Nov 30, 2017https://github.com/nodejs/node/pull/17403#discussion_r154219301
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/AndreasMadsen
AndreasMadsenhttps://github.com/AndreasMadsen
Nov 30, 2017 https://github.com/nodejs/node/pull/17403#pullrequestreview-80305498
View reviewed changes https://github.com/nodejs/node/pull/17403/files
AndreasMadsenhttps://github.com/AndreasMadsen
https://github.com/nodejs/node/pull/17403#pullrequestreview-80305498
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Nov 30, 2017https://github.com/nodejs/node/pull/17403#issuecomment-348342441
@addaleaxhttps://github.com/addaleax
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Nov 30, 2017 https://github.com/nodejs/node/pull/17403#pullrequestreview-80353288
View reviewed changes https://github.com/nodejs/node/pull/17403/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/17403#pullrequestreview-80353288
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Nov 30, 2017 https://github.com/nodejs/node/pull/17403#pullrequestreview-80353503
View reviewed changes https://github.com/nodejs/node/pull/17403/files
lib/domain.jshttps://github.com/nodejs/node/pull/17403/files#diff-f7f9af64ce3fbfb8fdb6e52d2452693b71f38e1cbedca80c22e2c7a59c7145e6
TimothyGuhttps://github.com/TimothyGu
Nov 30, 2017https://github.com/nodejs/node/pull/17403#discussion_r154221419
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
vdeturckheimhttps://github.com/vdeturckheim
Nov 30, 2017https://github.com/nodejs/node/pull/17403#discussion_r154222035
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/vdeturckheim
events: remove domain handling from events to domainhttps://github.com/nodejs/node/pull/17403/commits/1876e969b244dd29baf1882e34bb0617fe2cbc69
1876e96https://github.com/nodejs/node/pull/17403/commits/1876e969b244dd29baf1882e34bb0617fe2cbc69
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 1, 2017 https://github.com/nodejs/node/pull/17403#pullrequestreview-80520682
View reviewed changes https://github.com/nodejs/node/pull/17403/files/1876e969b244dd29baf1882e34bb0617fe2cbc69
apapirovskihttps://github.com/apapirovski
https://github.com/nodejs/node/pull/17403#pullrequestreview-80520682
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 1, 2017https://github.com/nodejs/node/pull/17403#issuecomment-348593033
https://ci.nodejs.org/job/node-test-commit/14516/https://ci.nodejs.org/job/node-test-commit/14516/
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 1, 2017https://github.com/nodejs/node/pull/17403#event-1368286724
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 4, 2017 https://github.com/nodejs/node/pull/17403#pullrequestreview-80851490
View reviewed changes https://github.com/nodejs/node/pull/17403/files/1876e969b244dd29baf1882e34bb0617fe2cbc69
apapirovskihttps://github.com/apapirovski
https://github.com/nodejs/node/pull/17403#pullrequestreview-80851490
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
lib/domain.jshttps://github.com/nodejs/node/pull/17403/files/1876e969b244dd29baf1882e34bb0617fe2cbc69#diff-f7f9af64ce3fbfb8fdb6e52d2452693b71f38e1cbedca80c22e2c7a59c7145e6
apapirovskihttps://github.com/apapirovski
Dec 4, 2017https://github.com/nodejs/node/pull/17403#discussion_r154657836
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@vdeturckheimhttps://github.com/vdeturckheim
Please reload this pagehttps://github.com/nodejs/node/pull/17403
benjamingrhttps://github.com/benjamingr
Dec 4, 2017https://github.com/nodejs/node/pull/17403#discussion_r154682836
Please reload this pagehttps://github.com/nodejs/node/pull/17403
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@apapirovskihttps://github.com/apapirovski
Please reload this pagehttps://github.com/nodejs/node/pull/17403
apapirovskihttps://github.com/apapirovski
Dec 4, 2017https://github.com/nodejs/node/pull/17403#discussion_r154683172
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
benjamingrhttps://github.com/benjamingr
Dec 4, 2017https://github.com/nodejs/node/pull/17403#discussion_r154685407
Please reload this pagehttps://github.com/nodejs/node/pull/17403
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@apapirovskihttps://github.com/apapirovski
@bmeurerhttps://github.com/bmeurer
Please reload this pagehttps://github.com/nodejs/node/pull/17403
apapirovskihttps://github.com/apapirovski
Dec 4, 2017https://github.com/nodejs/node/pull/17403#discussion_r154688894
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
apapirovskihttps://github.com/apapirovski
Dec 6, 2017https://github.com/nodejs/node/pull/17403#discussion_r155302682
Please reload this pagehttps://github.com/nodejs/node/pull/17403
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/17403
apapirovskihttps://github.com/apapirovski
Dec 6, 2017https://github.com/nodejs/node/pull/17403#discussion_r155303445
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
lib/domain.jshttps://github.com/nodejs/node/pull/17403/files/1876e969b244dd29baf1882e34bb0617fe2cbc69#diff-f7f9af64ce3fbfb8fdb6e52d2452693b71f38e1cbedca80c22e2c7a59c7145e6
apapirovskihttps://github.com/apapirovski
Dec 4, 2017https://github.com/nodejs/node/pull/17403#discussion_r154658020
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
benjamingrhttps://github.com/benjamingr
Dec 4, 2017https://github.com/nodejs/node/pull/17403#discussion_r154684388
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
apapirovskihttps://github.com/apapirovski
Dec 4, 2017https://github.com/nodejs/node/pull/17403#discussion_r154684697
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
benjamingrhttps://github.com/benjamingr
Dec 4, 2017https://github.com/nodejs/node/pull/17403#discussion_r154686715
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@apapirovskihttps://github.com/apapirovski
Please reload this pagehttps://github.com/nodejs/node/pull/17403
apapirovskihttps://github.com/apapirovski
Dec 4, 2017https://github.com/nodejs/node/pull/17403#discussion_r154687083
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
targoshttps://github.com/targos
Dec 4, 2017https://github.com/nodejs/node/pull/17403#discussion_r154689445
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
apapirovskihttps://github.com/apapirovski
Dec 4, 2017https://github.com/nodejs/node/pull/17403#discussion_r154690794
Please reload this pagehttps://github.com/nodejs/node/pull/17403
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
apapirovskihttps://github.com/apapirovski
Dec 4, 2017https://github.com/nodejs/node/pull/17403#discussion_r154691986
Please reload this pagehttps://github.com/nodejs/node/pull/17403
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/vdeturckheim
vdeturckheimhttps://github.com/vdeturckheim
Dec 4, 2017https://github.com/nodejs/node/pull/17403#issuecomment-349000300
@apapirovskihttps://github.com/apapirovski
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 4, 2017https://github.com/nodejs/node/pull/17403#issuecomment-349001301
@vdeturckheimhttps://github.com/vdeturckheim
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/vdeturckheim
vdeturckheimhttps://github.com/vdeturckheim
Dec 4, 2017https://github.com/nodejs/node/pull/17403#issuecomment-349004413
@apapirovskihttps://github.com/apapirovski
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 4, 2017https://github.com/nodejs/node/pull/17403#issuecomment-349012540
Please reload this pagehttps://github.com/nodejs/node/pull/17403
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 4, 2017https://github.com/nodejs/node/pull/17403#issuecomment-349017900
cf4448chttps://github.com/nodejs/node/commit/cf4448cbd48e2da0f9461709f27b6cb41ddd2c87
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 4, 2017https://github.com/nodejs/node/pull/17403#event-1370846908
apapirovskihttps://github.com/apapirovski
Dec 4, 2017 https://github.com/nodejs/node/pull/17403#ref-commit-cf4448c
https://github.com/vdeturckheim
https://github.com/apapirovski
events: move domain handling from events to domainhttps://github.com/nodejs/node/commit/cf4448cbd48e2da0f9461709f27b6cb41ddd2c87
cf4448chttps://github.com/nodejs/node/commit/cf4448cbd48e2da0f9461709f27b6cb41ddd2c87
#17403https://github.com/nodejs/node/pull/17403
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 4, 2017https://github.com/nodejs/node/pull/17403#issuecomment-349018469
@addaleaxhttps://github.com/addaleax
@AndreasMadsenhttps://github.com/AndreasMadsen
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Dec 4, 2017https://github.com/nodejs/node/pull/17403#event-1371298504
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v9.x
Dec 10, 2017https://github.com/nodejs/node/pull/17403#event-1380243162
https://github.com/novemberborn
novemberbornhttps://github.com/novemberborn
Dec 10, 2017https://github.com/nodejs/node/pull/17403#issuecomment-350560009
@addaleaxhttps://github.com/addaleax
this linehttps://github.com/nodejs/node/commit/cf4448cbd48e2da0f9461709f27b6cb41ddd2c87#diff-0b93f5d72b0d34f5b972b661935344c3R411
https://gist.github.com/novemberborn/2d6137cab8a57fdbafbccc5b33926585https://gist.github.com/novemberborn/2d6137cab8a57fdbafbccc5b33926585
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 10, 2017 https://github.com/nodejs/node/pull/17403#ref-pullrequest-280830093
domain: fix error emit handling #17588 https://github.com/nodejs/node/pull/17588
apapirovskihttps://github.com/apapirovski
Dec 13, 2017 https://github.com/nodejs/node/pull/17403#ref-commit-04ae486
https://github.com/apapirovski
domain: fix error emit handlinghttps://github.com/nodejs/node/commit/04ae4862e670a8849454e6d8db4d8f73d0492190
04ae486https://github.com/nodejs/node/commit/04ae4862e670a8849454e6d8db4d8f73d0492190
#17588https://github.com/nodejs/node/pull/17588
#17403https://github.com/nodejs/node/pull/17403
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
dont-land-on-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v9.x
Jan 31, 2018https://github.com/nodejs/node/pull/17403#event-1451537523
apapirovskihttps://github.com/apapirovski
Jan 31, 2018 https://github.com/nodejs/node/pull/17403#ref-commit-4f5ac7f
https://github.com/vdeturckheim
https://github.com/apapirovski
events: move domain handling from events to domainhttps://github.com/apapirovski/node/commit/4f5ac7fa84ec7ebb0d2b096b324cc5d3cdb1ebc0
4f5ac7fhttps://github.com/apapirovski/node/commit/4f5ac7fa84ec7ebb0d2b096b324cc5d3cdb1ebc0
nodejs#17403https://github.com/nodejs/node/pull/17403
apapirovskihttps://github.com/apapirovski
Jan 31, 2018 https://github.com/nodejs/node/pull/17403#ref-commit-9b98742
https://github.com/apapirovski
domain: fix error emit handlinghttps://github.com/apapirovski/node/commit/9b987428c08f589dec7edc8a8c1aa005b83ebf92
9b98742https://github.com/apapirovski/node/commit/9b987428c08f589dec7edc8a8c1aa005b83ebf92
nodejs#17588https://github.com/nodejs/node/pull/17588
nodejs#17403https://github.com/nodejs/node/pull/17403
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v9.x
Feb 20, 2018https://github.com/nodejs/node/pull/17403#event-1483354222
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 20, 2018https://github.com/nodejs/node/pull/17403#issuecomment-367117560
Please reload this pagehttps://github.com/nodejs/node/pull/17403
04ae486https://github.com/nodejs/node/commit/04ae4862e670a8849454e6d8db4d8f73d0492190
cf4448chttps://github.com/nodejs/node/commit/cf4448cbd48e2da0f9461709f27b6cb41ddd2c87
Please reload this pagehttps://github.com/nodejs/node/pull/17403
MylesBorinshttps://github.com/MylesBorins
Feb 20, 2018 https://github.com/nodejs/node/pull/17403#ref-commit-3ae5cf2
https://github.com/vdeturckheim
https://github.com/MylesBorins
events: move domain handling from events to domainhttps://github.com/nodejs/node/commit/3ae5cf205fade294a1120b99bea9638f3f06d92e
3ae5cf2https://github.com/nodejs/node/commit/3ae5cf205fade294a1120b99bea9638f3f06d92e
#18487https://github.com/nodejs/node/pull/18487
#17403https://github.com/nodejs/node/pull/17403
MylesBorinshttps://github.com/MylesBorins
Feb 20, 2018 https://github.com/nodejs/node/pull/17403#ref-commit-35471bc
https://github.com/apapirovski
https://github.com/MylesBorins
domain: fix error emit handlinghttps://github.com/nodejs/node/commit/35471bcfdffaa9624792a510ad04cbb4c8709193
35471bchttps://github.com/nodejs/node/commit/35471bcfdffaa9624792a510ad04cbb4c8709193
#18487https://github.com/nodejs/node/pull/18487
#17588https://github.com/nodejs/node/pull/17588
#17403https://github.com/nodejs/node/pull/17403
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backported-to-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v9.x
backport-requested-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v9.x
Feb 20, 2018https://github.com/nodejs/node/pull/17403#event-1483431331
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 21, 2018 https://github.com/nodejs/node/pull/17403#ref-pullrequest-299038228
v9.6.0 proposal #18902 https://github.com/nodejs/node/pull/18902
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 22, 2018https://github.com/nodejs/node/pull/17403#issuecomment-367814130
@watsonhttps://github.com/watson
https://gist.github.com/watson/d67b60629026fdb7d081be7477c040e5https://gist.github.com/watson/d67b60629026fdb7d081be7477c040e5
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 22, 2018 https://github.com/nodejs/node/pull/17403#ref-issue-299499605
Breaking change landed in v9.6.0 nodejs/Release#312 https://github.com/nodejs/Release/issues/312
https://github.com/vdeturckheim
vdeturckheimhttps://github.com/vdeturckheim
Feb 22, 2018https://github.com/nodejs/node/pull/17403#issuecomment-367816109
@MylesBorinshttps://github.com/MylesBorins
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/watson
watsonhttps://github.com/watson
Feb 22, 2018https://github.com/nodejs/node/pull/17403#issuecomment-367817939
@MylesBorinshttps://github.com/MylesBorins
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 22, 2018 https://github.com/nodejs/node/pull/17403#ref-pullrequest-299515655
events: preset usingDomains to false #18944 https://github.com/nodejs/node/pull/18944
MylesBorinshttps://github.com/MylesBorins
Feb 22, 2018 https://github.com/nodejs/node/pull/17403#ref-commit-ddf746c
https://github.com/MylesBorins
events: preset usingDomains to falsehttps://github.com/MylesBorins/node/commit/ddf746c816f11cd0a816db523ffa35b33baef152
ddf746chttps://github.com/MylesBorins/node/commit/ddf746c816f11cd0a816db523ffa35b33baef152
nodejs#17403 (comment)https://github.com/nodejs/node/pull/17403#issuecomment-367814130
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Feb 22, 2018https://github.com/nodejs/node/pull/17403#event-1488072911
MylesBorinshttps://github.com/MylesBorins
Feb 23, 2018 https://github.com/nodejs/node/pull/17403#ref-commit-6657b15
https://github.com/MylesBorins
events: preset usingDomains to falsehttps://github.com/nodejs/node/commit/6657b153abba09a16e4a628f3a46fc2cdf176b7d
6657b15https://github.com/nodejs/node/commit/6657b153abba09a16e4a628f3a46fc2cdf176b7d
#17403 (comment)https://github.com/nodejs/node/pull/17403#issuecomment-367814130
#18944https://github.com/nodejs/node/pull/18944
MylesBorinshttps://github.com/MylesBorins
Feb 23, 2018 https://github.com/nodejs/node/pull/17403#ref-commit-761caec
https://github.com/MylesBorins
events: preset usingDomains to falsehttps://github.com/nodejs/node/commit/761caec37925d68d8597dca2bf8148b4f7152150
https://github.com/nodejs/node/commit/761caec37925d68d8597dca2bf8148b4f7152150#comments
761caechttps://github.com/nodejs/node/commit/761caec37925d68d8597dca2bf8148b4f7152150
#17403 (comment)https://github.com/nodejs/node/pull/17403#issuecomment-367814130
#18944https://github.com/nodejs/node/pull/18944
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 2, 2018 https://github.com/nodejs/node/pull/17403#ref-pullrequest-301683497
Adding assertion for the test in test-event-emitter-subclass #19082 https://github.com/nodejs/node/pull/19082
MayaLekovahttps://github.com/MayaLekova
May 8, 2018 https://github.com/nodejs/node/pull/17403#ref-commit-45ecbba
https://github.com/MylesBorins
https://github.com/MayaLekova
events: preset usingDomains to falsehttps://github.com/MayaLekova/node/commit/45ecbba7203b44705e38e4795360cc832caf5fa5
45ecbbahttps://github.com/MayaLekova/node/commit/45ecbba7203b44705e38e4795360cc832caf5fa5
nodejs#17403 (comment)https://github.com/nodejs/node/pull/17403#issuecomment-367814130
nodejs#18944https://github.com/nodejs/node/pull/18944
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17403
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/17403/files/1876e969b244dd29baf1882e34bb0617fe2cbc69
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/17403/files/1876e969b244dd29baf1882e34bb0617fe2cbc69
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/17403/files/426afc70832c47f18f9afd9f90f35c1e554c8d3a
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/17403/files/1876e969b244dd29baf1882e34bb0617fe2cbc69
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/17403/files/eb08b1ce72371e0b46f17f4af901b3029f0d9aef
https://github.com/AndreasMadsen
AndreasMadsen https://github.com/AndreasMadsen
https://github.com/nodejs/node/pull/17403/files/283c72a4dc475d2d3c5b2662a8b422f32ceccee7
domain https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adomain
events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/17403
https://github.com/vdeturckheim
https://github.com/addaleax
https://github.com/benjamingr
https://github.com/TimothyGu
https://github.com/apapirovski
https://github.com/novemberborn
https://github.com/MylesBorins
https://github.com/watson
https://github.com/AndreasMadsen
https://github.com/targos
https://github.com/gibfahn
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.