| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9cc37583-5eab-112c-845b-56fe78fbf53d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A62:19F937:7996E3:9B5E9F:699137FB |
| html-safe-nonce | 40ce74776a0cd65c9720fa408b54dce9367a0249385e71cfeb4cb94a2a1de073 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTYyOjE5RjkzNzo3OTk2RTM6OUI1RTlGOjY5OTEzN0ZCIiwidmlzaXRvcl9pZCI6IjUyMDU0OTgxODI2Nzk3MzgzNjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 968ab7710c42700f740dba37a74a609b5214c239ad5d0ae0ba557eeb7a4d755f |
| hovercard-subject-tag | pull_request:154753872 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17345/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3a380f36484ca9d6bc8ef8d11370e4d038b57fe13c52aa5ff8c5a6e99100a818/nodejs/node/pull/17345 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3a380f36484ca9d6bc8ef8d11370e4d038b57fe13c52aa5ff8c5a6e99100a818/nodejs/node/pull/17345 |
| og:image:alt | This is part of Nodefest's Code and Learn nodejs/code-and-learn#72
Among the list of Code and Learn, I solved the unfinished task of replacing function with arrow function
test/parallel/test-a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Leko |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17345#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17345 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17345 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17345 |
| Reload | https://github.com/nodejs/node/pull/17345 |
| Reload | https://github.com/nodejs/node/pull/17345 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
710
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Leko | https://github.com/Leko |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/17345 |
| Commits5 (5) | https://github.com/nodejs/node/pull/17345/commits |
| Checks | https://github.com/nodejs/node/pull/17345/checks |
| Files changed | https://github.com/nodejs/node/pull/17345/files |
| test: replace function with arrow function | https://github.com/nodejs/node/pull/17345#top |
| Leko | https://github.com/Leko |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/Leko |
| Leko | https://github.com/Leko |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#issue-276942397 |
| nodejs/code-and-learn#72 | https://github.com/nodejs/code-and-learn/issues/72 |
| Code and Learn | https://github.com/nodejs/code-and-learn/issues/72#issuecomment-345667395 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
|
| https://github.com/Leko |
| test: replace function with arrow function | https://github.com/nodejs/node/pull/17345/commits/79d1fbca201de498b2deb5488bd1d80610fbc103 |
| 79d1fbc | https://github.com/nodejs/node/pull/17345/commits/79d1fbca201de498b2deb5488bd1d80610fbc103 |
| nodejs/code-and-learn#72 (comment) | https://github.com/nodejs/code-and-learn/issues/72#issuecomment-345667395 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#event-1358777234 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#event-1358853760 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Nov 27, 2017
| https://github.com/nodejs/node/pull/17345#pullrequestreview-79110445 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17345/files/79d1fbca201de498b2deb5488bd1d80610fbc103 |
| test/parallel/test-assert.js | https://github.com/nodejs/node/pull/17345/files/79d1fbca201de498b2deb5488bd1d80610fbc103#diff-968e57a9f4d4ce7494523f71b2594d844620c2794a68049cce33fcdc8c7c7b7c |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#discussion_r153147942 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| Leko | https://github.com/Leko |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#discussion_r153160052 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#discussion_r153163860 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| Leko | https://github.com/Leko |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#discussion_r153176136 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Nov 27, 2017
| https://github.com/nodejs/node/pull/17345#pullrequestreview-79110580 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17345/files/79d1fbca201de498b2deb5488bd1d80610fbc103 |
| test/parallel/test-assert.js | https://github.com/nodejs/node/pull/17345/files/79d1fbca201de498b2deb5488bd1d80610fbc103#diff-968e57a9f4d4ce7494523f71b2594d844620c2794a68049cce33fcdc8c7c7b7c |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#discussion_r153148057 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| Leko | https://github.com/Leko |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#discussion_r153164420 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Nov 27, 2017
| https://github.com/nodejs/node/pull/17345#pullrequestreview-79111214 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17345/files/79d1fbca201de498b2deb5488bd1d80610fbc103 |
| test/parallel/test-whatwg-url-searchparams-getall.js | https://github.com/nodejs/node/pull/17345/files/79d1fbca201de498b2deb5488bd1d80610fbc103#diff-70444656b0ddc55fe7180ebd9ac095f04a9d7a447319a1f6c100bf01474261c4 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#discussion_r153148612 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| Leko | https://github.com/Leko |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#discussion_r153160009 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Nov 27, 2017
| https://github.com/nodejs/node/pull/17345#pullrequestreview-79111303 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17345/files/79d1fbca201de498b2deb5488bd1d80610fbc103 |
| test/parallel/test-whatwg-url-searchparams-getall.js | https://github.com/nodejs/node/pull/17345/files/79d1fbca201de498b2deb5488bd1d80610fbc103#diff-70444656b0ddc55fe7180ebd9ac095f04a9d7a447319a1f6c100bf01474261c4 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#discussion_r153148683 |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| Leko | https://github.com/Leko |
| November 27, 2017 20:04 | https://github.com/nodejs/node/pull/17345#commits-pushed-c0e7ee8 |
|
| https://github.com/Leko |
| test: replace arrow function with shorter property syntax | https://github.com/nodejs/node/pull/17345/commits/c0e7ee81d742bbad08f1d6175067de4208a8c7e5 |
| c0e7ee8 | https://github.com/nodejs/node/pull/17345/commits/c0e7ee81d742bbad08f1d6175067de4208a8c7e5 |
|
| https://github.com/Leko |
| test: revert changes in test-whatwg-url-searchparams-getall | https://github.com/nodejs/node/pull/17345/commits/6dccb020e8a197812261cfcb10eddf0fab77653d |
| 6dccb02 | https://github.com/nodejs/node/pull/17345/commits/6dccb020e8a197812261cfcb10eddf0fab77653d |
| https://github.com/Leko |
| Leko | https://github.com/Leko |
|
Nov 27, 2017
| https://github.com/nodejs/node/pull/17345#pullrequestreview-79137344 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17345/files/79d1fbca201de498b2deb5488bd1d80610fbc103 |
| test/parallel/test-assert.js | https://github.com/nodejs/node/pull/17345/files/79d1fbca201de498b2deb5488bd1d80610fbc103#diff-968e57a9f4d4ce7494523f71b2594d844620c2794a68049cce33fcdc8c7c7b7c |
| Leko | https://github.com/Leko |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#discussion_r153171772 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| https://github.com/yosuke-furukawa |
| yosuke-furukawa | https://github.com/yosuke-furukawa |
|
Nov 27, 2017
| https://github.com/nodejs/node/pull/17345#pullrequestreview-79137570 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17345/files/79d1fbca201de498b2deb5488bd1d80610fbc103 |
| test/parallel/test-assert.js | https://github.com/nodejs/node/pull/17345/files/79d1fbca201de498b2deb5488bd1d80610fbc103#diff-968e57a9f4d4ce7494523f71b2594d844620c2794a68049cce33fcdc8c7c7b7c |
| yosuke-furukawa | https://github.com/yosuke-furukawa |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#discussion_r153171962 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
|
| https://github.com/Leko |
| test: replace this with null | https://github.com/nodejs/node/pull/17345/commits/073972394670942de94cf8a020d80c44b9b22f50 |
| 0739723 | https://github.com/nodejs/node/pull/17345/commits/073972394670942de94cf8a020d80c44b9b22f50 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
domain
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adomain |
|
querystring
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aquerystring |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#event-1359185812 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#issuecomment-347191280 |
| https://ci.nodejs.org/job/node-test-pull-request/11748/ | https://ci.nodejs.org/job/node-test-pull-request/11748/ |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
|
| https://github.com/Leko |
| test: revert to normal function | https://github.com/nodejs/node/pull/17345/commits/fa4eb729a76ca381447b54e6aa9194bc0dfc795f |
| fa4eb72 | https://github.com/nodejs/node/pull/17345/commits/fa4eb729a76ca381447b54e6aa9194bc0dfc795f |
| #17345 (comment) | https://github.com/nodejs/node/pull/17345#discussion_r153171772 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 27, 2017
| https://github.com/nodejs/node/pull/17345#pullrequestreview-79203487 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17345/files/fa4eb729a76ca381447b54e6aa9194bc0dfc795f |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#issuecomment-347218003 |
| https://ci.nodejs.org/job/node-test-pull-request/11751/ | https://ci.nodejs.org/job/node-test-pull-request/11751/ |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
|
Nov 27, 2017
| https://github.com/nodejs/node/pull/17345#pullrequestreview-79207461 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17345/files/fa4eb729a76ca381447b54e6aa9194bc0dfc795f |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#issuecomment-347222868 |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| https://github.com/Leko |
| Leko | https://github.com/Leko |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17345#issuecomment-347223444 |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Nov 27, 2017
| https://github.com/nodejs/node/pull/17345#ref-issue-277166506 |
|
CI does not post status to PR currently
#17358
| https://github.com/nodejs/node/issues/17358 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 28, 2017
| https://github.com/nodejs/node/pull/17345#pullrequestreview-79362821 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17345/files/fa4eb729a76ca381447b54e6aa9194bc0dfc795f |
| https://github.com/yosuke-furukawa |
| yosuke-furukawa | https://github.com/yosuke-furukawa |
|
Nov 28, 2017
| https://github.com/nodejs/node/pull/17345#pullrequestreview-79368150 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17345/files/fa4eb729a76ca381447b54e6aa9194bc0dfc795f |
| https://github.com/Leko |
| Leko | https://github.com/Leko |
| Nov 29, 2017 | https://github.com/nodejs/node/pull/17345#issuecomment-347834425 |
| @vsemozhetbyt | https://github.com/vsemozhetbyt |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 29, 2017 | https://github.com/nodejs/node/pull/17345#issuecomment-347836299 |
| @Leko | https://github.com/Leko |
| https://ci.nodejs.org/job/node-test-pull-request/11798/ | https://ci.nodejs.org/job/node-test-pull-request/11798/ |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| https://github.com/Leko |
| Leko | https://github.com/Leko |
| Nov 29, 2017 | https://github.com/nodejs/node/pull/17345#issuecomment-347836669 |
| @vsemozhetbyt | https://github.com/vsemozhetbyt |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Nov 29, 2017
| https://github.com/nodejs/node/pull/17345#ref-issue-277740925 |
|
CI status in PR differs from status in ci.nodejs.org
#17387
| https://github.com/nodejs/node/issues/17387 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 29, 2017 | https://github.com/nodejs/node/pull/17345#issuecomment-347869037 |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Nov 29, 2017
| https://github.com/nodejs/node/pull/17345#ref-commit-3c62f33 |
|
| https://github.com/Leko |
|
| https://github.com/vsemozhetbyt |
| test: replace function with arrow function | https://github.com/nodejs/node/commit/3c62f33d7ba0f0ec6124d5dc721811808803b8b7 |
| 3c62f33 | https://github.com/nodejs/node/commit/3c62f33d7ba0f0ec6124d5dc721811808803b8b7 |
| nodejs/code-and-learn#72 (comment) | https://github.com/nodejs/code-and-learn/issues/72#issuecomment-345667395 |
| #17345 | https://github.com/nodejs/node/pull/17345 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 29, 2017 | https://github.com/nodejs/node/pull/17345#issuecomment-347873650 |
| 3c62f33 | https://github.com/nodejs/node/commit/3c62f33d7ba0f0ec6124d5dc721811808803b8b7 |
| @Leko | https://github.com/Leko |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 29, 2017 | https://github.com/nodejs/node/pull/17345#event-1363609179 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17345#ref-commit-0c15703 |
|
| https://github.com/Leko |
|
| https://github.com/MylesBorins |
| test: replace function with arrow function | https://github.com/nodejs/node/commit/0c15703b181c81e9777c5cfe914b3a65e4a44b75 |
| 0c15703 | https://github.com/nodejs/node/commit/0c15703b181c81e9777c5cfe914b3a65e4a44b75 |
| nodejs/code-and-learn#72 (comment) | https://github.com/nodejs/code-and-learn/issues/72#issuecomment-345667395 |
| #17345 | https://github.com/nodejs/node/pull/17345 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17345#ref-commit-6e3a8be |
|
| https://github.com/Leko |
|
| https://github.com/MylesBorins |
| test: replace function with arrow function | https://github.com/nodejs/node/commit/6e3a8be43ae661aed6161842897edce3f8923c9e |
| 6e3a8be | https://github.com/nodejs/node/commit/6e3a8be43ae661aed6161842897edce3f8923c9e |
| nodejs/code-and-learn#72 (comment) | https://github.com/nodejs/code-and-learn/issues/72#issuecomment-345667395 |
| #17345 | https://github.com/nodejs/node/pull/17345 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17345#ref-pullrequest-281312309 |
|
v9.3.0 proposal
#17631
| https://github.com/nodejs/node/pull/17631 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/17345#event-1395130619 |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/17345#ref-commit-a27df5d |
|
| https://github.com/Leko |
|
| https://github.com/gibfahn |
| test: replace function with arrow function | https://github.com/nodejs/node/commit/a27df5d45ee787595ff67b5341b4c0aadd7356f7 |
| a27df5d | https://github.com/nodejs/node/commit/a27df5d45ee787595ff67b5341b4c0aadd7356f7 |
| nodejs/code-and-learn#72 (comment) | https://github.com/nodejs/code-and-learn/issues/72#issuecomment-345667395 |
| #17345 | https://github.com/nodejs/node/pull/17345 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17345#ref-pullrequest-283423333 |
|
v8.9.4 proposal
#17772
| https://github.com/nodejs/node/pull/17772 |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17345#ref-commit-f5cd808 |
|
| https://github.com/Leko |
|
| https://github.com/gibfahn |
| test: replace function with arrow function | https://github.com/nodejs/node/commit/f5cd808212aae760d6189288667abbf6152f4e19 |
| f5cd808 | https://github.com/nodejs/node/commit/f5cd808212aae760d6189288667abbf6152f4e19 |
| nodejs/code-and-learn#72 (comment) | https://github.com/nodejs/code-and-learn/issues/72#issuecomment-345667395 |
| #17345 | https://github.com/nodejs/node/pull/17345 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17345#ref-pullrequest-283426801 |
|
v8.9.4 proposal
#17774
| https://github.com/nodejs/node/pull/17774 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17345 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/17345/files/fa4eb729a76ca381447b54e6aa9194bc0dfc795f |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/17345/files/79d1fbca201de498b2deb5488bd1d80610fbc103 |
|
| https://github.com/yosuke-furukawa |
|
yosuke-furukawa
| https://github.com/yosuke-furukawa |
|
| https://github.com/nodejs/node/pull/17345/files/fa4eb729a76ca381447b54e6aa9194bc0dfc795f |
|
| https://github.com/maclover7 |
|
maclover7
| https://github.com/maclover7 |
|
| https://github.com/nodejs/node/pull/17345/files/fa4eb729a76ca381447b54e6aa9194bc0dfc795f |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
domain
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adomain |
|
querystring
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aquerystring |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/17345 |
|
| https://github.com/Leko |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/yosuke-furukawa |
|
| https://github.com/addaleax |
|
| https://github.com/maclover7 |
|
| https://github.com/mscdex |
|
| https://github.com/gibfahn |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |