| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fe80cbe7-517d-927a-28ac-1b0813c5789a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AD4C:28B211:1B1355B:22C7595:6990F080 |
| html-safe-nonce | ff5a8fe7f0157eb9ee72c937e00c0c4c4ed3e11512cfd29ccb7d5f6842018cd1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDRDOjI4QjIxMToxQjEzNTVCOjIyQzc1OTU6Njk5MEYwODAiLCJ2aXNpdG9yX2lkIjoiMTg2MzMzNjAxNzk5MTM2NDczNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5775e163fbae3d3cb7ba00257ea22292230cdb17879c9860c460939c0a4951b4 |
| hovercard-subject-tag | pull_request:154727498 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17339/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/14597c540402efd9f8845ae5bbe97218fa573b856ee4e613750e956682dacfe5/nodejs/node/pull/17339 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/14597c540402efd9f8845ae5bbe97218fa573b856ee4e613750e956682dacfe5/nodejs/node/pull/17339 |
| og:image:alt | Refactored the test case test-http-upgrade-client to use countdown, as per issue #17169
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mithunsasidharan |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17339#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17339 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17339 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17339 |
| Reload | https://github.com/nodejs/node/pull/17339 |
| Reload | https://github.com/nodejs/node/pull/17339 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17339 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
705
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mithunsasidharan | https://github.com/mithunsasidharan |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/17339 |
| Commits1 (1) | https://github.com/nodejs/node/pull/17339/commits |
| Checks | https://github.com/nodejs/node/pull/17339/checks |
| Files changed | https://github.com/nodejs/node/pull/17339/files |
| update : test-http-upgrade-client to use countdown | https://github.com/nodejs/node/pull/17339#top |
| mithunsasidharan | https://github.com/mithunsasidharan |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17339#issue-276905022 |
| Please reload this page | https://github.com/nodejs/node/pull/17339 |
| #17169 | https://github.com/nodejs/node/issues/17169 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/17339 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17339#event-1358559452 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17339#event-1358559755 |
| https://github.com/daxlab |
| daxlab | https://github.com/daxlab |
|
Nov 27, 2017
| https://github.com/nodejs/node/pull/17339#pullrequestreview-79076491 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17339/files |
| test/parallel/test-http-upgrade-client.js | https://github.com/nodejs/node/pull/17339/files#diff-4ba1938e29a9df8632e87a1d24666aa577b113b40293e84b7cdf788b7e192589 |
| daxlab | https://github.com/daxlab |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17339#discussion_r153117635 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17339 |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17339#discussion_r153119436 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @daxlab | https://github.com/daxlab |
| Please reload this page | https://github.com/nodejs/node/pull/17339 |
|
| https://github.com/mithunsasidharan |
| Updated test-http-upgrade-client to use countdown | https://github.com/nodejs/node/pull/17339/commits/76f0039d472e236dfeac93c6951e0c5ec1986d29 |
| 76f0039 | https://github.com/nodejs/node/pull/17339/commits/76f0039d472e236dfeac93c6951e0c5ec1986d29 |
| https://github.com/daxlab |
| daxlab | https://github.com/daxlab |
|
Nov 27, 2017
| https://github.com/nodejs/node/pull/17339#pullrequestreview-79082356 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17339/files/76f0039d472e236dfeac93c6951e0c5ec1986d29 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17339#event-1359007521 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
|
Nov 27, 2017
| https://github.com/nodejs/node/pull/17339#pullrequestreview-79198849 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17339/files/76f0039d472e236dfeac93c6951e0c5ec1986d29 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| Nov 27, 2017 | https://github.com/nodejs/node/pull/17339#issuecomment-347212830 |
| https://ci.nodejs.org/job/node-test-pull-request/11749/ | https://ci.nodejs.org/job/node-test-pull-request/11749/ |
| Please reload this page | https://github.com/nodejs/node/pull/17339 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| Dec 3, 2017 | https://github.com/nodejs/node/pull/17339#issuecomment-348800437 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/17339 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 3, 2017 | https://github.com/nodejs/node/pull/17339#issuecomment-348800792 |
| Please reload this page | https://github.com/nodejs/node/pull/17339 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
Dec 3, 2017
| https://github.com/nodejs/node/pull/17339#pullrequestreview-80708209 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17339/files/76f0039d472e236dfeac93c6951e0c5ec1986d29 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| Dec 3, 2017 | https://github.com/nodejs/node/pull/17339#issuecomment-348807432 |
| Please reload this page | https://github.com/nodejs/node/pull/17339 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| Dec 3, 2017 | https://github.com/nodejs/node/pull/17339#event-1369467173 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| Dec 3, 2017 | https://github.com/nodejs/node/pull/17339#issuecomment-348807476 |
| eb19c6b | https://github.com/nodejs/node/commit/eb19c6b39f5494eef501494b701aeb592f59a2aa |
| Please reload this page | https://github.com/nodejs/node/pull/17339 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| Dec 3, 2017 | https://github.com/nodejs/node/pull/17339#event-1369467357 |
| https://github.com/mithunsasidharan |
| mithunsasidharan | https://github.com/mithunsasidharan |
| December 3, 2017 19:27 | https://github.com/nodejs/node/pull/17339#event-1369467494 |
| maclover7 | https://github.com/maclover7 |
|
Dec 3, 2017
| https://github.com/nodejs/node/pull/17339#ref-commit-eb19c6b |
|
| https://github.com/mithunsasidharan |
|
| https://github.com/maclover7 |
| test: update test-http-upgrade-client to use countdown | https://github.com/nodejs/node/commit/eb19c6b39f5494eef501494b701aeb592f59a2aa |
| eb19c6b | https://github.com/nodejs/node/commit/eb19c6b39f5494eef501494b701aeb592f59a2aa |
| #17339 | https://github.com/nodejs/node/pull/17339 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17339#ref-commit-0905ed9 |
|
| https://github.com/mithunsasidharan |
|
| https://github.com/MylesBorins |
| test: update test-http-upgrade-client to use countdown | https://github.com/nodejs/node/commit/0905ed994d2b7262e2aed7e0e70d9a6b020ecaa9 |
| 0905ed9 | https://github.com/nodejs/node/commit/0905ed994d2b7262e2aed7e0e70d9a6b020ecaa9 |
| #17339 | https://github.com/nodejs/node/pull/17339 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17339#ref-commit-c9a4f4f |
|
| https://github.com/mithunsasidharan |
|
| https://github.com/MylesBorins |
| test: update test-http-upgrade-client to use countdown | https://github.com/nodejs/node/commit/c9a4f4f8f16c30b62b4a1b11ef9a5efc095c3beb |
| c9a4f4f | https://github.com/nodejs/node/commit/c9a4f4f8f16c30b62b4a1b11ef9a5efc095c3beb |
| #17339 | https://github.com/nodejs/node/pull/17339 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17339#ref-pullrequest-281312309 |
|
v9.3.0 proposal
#17631
| https://github.com/nodejs/node/pull/17631 |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17339#ref-commit-e6c5255 |
|
| https://github.com/mithunsasidharan |
|
| https://github.com/gibfahn |
| test: update test-http-upgrade-client to use countdown | https://github.com/nodejs/node/commit/e6c5255798c179e98c3d1f102abf957ec8c16ee3 |
| e6c5255 | https://github.com/nodejs/node/commit/e6c5255798c179e98c3d1f102abf957ec8c16ee3 |
| #17339 | https://github.com/nodejs/node/pull/17339 |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17339#ref-commit-660e6de |
|
| https://github.com/mithunsasidharan |
|
| https://github.com/gibfahn |
| test: update test-http-upgrade-client to use countdown | https://github.com/nodejs/node/commit/660e6dea8993d0a10748dc4e8aa61465aa74d631 |
| 660e6de | https://github.com/nodejs/node/commit/660e6dea8993d0a10748dc4e8aa61465aa74d631 |
| #17339 | https://github.com/nodejs/node/pull/17339 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
| Dec 20, 2017 | https://github.com/nodejs/node/pull/17339#event-1395217647 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17339#ref-pullrequest-283423333 |
|
v8.9.4 proposal
#17772
| https://github.com/nodejs/node/pull/17772 |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17339#ref-commit-6723619 |
|
| https://github.com/mithunsasidharan |
|
| https://github.com/gibfahn |
| test: update test-http-upgrade-client to use countdown | https://github.com/nodejs/node/commit/6723619a0792e07ba1cffeb4c7e4bbc539d20b95 |
| 6723619 | https://github.com/nodejs/node/commit/6723619a0792e07ba1cffeb4c7e4bbc539d20b95 |
| #17339 | https://github.com/nodejs/node/pull/17339 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17339#ref-pullrequest-283426801 |
|
v8.9.4 proposal
#17774
| https://github.com/nodejs/node/pull/17774 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17339#ref-pullrequest-283432791 |
|
v6.12.3 proposal
#17776
| https://github.com/nodejs/node/pull/17776 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17339 |
|
| https://github.com/apapirovski |
|
apapirovski
| https://github.com/apapirovski |
|
| https://github.com/nodejs/node/pull/17339/files/76f0039d472e236dfeac93c6951e0c5ec1986d29 |
|
| https://github.com/maclover7 |
|
maclover7
| https://github.com/maclover7 |
|
| https://github.com/nodejs/node/pull/17339/files/76f0039d472e236dfeac93c6951e0c5ec1986d29 |
|
| https://github.com/daxlab |
|
daxlab
| https://github.com/daxlab |
|
| https://github.com/nodejs/node/pull/17339/files/76f0039d472e236dfeac93c6951e0c5ec1986d29 |
|
| https://github.com/maclover7 |
|
maclover7
| https://github.com/maclover7 |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/17339 |
|
| https://github.com/mithunsasidharan |
|
| https://github.com/maclover7 |
|
| https://github.com/apapirovski |
|
| https://github.com/daxlab |
|
| https://github.com/mscdex |
|
| https://github.com/gibfahn |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |