René's URL Explorer Experiment


Title: test: fix isNAN->Number.isNAN by ykyz · Pull Request #17309 · nodejs/node · GitHub

Open Graph Title: test: fix isNAN->Number.isNAN by ykyz · Pull Request #17309 · nodejs/node

X Title: test: fix isNAN->Number.isNAN by ykyz · Pull Request #17309 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR is a part of Code And Learn in nodefest nodejs/code-and-learn#72 (comment) Fix isNAN to Number.isNAN Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchm...

X Description: This PR is a part of Code And Learn in nodefest nodejs/code-and-learn#72 (comment) Fix isNAN to Number.isNAN Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchm...

Opengraph URL: https://github.com/nodejs/node/pull/17309

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7dc662e4-3b11-ef33-848b-ec4315f4c50f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id828C:B5D65:9D2D2D:C99BCE:6990F0AC
html-safe-nonce51e81203b9f684aae584b14e48ce27012ee3c97cb354e767e6c2ef60f5f3778e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjhDOkI1RDY1OjlEMkQyRDpDOTlCQ0U6Njk5MEYwQUMiLCJ2aXNpdG9yX2lkIjoiMTY2OTIwOTgwMTIyNDE1NTMwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc1a7c79b3ac5eeb6a3651a09b02e006b53fffa571c16268f4a61d88002095f1d
hovercard-subject-tagpull_request:154670071
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17309/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/57f5751cbb3039aac000a86b5224e559ab8fc957b961cb068d4bdc1f2ebb582c/nodejs/node/pull/17309
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/57f5751cbb3039aac000a86b5224e559ab8fc957b961cb068d4bdc1f2ebb582c/nodejs/node/pull/17309
og:image:altThis PR is a part of Code And Learn in nodefest nodejs/code-and-learn#72 (comment) Fix isNAN to Number.isNAN Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchm...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameykyz
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17309#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17309
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17309
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17309
Reloadhttps://github.com/nodejs/node/pull/17309
Reloadhttps://github.com/nodejs/node/pull/17309
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17309
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 705 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ykyzhttps://github.com/ykyz
nodejs:masterhttps://github.com/nodejs/node/tree/master
ykyz:fix_testwireddoublehttps://github.com/ykyz/node/tree/fix_testwireddouble
Conversationhttps://github.com/nodejs/node/pull/17309
Commits1 (1)https://github.com/nodejs/node/pull/17309/commits
Checkshttps://github.com/nodejs/node/pull/17309/checks
Files changedhttps://github.com/nodejs/node/pull/17309/files
test: fix isNAN->Number.isNANhttps://github.com/nodejs/node/pull/17309#top
ykyzhttps://github.com/ykyz
nodejs:masterhttps://github.com/nodejs/node/tree/master
ykyz:fix_testwireddoublehttps://github.com/ykyz/node/tree/fix_testwireddouble
https://github.com/ykyz
ykyzhttps://github.com/ykyz
Nov 26, 2017https://github.com/nodejs/node/pull/17309#issue-276809320
nodejs/code-and-learn#72 (comment)https://github.com/nodejs/code-and-learn/issues/72#issuecomment-346990628
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17309
https://github.com/ykyz
test: fix isNAN->Number.isNANhttps://github.com/nodejs/node/pull/17309/commits/4b6cde5aba85d787a63ab7f7042df15db01dba47
4b6cde5https://github.com/nodejs/node/pull/17309/commits/4b6cde5aba85d787a63ab7f7042df15db01dba47
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Nov 26, 2017https://github.com/nodejs/node/pull/17309#event-1358076102
https://github.com/yosuke-furukawa
yosuke-furukawahttps://github.com/yosuke-furukawa
Nov 26, 2017 https://github.com/nodejs/node/pull/17309#pullrequestreview-79020350
View reviewed changes https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Nov 26, 2017https://github.com/nodejs/node/pull/17309#issuecomment-346993699
https://ci.nodejs.org/job/node-test-pull-request/11716/https://ci.nodejs.org/job/node-test-pull-request/11716/
Please reload this pagehttps://github.com/nodejs/node/pull/17309
https://github.com/lpinca
lpincahttps://github.com/lpinca
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Nov 26, 2017https://github.com/nodejs/node/pull/17309#event-1358079255
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 26, 2017 https://github.com/nodejs/node/pull/17309#pullrequestreview-79020683
View reviewed changes https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
https://github.com/targos
targoshttps://github.com/targos
Nov 26, 2017 https://github.com/nodejs/node/pull/17309#pullrequestreview-79021500
View reviewed changes https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Nov 26, 2017https://github.com/nodejs/node/pull/17309#event-1358091352
https://github.com/watilde
watildehttps://github.com/watilde
Nov 26, 2017 https://github.com/nodejs/node/pull/17309#pullrequestreview-79022262
View reviewed changes https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 26, 2017 https://github.com/nodejs/node/pull/17309#pullrequestreview-79024309
View reviewed changes https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
https://github.com/maclover7
maclover7https://github.com/maclover7
Nov 26, 2017 https://github.com/nodejs/node/pull/17309#pullrequestreview-79029249
View reviewed changes https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
https://github.com/mscdex
mscdexhttps://github.com/mscdex
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
Nov 26, 2017https://github.com/nodejs/node/pull/17309#event-1358191472
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 26, 2017 https://github.com/nodejs/node/pull/17309#pullrequestreview-79033345
View reviewed changes https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/17309#pullrequestreview-79033345
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17309
jasnellhttps://github.com/jasnell
Nov 26, 2017 https://github.com/nodejs/node/pull/17309#ref-commit-bb44626
https://github.com/ykyz
https://github.com/jasnell
test: fix isNAN->Number.isNANhttps://github.com/nodejs/node/commit/bb4462681cd2812d718897ca7ac8b8d48bca68f0
bb44626https://github.com/nodejs/node/commit/bb4462681cd2812d718897ca7ac8b8d48bca68f0
#17309https://github.com/nodejs/node/pull/17309
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 26, 2017https://github.com/nodejs/node/pull/17309#issuecomment-347025190
bb44626https://github.com/nodejs/node/commit/bb4462681cd2812d718897ca7ac8b8d48bca68f0
Please reload this pagehttps://github.com/nodejs/node/pull/17309
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 26, 2017https://github.com/nodejs/node/pull/17309#event-1358243861
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17309#ref-commit-2cfa6b4
https://github.com/ykyz
https://github.com/MylesBorins
test: fix isNAN->Number.isNANhttps://github.com/nodejs/node/commit/2cfa6b4fc83603f857e0d64a25fb8c28c0a57cec
2cfa6b4https://github.com/nodejs/node/commit/2cfa6b4fc83603f857e0d64a25fb8c28c0a57cec
#17309https://github.com/nodejs/node/pull/17309
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17309#ref-commit-1adccc6
https://github.com/ykyz
https://github.com/MylesBorins
test: fix isNAN->Number.isNANhttps://github.com/nodejs/node/commit/1adccc6a6a1fdd01674e32f77d07a59e0d9fd7a0
1adccc6https://github.com/nodejs/node/commit/1adccc6a6a1fdd01674e32f77d07a59e0d9fd7a0
#17309https://github.com/nodejs/node/pull/17309
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17309#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
gibfahnhttps://github.com/gibfahn
Dec 19, 2017 https://github.com/nodejs/node/pull/17309#ref-commit-5ac5663
https://github.com/ykyz
https://github.com/gibfahn
test: fix isNAN->Number.isNANhttps://github.com/nodejs/node/commit/5ac5663b3df725f1a97ff2447a5a2af212f9774d
5ac5663https://github.com/nodejs/node/commit/5ac5663b3df725f1a97ff2447a5a2af212f9774d
#17309https://github.com/nodejs/node/pull/17309
gibfahnhttps://github.com/gibfahn
Dec 19, 2017 https://github.com/nodejs/node/pull/17309#ref-commit-35cc1b3
https://github.com/ykyz
https://github.com/gibfahn
test: fix isNAN->Number.isNANhttps://github.com/nodejs/node/commit/35cc1b3fcc63d55c039856348aa52b5269055309
35cc1b3https://github.com/nodejs/node/commit/35cc1b3fcc63d55c039856348aa52b5269055309
#17309https://github.com/nodejs/node/pull/17309
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
Dec 19, 2017https://github.com/nodejs/node/pull/17309#event-1395073316
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17309#ref-pullrequest-283423333
v8.9.4 proposal #17772 https://github.com/nodejs/node/pull/17772
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17309#ref-commit-c1efba8
https://github.com/ykyz
https://github.com/gibfahn
test: fix isNAN->Number.isNANhttps://github.com/nodejs/node/commit/c1efba873718acf1e540eb26414acc07279a88d8
c1efba8https://github.com/nodejs/node/commit/c1efba873718acf1e540eb26414acc07279a88d8
#17309https://github.com/nodejs/node/pull/17309
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17309#ref-pullrequest-283426801
v8.9.4 proposal #17774 https://github.com/nodejs/node/pull/17774
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 20, 2017 https://github.com/nodejs/node/pull/17309#ref-pullrequest-283432791
v6.12.3 proposal #17776 https://github.com/nodejs/node/pull/17776
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17309
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
https://github.com/watilde
watilde https://github.com/watilde
https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
https://github.com/yosuke-furukawa
yosuke-furukawa https://github.com/yosuke-furukawa
https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
https://github.com/maclover7
maclover7 https://github.com/maclover7
https://github.com/nodejs/node/pull/17309/files/4b6cde5aba85d787a63ab7f7042df15db01dba47
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/17309
https://github.com/ykyz
https://github.com/vsemozhetbyt
https://github.com/jasnell
https://github.com/yosuke-furukawa
https://github.com/lpinca
https://github.com/watilde
https://github.com/targos
https://github.com/maclover7
https://github.com/gireeshpunathil
https://github.com/mscdex
https://github.com/joyeecheung
https://github.com/gibfahn
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.