| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2adab0ab-be5d-449e-bf54-2b976f11805c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C32E:13DA52:1AAE6B2:21ACD06:69917BBF |
| html-safe-nonce | ce292a4e098104d1065a9d87eedac3df21a4e982fc7d10dbfbf943cf12a2a589 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzJFOjEzREE1MjoxQUFFNkIyOjIxQUNEMDY6Njk5MTdCQkYiLCJ2aXNpdG9yX2lkIjoiMjY2MDkxMTc4ODQ1NTk4NDA2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 55c83ecfcad0b34a078836588ff3527eb44f820a3a5962ec372c776ac06c5692 |
| hovercard-subject-tag | pull_request:154096030 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17233/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1f52c7be55f101174d0da6bfaf0decfedaa9870773dade4015e71d50b68668a7/nodejs/node/pull/17233 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1f52c7be55f101174d0da6bfaf0decfedaa9870773dade4015e71d50b68668a7/nodejs/node/pull/17233 |
| og:image:alt | add common.crashOnUnhandledRejection() to test/parallel/test-repl-load-multiline.js
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines
Aff... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | shiningjason |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17233#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17233 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17233 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17233 |
| Reload | https://github.com/nodejs/node/pull/17233 |
| Reload | https://github.com/nodejs/node/pull/17233 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17233 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| shiningjason | https://github.com/shiningjason |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/17233 |
| Commits2 (2) | https://github.com/nodejs/node/pull/17233/commits |
| Checks | https://github.com/nodejs/node/pull/17233/checks |
| Files changed | https://github.com/nodejs/node/pull/17233/files |
| test: use common.crashOnUnhandledRejection | https://github.com/nodejs/node/pull/17233#top |
| shiningjason | https://github.com/shiningjason |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/shiningjason |
| shiningjason | https://github.com/shiningjason |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17233#issue-275990494 |
| Please reload this page | https://github.com/nodejs/node/pull/17233 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/17233 |
| test: use common.crashOnUnhandledRejection | https://github.com/nodejs/node/pull/17233/commits/84bbd5b767395869d16d69f6ddd9500ca392cae8 |
| 84bbd5b | https://github.com/nodejs/node/pull/17233/commits/84bbd5b767395869d16d69f6ddd9500ca392cae8 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17233#event-1353613355 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 22, 2017
| https://github.com/nodejs/node/pull/17233#pullrequestreview-78383183 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17233/files/84bbd5b767395869d16d69f6ddd9500ca392cae8 |
| test/parallel/test-repl-load-multiline.js | https://github.com/nodejs/node/pull/17233/files/84bbd5b767395869d16d69f6ddd9500ca392cae8#diff-7cda228653ecd40e9b2d45ece9ee4825995618e7d0ad17bad82d0e1b512ad1e6 |
| MylesBorins | https://github.com/MylesBorins |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17233#discussion_r152511202 |
| Please reload this page | https://github.com/nodejs/node/pull/17233 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17233 |
| shiningjason | https://github.com/shiningjason |
| Nov 23, 2017 | https://github.com/nodejs/node/pull/17233#discussion_r152713152 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/17233 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17233#issuecomment-346297459 |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/17233 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17233#event-1353704783 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
repl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17233#event-1354016429 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 22, 2017
| https://github.com/nodejs/node/pull/17233#pullrequestreview-78564640 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17233/files/84bbd5b767395869d16d69f6ddd9500ca392cae8 |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/17233#pullrequestreview-78564640 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/17233 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17233#issuecomment-346470415 |
| https://ci.nodejs.org/job/node-test-pull-request/11647/ | https://ci.nodejs.org/job/node-test-pull-request/11647/ |
| Please reload this page | https://github.com/nodejs/node/pull/17233 |
| fix: move common.crashOnUnhandledRejection to below the require state… | https://github.com/nodejs/node/pull/17233/commits/aa3b9f8820faed56f3cb44bbfe146dd8e5c86cfc |
| aa3b9f8 | https://github.com/nodejs/node/pull/17233/commits/aa3b9f8820faed56f3cb44bbfe146dd8e5c86cfc |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 23, 2017
| https://github.com/nodejs/node/pull/17233#pullrequestreview-78618691 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17233/files/aa3b9f8820faed56f3cb44bbfe146dd8e5c86cfc |
| MylesBorins | https://github.com/MylesBorins |
| https://github.com/nodejs/node/pull/17233#pullrequestreview-78618691 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17233 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 23, 2017 | https://github.com/nodejs/node/pull/17233#issuecomment-346520326 |
| 317f596 | https://github.com/nodejs/node/commit/317f596bab62e4c596e73c10c2d8c007b562a904 |
| Please reload this page | https://github.com/nodejs/node/pull/17233 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 23, 2017 | https://github.com/nodejs/node/pull/17233#event-1355135446 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 23, 2017
| https://github.com/nodejs/node/pull/17233#ref-commit-317f596 |
|
| https://github.com/MylesBorins |
| test: use common.crashOnUnhandledRejection | https://github.com/nodejs/node/commit/317f596bab62e4c596e73c10c2d8c007b562a904 |
| 317f596 | https://github.com/nodejs/node/commit/317f596bab62e4c596e73c10c2d8c007b562a904 |
| #17233 | https://github.com/nodejs/node/pull/17233 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17233#ref-commit-9e8ea6d |
|
| https://github.com/MylesBorins |
| test: use common.crashOnUnhandledRejection | https://github.com/nodejs/node/commit/9e8ea6d21d417ae3af2757c475d625e459c8ef0b |
| 9e8ea6d | https://github.com/nodejs/node/commit/9e8ea6d21d417ae3af2757c475d625e459c8ef0b |
| #17233 | https://github.com/nodejs/node/pull/17233 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17233#ref-commit-cb33487 |
|
| https://github.com/MylesBorins |
| test: use common.crashOnUnhandledRejection | https://github.com/nodejs/node/commit/cb3348715b7f6d82e2b19b3ad3a854f05692c105 |
| cb33487 | https://github.com/nodejs/node/commit/cb3348715b7f6d82e2b19b3ad3a854f05692c105 |
| #17233 | https://github.com/nodejs/node/pull/17233 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17233#ref-pullrequest-281312309 |
|
v9.3.0 proposal
#17631
| https://github.com/nodejs/node/pull/17631 |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/17233#ref-commit-fa6867d |
|
| https://github.com/gibfahn |
| test: use common.crashOnUnhandledRejection | https://github.com/nodejs/node/commit/fa6867de856c71b534d7220180aa618bcfd97f43 |
| fa6867d | https://github.com/nodejs/node/commit/fa6867de856c71b534d7220180aa618bcfd97f43 |
| #17233 | https://github.com/nodejs/node/pull/17233 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
land-on-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/17233#event-1394992917 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/17233#event-1395013443 |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/17233#ref-commit-797e33b |
|
| https://github.com/gibfahn |
| test: use common.crashOnUnhandledRejection | https://github.com/nodejs/node/commit/797e33b602f93bc9e6e3b0dfce7edda72ca85e84 |
| 797e33b | https://github.com/nodejs/node/commit/797e33b602f93bc9e6e3b0dfce7edda72ca85e84 |
| #17233 | https://github.com/nodejs/node/pull/17233 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17233#ref-pullrequest-283423333 |
|
v8.9.4 proposal
#17772
| https://github.com/nodejs/node/pull/17772 |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17233#ref-commit-3255686 |
|
| https://github.com/gibfahn |
| test: use common.crashOnUnhandledRejection | https://github.com/nodejs/node/commit/3255686722bd26c82aeff1841d7fa87c559cd350 |
| 3255686 | https://github.com/nodejs/node/commit/3255686722bd26c82aeff1841d7fa87c559cd350 |
| #17233 | https://github.com/nodejs/node/pull/17233 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17233#ref-pullrequest-283426801 |
|
v8.9.4 proposal
#17774
| https://github.com/nodejs/node/pull/17774 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17233#ref-pullrequest-283432791 |
|
v6.12.3 proposal
#17776
| https://github.com/nodejs/node/pull/17776 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17233 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/17233/files/84bbd5b767395869d16d69f6ddd9500ca392cae8 |
|
| https://github.com/MylesBorins |
|
MylesBorins
| https://github.com/MylesBorins |
|
| https://github.com/nodejs/node/pull/17233/files/aa3b9f8820faed56f3cb44bbfe146dd8e5c86cfc |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
repl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/17233 |
|
| https://github.com/shiningjason |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com/mscdex |
|
| https://github.com/gibfahn |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |