| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4f8cf778-10fa-7955-a6f9-744dee2bf9ed |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A36A:14AA66:9CD3FF:C812EF:6990F07F |
| html-safe-nonce | 66529f74d70d4eddc97fa68ef5ff5576fbdb583d52141958cce2a13b30dc9f7c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzZBOjE0QUE2Njo5Q0QzRkY6QzgxMkVGOjY5OTBGMDdGIiwidmlzaXRvcl9pZCI6IjY4MzcxODA3OTU1NzgyODIxMTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9e33136391a9b4c857899fe718d3cc56b4be7ea7080cc5a7568ab0cadb05d174 |
| hovercard-subject-tag | pull_request:154094573 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17228/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/41bd654d136eb32d2d7e98a9df69e44c7dd28fdd770f44458d7fa316597aec2e/nodejs/node/pull/17228 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/41bd654d136eb32d2d7e98a9df69e44c7dd28fdd770f44458d7fa316597aec2e/nodejs/node/pull/17228 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s) |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | LarryLuTW |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17228#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17228 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17228 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17228 |
| Reload | https://github.com/nodejs/node/pull/17228 |
| Reload | https://github.com/nodejs/node/pull/17228 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17228 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
705
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| LarryLuTW | https://github.com/LarryLuTW |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/17228 |
| Commits1 (1) | https://github.com/nodejs/node/pull/17228/commits |
| Checks | https://github.com/nodejs/node/pull/17228/checks |
| Files changed | https://github.com/nodejs/node/pull/17228/files |
| Add test on unhandled rejection | https://github.com/nodejs/node/pull/17228#top |
| LarryLuTW | https://github.com/LarryLuTW |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/LarryLuTW |
| LarryLuTW | https://github.com/LarryLuTW |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17228#issue-275988481 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/17228 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17228#event-1353601514 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17228#issuecomment-346293654 |
| Please reload this page | https://github.com/nodejs/node/pull/17228 |
|
| https://github.com/LarryLuTW |
| test: add test on unhandled rejection | https://github.com/nodejs/node/pull/17228/commits/6e696bb66eaac61085bb741a28debc0d3acb7c0b |
| 6e696bb | https://github.com/nodejs/node/pull/17228/commits/6e696bb66eaac61085bb741a28debc0d3acb7c0b |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 22, 2017
| https://github.com/nodejs/node/pull/17228#pullrequestreview-78381493 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17228/files/6e696bb66eaac61085bb741a28debc0d3acb7c0b |
| MylesBorins | https://github.com/MylesBorins |
| https://github.com/nodejs/node/pull/17228#pullrequestreview-78381493 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/17228 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17228#issuecomment-346294917 |
| https://ci.nodejs.org/job/node-test-pull-request/11615/ | https://ci.nodejs.org/job/node-test-pull-request/11615/ |
| Please reload this page | https://github.com/nodejs/node/pull/17228 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 22, 2017
| https://github.com/nodejs/node/pull/17228#pullrequestreview-78384626 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17228/files/6e696bb66eaac61085bb741a28debc0d3acb7c0b |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17228#event-1353706731 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
async_hooks
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17228#event-1354017205 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 22, 2017
| https://github.com/nodejs/node/pull/17228#pullrequestreview-78466486 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17228/files/6e696bb66eaac61085bb741a28debc0d3acb7c0b |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 22, 2017
| https://github.com/nodejs/node/pull/17228#pullrequestreview-78468534 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17228/files/6e696bb66eaac61085bb741a28debc0d3acb7c0b |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17228#issuecomment-346409165 |
| Please reload this page | https://github.com/nodejs/node/pull/17228 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17228#issuecomment-346466319 |
| Please reload this page | https://github.com/nodejs/node/pull/17228 |
| jasnell | https://github.com/jasnell |
|
Nov 22, 2017
| https://github.com/nodejs/node/pull/17228#ref-commit-18cf096 |
|
| https://github.com/LarryLuTW |
|
| https://github.com/jasnell |
| test: add test on unhandled rejection | https://github.com/nodejs/node/commit/18cf0960eab834ed3a4ddef22a7e8b6dcecfc058 |
| 18cf096 | https://github.com/nodejs/node/commit/18cf0960eab834ed3a4ddef22a7e8b6dcecfc058 |
| #17228 | https://github.com/nodejs/node/pull/17228 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17228#issuecomment-346469183 |
| Please reload this page | https://github.com/nodejs/node/pull/17228 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/17228#event-1354840773 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17228#ref-commit-176229f |
|
| https://github.com/LarryLuTW |
|
| https://github.com/MylesBorins |
| test: add test on unhandled rejection | https://github.com/nodejs/node/commit/176229f32daf41c41dd06427770b7f9fc50711e2 |
| 176229f | https://github.com/nodejs/node/commit/176229f32daf41c41dd06427770b7f9fc50711e2 |
| #17228 | https://github.com/nodejs/node/pull/17228 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17228#ref-commit-2d2e780 |
|
| https://github.com/LarryLuTW |
|
| https://github.com/MylesBorins |
| test: add test on unhandled rejection | https://github.com/nodejs/node/commit/2d2e7803b23d2c523626cb8d6a04d843fda09de4 |
| 2d2e780 | https://github.com/nodejs/node/commit/2d2e7803b23d2c523626cb8d6a04d843fda09de4 |
| #17228 | https://github.com/nodejs/node/pull/17228 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17228#ref-pullrequest-281312309 |
|
v9.3.0 proposal
#17631
| https://github.com/nodejs/node/pull/17631 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/17228#event-1394982475 |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/17228#ref-commit-5125e6c |
|
| https://github.com/LarryLuTW |
|
| https://github.com/gibfahn |
| test: add test on unhandled rejection | https://github.com/nodejs/node/commit/5125e6cee513ff50d64fd944ca427866f4dd0590 |
| 5125e6c | https://github.com/nodejs/node/commit/5125e6cee513ff50d64fd944ca427866f4dd0590 |
| #17228 | https://github.com/nodejs/node/pull/17228 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
land-on-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/17228#event-1394983286 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17228#ref-pullrequest-283423333 |
|
v8.9.4 proposal
#17772
| https://github.com/nodejs/node/pull/17772 |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17228#ref-commit-b4726fa |
|
| https://github.com/LarryLuTW |
|
| https://github.com/gibfahn |
| test: add test on unhandled rejection | https://github.com/nodejs/node/commit/b4726fabb6627dae64ee6b1e24cd772c46c53d4f |
| b4726fa | https://github.com/nodejs/node/commit/b4726fabb6627dae64ee6b1e24cd772c46c53d4f |
| #17228 | https://github.com/nodejs/node/pull/17228 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17228#ref-pullrequest-283426801 |
|
v8.9.4 proposal
#17774
| https://github.com/nodejs/node/pull/17774 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17228 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/17228/files/6e696bb66eaac61085bb741a28debc0d3acb7c0b |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/17228/files/6e696bb66eaac61085bb741a28debc0d3acb7c0b |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/17228/files/6e696bb66eaac61085bb741a28debc0d3acb7c0b |
|
| https://github.com/MylesBorins |
|
MylesBorins
| https://github.com/MylesBorins |
|
| https://github.com/nodejs/node/pull/17228/files/6e696bb66eaac61085bb741a28debc0d3acb7c0b |
|
async_hooks
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/17228 |
|
| https://github.com/LarryLuTW |
|
| https://github.com/MylesBorins |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/mscdex |
|
| https://github.com/gibfahn |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |