| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f05b8104-d139-9577-92df-c8aab3f9547d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C9D4:16C3D3:334EEAF:4839E19:6A4F7C95 |
| html-safe-nonce | caaf4cd3b12b55e10a7a66273616444e3b7a9b36d30bbc08756c796ed9ae1745 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUQ0OjE2QzNEMzozMzRFRUFGOjQ4MzlFMTk6NkE0RjdDOTUiLCJ2aXNpdG9yX2lkIjoiOTAwMDQ2NTA1Mjc0NzEzNjE0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5e9ef2e9ba2327b294f4d6f62a9cbf4af5def4c1aca9c4e8cc35f2946734662c |
| hovercard-subject-tag | pull_request:35590073 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1721/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/091ecd0bca5b4bb50860c468e875f43557399aa360a056810b04650949f9412b/nodejs/node/pull/1721 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/091ecd0bca5b4bb50860c468e875f43557399aa360a056810b04650949f9412b/nodejs/node/pull/1721 |
| og:image:alt | This enables eslint for the test subdirectory. Noteable changes:
Put all tests in strict mode except a handful of exceptions
debugger and unreachable code are allowed in tests
Enabled forOf in glo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | silverwind |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/1721#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1721 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1721 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/1721 |
| Reload | https://github.com/nodejs/node/pull/1721 |
| Reload | https://github.com/nodejs/node/pull/1721 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| silverwind | https://github.com/silverwind |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| silverwind:test-lint | https://github.com/silverwind/node/tree/test-lint |
| Conversation | https://github.com/nodejs/node/pull/1721 |
| Commits2 (2) | https://github.com/nodejs/node/pull/1721/commits |
| Checks | https://github.com/nodejs/node/pull/1721/checks |
| Files changed | https://github.com/nodejs/node/pull/1721/files |
| test: enable linting for tests and fix tests | https://github.com/nodejs/node/pull/1721#top |
| silverwind | https://github.com/silverwind |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| silverwind:test-lint | https://github.com/silverwind/node/tree/test-lint |
|
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 17, 2015 | https://github.com/nodejs/node/pull/1721#issue-77351068 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| May 17, 2015 | https://github.com/nodejs/node/pull/1721#event-306828943 |
| https://github.com/rlidwka |
| rlidwka | https://github.com/rlidwka |
| May 17, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-102824316 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 17, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-102824933 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| force-pushed | https://github.com/nodejs/node/compare/0daf3928b31931ccf081089d754368058a7743b7..234eb90855a195873af5d7ea8824efd5fea4ce67 |
| 0daf392 | https://github.com/nodejs/node/commit/0daf3928b31931ccf081089d754368058a7743b7 |
| 234eb90 | https://github.com/nodejs/node/commit/234eb90855a195873af5d7ea8824efd5fea4ce67 |
|
Compare
| https://github.com/nodejs/node/compare/0daf3928b31931ccf081089d754368058a7743b7..234eb90855a195873af5d7ea8824efd5fea4ce67 |
| May 17, 2015 17:37 | https://github.com/nodejs/node/pull/1721#event-306832857 |
| https://github.com/rlidwka |
| rlidwka | https://github.com/rlidwka |
| May 17, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-102843291 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 17, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-102849647 |
| 1 | https://github.com/nodejs/io.js/blob/7d90c90aaf0c59d102692ca119f7f7560a9eb8d9/test/parallel/test-domain.js#L169-L170 |
| 2 | https://github.com/nodejs/io.js/blob/7d90c90aaf0c59d102692ca119f7f7560a9eb8d9/test/parallel/test-file-write-stream.js#L26-L27 |
| 3 | https://github.com/nodejs/io.js/blob/7d90c90aaf0c59d102692ca119f7f7560a9eb8d9/test/message/throw_custom_error.js#L7-L9 |
| 4 | https://github.com/nodejs/io.js/blob/7d90c90aaf0c59d102692ca119f7f7560a9eb8d9/test/parallel/test-listen-fd-detached-inherit.js#L66-L67 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/brendanashworth |
| brendanashworth | https://github.com/brendanashworth |
| May 17, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-102855990 |
| joyent/node#25280 | https://github.com/joyent/node/pull/25280 |
| joyent/node#25288 | https://github.com/joyent/node/pull/25288 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
May 17, 2015
| https://github.com/nodejs/node/pull/1721#ref-issue-75492938 |
|
test: Fix make jslint to include test scripts too.
nodejs/node-v0.x-archive#25280
| https://github.com/nodejs/node-v0.x-archive/issues/25280 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| May 17, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-102869409 |
| @silverwind | https://github.com/silverwind |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 18, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-102881581 |
| here | http://eslint.org/docs/rules/space-before-function-paren |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 18, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-102932308 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/yosuke-furukawa |
| yosuke-furukawa | https://github.com/yosuke-furukawa |
| May 18, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-102943361 |
| @silverwind | https://github.com/silverwind |
| http://eslint.org/docs/user-guide/configuring#extending-configuration-files | http://eslint.org/docs/user-guide/configuring#extending-configuration-files |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 18, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-102943667 |
| @yosuke-furukawa | https://github.com/yosuke-furukawa |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/yosuke-furukawa |
| yosuke-furukawa | https://github.com/yosuke-furukawa |
| May 18, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-102952309 |
| @silverwind | https://github.com/silverwind |
| v0.21 feature | http://eslint.org/blog/2015/05/eslint-0.21.0-released/ |
| v0.20 | https://github.com/nodejs/io.js/blob/master/tools/eslint/package.json#L3 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 18, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-102953081 |
| configuration cascading | http://eslint.org/docs/user-guide/configuring#configuration-cascading-and-hierarchy |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/yosuke-furukawa |
| yosuke-furukawa | https://github.com/yosuke-furukawa |
| May 18, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-102974910 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/yosuke-furukawa |
| yosuke-furukawa | https://github.com/yosuke-furukawa |
| May 18, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103162348 |
| @silverwind | https://github.com/silverwind |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 18, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103166924 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/yosuke-furukawa |
| yosuke-furukawa | https://github.com/yosuke-furukawa |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103291836 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103294690 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/yosuke-furukawa |
| yosuke-furukawa | https://github.com/yosuke-furukawa |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103313922 |
| @silverwind | https://github.com/silverwind |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103334930 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/yosuke-furukawa |
| yosuke-furukawa | https://github.com/yosuke-furukawa |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103347685 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/rlidwka |
| rlidwka | https://github.com/rlidwka |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103430233 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103432505 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103433472 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
|
| https://github.com/silverwind |
| test: enable linting for tests | https://github.com/nodejs/node/pull/1721/commits/5a8d7ca1c341e3f28c71406f12ac9f11284585dc |
| 5a8d7ca | https://github.com/nodejs/node/pull/1721/commits/5a8d7ca1c341e3f28c71406f12ac9f11284585dc |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| force-pushed | https://github.com/nodejs/node/compare/68a270e298c5364ab7f731188f082f89b5207a97..5a8d7ca1c341e3f28c71406f12ac9f11284585dc |
| 68a270e | https://github.com/nodejs/node/commit/68a270e298c5364ab7f731188f082f89b5207a97 |
| 5a8d7ca | https://github.com/nodejs/node/commit/5a8d7ca1c341e3f28c71406f12ac9f11284585dc |
|
Compare
| https://github.com/nodejs/node/compare/68a270e298c5364ab7f731188f082f89b5207a97..5a8d7ca1c341e3f28c71406f12ac9f11284585dc |
| May 19, 2015 11:07 | https://github.com/nodejs/node/pull/1721#event-308326666 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103443682 |
| https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/686/ | https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/686/ |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103471569 |
| #1707 | https://github.com/nodejs/node/pull/1707 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103478014 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103478658 |
| https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/688/ | https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/688/ |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103482062 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103519298 |
| @rvagg | https://github.com/rvagg |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
May 19, 2015
| https://github.com/nodejs/node/pull/1721#ref-pullrequest-70706069 |
|
net: persist net.Socket options before connect
#1518
| https://github.com/nodejs/node/pull/1518 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103616963 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103619969 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
|
| https://github.com/silverwind |
| Revert and blacklist test-fs-non-number-arguments-throw | https://github.com/nodejs/node/pull/1721/commits/bb1db5112f8136c4014668c35d3a805a594f3ae5 |
| bb1db51 | https://github.com/nodejs/node/pull/1721/commits/bb1db5112f8136c4014668c35d3a805a594f3ae5 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103621837 |
| https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/692/ | https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/692/ |
| https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/693/ | https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/693/ |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103638945 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| silverwind | https://github.com/silverwind |
|
May 19, 2015
| https://github.com/nodejs/node/pull/1721#ref-commit-f29762f |
|
| https://github.com/silverwind |
| test: enable linting for tests | https://github.com/nodejs/node/commit/f29762f4dd5811464684f820286f1c90a694bdff |
| f29762f | https://github.com/nodejs/node/commit/f29762f4dd5811464684f820286f1c90a694bdff |
| #1721 | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
May 19, 2015
| https://github.com/nodejs/node/pull/1721#ref-issue-78220315 |
|
test: fs.createReadStream weirdness on Windows CI
#1737
| https://github.com/nodejs/node/issues/1737 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#issuecomment-103644193 |
| f29762f | https://github.com/nodejs/node/commit/f29762f4dd5811464684f820286f1c90a694bdff |
| #1737 | https://github.com/nodejs/node/issues/1737 |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| May 19, 2015 | https://github.com/nodejs/node/pull/1721#event-308833925 |
| Fishrock123 | https://github.com/Fishrock123 |
|
May 21, 2015
| https://github.com/nodejs/node/pull/1721#ref-commit-9f8a3a4 |
|
| https://github.com/silverwind |
|
| https://github.com/Fishrock123 |
| test: enable linting for tests | https://github.com/Fishrock123/node/commit/9f8a3a4e456fb21a10212081dc8744a808af5459 |
| 9f8a3a4 | https://github.com/Fishrock123/node/commit/9f8a3a4e456fb21a10212081dc8744a808af5459 |
| nodejs#1721 | https://github.com/nodejs/node/pull/1721 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
May 23, 2015
| https://github.com/nodejs/node/pull/1721#ref-pullrequest-79683576 |
|
Release proposal v2.1.0
#1777
| https://github.com/nodejs/node/pull/1777 |
| andrewdeandrade | https://github.com/andrewdeandrade |
|
Jun 3, 2015
| https://github.com/nodejs/node/pull/1721#ref-commit-0e4c0c7 |
|
| https://github.com/silverwind |
|
| https://github.com/andrewdeandrade |
| test: enable linting for tests | https://github.com/andrewdeandrade/node/commit/0e4c0c70f19b0566f7412b88f0d3713d61b5371a |
| 0e4c0c7 | https://github.com/andrewdeandrade/node/commit/0e4c0c70f19b0566f7412b88f0d3713d61b5371a |
| nodejs/node#1721 | https://github.com/nodejs/node/pull/1721 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Jun 28, 2015
| https://github.com/nodejs/node/pull/1721#ref-pullrequest-91611214 |
|
tools: update eslint and re-enable comma-spacing rule
#2072
| https://github.com/nodejs/node/pull/2072 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Aug 20, 2015
| https://github.com/nodejs/node/pull/1721#ref-pullrequest-98599558 |
|
test: remove unreachable code
#2289
| https://github.com/nodejs/node/pull/2289 |
| https://github.com/snyk-bot |
| snyk-bot | https://github.com/snyk-bot |
|
Jan 20, 2023
| https://github.com/nodejs/node/pull/1721#ref-pullrequest-1551562297 |
|
[Snyk] Upgrade commander from 2.11.0 to 9.4.1
Supermajestcd/node#3
| https://github.com/Supermajestcd/node/pull/3 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1721 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/1721 |
|
| https://github.com/silverwind |
|
| https://github.com/rlidwka |
|
| https://github.com/brendanashworth |
|
| https://github.com/bnoordhuis |
|
| https://github.com/yosuke-furukawa |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |