René's URL Explorer Experiment


Title: http2: tidying up in core.js by jasnell · Pull Request #17209 · nodejs/node · GitHub

Open Graph Title: http2: tidying up in core.js by jasnell · Pull Request #17209 · nodejs/node

X Title: http2: tidying up in core.js by jasnell · Pull Request #17209 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: A number of cleanups and improvements in core.js Getting these out of the way before working on a larger cleanup around the lifecycle and error handling in Http2Stream and Http2Session ping @nodejs...

X Description: A number of cleanups and improvements in core.js Getting these out of the way before working on a larger cleanup around the lifecycle and error handling in Http2Stream and Http2Session ping @nodejs...

Opengraph URL: https://github.com/nodejs/node/pull/17209

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:da97fc76-c7dc-872f-4d7b-64111819d5c0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB1A:5105D:3BCD5C8:52CF08E:6A4F4B5C
html-safe-nonce9a44ba8ac9cd48f6e5491a4d175f5c6bab461045607816a3f813cd68fd9fce2b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjFBOjUxMDVEOjNCQ0Q1Qzg6NTJDRjA4RTo2QTRGNEI1QyIsInZpc2l0b3JfaWQiOiIxNzU0Mzk4MzM4NjU5MDc2OTU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac29143a006f8f5f439e0326897f31e62b3baeec982c8aa7366a5ad44c27df1330
hovercard-subject-tagpull_request:154071913
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17209/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dba346dbeb92f3555e2f7ab428d44087e8ce8f522bf56d3d9c9c0318f78b4abc/nodejs/node/pull/17209
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dba346dbeb92f3555e2f7ab428d44087e8ce8f522bf56d3d9c9c0318f78b4abc/nodejs/node/pull/17209
og:image:altA number of cleanups and improvements in core.js Getting these out of the way before working on a larger cleanup around the lifecycle and error handling in Http2Stream and Http2Session ping @nodejs...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17209#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17209
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17209
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17209
Reloadhttps://github.com/nodejs/node/pull/17209
Reloadhttps://github.com/nodejs/node/pull/17209
Please reload this pagehttps://github.com/nodejs/node/pull/17209
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17209
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 969 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:http2-refactor3https://github.com/jasnell/node/tree/http2-refactor3
Conversationhttps://github.com/nodejs/node/pull/17209
Commits9 (9)https://github.com/nodejs/node/pull/17209/commits
Checkshttps://github.com/nodejs/node/pull/17209/checks
Files changedhttps://github.com/nodejs/node/pull/17209/files
http2: tidying up in core.jshttps://github.com/nodejs/node/pull/17209#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:http2-refactor3https://github.com/jasnell/node/tree/http2-refactor3
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 22, 2017https://github.com/nodejs/node/pull/17209#issue-275957169
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17209
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Nov 22, 2017https://github.com/nodejs/node/pull/17209#event-1353424035
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 22, 2017https://github.com/nodejs/node/pull/17209#issuecomment-346376541
https://ci.nodejs.org/job/node-test-pull-request/11633/https://ci.nodejs.org/job/node-test-pull-request/11633/
Please reload this pagehttps://github.com/nodejs/node/pull/17209
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Nov 22, 2017 https://github.com/nodejs/node/pull/17209#pullrequestreview-78525788
View reviewed changes https://github.com/nodejs/node/pull/17209/files
apapirovskihttps://github.com/apapirovski
Please reload this pagehttps://github.com/nodejs/node/pull/17209
https://github.com/nodejs/node/pull/17209#pullrequestreview-78525788
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17209
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 22, 2017https://github.com/nodejs/node/pull/17209#issuecomment-346422853
Please reload this pagehttps://github.com/nodejs/node/pull/17209
https://github.com/maclover7
maclover7https://github.com/maclover7
Nov 22, 2017 https://github.com/nodejs/node/pull/17209#pullrequestreview-78531950
View reviewed changes https://github.com/nodejs/node/pull/17209/files
maclover7https://github.com/maclover7
https://github.com/nodejs/node/pull/17209#pullrequestreview-78531950
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17209
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/17209/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
maclover7https://github.com/maclover7
Nov 22, 2017https://github.com/nodejs/node/pull/17209#discussion_r152638550
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17209
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/17209/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
maclover7https://github.com/maclover7
Nov 22, 2017https://github.com/nodejs/node/pull/17209#discussion_r152638590
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17209
jasnellhttps://github.com/jasnell
November 22, 2017 09:58https://github.com/nodejs/node/pull/17209#commits-pushed-b92ff9b
https://github.com/jasnell
http2: fixup js debug messageshttps://github.com/nodejs/node/pull/17209/commits/b92ff9b51040fe4189f1bceff7904a2ec13cef78
b92ff9bhttps://github.com/nodejs/node/pull/17209/commits/b92ff9b51040fe4189f1bceff7904a2ec13cef78
https://github.com/jasnell
http2: simplify and improve rstStreamhttps://github.com/nodejs/node/pull/17209/commits/2c13db4872e28c7e0d65e37975f8110fef85bc97
2c13db4https://github.com/nodejs/node/pull/17209/commits/2c13db4872e28c7e0d65e37975f8110fef85bc97
https://github.com/jasnell
http2: improve and simplify _readhttps://github.com/nodejs/node/pull/17209/commits/97d488d51ca79831eb56acf652cc85db19604ba6
97d488dhttps://github.com/nodejs/node/pull/17209/commits/97d488d51ca79831eb56acf652cc85db19604ba6
https://github.com/jasnell
http2: simplify and improve priorityhttps://github.com/nodejs/node/pull/17209/commits/215a347c6c9996fff71f84bbcc06d7abe9f18be0
215a347https://github.com/nodejs/node/pull/17209/commits/215a347c6c9996fff71f84bbcc06d7abe9f18be0
https://github.com/jasnell
http2: simplify on ready a bithttps://github.com/nodejs/node/pull/17209/commits/d22b61c7def12121a9d0a9a4a5e41ae1014f19b6
d22b61chttps://github.com/nodejs/node/pull/17209/commits/d22b61c7def12121a9d0a9a4a5e41ae1014f19b6
https://github.com/jasnell
http2: simplify and improve respond/pushhttps://github.com/nodejs/node/pull/17209/commits/f35a21a678e2e48028576fa5c206370c525e15b0
f35a21ahttps://github.com/nodejs/node/pull/17209/commits/f35a21a678e2e48028576fa5c206370c525e15b0
https://github.com/jasnell
http2: reduce duplication with _unrefActivehttps://github.com/nodejs/node/pull/17209/commits/365209980da3c759b1424a6889a9cafed600d552
3652099https://github.com/nodejs/node/pull/17209/commits/365209980da3c759b1424a6889a9cafed600d552
https://github.com/jasnell
http2: simplify stream close handlinghttps://github.com/nodejs/node/pull/17209/commits/a9f60afa122a5c561c8f264a03d8e8ee2bde91f3
a9f60afhttps://github.com/nodejs/node/pull/17209/commits/a9f60afa122a5c561c8f264a03d8e8ee2bde91f3
https://github.com/jasnell
[Squash] Fix nitshttps://github.com/nodejs/node/pull/17209/commits/46827dbbd53a01d3e42ba8bc9e0fa2dfe25b6501
46827dbhttps://github.com/nodejs/node/pull/17209/commits/46827dbbd53a01d3e42ba8bc9e0fa2dfe25b6501
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/85c0642a4a3e58205abd8291c873d0f2ddd0c357..46827dbbd53a01d3e42ba8bc9e0fa2dfe25b6501
85c0642https://github.com/nodejs/node/commit/85c0642a4a3e58205abd8291c873d0f2ddd0c357
46827dbhttps://github.com/nodejs/node/commit/46827dbbd53a01d3e42ba8bc9e0fa2dfe25b6501
Compare https://github.com/nodejs/node/compare/85c0642a4a3e58205abd8291c873d0f2ddd0c357..46827dbbd53a01d3e42ba8bc9e0fa2dfe25b6501
November 22, 2017 17:58https://github.com/nodejs/node/pull/17209#event-1354592805
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 22, 2017https://github.com/nodejs/node/pull/17209#issuecomment-346428643
@maclover7https://github.com/maclover7
Please reload this pagehttps://github.com/nodejs/node/pull/17209
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 22, 2017https://github.com/nodejs/node/pull/17209#issuecomment-346456588
Please reload this pagehttps://github.com/nodejs/node/pull/17209
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 24, 2017https://github.com/nodejs/node/pull/17209#issuecomment-346887400
https://ci.nodejs.org/job/node-test-pull-request/11689/https://ci.nodejs.org/job/node-test-pull-request/11689/
Please reload this pagehttps://github.com/nodejs/node/pull/17209
jasnellhttps://github.com/jasnell
Nov 24, 2017 https://github.com/nodejs/node/pull/17209#ref-commit-9d87082
https://github.com/jasnell
http2: general cleanups in core.jshttps://github.com/nodejs/node/commit/9d87082d7df8b509d3e035b0222899d9cd8e58a3
9d87082https://github.com/nodejs/node/commit/9d87082d7df8b509d3e035b0222899d9cd8e58a3
#17209https://github.com/nodejs/node/pull/17209
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 24, 2017https://github.com/nodejs/node/pull/17209#issuecomment-346892189
Please reload this pagehttps://github.com/nodejs/node/pull/17209
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 24, 2017https://github.com/nodejs/node/pull/17209#event-1357573871
MylesBorinshttps://github.com/MylesBorins
Dec 7, 2017 https://github.com/nodejs/node/pull/17209#ref-commit-8442b53
https://github.com/jasnell
https://github.com/MylesBorins
http2: general cleanups in core.jshttps://github.com/nodejs/node/commit/8442b53a2092769cf93e0742f081991c5758c98b
8442b53https://github.com/nodejs/node/commit/8442b53a2092769cf93e0742f081991c5758c98b
#17209https://github.com/nodejs/node/pull/17209
MylesBorinshttps://github.com/MylesBorins
Dec 7, 2017 https://github.com/nodejs/node/pull/17209#ref-commit-7ceccb1
https://github.com/jasnell
https://github.com/MylesBorins
http2: general cleanups in core.jshttps://github.com/nodejs/node/commit/7ceccb1f2ae1d2825f058e333d10798bd6418a22
7ceccb1https://github.com/nodejs/node/commit/7ceccb1f2ae1d2825f058e333d10798bd6418a22
#17209https://github.com/nodejs/node/pull/17209
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 7, 2017 https://github.com/nodejs/node/pull/17209#ref-pullrequest-280275791
v8.9.3 proposal #17532 https://github.com/nodejs/node/pull/17532
MylesBorinshttps://github.com/MylesBorins
Dec 8, 2017 https://github.com/nodejs/node/pull/17209#ref-commit-bd035d7
https://github.com/jasnell
https://github.com/MylesBorins
http2: general cleanups in core.jshttps://github.com/nodejs/node/commit/bd035d75bd36a97a0594317b611c17a732bd3c45
bd035d7https://github.com/nodejs/node/commit/bd035d75bd36a97a0594317b611c17a732bd3c45
#17209https://github.com/nodejs/node/pull/17209
MylesBorinshttps://github.com/MylesBorins
Dec 8, 2017 https://github.com/nodejs/node/pull/17209#ref-commit-d3e2bf0
https://github.com/jasnell
https://github.com/MylesBorins
http2: general cleanups in core.jshttps://github.com/nodejs/node/commit/d3e2bf0c8d004e988f7e51ab13d8b9820a474e7a
d3e2bf0https://github.com/nodejs/node/commit/d3e2bf0c8d004e988f7e51ab13d8b9820a474e7a
#17209https://github.com/nodejs/node/pull/17209
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17209
https://github.com/maclover7
maclover7 https://github.com/maclover7
https://github.com/nodejs/node/pull/17209/files/85c0642a4a3e58205abd8291c873d0f2ddd0c357
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/17209/files/85c0642a4a3e58205abd8291c873d0f2ddd0c357
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Please reload this pagehttps://github.com/nodejs/node/pull/17209
https://github.com/jasnell
https://github.com/apapirovski
https://github.com/maclover7
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.