René's URL Explorer Experiment


Title: module: Fix for #17130 CJS dependency shared with loader by guybedford · Pull Request #17131 · nodejs/node · GitHub

Open Graph Title: module: Fix for #17130 CJS dependency shared with loader by guybedford · Pull Request #17131 · nodejs/node

X Title: module: Fix for #17130 CJS dependency shared with loader by guybedford · Pull Request #17131 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This fixes the issue of a CJS dependency loaded by the loader then not being defined when imported. The reason for this is that CJS modules define themselves early into the loader on execution, ins...

X Description: This fixes the issue of a CJS dependency loaded by the loader then not being defined when imported. The reason for this is that CJS modules define themselves early into the loader on execution, ins...

Opengraph URL: https://github.com/nodejs/node/pull/17131

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c8b8fef1-e54b-6205-ac30-e7bb64ff560a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB36C:1F4D74:1DF84BF:25DDC5B:69918B42
html-safe-nonceffb348c38dcd7c3aba6e103ee62c91ea1c80227acf8be97ae1b87f6881666a70
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzZDOjFGNEQ3NDoxREY4NEJGOjI1RERDNUI6Njk5MThCNDIiLCJ2aXNpdG9yX2lkIjoiNDIzMjk5MDgzODA4NTQ4NzQyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac040697e920212e7fc0a0db7eea1c4527c3ff6f0fd32356b645ab173a0bef6826
hovercard-subject-tagpull_request:153494175
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17131/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f5ed84f46f8e61e6016a368e8ed8e647faabb94e0f2c9677071f800f1bfe69c8/nodejs/node/pull/17131
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f5ed84f46f8e61e6016a368e8ed8e647faabb94e0f2c9677071f800f1bfe69c8/nodejs/node/pull/17131
og:image:altThis fixes the issue of a CJS dependency loaded by the loader then not being defined when imported. The reason for this is that CJS modules define themselves early into the loader on execution, ins...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameguybedford
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17131#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17131
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17131
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17131
Reloadhttps://github.com/nodejs/node/pull/17131
Reloadhttps://github.com/nodejs/node/pull/17131
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17131
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:loader-shared-dephttps://github.com/guybedford/node/tree/loader-shared-dep
Conversationhttps://github.com/nodejs/node/pull/17131
Commits2 (2)https://github.com/nodejs/node/pull/17131/commits
Checkshttps://github.com/nodejs/node/pull/17131/checks
Files changedhttps://github.com/nodejs/node/pull/17131/files
module: Fix for #17130 CJS dependency shared with loaderhttps://github.com/nodejs/node/pull/17131#top
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:loader-shared-dephttps://github.com/guybedford/node/tree/loader-shared-dep
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 19, 2017https://github.com/nodejs/node/pull/17131#issue-275155251
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 19, 2017 https://github.com/nodejs/node/pull/17131#ref-issue-275126860
Imported modules are undefined if also used inside loader #17130 https://github.com/nodejs/node/issues/17130
https://github.com/mscdex
mscdexhttps://github.com/mscdex
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
Nov 19, 2017https://github.com/nodejs/node/pull/17131#event-1348778056
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 19, 2017https://github.com/nodejs/node/pull/17131#event-1348783799
https://github.com/refack
refackhttps://github.com/refack
Nov 19, 2017https://github.com/nodejs/node/pull/17131#event-1348795701
https://github.com/targos
targoshttps://github.com/targos
Nov 19, 2017 https://github.com/nodejs/node/pull/17131#pullrequestreview-77650303
View reviewed changes https://github.com/nodejs/node/pull/17131/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 20, 2017 https://github.com/nodejs/node/pull/17131#pullrequestreview-77817874
View reviewed changes https://github.com/nodejs/node/pull/17131/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 20, 2017 https://github.com/nodejs/node/pull/17131#pullrequestreview-77957591
View reviewed changes https://github.com/nodejs/node/pull/17131/files
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Nov 20, 2017 https://github.com/nodejs/node/pull/17131#pullrequestreview-77961163
View reviewed changes https://github.com/nodejs/node/pull/17131/files
test/fixtures/es-module-loaders/loader-shared-dep.mjshttps://github.com/nodejs/node/pull/17131/files#diff-1847dd7242b36d93ee882a5590215bfb904d4054f5ca2d11a76d2f72c111454e
TimothyGuhttps://github.com/TimothyGu
Nov 20, 2017https://github.com/nodejs/node/pull/17131#discussion_r152144131
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17131
guybedfordhttps://github.com/guybedford
Nov 21, 2017https://github.com/nodejs/node/pull/17131#discussion_r152338211
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/18037ac21ca2363c01de201ec9db50297b26b4b4..e480ba7d77cddf03fbec7fb92792e855cd5713cd
18037achttps://github.com/nodejs/node/commit/18037ac21ca2363c01de201ec9db50297b26b4b4
e480ba7https://github.com/nodejs/node/commit/e480ba7d77cddf03fbec7fb92792e855cd5713cd
Compare https://github.com/nodejs/node/compare/18037ac21ca2363c01de201ec9db50297b26b4b4..e480ba7d77cddf03fbec7fb92792e855cd5713cd
November 21, 2017 16:55https://github.com/nodejs/node/pull/17131#event-1352421227
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 21, 2017https://github.com/nodejs/node/pull/17131#issuecomment-346159147
https://ci.nodejs.org/job/node-test-pull-request/11598/https://ci.nodejs.org/job/node-test-pull-request/11598/
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 21, 2017https://github.com/nodejs/node/pull/17131#event-1352850306
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/8acb1e2edf1bdb9770b11bc9c898e88f83f752f0..6462cbe195002b628ae5e498c7cfa28a7e5395fb
8acb1e2https://github.com/nodejs/node/commit/8acb1e2edf1bdb9770b11bc9c898e88f83f752f0
6462cbehttps://github.com/nodejs/node/commit/6462cbe195002b628ae5e498c7cfa28a7e5395fb
Compare https://github.com/nodejs/node/compare/8acb1e2edf1bdb9770b11bc9c898e88f83f752f0..6462cbe195002b628ae5e498c7cfa28a7e5395fb
November 22, 2017 09:51https://github.com/nodejs/node/pull/17131#event-1353698875
https://github.com/guybedford
module: fix forhttps://github.com/nodejs/node/pull/17131/commits/10a065032debfb240d473dae27c15cc85f8491eb
nodejs#17130https://github.com/nodejs/node/issues/17130
shared loader cjs dephttps://github.com/nodejs/node/pull/17131/commits/10a065032debfb240d473dae27c15cc85f8491eb
10a0650https://github.com/nodejs/node/pull/17131/commits/10a065032debfb240d473dae27c15cc85f8491eb
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/6462cbe195002b628ae5e498c7cfa28a7e5395fb..10a065032debfb240d473dae27c15cc85f8491eb
6462cbehttps://github.com/nodejs/node/commit/6462cbe195002b628ae5e498c7cfa28a7e5395fb
10a0650https://github.com/nodejs/node/commit/10a065032debfb240d473dae27c15cc85f8491eb
Compare https://github.com/nodejs/node/compare/6462cbe195002b628ae5e498c7cfa28a7e5395fb..10a065032debfb240d473dae27c15cc85f8491eb
November 22, 2017 10:01https://github.com/nodejs/node/pull/17131#event-1353717093
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 22, 2017https://github.com/nodejs/node/pull/17131#issuecomment-346304327
Please reload this pagehttps://github.com/nodejs/node/pull/17131
node/lib/module.jshttps://github.com/nodejs/node/blob/9c6f6b0633ef4009cc04cfff5efb29c23ef5fc2b/lib/module.js#L538-L552
9c6f6b0https://github.com/nodejs/node/commit/9c6f6b0633ef4009cc04cfff5efb29c23ef5fc2b
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 22, 2017 https://github.com/nodejs/node/pull/17131#pullrequestreview-78392403
View reviewed changes https://github.com/nodejs/node/pull/17131/files/10a065032debfb240d473dae27c15cc85f8491eb
lib/internal/loader/ModuleRequest.jshttps://github.com/nodejs/node/pull/17131/files/10a065032debfb240d473dae27c15cc85f8491eb#diff-427dcaab7306a76efa5c8e32307a02e87d2ba9e57e5052f828ce6fd77148b8b1
guybedfordhttps://github.com/guybedford
Nov 22, 2017https://github.com/nodejs/node/pull/17131#discussion_r152519234
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/jdalton
jdaltonhttps://github.com/jdalton
Nov 23, 2017 https://github.com/nodejs/node/pull/17131#pullrequestreview-78623602
View reviewed changes https://github.com/nodejs/node/pull/17131/files/10a065032debfb240d473dae27c15cc85f8491eb
lib/internal/loader/ModuleRequest.jshttps://github.com/nodejs/node/pull/17131/files/10a065032debfb240d473dae27c15cc85f8491eb#diff-427dcaab7306a76efa5c8e32307a02e87d2ba9e57e5052f828ce6fd77148b8b1
jdaltonhttps://github.com/jdalton
Nov 23, 2017https://github.com/nodejs/node/pull/17131#discussion_r152720300
Please reload this pagehttps://github.com/nodejs/node/pull/17131
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17131
devsnekhttps://github.com/devsnek
Nov 23, 2017https://github.com/nodejs/node/pull/17131#discussion_r152721095
Please reload this pagehttps://github.com/nodejs/node/pull/17131
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/lib/module.jshttps://github.com/nodejs/node/blob/317f596bab62e4c596e73c10c2d8c007b562a904/lib/module.js#L577-L581
317f596https://github.com/nodejs/node/commit/317f596bab62e4c596e73c10c2d8c007b562a904
Please reload this pagehttps://github.com/nodejs/node/pull/17131
jdaltonhttps://github.com/jdalton
Nov 23, 2017https://github.com/nodejs/node/pull/17131#discussion_r152721967
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/17131
devsnekhttps://github.com/devsnek
Nov 23, 2017https://github.com/nodejs/node/pull/17131#discussion_r152724747
Please reload this pagehttps://github.com/nodejs/node/pull/17131
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/targos
targoshttps://github.com/targos
Nov 23, 2017https://github.com/nodejs/node/pull/17131#issuecomment-346631269
https://ci.nodejs.org/job/node-test-pull-request/11668/https://ci.nodejs.org/job/node-test-pull-request/11668/
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 23, 2017https://github.com/nodejs/node/pull/17131#issuecomment-346663120
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/targos
targoshttps://github.com/targos
Nov 23, 2017https://github.com/nodejs/node/pull/17131#issuecomment-346666299
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 23, 2017https://github.com/nodejs/node/pull/17131#issuecomment-346666752
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 23, 2017 https://github.com/nodejs/node/pull/17131#pullrequestreview-78779678
View reviewed changes https://github.com/nodejs/node/pull/17131/files/10a065032debfb240d473dae27c15cc85f8491eb
https://github.com/guybedford
fix windows cache path lookuphttps://github.com/nodejs/node/pull/17131/commits/ffe969a8d4c471a8e30bf65cea97ef80b11f1fa0
https://github.com/nodejs/node/commit/ffe969a8d4c471a8e30bf65cea97ef80b11f1fa0#comments
ffe969ahttps://github.com/nodejs/node/pull/17131/commits/ffe969a8d4c471a8e30bf65cea97ef80b11f1fa0
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 23, 2017https://github.com/nodejs/node/pull/17131#issuecomment-346685667
https://ci.nodejs.org/job/node-test-pull-request/11677/https://ci.nodejs.org/job/node-test-pull-request/11677/
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 23, 2017https://github.com/nodejs/node/pull/17131#issuecomment-346687054
@jdaltonhttps://github.com/jdalton
https://github.com/nodejs/node/blob/master/lib/internal/url.js#L1317https://github.com/nodejs/node/blob/master/lib/internal/url.js#L1317
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/jdalton
jdaltonhttps://github.com/jdalton
Nov 23, 2017https://github.com/nodejs/node/pull/17131#issuecomment-346704875
Please reload this pagehttps://github.com/nodejs/node/pull/17131
@guybedfordhttps://github.com/guybedford
https://github.com/nodejs/node/blob/master/lib/internal/url.js#L1317https://github.com/nodejs/node/blob/master/lib/internal/url.js#L1317
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 24, 2017https://github.com/nodejs/node/pull/17131#issuecomment-346812725
@jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/17131/files#diff-c5e21b512cde1c24955c7231ebf52254R44https://github.com/nodejs/node/pull/17131/files#diff-c5e21b512cde1c24955c7231ebf52254R44
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 26, 2017https://github.com/nodejs/node/pull/17131#issuecomment-347023620
@bmeckhttps://github.com/bmeck
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Nov 27, 2017https://github.com/nodejs/node/pull/17131#issuecomment-347175765
#17153https://github.com/nodejs/node/pull/17153
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Nov 27, 2017 https://github.com/nodejs/node/pull/17131#pullrequestreview-79158937
View reviewed changes https://github.com/nodejs/node/pull/17131/files/ffe969a8d4c471a8e30bf65cea97ef80b11f1fa0
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 27, 2017https://github.com/nodejs/node/pull/17131#issuecomment-347209960
@bmeckhttps://github.com/bmeck
Please reload this pagehttps://github.com/nodejs/node/pull/17131
guybedfordhttps://github.com/guybedford
Nov 28, 2017 https://github.com/nodejs/node/pull/17131#ref-commit-1f5ee33
https://github.com/guybedford
module: fix forhttps://github.com/nodejs/node/commit/1f5ee33dcb74202a0f29ed1ee2e941b36138f9b0
#17130https://github.com/nodejs/node/issues/17130
shared loader cjs dephttps://github.com/nodejs/node/commit/1f5ee33dcb74202a0f29ed1ee2e941b36138f9b0
1f5ee33https://github.com/nodejs/node/commit/1f5ee33dcb74202a0f29ed1ee2e941b36138f9b0
#17131https://github.com/nodejs/node/pull/17131
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 28, 2017https://github.com/nodejs/node/pull/17131#issuecomment-347480405
1f5ee33https://github.com/nodejs/node/commit/1f5ee33dcb74202a0f29ed1ee2e941b36138f9b0
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 28, 2017https://github.com/nodejs/node/pull/17131#event-1361057633
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 29, 2017https://github.com/nodejs/node/pull/17131#event-1364423800
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17131#ref-commit-e820e2a
https://github.com/guybedford
https://github.com/MylesBorins
module: fix forhttps://github.com/nodejs/node/commit/e820e2a3e307fc820c971beebc2707dac4506364
#17130https://github.com/nodejs/node/issues/17130
shared loader cjs dephttps://github.com/nodejs/node/commit/e820e2a3e307fc820c971beebc2707dac4506364
e820e2ahttps://github.com/nodejs/node/commit/e820e2a3e307fc820c971beebc2707dac4506364
#17131https://github.com/nodejs/node/pull/17131
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17131#ref-commit-2fc86de
https://github.com/guybedford
https://github.com/MylesBorins
module: fix forhttps://github.com/nodejs/node/commit/2fc86de29fa89973ad03279bddf9dbd58f158e27
#17130https://github.com/nodejs/node/issues/17130
shared loader cjs dephttps://github.com/nodejs/node/commit/2fc86de29fa89973ad03279bddf9dbd58f158e27
2fc86dehttps://github.com/nodejs/node/commit/2fc86de29fa89973ad03279bddf9dbd58f158e27
#17131https://github.com/nodejs/node/pull/17131
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17131#ref-commit-5736dc4
https://github.com/guybedford
https://github.com/MylesBorins
module: fix forhttps://github.com/nodejs/node/commit/5736dc4ab9a839996db56a46a64f842b0be08026
#17130https://github.com/nodejs/node/issues/17130
shared loader cjs dephttps://github.com/nodejs/node/commit/5736dc4ab9a839996db56a46a64f842b0be08026
5736dc4https://github.com/nodejs/node/commit/5736dc4ab9a839996db56a46a64f842b0be08026
#17131https://github.com/nodejs/node/pull/17131
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17131#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
gibfahnhttps://github.com/gibfahn
Dec 19, 2017 https://github.com/nodejs/node/pull/17131#ref-commit-281a330
https://github.com/guybedford
https://github.com/gibfahn
module: fix forhttps://github.com/nodejs/node/commit/281a3304f5d511de186aad542599383db4d5e54c
#17130https://github.com/nodejs/node/issues/17130
shared loader cjs dephttps://github.com/nodejs/node/commit/281a3304f5d511de186aad542599383db4d5e54c
281a330https://github.com/nodejs/node/commit/281a3304f5d511de186aad542599383db4d5e54c
#17131https://github.com/nodejs/node/pull/17131
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Dec 19, 2017https://github.com/nodejs/node/pull/17131#event-1395112369
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17131#ref-pullrequest-283423333
v8.9.4 proposal #17772 https://github.com/nodejs/node/pull/17772
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17131#ref-commit-c3fdef7
https://github.com/guybedford
https://github.com/gibfahn
module: fix forhttps://github.com/nodejs/node/commit/c3fdef74694b07afd1799241a499e021177974c1
#17130https://github.com/nodejs/node/issues/17130
shared loader cjs dephttps://github.com/nodejs/node/commit/c3fdef74694b07afd1799241a499e021177974c1
c3fdef7https://github.com/nodejs/node/commit/c3fdef74694b07afd1799241a499e021177974c1
#17131https://github.com/nodejs/node/pull/17131
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17131#ref-pullrequest-283426801
v8.9.4 proposal #17774 https://github.com/nodejs/node/pull/17774
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17131
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/17131/files/18037ac21ca2363c01de201ec9db50297b26b4b4
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/17131/files/18037ac21ca2363c01de201ec9db50297b26b4b4
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/17131/files/18037ac21ca2363c01de201ec9db50297b26b4b4
https://github.com/jdalton
jdalton https://github.com/jdalton
https://github.com/nodejs/node/pull/17131/files/10a065032debfb240d473dae27c15cc85f8491eb
https://github.com/bmeck
bmeck https://github.com/bmeck
https://github.com/nodejs/node/pull/17131/files/ffe969a8d4c471a8e30bf65cea97ef80b11f1fa0
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/17131/files/18037ac21ca2363c01de201ec9db50297b26b4b4
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/17131/files/10a065032debfb240d473dae27c15cc85f8491eb
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
Please reload this pagehttps://github.com/nodejs/node/pull/17131
https://github.com/guybedford
https://github.com/joyeecheung
https://github.com/targos
https://github.com/jdalton
https://github.com/bmeck
https://github.com/jasnell
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/devsnek
https://github.com/mscdex
https://github.com/gibfahn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.