| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5808fa16-1629-cda6-0976-92b8ce1b3c0a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E824:1FD988:14784AD:19C57F1:69917C12 |
| html-safe-nonce | 11782791759b19b01bf827016c7f3009c165df94d5e9bdf6e648125a9c6450b7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODI0OjFGRDk4ODoxNDc4NEFEOjE5QzU3RjE6Njk5MTdDMTIiLCJ2aXNpdG9yX2lkIjoiMjI0MTAwODA5MTY0OTg5OTUzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5d74b2165a14e4e3e562798a6df980845d6950961aefc3463c6cec947461efc7 |
| hovercard-subject-tag | pull_request:153461786 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17121/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d30f691d7e59a39f40a6444e9c36545b55b91521fa947257470a9b85fe928358/nodejs/node/pull/17121 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d30f691d7e59a39f40a6444e9c36545b55b91521fa947257470a9b85fe928358/nodejs/node/pull/17121 |
| og:image:alt | The first occurrence of path.join() can be replaced with path.resolve(). The second occurrence should be unnecessary as ESLint will resolve the path internally, and the old check probably did not w... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tniessen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17121#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17121 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17121 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17121 |
| Reload | https://github.com/nodejs/node/pull/17121 |
| Reload | https://github.com/nodejs/node/pull/17121 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17121 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:dont-join-paths-in-lint-js | https://github.com/tniessen/node/tree/dont-join-paths-in-lint-js |
| Conversation | https://github.com/nodejs/node/pull/17121 |
| Commits1 (1) | https://github.com/nodejs/node/pull/17121/commits |
| Checks | https://github.com/nodejs/node/pull/17121/checks |
| Files changed | https://github.com/nodejs/node/pull/17121/files |
| tools: avoid using process.cwd in tools/lint-js | https://github.com/nodejs/node/pull/17121#top |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:dont-join-paths-in-lint-js | https://github.com/tniessen/node/tree/dont-join-paths-in-lint-js |
|
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Nov 18, 2017 | https://github.com/nodejs/node/pull/17121#issue-275099303 |
| Please reload this page | https://github.com/nodejs/node/pull/17121 |
| https://ci.nodejs.org/job/node-test-linter/13675/ | https://ci.nodejs.org/job/node-test-linter/13675/ |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/17121 |
|
| https://github.com/tniessen |
| tools: avoid using process.cwd in tools/lint-js | https://github.com/nodejs/node/pull/17121/commits/e98073d79ab6b2da235d4ae8253a5bf9eac75c98 |
| e98073d | https://github.com/nodejs/node/pull/17121/commits/e98073d79ab6b2da235d4ae8253a5bf9eac75c98 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| mscdex | https://github.com/mscdex |
| November 18, 2017 18:25 | https://github.com/nodejs/node/pull/17121#event-1348487164 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Nov 18, 2017 | https://github.com/nodejs/node/pull/17121#event-1348487178 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Nov 19, 2017
| https://github.com/nodejs/node/pull/17121#pullrequestreview-77636988 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17121/files/e98073d79ab6b2da235d4ae8253a5bf9eac75c98 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 19, 2017 | https://github.com/nodejs/node/pull/17121#event-1348733062 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 19, 2017
| https://github.com/nodejs/node/pull/17121#pullrequestreview-77645410 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17121/files/e98073d79ab6b2da235d4ae8253a5bf9eac75c98 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 19, 2017 | https://github.com/nodejs/node/pull/17121#issuecomment-345523722 |
| @tniessen | https://github.com/tniessen |
| https://ci.nodejs.org/job/node-test-commit/14149/ | https://ci.nodejs.org/job/node-test-commit/14149/ |
| Please reload this page | https://github.com/nodejs/node/pull/17121 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Nov 19, 2017 | https://github.com/nodejs/node/pull/17121#issuecomment-345525078 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/17121 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Nov 19, 2017
| https://github.com/nodejs/node/pull/17121#ref-pullrequest-275095240 |
|
tools: use built-in padStart instead of padString
#17120
| https://github.com/nodejs/node/pull/17120 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 19, 2017 | https://github.com/nodejs/node/pull/17121#issuecomment-345529806 |
| @tniessen | https://github.com/tniessen |
| Please reload this page | https://github.com/nodejs/node/pull/17121 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Nov 20, 2017
| https://github.com/nodejs/node/pull/17121#pullrequestreview-77665957 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17121/files/e98073d79ab6b2da235d4ae8253a5bf9eac75c98 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 20, 2017
| https://github.com/nodejs/node/pull/17121#pullrequestreview-77958755 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17121/files/e98073d79ab6b2da235d4ae8253a5bf9eac75c98 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Nov 21, 2017 | https://github.com/nodejs/node/pull/17121#issuecomment-345960748 |
| f82f5a4 | https://github.com/nodejs/node/commit/f82f5a4e6ecdbf2bbbbc8de247babd682d4146a3 |
| Please reload this page | https://github.com/nodejs/node/pull/17121 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Nov 21, 2017 | https://github.com/nodejs/node/pull/17121#event-1351522518 |
| tniessen | https://github.com/tniessen |
|
Nov 21, 2017
| https://github.com/nodejs/node/pull/17121#ref-commit-f82f5a4 |
|
| https://github.com/tniessen |
| tools: avoid using process.cwd in tools/lint-js | https://github.com/nodejs/node/commit/f82f5a4e6ecdbf2bbbbc8de247babd682d4146a3 |
| f82f5a4 | https://github.com/nodejs/node/commit/f82f5a4e6ecdbf2bbbbc8de247babd682d4146a3 |
| #17121 | https://github.com/nodejs/node/pull/17121 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 28, 2017 | https://github.com/nodejs/node/pull/17121#event-1360392888 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17121#ref-commit-34bfbfe |
|
| https://github.com/tniessen |
|
| https://github.com/MylesBorins |
| tools: avoid using process.cwd in tools/lint-js | https://github.com/nodejs/node/commit/34bfbfece465567381262e22a5a35a7244916d75 |
| 34bfbfe | https://github.com/nodejs/node/commit/34bfbfece465567381262e22a5a35a7244916d75 |
| #17121 | https://github.com/nodejs/node/pull/17121 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17121#ref-pullrequest-281312309 |
|
v9.3.0 proposal
#17631
| https://github.com/nodejs/node/pull/17631 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/17121#ref-commit-466e94a |
|
| https://github.com/tniessen |
|
| https://github.com/MylesBorins |
| tools: avoid using process.cwd in tools/lint-js | https://github.com/nodejs/node/commit/466e94a6c1e67c3ff7c5b39485ba6cece5caff27 |
| 466e94a | https://github.com/nodejs/node/commit/466e94a6c1e67c3ff7c5b39485ba6cece5caff27 |
| #17121 | https://github.com/nodejs/node/pull/17121 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/17121#event-1394929308 |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/17121#ref-commit-5aff3d2 |
|
| https://github.com/tniessen |
|
| https://github.com/gibfahn |
| tools: avoid using process.cwd in tools/lint-js | https://github.com/nodejs/node/commit/5aff3d250c23bf455234d6f24f5c8372bd6551b3 |
| 5aff3d2 | https://github.com/nodejs/node/commit/5aff3d250c23bf455234d6f24f5c8372bd6551b3 |
| #17121 | https://github.com/nodejs/node/pull/17121 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
land-on-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/17121#event-1394937264 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17121#ref-pullrequest-283423333 |
|
v8.9.4 proposal
#17772
| https://github.com/nodejs/node/pull/17772 |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17121#ref-commit-df39389 |
|
| https://github.com/tniessen |
|
| https://github.com/gibfahn |
| tools: avoid using process.cwd in tools/lint-js | https://github.com/nodejs/node/commit/df39389175671dc4801cec4d461364bc3f9726b9 |
| df39389 | https://github.com/nodejs/node/commit/df39389175671dc4801cec4d461364bc3f9726b9 |
| #17121 | https://github.com/nodejs/node/pull/17121 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17121#ref-pullrequest-283426801 |
|
v8.9.4 proposal
#17774
| https://github.com/nodejs/node/pull/17774 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17121#ref-pullrequest-283432791 |
|
v6.12.3 proposal
#17776
| https://github.com/nodejs/node/pull/17776 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17121 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/17121/files/e98073d79ab6b2da235d4ae8253a5bf9eac75c98 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/17121/files/e98073d79ab6b2da235d4ae8253a5bf9eac75c98 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/17121/files/e98073d79ab6b2da235d4ae8253a5bf9eac75c98 |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/17121/files/e98073d79ab6b2da235d4ae8253a5bf9eac75c98 |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/17121 |
|
| https://github.com/tniessen |
|
| https://github.com/addaleax |
|
| https://github.com/refack |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
|
| https://github.com/gibfahn |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |