René's URL Explorer Experiment


Title: http2: major update to internals by jasnell · Pull Request #17105 · nodejs/node · GitHub

Open Graph Title: http2: major update to internals by jasnell · Pull Request #17105 · nodejs/node

X Title: http2: major update to internals by jasnell · Pull Request #17105 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This update does several significant things: It eliminates the base Nghttp2* classes and folds those in to node::http2::Http2Session and node::http2::Http2Stream It makes node::http2::Http2Stream ...

X Description: This update does several significant things: It eliminates the base Nghttp2* classes and folds those in to node::http2::Http2Session and node::http2::Http2Stream It makes node::http2::Http2Stream ...

Opengraph URL: https://github.com/nodejs/node/pull/17105

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b103fc0a-445d-c12c-4183-123d4d7b46dd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD928:34DA5A:243F421:325294D:6A4F4CCB
html-safe-nonceaef079f0d142ba974c30c502dab7fdefbf3f7be0f5a0f768ebe8c860efb906d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTI4OjM0REE1QToyNDNGNDIxOjMyNTI5NEQ6NkE0RjRDQ0IiLCJ2aXNpdG9yX2lkIjoiOTAyMDQ5NjcyNDM4MTA5MzA2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4f65494b13f33cb460e6b9d03118696ecbfd645b8383b975335d6822d254a889
hovercard-subject-tagpull_request:153392367
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17105/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ad6584bafca0ff9fd0eae140f67297ed52119f38506ce17e5e04f4738bdb3c40/nodejs/node/pull/17105
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ad6584bafca0ff9fd0eae140f67297ed52119f38506ce17e5e04f4738bdb3c40/nodejs/node/pull/17105
og:image:altThis update does several significant things: It eliminates the base Nghttp2* classes and folds those in to node::http2::Http2Session and node::http2::Http2Stream It makes node::http2::Http2Stream ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17105#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17105
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17105
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17105
Reloadhttps://github.com/nodejs/node/pull/17105
Reloadhttps://github.com/nodejs/node/pull/17105
Please reload this pagehttps://github.com/nodejs/node/pull/17105
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17105
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 969 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:http2-rework-internalshttps://github.com/jasnell/node/tree/http2-rework-internals
Conversationhttps://github.com/nodejs/node/pull/17105
Commits2 (2)https://github.com/nodejs/node/pull/17105/commits
Checkshttps://github.com/nodejs/node/pull/17105/checks
Files changedhttps://github.com/nodejs/node/pull/17105/files
http2: major update to internalshttps://github.com/nodejs/node/pull/17105#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:http2-rework-internalshttps://github.com/jasnell/node/tree/http2-rework-internals
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 17, 2017https://github.com/nodejs/node/pull/17105#issue-274994464
Please reload this pagehttps://github.com/nodejs/node/pull/17105
@mcollinahttps://github.com/mcollina
@apapirovskihttps://github.com/apapirovski
@addaleaxhttps://github.com/addaleax
@sebdeckershttps://github.com/sebdeckers
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Nov 17, 2017https://github.com/nodejs/node/pull/17105#event-1347923617
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 17, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345365352
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 17, 2017 https://github.com/nodejs/node/pull/17105#pullrequestreview-77560654
View reviewed changes https://github.com/nodejs/node/pull/17105/files
src/node_http2.cchttps://github.com/nodejs/node/pull/17105/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
addaleaxhttps://github.com/addaleax
Nov 17, 2017https://github.com/nodejs/node/pull/17105#discussion_r151789028
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/c43fa6bc4c9808178aaf841d79af54569e29b429..e1542d02136de01fa88b1f07ea8dc8af657b801c
c43fa6bhttps://github.com/nodejs/node/commit/c43fa6bc4c9808178aaf841d79af54569e29b429
e1542d0https://github.com/nodejs/node/commit/e1542d02136de01fa88b1f07ea8dc8af657b801c
Compare https://github.com/nodejs/node/compare/c43fa6bc4c9808178aaf841d79af54569e29b429..e1542d02136de01fa88b1f07ea8dc8af657b801c
November 17, 2017 23:05https://github.com/nodejs/node/pull/17105#event-1348089248
https://github.com/mscdex
mscdexhttps://github.com/mscdex
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Nov 18, 2017https://github.com/nodejs/node/pull/17105#event-1348273986
https://github.com/sebdeckers
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345432599
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/sebdeckers
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017 https://github.com/nodejs/node/pull/17105#pullrequestreview-77612900
View reviewed changes https://github.com/nodejs/node/pull/17105/files
sebdeckershttps://github.com/sebdeckers
https://github.com/nodejs/node/pull/17105#pullrequestreview-77612900
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
test/parallel/test-http2-ping.jshttps://github.com/nodejs/node/pull/17105/files#diff-9e9216d0d6c9b9835f94cc0d1f8997e2c5e92b1f5204daa5686874bfa1c0b86c
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151834597
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151838236
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151840868
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151840915
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151841334
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
sebdeckershttps://github.com/sebdeckers
Nov 20, 2017https://github.com/nodejs/node/pull/17105#discussion_r151897862
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
doc/api/http2.mdhttps://github.com/nodejs/node/pull/17105/files#diff-f63531002261f56a8c6723723d2b7e6d05ea9ec8d433195fdf7c47728f6e3700
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151834624
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151838176
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151840181
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
test/parallel/test-http2-shutdown-errors.jshttps://github.com/nodejs/node/pull/17105/files#diff-498f0d9db5e41ab3cb34378c05342ab620246fb5767ba0b7d89f7998ce133d32
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151834682
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151838272
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
test/parallel/test-http2-client-unescaped-path.jshttps://github.com/nodejs/node/pull/17105/files#diff-6a8539286c6986b7f4c064f11deea7d06e6fae36a3fdc2156d5fda749fd06ac0
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151834706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151838305
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
test/parallel/test-http2-client-onconnect-errors.jshttps://github.com/nodejs/node/pull/17105/files#diff-bf8da8e01b704fbfecc99576a7d164b223c504119e55501bfe7a246b9ece3c07
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151834726
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/17105/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151834779
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151838194
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/17105/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151834821
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151838211
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
addaleaxhttps://github.com/addaleax
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151838482
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151840000
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/sebdeckers
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345434138
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345443554
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 18, 2017 https://github.com/nodejs/node/pull/17105#pullrequestreview-77616837
View reviewed changes https://github.com/nodejs/node/pull/17105/files
doc/api/http2.mdhttps://github.com/nodejs/node/pull/17105/files#diff-f63531002261f56a8c6723723d2b7e6d05ea9ec8d433195fdf7c47728f6e3700
addaleaxhttps://github.com/addaleax
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151838578
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151839102
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
sebdeckershttps://github.com/sebdeckers
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151840331
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 18, 2017 https://github.com/nodejs/node/pull/17105#ref-pullrequest-275083914
src: introduce internal C++ SetImmediate() and remove async_hooks destroy timer #17117 https://github.com/nodejs/node/pull/17117
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Nov 18, 2017 https://github.com/nodejs/node/pull/17105#pullrequestreview-77560002
View reviewed changes https://github.com/nodejs/node/pull/17105/files
apapirovskihttps://github.com/apapirovski
https://github.com/nodejs/node/pull/17105#pullrequestreview-77560002
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/17105/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
apapirovskihttps://github.com/apapirovski
Nov 17, 2017https://github.com/nodejs/node/pull/17105#discussion_r151788512
Please reload this pagehttps://github.com/nodejs/node/pull/17105
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151839929
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
apapirovskihttps://github.com/apapirovski
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151839974
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
test/parallel/test-http2-client-onconnect-errors.jshttps://github.com/nodejs/node/pull/17105/files#diff-bf8da8e01b704fbfecc99576a7d164b223c504119e55501bfe7a246b9ece3c07
apapirovskihttps://github.com/apapirovski
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151839097
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151839880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
apapirovskihttps://github.com/apapirovski
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151839906
Please reload this pagehttps://github.com/nodejs/node/pull/17105
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/17105/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
apapirovskihttps://github.com/apapirovski
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151839568
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151839887
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/17105/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
apapirovskihttps://github.com/apapirovski
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151839682
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
addaleaxhttps://github.com/addaleax
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151839823
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
apapirovskihttps://github.com/apapirovski
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151839850
Please reload this pagehttps://github.com/nodejs/node/pull/17105
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 18, 2017https://github.com/nodejs/node/pull/17105#discussion_r151839905
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/ronkorving
ronkorvinghttps://github.com/ronkorving
Nov 20, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345659153
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 20, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345699710
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 20, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345810417
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/9c649e2506d6842c5c58492da351ab11734fccbd..4c229dbf35e0ddab49da8c28a50ce845da4ea3cd
9c649e2https://github.com/nodejs/node/commit/9c649e2506d6842c5c58492da351ab11734fccbd
4c229dbhttps://github.com/nodejs/node/commit/4c229dbf35e0ddab49da8c28a50ce845da4ea3cd
Compare https://github.com/nodejs/node/compare/9c649e2506d6842c5c58492da351ab11734fccbd..4c229dbf35e0ddab49da8c28a50ce845da4ea3cd
November 20, 2017 19:54https://github.com/nodejs/node/pull/17105#event-1350616290
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 20, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345811174
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://ci.nodejs.org/job/node-test-pull-request/11558/https://ci.nodejs.org/job/node-test-pull-request/11558/
https://ci.nodejs.org/job/node-test-pull-request/11560/https://ci.nodejs.org/job/node-test-pull-request/11560/
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 20, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345839881
https://ci.nodejs.org/job/node-test-pull-request/11565/https://ci.nodejs.org/job/node-test-pull-request/11565/
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 20, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345849571
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 20, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345870292
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/jasnell
http2: major update to internalshttps://github.com/nodejs/node/pull/17105/commits/a21dca0056435baf7edebb85a4a9d77ee093ef76
a21dca0https://github.com/nodejs/node/pull/17105/commits/a21dca0056435baf7edebb85a4a9d77ee093ef76
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/72ec460131a735a1d8229f9010f423d642e55df7..a21dca0056435baf7edebb85a4a9d77ee093ef76
72ec460https://github.com/nodejs/node/commit/72ec460131a735a1d8229f9010f423d642e55df7
a21dca0https://github.com/nodejs/node/commit/a21dca0056435baf7edebb85a4a9d77ee093ef76
Compare https://github.com/nodejs/node/compare/72ec460131a735a1d8229f9010f423d642e55df7..a21dca0056435baf7edebb85a4a9d77ee093ef76
November 20, 2017 23:53https://github.com/nodejs/node/pull/17105#event-1350977946
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 20, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345871486
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 21, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345872140
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 21, 2017 https://github.com/nodejs/node/pull/17105#pullrequestreview-77966538
View reviewed changes https://github.com/nodejs/node/pull/17105/files/a21dca0056435baf7edebb85a4a9d77ee093ef76
doc/api/errors.mdhttps://github.com/nodejs/node/pull/17105/files/a21dca0056435baf7edebb85a4a9d77ee093ef76#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
addaleaxhttps://github.com/addaleax
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152148940
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
doc/api/http2.mdhttps://github.com/nodejs/node/pull/17105/files/a21dca0056435baf7edebb85a4a9d77ee093ef76#diff-f63531002261f56a8c6723723d2b7e6d05ea9ec8d433195fdf7c47728f6e3700
addaleaxhttps://github.com/addaleax
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152149013
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
src/node_http2.cchttps://github.com/nodejs/node/pull/17105/files/a21dca0056435baf7edebb85a4a9d77ee093ef76#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
addaleaxhttps://github.com/addaleax
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152150703
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
src/node_http2.cchttps://github.com/nodejs/node/pull/17105/files/a21dca0056435baf7edebb85a4a9d77ee093ef76#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
addaleaxhttps://github.com/addaleax
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152150756
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152162397
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
src/node_http2.cchttps://github.com/nodejs/node/pull/17105/files/a21dca0056435baf7edebb85a4a9d77ee093ef76#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
addaleaxhttps://github.com/addaleax
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152151085
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#17117https://github.com/nodejs/node/pull/17117
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152162638
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
addaleaxhttps://github.com/addaleax
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152169051
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152170327
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152172047
Please reload this pagehttps://github.com/nodejs/node/pull/17105
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
src/node_http2.cchttps://github.com/nodejs/node/pull/17105/files/a21dca0056435baf7edebb85a4a9d77ee093ef76#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
addaleaxhttps://github.com/addaleax
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152152607
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
src/node_http2.cchttps://github.com/nodejs/node/pull/17105/files/a21dca0056435baf7edebb85a4a9d77ee093ef76#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
addaleaxhttps://github.com/addaleax
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152152642
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
src/node_http2.cchttps://github.com/nodejs/node/pull/17105/files/a21dca0056435baf7edebb85a4a9d77ee093ef76#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
addaleaxhttps://github.com/addaleax
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152152748
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
src/node_http2.cchttps://github.com/nodejs/node/pull/17105/files/a21dca0056435baf7edebb85a4a9d77ee093ef76#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
addaleaxhttps://github.com/addaleax
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152153181
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152158282
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
src/node_http2.hhttps://github.com/nodejs/node/pull/17105/files/a21dca0056435baf7edebb85a4a9d77ee093ef76#diff-430b8a0d2f4cc14e0eac16d13f3879eed2697ebe3749acbb48a11db567a7e936
addaleaxhttps://github.com/addaleax
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152154345
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
jasnellhttps://github.com/jasnell
Nov 21, 2017https://github.com/nodejs/node/pull/17105#discussion_r152158175
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 21, 2017 https://github.com/nodejs/node/pull/17105#pullrequestreview-77990254
View reviewed changes https://github.com/nodejs/node/pull/17105/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 21, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345904324
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/jasnell
[Squash] Fix nitshttps://github.com/nodejs/node/pull/17105/commits/b05f1dccbed989563e7e678ca2c906e610859312
b05f1dchttps://github.com/nodejs/node/pull/17105/commits/b05f1dccbed989563e7e678ca2c906e610859312
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/6a7ca53f21e729c6a9ec36b8e39e798f1fefcf65..b05f1dccbed989563e7e678ca2c906e610859312
6a7ca53https://github.com/nodejs/node/commit/6a7ca53f21e729c6a9ec36b8e39e798f1fefcf65
b05f1dchttps://github.com/nodejs/node/commit/b05f1dccbed989563e7e678ca2c906e610859312
Compare https://github.com/nodejs/node/compare/6a7ca53f21e729c6a9ec36b8e39e798f1fefcf65..b05f1dccbed989563e7e678ca2c906e610859312
November 21, 2017 03:17https://github.com/nodejs/node/pull/17105#event-1351177904
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 21, 2017https://github.com/nodejs/node/pull/17105#issuecomment-345904750
https://ci.nodejs.org/job/node-test-pull-request/11567/https://ci.nodejs.org/job/node-test-pull-request/11567/
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 21, 2017https://github.com/nodejs/node/pull/17105#event-1351180582
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 21, 2017https://github.com/nodejs/node/pull/17105#issuecomment-346003282
69e6c5ahttps://github.com/nodejs/node/commit/69e6c5a212622ec15b8c2cf904480b6582c6c3a5
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 21, 2017https://github.com/nodejs/node/pull/17105#event-1351812630
addaleaxhttps://github.com/addaleax
Nov 21, 2017 https://github.com/nodejs/node/pull/17105#ref-commit-69e6c5a
https://github.com/jasnell
https://github.com/addaleax
http2: major update to internalshttps://github.com/nodejs/node/commit/69e6c5a212622ec15b8c2cf904480b6582c6c3a5
69e6c5ahttps://github.com/nodejs/node/commit/69e6c5a212622ec15b8c2cf904480b6582c6c3a5
#17105https://github.com/nodejs/node/pull/17105
MylesBorinshttps://github.com/MylesBorins
Dec 7, 2017 https://github.com/nodejs/node/pull/17105#ref-commit-70a4690
https://github.com/jasnell
https://github.com/MylesBorins
http2: major update to internalshttps://github.com/nodejs/node/commit/70a46903bc78fea940df2e2daf2f336517c4300d
70a4690https://github.com/nodejs/node/commit/70a46903bc78fea940df2e2daf2f336517c4300d
#17105https://github.com/nodejs/node/pull/17105
MylesBorinshttps://github.com/MylesBorins
Dec 7, 2017 https://github.com/nodejs/node/pull/17105#ref-commit-929f387
https://github.com/jasnell
https://github.com/MylesBorins
http2: major update to internalshttps://github.com/nodejs/node/commit/929f387cc8897a0589d6e83d2d9b994fc6249619
929f387https://github.com/nodejs/node/commit/929f387cc8897a0589d6e83d2d9b994fc6249619
#17105https://github.com/nodejs/node/pull/17105
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 7, 2017 https://github.com/nodejs/node/pull/17105#ref-pullrequest-280275791
v8.9.3 proposal #17532 https://github.com/nodejs/node/pull/17532
MylesBorinshttps://github.com/MylesBorins
Dec 8, 2017 https://github.com/nodejs/node/pull/17105#ref-commit-a5e3ba2
https://github.com/jasnell
https://github.com/MylesBorins
http2: major update to internalshttps://github.com/nodejs/node/commit/a5e3ba2cb35d1cb94238a70bd4eafa3568b3e9d7
a5e3ba2https://github.com/nodejs/node/commit/a5e3ba2cb35d1cb94238a70bd4eafa3568b3e9d7
#17105https://github.com/nodejs/node/pull/17105
MylesBorinshttps://github.com/MylesBorins
Dec 8, 2017 https://github.com/nodejs/node/pull/17105#ref-commit-6a76097
https://github.com/jasnell
https://github.com/MylesBorins
http2: major update to internalshttps://github.com/nodejs/node/commit/6a76097fadd372a4b4710f378491d59e761a4dbd
6a76097https://github.com/nodejs/node/commit/6a76097fadd372a4b4710f378491d59e761a4dbd
#17105https://github.com/nodejs/node/pull/17105
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17105
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/17105/files/6a7ca53f21e729c6a9ec36b8e39e798f1fefcf65
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/17105/files/3648078691e1d1da2493b7fd7974342dae4a7745
https://github.com/sebdeckers
sebdeckers https://github.com/sebdeckers
https://github.com/nodejs/node/pull/17105/files/56ffb60310b873c6b50c2324d64e34bd4467e0fc
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/17105
https://github.com/jasnell
https://github.com/addaleax
https://github.com/sebdeckers
https://github.com/ronkorving
https://github.com/apapirovski
https://github.com/mscdex
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.