René's URL Explorer Experiment


Title: build,win,msi: support WiX with VS2017 by joaocgreis · Pull Request #17101 · nodejs/node · GitHub

Open Graph Title: build,win,msi: support WiX with VS2017 by joaocgreis · Pull Request #17101 · nodejs/node

X Title: build,win,msi: support WiX with VS2017 by joaocgreis · Pull Request #17101 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: To support releasing with VS2017, we need to be able to build the MSI with it. This PR: Passes the Windows SDK version to the MSBuild invocation that builds the MSI, to support SDKs other than 8.1...

X Description: To support releasing with VS2017, we need to be able to build the MSI with it. This PR: Passes the Windows SDK version to the MSBuild invocation that builds the MSI, to support SDKs other than 8.1...

Opengraph URL: https://github.com/nodejs/node/pull/17101

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ed85b4ec-2927-5eb8-cf9f-ae10dad92916
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8706:17D55F:226A158:2BE285B:69919C81
html-safe-noncecfe9f780cd91b683e25c72513b0afed729c912f0e60979c89ab6630b3514b1c7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzA2OjE3RDU1RjoyMjZBMTU4OjJCRTI4NUI6Njk5MTlDODEiLCJ2aXNpdG9yX2lkIjoiNTI2OTg5MDA0NjA3MzM0NzIwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd53a330ef56339544d49e201c881153af0260a7a387d21f59c379bc2fd2b92e5
hovercard-subject-tagpull_request:153361573
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17101/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d513b15378688f2ef4f0c46cbbb13dbad13a92b7c59d8903c0139d5134b7d0a3/nodejs/node/pull/17101
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d513b15378688f2ef4f0c46cbbb13dbad13a92b7c59d8903c0139d5134b7d0a3/nodejs/node/pull/17101
og:image:altTo support releasing with VS2017, we need to be able to build the MSI with it. This PR: Passes the Windows SDK version to the MSBuild invocation that builds the MSI, to support SDKs other than 8.1...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoaocgreis
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17101#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17101
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17101
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17101
Reloadhttps://github.com/nodejs/node/pull/17101
Reloadhttps://github.com/nodejs/node/pull/17101
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17101
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joaocgreishttps://github.com/joaocgreis
nodejs:masterhttps://github.com/nodejs/node/tree/master
JaneaSystems:joaocgreis-HBH-vs2017-wixhttps://github.com/JaneaSystems/node/tree/joaocgreis-HBH-vs2017-wix
Conversationhttps://github.com/nodejs/node/pull/17101
Commits1 (1)https://github.com/nodejs/node/pull/17101/commits
Checkshttps://github.com/nodejs/node/pull/17101/checks
Files changedhttps://github.com/nodejs/node/pull/17101/files
build,win,msi: support WiX with VS2017https://github.com/nodejs/node/pull/17101#top
joaocgreishttps://github.com/joaocgreis
nodejs:masterhttps://github.com/nodejs/node/tree/master
JaneaSystems:joaocgreis-HBH-vs2017-wixhttps://github.com/JaneaSystems/node/tree/joaocgreis-HBH-vs2017-wix
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Nov 17, 2017https://github.com/nodejs/node/pull/17101#issue-274951375
#13052https://github.com/nodejs/node/issues/13052
#16969https://github.com/nodejs/node/pull/16969
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17101
https://github.com/joaocgreis
build,win,msi: support WiX with VS2017https://github.com/nodejs/node/pull/17101/commits/031a22e4e328f4863e116fdafea2619ca44d59bd
031a22ehttps://github.com/nodejs/node/pull/17101/commits/031a22e4e328f4863e116fdafea2619ca44d59bd
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Nov 17, 2017https://github.com/nodejs/node/pull/17101#event-1347661184
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Nov 17, 2017https://github.com/nodejs/node/pull/17101#event-1347661246
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Nov 17, 2017https://github.com/nodejs/node/pull/17101#issuecomment-345321798
https://ci.nodejs.org/view/All/job/node-test-pull-request/11498/https://ci.nodejs.org/view/All/job/node-test-pull-request/11498/
Please reload this pagehttps://github.com/nodejs/node/pull/17101
https://github.com/seishun
seishunhttps://github.com/seishun
Nov 17, 2017 https://github.com/nodejs/node/pull/17101#pullrequestreview-77527607
View reviewed changes https://github.com/nodejs/node/pull/17101/files/031a22e4e328f4863e116fdafea2619ca44d59bd
vcbuild.bathttps://github.com/nodejs/node/pull/17101/files/031a22e4e328f4863e116fdafea2619ca44d59bd#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e
seishunhttps://github.com/seishun
Nov 17, 2017https://github.com/nodejs/node/pull/17101#discussion_r151761650
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17101
joaocgreishttps://github.com/joaocgreis
Nov 20, 2017https://github.com/nodejs/node/pull/17101#discussion_r152051320
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17101
https://github.com/refack
refackhttps://github.com/refack
Nov 17, 2017https://github.com/nodejs/node/pull/17101#issuecomment-345335332
Please reload this pagehttps://github.com/nodejs/node/pull/17101
https://github.com/refack
refackhttps://github.com/refack
Nov 18, 2017 https://github.com/nodejs/node/pull/17101#ref-issue-267304797
Last builds lack Windows installers and binaries nodejs/node-v8#19 https://github.com/nodejs/node-v8/issues/19
https://github.com/seishun
seishunhttps://github.com/seishun
Nov 20, 2017 https://github.com/nodejs/node/pull/17101#pullrequestreview-77860073
View reviewed changes https://github.com/nodejs/node/pull/17101/files/031a22e4e328f4863e116fdafea2619ca44d59bd
vcbuild.bathttps://github.com/nodejs/node/pull/17101/files/031a22e4e328f4863e116fdafea2619ca44d59bd#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e
seishunhttps://github.com/seishun
Nov 20, 2017https://github.com/nodejs/node/pull/17101#discussion_r152056901
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#16969https://github.com/nodejs/node/pull/16969
Please reload this pagehttps://github.com/nodejs/node/pull/17101
joaocgreishttps://github.com/joaocgreis
Nov 21, 2017https://github.com/nodejs/node/pull/17101#discussion_r152148631
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17101
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Nov 23, 2017https://github.com/nodejs/node/pull/17101#issuecomment-346504831
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/17101
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Nov 23, 2017https://github.com/nodejs/node/pull/17101#issuecomment-346661874
Please reload this pagehttps://github.com/nodejs/node/pull/17101
https://github.com/seishun
seishunhttps://github.com/seishun
Nov 26, 2017 https://github.com/nodejs/node/pull/17101#pullrequestreview-79023647
View reviewed changes https://github.com/nodejs/node/pull/17101/files/031a22e4e328f4863e116fdafea2619ca44d59bd
BUILDING.mdhttps://github.com/nodejs/node/pull/17101/files/031a22e4e328f4863e116fdafea2619ca44d59bd#diff-f1355fd54329147c830843ab133fed7716180c3242031487b861a2a3235d0078
seishunhttps://github.com/seishun
Nov 26, 2017https://github.com/nodejs/node/pull/17101#discussion_r153067040
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17101
richardlauhttps://github.com/richardlau
Nov 26, 2017https://github.com/nodejs/node/pull/17101#discussion_r153071111
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17101
https://github.com/seishun
seishunhttps://github.com/seishun
Nov 26, 2017https://github.com/nodejs/node/pull/17101#issuecomment-347013099
Please reload this pagehttps://github.com/nodejs/node/pull/17101
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Nov 27, 2017https://github.com/nodejs/node/pull/17101#issuecomment-347272971
wixtoolset/issues#5525 (comment)https://github.com/wixtoolset/issues/issues/5525#issuecomment-290312186
Please reload this pagehttps://github.com/nodejs/node/pull/17101
https://github.com/seishun
seishunhttps://github.com/seishun
Nov 27, 2017 https://github.com/nodejs/node/pull/17101#pullrequestreview-79261658
View reviewed changes https://github.com/nodejs/node/pull/17101/files/031a22e4e328f4863e116fdafea2619ca44d59bd
seishunhttps://github.com/seishun
https://github.com/nodejs/node/pull/17101#pullrequestreview-79261658
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17101
joaocgreishttps://github.com/joaocgreis
Nov 28, 2017 https://github.com/nodejs/node/pull/17101#ref-commit-04566d3
https://github.com/joaocgreis
build,win,msi: support WiX with VS2017https://github.com/nodejs/node/commit/04566d3698fac6c6afc7896619c92cc2e05d1440
04566d3https://github.com/nodejs/node/commit/04566d3698fac6c6afc7896619c92cc2e05d1440
#17101https://github.com/nodejs/node/pull/17101
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Nov 28, 2017https://github.com/nodejs/node/pull/17101#issuecomment-347697994
04566d3https://github.com/nodejs/node/commit/04566d3698fac6c6afc7896619c92cc2e05d1440
@seishunhttps://github.com/seishun
Please reload this pagehttps://github.com/nodejs/node/pull/17101
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Nov 28, 2017https://github.com/nodejs/node/pull/17101#event-1362493599
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17101#ref-commit-a441d05
https://github.com/joaocgreis
https://github.com/MylesBorins
build,win,msi: support WiX with VS2017https://github.com/nodejs/node/commit/a441d05e948f7cb05a5982342bf70ada4c0aa1a2
a441d05https://github.com/nodejs/node/commit/a441d05e948f7cb05a5982342bf70ada4c0aa1a2
#17101https://github.com/nodejs/node/pull/17101
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17101#ref-commit-87c885b
https://github.com/joaocgreis
https://github.com/MylesBorins
build,win,msi: support WiX with VS2017https://github.com/nodejs/node/commit/87c885bd44e5c6c54ebe50324d3da76bfd9e094f
87c885bhttps://github.com/nodejs/node/commit/87c885bd44e5c6c54ebe50324d3da76bfd9e094f
#17101https://github.com/nodejs/node/pull/17101
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17101#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 19, 2017https://github.com/nodejs/node/pull/17101#issuecomment-352911107
Please reload this pagehttps://github.com/nodejs/node/pull/17101
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Jan 10, 2018https://github.com/nodejs/node/pull/17101#issuecomment-356704755
@gibfahnhttps://github.com/gibfahn
Please reload this pagehttps://github.com/nodejs/node/pull/17101
gibfahnhttps://github.com/gibfahn
Feb 19, 2018 https://github.com/nodejs/node/pull/17101#ref-commit-44ab4f0
https://github.com/joaocgreis
https://github.com/gibfahn
build,win,msi: support WiX with VS2017https://github.com/nodejs/node/commit/44ab4f09a21b1c8bc82bde590f8bfa123bb1743a
44ab4f0https://github.com/nodejs/node/commit/44ab4f09a21b1c8bc82bde590f8bfa123bb1743a
#17101https://github.com/nodejs/node/pull/17101
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Feb 19, 2018https://github.com/nodejs/node/pull/17101#event-1479779932
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17101
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/17101/files/031a22e4e328f4863e116fdafea2619ca44d59bd
https://github.com/seishun
seishun https://github.com/seishun
https://github.com/nodejs/node/pull/17101/files/031a22e4e328f4863e116fdafea2619ca44d59bd
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Please reload this pagehttps://github.com/nodejs/node/pull/17101
https://github.com/joaocgreis
https://github.com/refack
https://github.com/seishun
https://github.com/gibfahn
https://github.com/richardlau
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.