| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1fcb0d6a-389c-19be-d46b-566335d1def5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9AA0:4E57:2477D2:2D9B1F:69911D6A |
| html-safe-nonce | 2b5f666f2323f61d4e80bf305649b2404aed8a0adc6c71eea6d2e7888efe18e4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUEwOjRFNTc6MjQ3N0QyOjJEOUIxRjo2OTkxMUQ2QSIsInZpc2l0b3JfaWQiOiIxMDU0MjgzMzI2MTEyNzM0NTcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8854955117dc29760caea8daccffe3390d511f7ff294cc8f851f6a1415de8bbe |
| hovercard-subject-tag | pull_request:153353065 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17100/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/649ba89a05ab64c815e3a1b1d90c477837fff3a174b3803b55d7d7d7372063e4/nodejs/node/pull/17100 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/649ba89a05ab64c815e3a1b1d90c477837fff3a174b3803b55d7d7d7372063e4/nodejs/node/pull/17100 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines
Affected core... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17100#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17100 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17100 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17100 |
| Reload | https://github.com/nodejs/node/pull/17100 |
| Reload | https://github.com/nodejs/node/pull/17100 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
709
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:cp-doc-tarball | https://github.com/joyeecheung/node/tree/cp-doc-tarball |
| Conversation | https://github.com/nodejs/node/pull/17100 |
| Commits1 (1) | https://github.com/nodejs/node/pull/17100/commits |
| Checks | https://github.com/nodejs/node/pull/17100/checks |
| Files changed | https://github.com/nodejs/node/pull/17100/files |
| build: do not build doc in source tarball | https://github.com/nodejs/node/pull/17100#top |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:cp-doc-tarball | https://github.com/joyeecheung/node/tree/cp-doc-tarball |
|
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/17100#issue-274939842 |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| #16650 | https://github.com/nodejs/node/issues/16650 |
| #16650 | https://github.com/nodejs/node/issues/16650 |
| #16650 (comment) | https://github.com/nodejs/node/issues/16650#issuecomment-345265520 |
| #17043 | https://github.com/nodejs/node/issues/17043 |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/17100#event-1347592030 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/0486a849ae4fd61667277505d5acf8be0a6b363d..9a82b271b4d86d4fa337303cea1481bcfc3b13fe |
| 0486a84 | https://github.com/nodejs/node/commit/0486a849ae4fd61667277505d5acf8be0a6b363d |
| 9a82b27 | https://github.com/nodejs/node/commit/9a82b271b4d86d4fa337303cea1481bcfc3b13fe |
|
Compare
| https://github.com/nodejs/node/compare/0486a849ae4fd61667277505d5acf8be0a6b363d..9a82b271b4d86d4fa337303cea1481bcfc3b13fe |
| November 17, 2017 18:07 | https://github.com/nodejs/node/pull/17100#event-1347649004 |
|
| https://github.com/joyeecheung |
| build: do not build doc in source tarball | https://github.com/nodejs/node/pull/17100/commits/b88ae43df2bd1736c7e055bbb2815d11ddd10831 |
| b88ae43 | https://github.com/nodejs/node/pull/17100/commits/b88ae43df2bd1736c7e055bbb2815d11ddd10831 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/9a82b271b4d86d4fa337303cea1481bcfc3b13fe..b88ae43df2bd1736c7e055bbb2815d11ddd10831 |
| 9a82b27 | https://github.com/nodejs/node/commit/9a82b271b4d86d4fa337303cea1481bcfc3b13fe |
| b88ae43 | https://github.com/nodejs/node/commit/b88ae43df2bd1736c7e055bbb2815d11ddd10831 |
|
Compare
| https://github.com/nodejs/node/compare/9a82b271b4d86d4fa337303cea1481bcfc3b13fe..b88ae43df2bd1736c7e055bbb2815d11ddd10831 |
| November 17, 2017 18:08 | https://github.com/nodejs/node/pull/17100#event-1347650404 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/17100#issuecomment-345350287 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/17100#issuecomment-345359506 |
| @joyeecheung | https://github.com/joyeecheung |
| @MylesBorins | https://github.com/MylesBorins |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/17100#issuecomment-345359519 |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/17100#issuecomment-345361430 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/17100#issuecomment-345363879 |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/17100#issuecomment-345367780 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Nov 17, 2017
| https://github.com/nodejs/node/pull/17100#pullrequestreview-77564142 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17100/files/b88ae43df2bd1736c7e055bbb2815d11ddd10831 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/17100#issuecomment-345369009 |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| #16661 | https://github.com/nodejs/node/pull/16661 |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 18, 2017 | https://github.com/nodejs/node/pull/17100#issuecomment-345425215 |
| https://ci.nodejs.org/job/node-test-pull-request/11513/ | https://ci.nodejs.org/job/node-test-pull-request/11513/ |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 20, 2017 | https://github.com/nodejs/node/pull/17100#issuecomment-345698544 |
| 289fcb0 | https://github.com/nodejs/node/commit/289fcb05be0efe5f57c742af7113547a4af94c69 |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 20, 2017 | https://github.com/nodejs/node/pull/17100#event-1349883427 |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 20, 2017
| https://github.com/nodejs/node/pull/17100#ref-commit-289fcb0 |
|
| https://github.com/joyeecheung |
| build: do not build doc in source tarball | https://github.com/nodejs/node/commit/289fcb05be0efe5f57c742af7113547a4af94c69 |
| 289fcb0 | https://github.com/nodejs/node/commit/289fcb05be0efe5f57c742af7113547a4af94c69 |
| #17100 | https://github.com/nodejs/node/pull/17100 |
| #16650 | https://github.com/nodejs/node/issues/16650 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17100#ref-commit-9093392 |
|
| https://github.com/joyeecheung |
|
| https://github.com/MylesBorins |
| build: do not build doc in source tarball | https://github.com/nodejs/node/commit/90933929543d814841e753c08fba1955c8cab6c2 |
| 9093392 | https://github.com/nodejs/node/commit/90933929543d814841e753c08fba1955c8cab6c2 |
| #17100 | https://github.com/nodejs/node/pull/17100 |
| #16650 | https://github.com/nodejs/node/issues/16650 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17100#ref-pullrequest-281312309 |
|
v9.3.0 proposal
#17631
| https://github.com/nodejs/node/pull/17631 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/17100#event-1394918916 |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/17100#ref-commit-2c62ff9 |
|
| https://github.com/joyeecheung |
|
| https://github.com/gibfahn |
| build: do not build doc in source tarball | https://github.com/nodejs/node/commit/2c62ff9a9281a6eb92587179103685f59959f931 |
| 2c62ff9 | https://github.com/nodejs/node/commit/2c62ff9a9281a6eb92587179103685f59959f931 |
| #17100 | https://github.com/nodejs/node/pull/17100 |
| #16650 | https://github.com/nodejs/node/issues/16650 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
land-on-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/17100#event-1394922105 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17100#ref-pullrequest-283423333 |
|
v8.9.4 proposal
#17772
| https://github.com/nodejs/node/pull/17772 |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17100#ref-commit-1941d0a |
|
| https://github.com/joyeecheung |
|
| https://github.com/gibfahn |
| build: do not build doc in source tarball | https://github.com/nodejs/node/commit/1941d0a405fa3439e6cb3715628bc19cc254855c |
| 1941d0a | https://github.com/nodejs/node/commit/1941d0a405fa3439e6cb3715628bc19cc254855c |
| #17100 | https://github.com/nodejs/node/pull/17100 |
| #16650 | https://github.com/nodejs/node/issues/16650 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17100#ref-pullrequest-283426801 |
|
v8.9.4 proposal
#17774
| https://github.com/nodejs/node/pull/17774 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Feb 27, 2018 | https://github.com/nodejs/node/pull/17100#event-1493462586 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Feb 27, 2018 | https://github.com/nodejs/node/pull/17100#issuecomment-368729170 |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17100 |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/17100/files/b88ae43df2bd1736c7e055bbb2815d11ddd10831 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
test: Node 8.9.0 cannot 'make test' when building from source code
| https://github.com/nodejs/node/issues/16650 |
| Please reload this page | https://github.com/nodejs/node/pull/17100 |
|
| https://github.com/joyeecheung |
|
| https://github.com/MylesBorins |
|
| https://github.com/refack |
|
| https://github.com/gibfahn |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |