René's URL Explorer Experiment


Title: build: enforce order of dependency when building addons by joyeecheung · Pull Request #17048 · nodejs/node · GitHub

Open Graph Title: build: enforce order of dependency when building addons by joyeecheung · Pull Request #17048 · nodejs/node

X Title: build: enforce order of dependency when building addons by joyeecheung · Pull Request #17048 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #17043 (Hopefully) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit...

X Description: Fixes: #17043 (Hopefully) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit...

Opengraph URL: https://github.com/nodejs/node/pull/17048

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:23fad73b-da2d-9e8f-158d-65eb19f18caa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC50A:1F64D6:2A358F8:35F7623:6991CD93
html-safe-nonce84d6e205dbd791790ea48f38e7fa0b111fc2e2bae4d09ed1b6852c57aead228e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTBBOjFGNjRENjoyQTM1OEY4OjM1Rjc2MjM6Njk5MUNEOTMiLCJ2aXNpdG9yX2lkIjoiNjIyNDMzNzEyNjIwMjM5NjA1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac345ec1ddffa67f077f32fabb1d1fdb801579e35d34b2fd77ccf2bd1d54ff54e6
hovercard-subject-tagpull_request:152812694
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17048/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cb3faebac481a905020ce4a0640e210d291f7500471c6095e00e098623f85274/nodejs/node/pull/17048
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cb3faebac481a905020ce4a0640e210d291f7500471c6095e00e098623f85274/nodejs/node/pull/17048
og:image:altFixes: #17043 (Hopefully) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17048#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17048
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17048
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17048
Reloadhttps://github.com/nodejs/node/pull/17048
Reloadhttps://github.com/nodejs/node/pull/17048
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17048
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:order-node-exehttps://github.com/joyeecheung/node/tree/order-node-exe
Conversationhttps://github.com/nodejs/node/pull/17048
Commits1 (1)https://github.com/nodejs/node/pull/17048/commits
Checkshttps://github.com/nodejs/node/pull/17048/checks
Files changedhttps://github.com/nodejs/node/pull/17048/files
build: enforce order of dependency when building addonshttps://github.com/nodejs/node/pull/17048#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:order-node-exehttps://github.com/joyeecheung/node/tree/order-node-exe
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 15, 2017https://github.com/nodejs/node/pull/17048#issue-274207111
#17043https://github.com/nodejs/node/issues/17043
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17048
https://github.com/joyeecheung
build: enforce order of dependency when building addonshttps://github.com/nodejs/node/pull/17048/commits/6602d6951857ea7f0737d64b1e98c56f79ae7f1d
6602d69https://github.com/nodejs/node/pull/17048/commits/6602d6951857ea7f0737d64b1e98c56f79ae7f1d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Nov 15, 2017https://github.com/nodejs/node/pull/17048#event-1343292849
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 15, 2017https://github.com/nodejs/node/pull/17048#issuecomment-344636996
https://ci.nodejs.org/job/node-test-pull-request/11456/https://ci.nodejs.org/job/node-test-pull-request/11456/
Please reload this pagehttps://github.com/nodejs/node/pull/17048
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 15, 2017https://github.com/nodejs/node/pull/17048#issuecomment-344637084
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/17048
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 16, 2017https://github.com/nodejs/node/pull/17048#issuecomment-344846249
https://ci.nodejs.org/job/node-test-commit-smartos/13154/nodes=smartos16-64/consolehttps://ci.nodejs.org/job/node-test-commit-smartos/13154/nodes=smartos16-64/console
Please reload this pagehttps://github.com/nodejs/node/pull/17048
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 16, 2017 https://github.com/nodejs/node/pull/17048#pullrequestreview-77222696
View reviewed changes https://github.com/nodejs/node/pull/17048/files/6602d6951857ea7f0737d64b1e98c56f79ae7f1d
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 18, 2017 https://github.com/nodejs/node/pull/17048#pullrequestreview-77623617
View reviewed changes https://github.com/nodejs/node/pull/17048/files/6602d6951857ea7f0737d64b1e98c56f79ae7f1d
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 18, 2017https://github.com/nodejs/node/pull/17048#issuecomment-345465542
c5b8e16https://github.com/nodejs/node/commit/c5b8e168b32393a486238e537b1eeac24013bfed
Please reload this pagehttps://github.com/nodejs/node/pull/17048
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 18, 2017https://github.com/nodejs/node/pull/17048#event-1348509332
addaleaxhttps://github.com/addaleax
Nov 18, 2017 https://github.com/nodejs/node/pull/17048#ref-commit-c5b8e16
https://github.com/joyeecheung
https://github.com/addaleax
build: enforce order of dependency when building addonshttps://github.com/nodejs/node/commit/c5b8e168b32393a486238e537b1eeac24013bfed
c5b8e16https://github.com/nodejs/node/commit/c5b8e168b32393a486238e537b1eeac24013bfed
#17048https://github.com/nodejs/node/pull/17048
#17043https://github.com/nodejs/node/issues/17043
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 19, 2017 https://github.com/nodejs/node/pull/17048#ref-issue-274162921
build: Makefile dependency regression #17043 https://github.com/nodejs/node/issues/17043
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17048#ref-commit-035a24e
https://github.com/joyeecheung
https://github.com/MylesBorins
build: enforce order of dependency when building addonshttps://github.com/nodejs/node/commit/035a24e619a19e6911bc7887a128bf03b301964e
035a24ehttps://github.com/nodejs/node/commit/035a24e619a19e6911bc7887a128bf03b301964e
#17048https://github.com/nodejs/node/pull/17048
#17043https://github.com/nodejs/node/issues/17043
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17048#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
gibfahnhttps://github.com/gibfahn
Dec 19, 2017 https://github.com/nodejs/node/pull/17048#ref-commit-f0fb1d4
https://github.com/joyeecheung
https://github.com/gibfahn
build: enforce order of dependency when building addonshttps://github.com/nodejs/node/commit/f0fb1d4dff8a9de534f1f4b0ed5546b2bcf5659b
f0fb1d4https://github.com/nodejs/node/commit/f0fb1d4dff8a9de534f1f4b0ed5546b2bcf5659b
#17048https://github.com/nodejs/node/pull/17048
#17043https://github.com/nodejs/node/issues/17043
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
Dec 19, 2017https://github.com/nodejs/node/pull/17048#event-1394895037
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x
Dec 19, 2017https://github.com/nodejs/node/pull/17048#event-1394895358
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 19, 2017https://github.com/nodejs/node/pull/17048#issuecomment-352875102
Please reload this pagehttps://github.com/nodejs/node/pull/17048
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17048#ref-pullrequest-283423333
v8.9.4 proposal #17772 https://github.com/nodejs/node/pull/17772
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17048#ref-commit-3036b36
https://github.com/joyeecheung
https://github.com/gibfahn
build: enforce order of dependency when building addonshttps://github.com/nodejs/node/commit/3036b36b769a896cd22f805c15a336abad5f3d02
3036b36https://github.com/nodejs/node/commit/3036b36b769a896cd22f805c15a336abad5f3d02
#17048https://github.com/nodejs/node/pull/17048
#17043https://github.com/nodejs/node/issues/17043
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17048#ref-pullrequest-283426801
v8.9.4 proposal #17774 https://github.com/nodejs/node/pull/17774
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
backport-requested-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x
Jan 24, 2018https://github.com/nodejs/node/pull/17048#event-1439413025
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17048
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/17048/files/6602d6951857ea7f0737d64b1e98c56f79ae7f1d
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/17048/files/6602d6951857ea7f0737d64b1e98c56f79ae7f1d
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
build: Makefile dependency regression https://github.com/nodejs/node/issues/17043
Please reload this pagehttps://github.com/nodejs/node/pull/17048
https://github.com/joyeecheung
https://github.com/addaleax
https://github.com/MylesBorins
https://github.com/jasnell
https://github.com/gibfahn
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.