René's URL Explorer Experiment


Title: test: fs.write() if 3rd argument is a callback, not offset by PatrickHeneise · Pull Request #17045 · nodejs/node · GitHub

Open Graph Title: test: fs.write() if 3rd argument is a callback, not offset by PatrickHeneise · Pull Request #17045 · nodejs/node

X Title: test: fs.write() if 3rd argument is a callback, not offset by PatrickHeneise · Pull Request #17045 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: #16827 and #16822 resulted in some serious merge conflicts, so I decided to open a fresh PR for this with everything resolved. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes te...

X Description: #16827 and #16822 resulted in some serious merge conflicts, so I decided to open a fresh PR for this with everything resolved. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes te...

Opengraph URL: https://github.com/nodejs/node/pull/17045

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ce407747-050a-9c61-9b1d-df115a3bb86e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBAAE:29615:7D13B:9D5E0:69911B51
html-safe-nonce1c2ba034c4e8d2cf9f9369c5234bb9a75aff035c2f11e91b9ded1084d83c4992
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUFFOjI5NjE1OjdEMTNCOjlENUUwOjY5OTExQjUxIiwidmlzaXRvcl9pZCI6IjMwMjE4MzE4MjMyMTI3NDc2MDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca844f30c51f7d8f4ad18781680bf036df0bc96a63426f4a026b2bc93cdcc59a1
hovercard-subject-tagpull_request:152804553
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17045/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a517595a9d447b15b475efacd2a42d372554bb818faab05548c57f7023368f4d/nodejs/node/pull/17045
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a517595a9d447b15b475efacd2a42d372554bb818faab05548c57f7023368f4d/nodejs/node/pull/17045
og:image:alt#16827 and #16822 resulted in some serious merge conflicts, so I decided to open a fresh PR for this with everything resolved. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes te...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamePatrickHeneise
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17045#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17045
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17045
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17045
Reloadhttps://github.com/nodejs/node/pull/17045
Reloadhttps://github.com/nodejs/node/pull/17045
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17045
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
PatrickHeneisehttps://github.com/PatrickHeneise
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/17045
Commits3 (3)https://github.com/nodejs/node/pull/17045/commits
Checkshttps://github.com/nodejs/node/pull/17045/checks
Files changedhttps://github.com/nodejs/node/pull/17045/files
test: fs.write() if 3rd argument is a callback, not offsethttps://github.com/nodejs/node/pull/17045#top
PatrickHeneisehttps://github.com/PatrickHeneise
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/PatrickHeneise
PatrickHeneisehttps://github.com/PatrickHeneise
Nov 15, 2017https://github.com/nodejs/node/pull/17045#issue-274196337
#16827https://github.com/nodejs/node/pull/16827
#16822https://github.com/nodejs/node/pull/16822
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17045
test: fs.write() if 3rd argument is a callback, not offset; easier wa…https://github.com/nodejs/node/pull/17045/commits/7e3635f8adfcce8dde4c39f4d640708dd2a96c7b
7e3635fhttps://github.com/nodejs/node/pull/17045/commits/7e3635f8adfcce8dde4c39f4d640708dd2a96c7b
#16822https://github.com/nodejs/node/pull/16822
#16827https://github.com/nodejs/node/pull/16827
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Nov 15, 2017https://github.com/nodejs/node/pull/17045#event-1343227955
https://github.com/PatrickHeneise
PatrickHeneisehttps://github.com/PatrickHeneise
Nov 15, 2017 https://github.com/nodejs/node/pull/17045#ref-pullrequest-271518624
test: fs.write() if 3rd argument is a callback, not offset #16822 https://github.com/nodejs/node/pull/16822
fix: done, written, and console.logs removedhttps://github.com/nodejs/node/pull/17045/commits/a11d130789447e0118e9c904db7b289728ec9d08
a11d130https://github.com/nodejs/node/pull/17045/commits/a11d130789447e0118e9c904db7b289728ec9d08
https://github.com/mscdex
mscdexhttps://github.com/mscdex
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Nov 15, 2017https://github.com/nodejs/node/pull/17045#event-1343429097
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 16, 2017 https://github.com/nodejs/node/pull/17045#pullrequestreview-77212330
View reviewed changes https://github.com/nodejs/node/pull/17045/files/a11d130789447e0118e9c904db7b289728ec9d08
test/parallel/test-fs-write.jshttps://github.com/nodejs/node/pull/17045/files/a11d130789447e0118e9c904db7b289728ec9d08#diff-5c2fce36f717b4794035200aa30bf929da0d8bc4337587f7e84202bc5ca3c04b
cjihrighttps://github.com/cjihrig
Nov 16, 2017https://github.com/nodejs/node/pull/17045#discussion_r151494537
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17045
PatrickHeneisehttps://github.com/PatrickHeneise
Nov 17, 2017https://github.com/nodejs/node/pull/17045#discussion_r151664665
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/17045
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 16, 2017 https://github.com/nodejs/node/pull/17045#pullrequestreview-77215499
View reviewed changes https://github.com/nodejs/node/pull/17045/files/a11d130789447e0118e9c904db7b289728ec9d08
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/17045#pullrequestreview-77215499
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/17045
rename fn to fn3 to avoid conflicts with other testshttps://github.com/nodejs/node/pull/17045/commits/5e789afd20f4c0c3a10223d0bf7bcddebd63149f
5e789afhttps://github.com/nodejs/node/pull/17045/commits/5e789afd20f4c0c3a10223d0bf7bcddebd63149f
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 18, 2017 https://github.com/nodejs/node/pull/17045#pullrequestreview-77623652
View reviewed changes https://github.com/nodejs/node/pull/17045/files/5e789afd20f4c0c3a10223d0bf7bcddebd63149f
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 18, 2017https://github.com/nodejs/node/pull/17045#issuecomment-345465667
https://ci.nodejs.org/job/node-test-commit/14132/https://ci.nodejs.org/job/node-test-commit/14132/
Please reload this pagehttps://github.com/nodejs/node/pull/17045
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 18, 2017https://github.com/nodejs/node/pull/17045#event-1348510170
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 18, 2017 https://github.com/nodejs/node/pull/17045#pullrequestreview-77623972
View reviewed changes https://github.com/nodejs/node/pull/17045/files/5e789afd20f4c0c3a10223d0bf7bcddebd63149f
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 18, 2017https://github.com/nodejs/node/pull/17045#issuecomment-345471476
8f8999chttps://github.com/nodejs/node/commit/8f8999c1c0de92b3720bead0c09b06d6cdc44ac7
Please reload this pagehttps://github.com/nodejs/node/pull/17045
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 18, 2017https://github.com/nodejs/node/pull/17045#event-1348539707
addaleaxhttps://github.com/addaleax
Nov 18, 2017 https://github.com/nodejs/node/pull/17045#ref-commit-8f8999c
https://github.com/addaleax
test: fs.write() if 3rd argument is a callback, not offsethttps://github.com/nodejs/node/commit/8f8999c1c0de92b3720bead0c09b06d6cdc44ac7
8f8999chttps://github.com/nodejs/node/commit/8f8999c1c0de92b3720bead0c09b06d6cdc44ac7
#16822https://github.com/nodejs/node/pull/16822
#16827https://github.com/nodejs/node/pull/16827
#17045https://github.com/nodejs/node/pull/17045
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 18, 2017https://github.com/nodejs/node/pull/17045#event-1348544125
https://github.com/PatrickHeneise
PatrickHeneisehttps://github.com/PatrickHeneise
November 18, 2017 21:52https://github.com/nodejs/node/pull/17045#event-1348552134
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17045#ref-commit-79ba863
https://github.com/MylesBorins
test: fs.write() if 3rd argument is a callback, not offsethttps://github.com/nodejs/node/commit/79ba8637d06c2be7e7b58be068501d0aa6cc5a8a
79ba863https://github.com/nodejs/node/commit/79ba8637d06c2be7e7b58be068501d0aa6cc5a8a
#16822https://github.com/nodejs/node/pull/16822
#16827https://github.com/nodejs/node/pull/16827
#17045https://github.com/nodejs/node/pull/17045
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17045#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
gibfahnhttps://github.com/gibfahn
Dec 19, 2017 https://github.com/nodejs/node/pull/17045#ref-commit-c01d934
https://github.com/gibfahn
test: fs.write() if 3rd argument is a callback, not offsethttps://github.com/nodejs/node/commit/c01d934d3d878ec2dee6001d9da8d5b1eea3c419
c01d934https://github.com/nodejs/node/commit/c01d934d3d878ec2dee6001d9da8d5b1eea3c419
#16822https://github.com/nodejs/node/pull/16822
#16827https://github.com/nodejs/node/pull/16827
#17045https://github.com/nodejs/node/pull/17045
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
Dec 19, 2017https://github.com/nodejs/node/pull/17045#event-1394912416
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Dec 19, 2017https://github.com/nodejs/node/pull/17045#event-1394912940
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17045#ref-pullrequest-283423333
v8.9.4 proposal #17772 https://github.com/nodejs/node/pull/17772
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17045#ref-commit-2f276c8
https://github.com/gibfahn
test: fs.write() if 3rd argument is a callback, not offsethttps://github.com/nodejs/node/commit/2f276c894e415108082b46fd8c8f215db9f8aee3
2f276c8https://github.com/nodejs/node/commit/2f276c894e415108082b46fd8c8f215db9f8aee3
#16822https://github.com/nodejs/node/pull/16822
#16827https://github.com/nodejs/node/pull/16827
#17045https://github.com/nodejs/node/pull/17045
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17045#ref-pullrequest-283426801
v8.9.4 proposal #17774 https://github.com/nodejs/node/pull/17774
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17045
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/17045/files/a11d130789447e0118e9c904db7b289728ec9d08
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/17045/files/5e789afd20f4c0c3a10223d0bf7bcddebd63149f
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/17045/files/5e789afd20f4c0c3a10223d0bf7bcddebd63149f
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/17045
https://github.com/PatrickHeneise
https://github.com/addaleax
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/mscdex
https://github.com/MylesBorins
https://github.com/Trott
https://github.com/gibfahn
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.