René's URL Explorer Experiment


Title: src: make ownership of stdio_pipes explicit by fhinkel · Pull Request #17030 · nodejs/node · GitHub

Open Graph Title: src: make ownership of stdio_pipes explicit by fhinkel · Pull Request #17030 · nodejs/node

X Title: src: make ownership of stdio_pipes explicit by fhinkel · Pull Request #17030 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Use smart pointers instead of raw pointers for StdioPipes. Also, use a smart pointer for the array holding them. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message...

X Description: Use smart pointers instead of raw pointers for StdioPipes. Also, use a smart pointer for the array holding them. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message...

Opengraph URL: https://github.com/nodejs/node/pull/17030

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0d4b4bca-42e1-27b9-5e87-30eed086191a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E1E:104998:7595B2:943106:69914C31
html-safe-nonceb00257bb691ace33ea595246c78d3ff79a451237f4d22d201cf52b9b26f2045a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTFFOjEwNDk5ODo3NTk1QjI6OTQzMTA2OjY5OTE0QzMxIiwidmlzaXRvcl9pZCI6IjU3MzgzMTU0MzU4MjYzMDIwMDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbc9ee47932c21b31a9b9973ec987442aa7c475de41196d884cc24f37625e71d5
hovercard-subject-tagpull_request:152624251
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17030/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cce41e0b4db8fe4935030509b892b4aa0187bcb9e791d5966990ef8c08377d81/nodejs/node/pull/17030
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cce41e0b4db8fe4935030509b892b4aa0187bcb9e791d5966990ef8c08377d81/nodejs/node/pull/17030
og:image:altUse smart pointers instead of raw pointers for StdioPipes. Also, use a smart pointer for the array holding them. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefhinkel
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17030#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17030
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17030
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17030
Reloadhttps://github.com/nodejs/node/pull/17030
Reloadhttps://github.com/nodejs/node/pull/17030
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17030
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
fhinkelhttps://github.com/fhinkel
nodejs:masterhttps://github.com/nodejs/node/tree/master
fhinkel:nov/StdioPipeshttps://github.com/fhinkel/node/tree/nov/StdioPipes
Conversationhttps://github.com/nodejs/node/pull/17030
Commits1 (1)https://github.com/nodejs/node/pull/17030/commits
Checkshttps://github.com/nodejs/node/pull/17030/checks
Files changedhttps://github.com/nodejs/node/pull/17030/files
src: make ownership of stdio_pipes explicithttps://github.com/nodejs/node/pull/17030#top
fhinkelhttps://github.com/fhinkel
nodejs:masterhttps://github.com/nodejs/node/tree/master
fhinkel:nov/StdioPipeshttps://github.com/fhinkel/node/tree/nov/StdioPipes
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 14, 2017https://github.com/nodejs/node/pull/17030#issue-273951502
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/17030
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Nov 14, 2017https://github.com/nodejs/node/pull/17030#event-1341822283
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 14, 2017 https://github.com/nodejs/node/pull/17030#pullrequestreview-76604212
View reviewed changes https://github.com/nodejs/node/pull/17030/files
https://github.com/fhinkel
src: make ownership of stdio_pipes explicithttps://github.com/nodejs/node/pull/17030/commits/df5b857ec302624ec9f0f1d828fa0ff59aee32bd
df5b857https://github.com/nodejs/node/pull/17030/commits/df5b857ec302624ec9f0f1d828fa0ff59aee32bd
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
force-pushedhttps://github.com/nodejs/node/compare/dafced2ead8704095e7fb19bec6d72eae13ced0e..df5b857ec302624ec9f0f1d828fa0ff59aee32bd
dafced2https://github.com/nodejs/node/commit/dafced2ead8704095e7fb19bec6d72eae13ced0e
df5b857https://github.com/nodejs/node/commit/df5b857ec302624ec9f0f1d828fa0ff59aee32bd
Compare https://github.com/nodejs/node/compare/dafced2ead8704095e7fb19bec6d72eae13ced0e..df5b857ec302624ec9f0f1d828fa0ff59aee32bd
November 14, 2017 21:53https://github.com/nodejs/node/pull/17030#event-1341851576
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 15, 2017 https://github.com/nodejs/node/pull/17030#ref-pullrequest-274261031
doc: mention smart pointers in Cpp style guide #17055 https://github.com/nodejs/node/pull/17055
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 16, 2017https://github.com/nodejs/node/pull/17030#issuecomment-344968480
b3127cdhttps://github.com/nodejs/node/commit/b3127cd537a62fd02a639333193dde5741ac3a68
Please reload this pagehttps://github.com/nodejs/node/pull/17030
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 16, 2017https://github.com/nodejs/node/pull/17030#event-1345407570
fhinkelhttps://github.com/fhinkel
Nov 16, 2017 https://github.com/nodejs/node/pull/17030#ref-commit-b3127cd
https://github.com/fhinkel
src: make ownership of stdio_pipes explicithttps://github.com/nodejs/node/commit/b3127cd537a62fd02a639333193dde5741ac3a68
b3127cdhttps://github.com/nodejs/node/commit/b3127cd537a62fd02a639333193dde5741ac3a68
#17030https://github.com/nodejs/node/pull/17030
fhinkelhttps://github.com/fhinkel
Nov 17, 2017 https://github.com/nodejs/node/pull/17030#ref-commit-0e1abb1
https://github.com/fhinkel
doc: mention smart pointers in Cpp style guidehttps://github.com/nodejs/node/commit/0e1abb12e2b69f80c401023da6b546ad4f83d59f
0e1abb1https://github.com/nodejs/node/commit/0e1abb12e2b69f80c401023da6b546ad4f83d59f
#17055https://github.com/nodejs/node/pull/17055
#16970https://github.com/nodejs/node/pull/16970
#16974https://github.com/nodejs/node/pull/16974
#17000https://github.com/nodejs/node/pull/17000
#17012https://github.com/nodejs/node/pull/17012
#17020https://github.com/nodejs/node/pull/17020
#17030https://github.com/nodejs/node/pull/17030
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Nov 17, 2017https://github.com/nodejs/node/pull/17030#event-1347509379
MylesBorinshttps://github.com/MylesBorins
Dec 11, 2017 https://github.com/nodejs/node/pull/17030#ref-commit-a1a9957
https://github.com/fhinkel
https://github.com/MylesBorins
src: make ownership of stdio_pipes explicithttps://github.com/nodejs/node/commit/a1a99570aa94a400599907f364376e6e66a545c1
a1a9957https://github.com/nodejs/node/commit/a1a99570aa94a400599907f364376e6e66a545c1
#17030https://github.com/nodejs/node/pull/17030
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17030#ref-commit-03803ee
https://github.com/fhinkel
https://github.com/MylesBorins
doc: mention smart pointers in Cpp style guidehttps://github.com/nodejs/node/commit/03803ee505a455131c5385a470a0691923461401
03803eehttps://github.com/nodejs/node/commit/03803ee505a455131c5385a470a0691923461401
#17055https://github.com/nodejs/node/pull/17055
#16970https://github.com/nodejs/node/pull/16970
#16974https://github.com/nodejs/node/pull/16974
#17000https://github.com/nodejs/node/pull/17000
#17012https://github.com/nodejs/node/pull/17012
#17020https://github.com/nodejs/node/pull/17020
#17030https://github.com/nodejs/node/pull/17030
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17030#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 19, 2017https://github.com/nodejs/node/pull/17030#event-1394847226
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 19, 2017https://github.com/nodejs/node/pull/17030#issuecomment-352867830
Please reload this pagehttps://github.com/nodejs/node/pull/17030
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Dec 19, 2017https://github.com/nodejs/node/pull/17030#event-1394852974
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 19, 2017https://github.com/nodejs/node/pull/17030#issuecomment-352869085
Please reload this pagehttps://github.com/nodejs/node/pull/17030
Please reload this pagehttps://github.com/nodejs/node/pull/17030
gibfahnhttps://github.com/gibfahn
Dec 19, 2017 https://github.com/nodejs/node/pull/17030#ref-commit-f30fcdb
https://github.com/fhinkel
https://github.com/gibfahn
doc: mention smart pointers in Cpp style guidehttps://github.com/nodejs/node/commit/f30fcdb00201281a2b4045d0cd38e36262d3cbea
f30fcdbhttps://github.com/nodejs/node/commit/f30fcdb00201281a2b4045d0cd38e36262d3cbea
#17055https://github.com/nodejs/node/pull/17055
#16970https://github.com/nodejs/node/pull/16970
#16974https://github.com/nodejs/node/pull/16974
#17000https://github.com/nodejs/node/pull/17000
#17012https://github.com/nodejs/node/pull/17012
#17020https://github.com/nodejs/node/pull/17020
#17030https://github.com/nodejs/node/pull/17030
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/17030#ref-commit-706aab9
https://github.com/fhinkel
https://github.com/gibfahn
doc: mention smart pointers in Cpp style guidehttps://github.com/nodejs/node/commit/706aab9d9147e444286609878b50bdb63ced7d85
706aab9https://github.com/nodejs/node/commit/706aab9d9147e444286609878b50bdb63ced7d85
#17055https://github.com/nodejs/node/pull/17055
#16970https://github.com/nodejs/node/pull/16970
#16974https://github.com/nodejs/node/pull/16974
#17000https://github.com/nodejs/node/pull/17000
#17012https://github.com/nodejs/node/pull/17012
#17020https://github.com/nodejs/node/pull/17020
#17030https://github.com/nodejs/node/pull/17030
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17030
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/17030/files/dafced2ead8704095e7fb19bec6d72eae13ced0e
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Please reload this pagehttps://github.com/nodejs/node/pull/17030
https://github.com/fhinkel
https://github.com/MylesBorins
https://github.com/gibfahn
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.