René's URL Explorer Experiment


Title: src: fix bad sizeof expression by bnoordhuis · Pull Request #17014 · nodejs/node · GitHub

Open Graph Title: src: fix bad sizeof expression by bnoordhuis · Pull Request #17014 · nodejs/node

X Title: src: fix bad sizeof expression by bnoordhuis · Pull Request #17014 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: It was computing the size of the pointer, not the size of the pointed-to object. Introduced in commit 727b291 ("src,dns: refactor cares_wrap to avoid global state".) CI: https://ci.nodejs...

X Description: It was computing the size of the pointer, not the size of the pointed-to object. Introduced in commit 727b291 ("src,dns: refactor cares_wrap to avoid global state".) CI: https://c...

Opengraph URL: https://github.com/nodejs/node/pull/17014

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9109fbe1-105f-b448-0a86-bdf7071ad868
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC64:223E3:13D7BFE:192BA2D:699116D1
html-safe-nonceb7728ca3fe026836c8ca6e8ed64005779f8765e3901bc1a204c0b60a0d7063c0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzY0OjIyM0UzOjEzRDdCRkU6MTkyQkEyRDo2OTkxMTZEMSIsInZpc2l0b3JfaWQiOiI4OTcyNTAxNTM4NTc3NjUxNDA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac74464b6464dc58b74305f322c4473f4dbddfbbc0e524c5b9179f006a5e44ea70
hovercard-subject-tagpull_request:152455249
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/17014/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/73a1105d07f24be70548422cfe606d63983f5eb82440dba5de7e75db45d24b75/nodejs/node/pull/17014
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/73a1105d07f24be70548422cfe606d63983f5eb82440dba5de7e75db45d24b75/nodejs/node/pull/17014
og:image:altIt was computing the size of the pointer, not the size of the pointed-to object. Introduced in commit 727b291 ("src,dns: refactor cares_wrap to avoid global state".) CI: https://ci.nodejs...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/17014#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17014
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17014
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/17014
Reloadhttps://github.com/nodejs/node/pull/17014
Reloadhttps://github.com/nodejs/node/pull/17014
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/17014
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-cares-sizeofhttps://github.com/bnoordhuis/io.js/tree/fix-cares-sizeof
Conversationhttps://github.com/nodejs/node/pull/17014
Commits1 (1)https://github.com/nodejs/node/pull/17014/commits
Checkshttps://github.com/nodejs/node/pull/17014/checks
Files changedhttps://github.com/nodejs/node/pull/17014/files
src: fix bad sizeof expressionhttps://github.com/nodejs/node/pull/17014#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-cares-sizeofhttps://github.com/bnoordhuis/io.js/tree/fix-cares-sizeof
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 14, 2017https://github.com/nodejs/node/pull/17014#issue-273725843
Please reload this pagehttps://github.com/nodejs/node/pull/17014
727b291https://github.com/nodejs/node/commit/727b2911eca9f00cb7fa6a5f4ee8a73c7e9c94f0
https://ci.nodejs.org/job/node-test-pull-request/11416/https://ci.nodejs.org/job/node-test-pull-request/11416/
https://ci.nodejs.org/job/node-test-pull-request/11418/https://ci.nodejs.org/job/node-test-pull-request/11418/
Please reload this pagehttps://github.com/nodejs/node/pull/17014
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
Nov 14, 2017https://github.com/nodejs/node/pull/17014#event-1340465342
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 14, 2017 https://github.com/nodejs/node/pull/17014#pullrequestreview-76403317
View reviewed changes https://github.com/nodejs/node/pull/17014/files
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 14, 2017 https://github.com/nodejs/node/pull/17014#pullrequestreview-76437269
View reviewed changes https://github.com/nodejs/node/pull/17014/files
https://github.com/danbev
danbevhttps://github.com/danbev
Nov 14, 2017 https://github.com/nodejs/node/pull/17014#pullrequestreview-76438685
View reviewed changes https://github.com/nodejs/node/pull/17014/files
https://github.com/refack
refackhttps://github.com/refack
Nov 14, 2017 https://github.com/nodejs/node/pull/17014#pullrequestreview-76439617
View reviewed changes https://github.com/nodejs/node/pull/17014/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 14, 2017 https://github.com/nodejs/node/pull/17014#pullrequestreview-76535642
View reviewed changes https://github.com/nodejs/node/pull/17014/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 14, 2017 https://github.com/nodejs/node/pull/17014#pullrequestreview-76537352
View reviewed changes https://github.com/nodejs/node/pull/17014/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 14, 2017 https://github.com/nodejs/node/pull/17014#pullrequestreview-76538600
View reviewed changes https://github.com/nodejs/node/pull/17014/files
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 15, 2017 https://github.com/nodejs/node/pull/17014#pullrequestreview-76734669
View reviewed changes https://github.com/nodejs/node/pull/17014/files
https://github.com/bnoordhuis
src: fix bad sizeof expressionhttps://github.com/nodejs/node/pull/17014/commits/8203ce8316358c91bce455bb0d309cb3b5289d15
8203ce8https://github.com/nodejs/node/pull/17014/commits/8203ce8316358c91bce455bb0d309cb3b5289d15
727b291https://github.com/bnoordhuis/io.js/commit/727b2911eca9f00cb7fa6a5f4ee8a73c7e9c94f0
nodejs#17014https://github.com/nodejs/node/pull/17014
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/4c054aa311a958acdeba1eee35e3136c69e5c6cc..8203ce8316358c91bce455bb0d309cb3b5289d15
4c054aahttps://github.com/nodejs/node/commit/4c054aa311a958acdeba1eee35e3136c69e5c6cc
8203ce8https://github.com/nodejs/node/commit/8203ce8316358c91bce455bb0d309cb3b5289d15
Compare https://github.com/nodejs/node/compare/4c054aa311a958acdeba1eee35e3136c69e5c6cc..8203ce8316358c91bce455bb0d309cb3b5289d15
November 15, 2017 11:12https://github.com/nodejs/node/pull/17014#event-1342779507
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 15, 2017https://github.com/nodejs/node/pull/17014#event-1342779674
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
November 15, 2017 11:12https://github.com/nodejs/node/pull/17014#event-1342779678
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
8203ce8https://github.com/nodejs/node/commit/8203ce8316358c91bce455bb0d309cb3b5289d15
Nov 15, 2017https://github.com/nodejs/node/pull/17014#event-1342780908
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 15, 2017https://github.com/nodejs/node/pull/17014#issuecomment-344561890
8203ce8https://github.com/nodejs/node/commit/8203ce8316358c91bce455bb0d309cb3b5289d15
Please reload this pagehttps://github.com/nodejs/node/pull/17014
MylesBorinshttps://github.com/MylesBorins
Dec 11, 2017 https://github.com/nodejs/node/pull/17014#ref-commit-f6ec5fa
https://github.com/bnoordhuis
https://github.com/MylesBorins
src: fix bad sizeof expressionhttps://github.com/nodejs/node/commit/f6ec5fa4e8876af2f88f575da162b77aa09669d5
f6ec5fahttps://github.com/nodejs/node/commit/f6ec5fa4e8876af2f88f575da162b77aa09669d5
727b291https://github.com/nodejs/node/commit/727b2911eca9f00cb7fa6a5f4ee8a73c7e9c94f0
#17014https://github.com/nodejs/node/pull/17014
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/17014#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 13, 2017 https://github.com/nodejs/node/pull/17014#ref-pullrequest-246115806
dns: enable managing independent channels in JS #14518 https://github.com/nodejs/node/pull/14518
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
Dec 13, 2017https://github.com/nodejs/node/pull/17014#event-1385898106
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 13, 2017https://github.com/nodejs/node/pull/17014#issuecomment-351431864
#14518https://github.com/nodejs/node/pull/14518
Please reload this pagehttps://github.com/nodejs/node/pull/17014
gibfahnhttps://github.com/gibfahn
Dec 13, 2017 https://github.com/nodejs/node/pull/17014#ref-commit-af57990
https://github.com/bnoordhuis
https://github.com/gibfahn
src: fix bad sizeof expressionhttps://github.com/nodejs/node/commit/af579907de829d7fa4ea8e6b50c8c6a8ac157dfb
af57990https://github.com/nodejs/node/commit/af579907de829d7fa4ea8e6b50c8c6a8ac157dfb
727b291https://github.com/nodejs/node/commit/727b2911eca9f00cb7fa6a5f4ee8a73c7e9c94f0
#17014https://github.com/nodejs/node/pull/17014
v8.9.4 proposal #17772 https://github.com/nodejs/node/pull/17772
v8.9.4 proposal #17774 https://github.com/nodejs/node/pull/17774
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Jan 19, 2018https://github.com/nodejs/node/pull/17014#event-1433004148
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17014
https://github.com/fhinkel
fhinkel https://github.com/fhinkel
https://github.com/nodejs/node/pull/17014/files/4c054aa311a958acdeba1eee35e3136c69e5c6cc
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/17014/files/4c054aa311a958acdeba1eee35e3136c69e5c6cc
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/17014/files/4c054aa311a958acdeba1eee35e3136c69e5c6cc
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/17014/files/4c054aa311a958acdeba1eee35e3136c69e5c6cc
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/17014/files/4c054aa311a958acdeba1eee35e3136c69e5c6cc
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/17014/files/4c054aa311a958acdeba1eee35e3136c69e5c6cc
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/17014/files/4c054aa311a958acdeba1eee35e3136c69e5c6cc
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/17014/files/4c054aa311a958acdeba1eee35e3136c69e5c6cc
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
Please reload this pagehttps://github.com/nodejs/node/pull/17014
https://github.com/bnoordhuis
https://github.com/gibfahn
https://github.com/refack
https://github.com/fhinkel
https://github.com/danbev
https://github.com/jasnell
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/gireeshpunathil
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.