| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:ae3fcf12-538b-ba7c-a31c-202b3b773420 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CEAC:1AF714:7BFA1C:9CE76A:69914C70 |
| html-safe-nonce | bb4845705be0e2018870906e18068ce5498596289d74b55c479812477a50412d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUFDOjFBRjcxNDo3QkZBMUM6OUNFNzZBOjY5OTE0QzcwIiwidmlzaXRvcl9pZCI6Ijg3MzgzNjU1MTEwMTQ4OTQ3MDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | bba4867b3bdeaddc392eacd0eb00e11a31868f9a3f6ce2a4ad36ffc4365473be |
| hovercard-subject-tag | pull_request:152436071 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/17010 |
| twitter:image | https://opengraph.githubassets.com/47229564931e089e11d220b2d930e4a8ae77aef713398b5ef1cda359fe7caae3/nodejs/node/pull/17010 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/47229564931e089e11d220b2d930e4a8ae77aef713398b5ef1cda359fe7caae3/nodejs/node/pull/17010 |
| og:image:alt | Currenlty the test target will echo additional information that might
not be that useful, for example:
make doc-only
make[1]: Nothing to be done for `doc-only'.
make lint
Running JS linter...
R... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/17010#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17010 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17010 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/17010 |
| Reload | https://github.com/nodejs/node/pull/17010 |
| Reload | https://github.com/nodejs/node/pull/17010 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/17010 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:reduce-echoing | https://github.com/danbev/node/tree/reduce-echoing |
| Conversation | https://github.com/nodejs/node/pull/17010 |
| Commits1 (1) | https://github.com/nodejs/node/pull/17010/commits |
| Checks | https://github.com/nodejs/node/pull/17010/checks |
| Files changed | https://github.com/nodejs/node/pull/17010/files |
| build: prevent echoing of recipes for test target | https://github.com/nodejs/node/pull/17010#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:reduce-echoing | https://github.com/danbev/node/tree/reduce-echoing |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 14, 2017 | https://github.com/nodejs/node/pull/17010#issue-273699507 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/17010 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Nov 14, 2017 | https://github.com/nodejs/node/pull/17010#event-1340300031 |
|
| https://github.com/danbev |
| build: prevent echoing of recipes for test target | https://github.com/nodejs/node/pull/17010/commits/d56518b87274a75ad2e3dc6f8ce43aefb50a5890 |
| d56518b | https://github.com/nodejs/node/pull/17010/commits/d56518b87274a75ad2e3dc6f8ce43aefb50a5890 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 14, 2017
| https://github.com/nodejs/node/pull/17010#pullrequestreview-76554211 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17010/files/d56518b87274a75ad2e3dc6f8ce43aefb50a5890 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 14, 2017
| https://github.com/nodejs/node/pull/17010#pullrequestreview-76559045 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17010/files/d56518b87274a75ad2e3dc6f8ce43aefb50a5890 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 15, 2017
| https://github.com/nodejs/node/pull/17010#pullrequestreview-76671919 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/17010/files/d56518b87274a75ad2e3dc6f8ce43aefb50a5890 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 15, 2017 | https://github.com/nodejs/node/pull/17010#issuecomment-344481555 |
| https://ci.nodejs.org/job/node-test-pull-request/11442/ | https://ci.nodejs.org/job/node-test-pull-request/11442/ |
| Please reload this page | https://github.com/nodejs/node/pull/17010 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 16, 2017 | https://github.com/nodejs/node/pull/17010#issuecomment-344838949 |
| console output | https://ci.nodejs.org/job/git-nodesource-update-reference/9292/console |
| console output | https://ci.nodejs.org/job/node-test-commit-smartos/nodes=smartos15-64/13130/console |
| Please reload this page | https://github.com/nodejs/node/pull/17010 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 16, 2017 | https://github.com/nodejs/node/pull/17010#issuecomment-344840466 |
| a0b1e2e | https://github.com/nodejs/node/commit/a0b1e2eca684a21e87dd8ae1d5becb4c85e4ddd4 |
| Please reload this page | https://github.com/nodejs/node/pull/17010 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 16, 2017 | https://github.com/nodejs/node/pull/17010#event-1344547476 |
| danbev | https://github.com/danbev |
|
Nov 16, 2017
| https://github.com/nodejs/node/pull/17010#ref-commit-a0b1e2e |
|
| https://github.com/danbev |
| build: prevent echoing of recipes for test target | https://github.com/nodejs/node/commit/a0b1e2eca684a21e87dd8ae1d5becb4c85e4ddd4 |
| a0b1e2e | https://github.com/nodejs/node/commit/a0b1e2eca684a21e87dd8ae1d5becb4c85e4ddd4 |
| #17010 | https://github.com/nodejs/node/pull/17010 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| November 16, 2017 07:49 | https://github.com/nodejs/node/pull/17010#event-1344559018 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 11, 2017
| https://github.com/nodejs/node/pull/17010#ref-commit-578d80b |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
| build: prevent echoing of recipes for test target | https://github.com/nodejs/node/commit/578d80b59bf115a8e7a8e562af3bae4c5c6e59af |
| 578d80b | https://github.com/nodejs/node/commit/578d80b59bf115a8e7a8e562af3bae4c5c6e59af |
| #17010 | https://github.com/nodejs/node/pull/17010 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/17010#ref-pullrequest-281312309 |
|
v9.3.0 proposal
#17631
| https://github.com/nodejs/node/pull/17631 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/17010#event-1394833660 |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/17010#ref-commit-0348dad |
|
| https://github.com/danbev |
|
| https://github.com/gibfahn |
| build: prevent echoing of recipes for test target | https://github.com/nodejs/node/commit/0348dad25ff4fa653c14a6428aba3335bb499c70 |
| 0348dad | https://github.com/nodejs/node/commit/0348dad25ff4fa653c14a6428aba3335bb499c70 |
| #17010 | https://github.com/nodejs/node/pull/17010 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
land-on-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/17010#event-1394834853 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17010#ref-pullrequest-283423333 |
|
v8.9.4 proposal
#17772
| https://github.com/nodejs/node/pull/17772 |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17010#ref-commit-9532e98 |
|
| https://github.com/danbev |
|
| https://github.com/gibfahn |
| build: prevent echoing of recipes for test target | https://github.com/nodejs/node/commit/9532e982dcd89704b7cbce078cb04b0ea1a9bf6e |
| 9532e98 | https://github.com/nodejs/node/commit/9532e982dcd89704b7cbce078cb04b0ea1a9bf6e |
| #17010 | https://github.com/nodejs/node/pull/17010 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/17010#ref-pullrequest-283426801 |
|
v8.9.4 proposal
#17774
| https://github.com/nodejs/node/pull/17774 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F17010 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/17010/files/d56518b87274a75ad2e3dc6f8ce43aefb50a5890 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/17010/files/d56518b87274a75ad2e3dc6f8ce43aefb50a5890 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/17010/files/d56518b87274a75ad2e3dc6f8ce43aefb50a5890 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Please reload this page | https://github.com/nodejs/node/pull/17010 |
|
| https://github.com/danbev |
|
| https://github.com/joyeecheung |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
|
| https://github.com/gibfahn |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |