René's URL Explorer Experiment


Title: src: turn inspector raw pointer into unique_ptr by fhinkel · Pull Request #16974 · nodejs/node · GitHub

Open Graph Title: src: turn inspector raw pointer into unique_ptr by fhinkel · Pull Request #16974 · nodejs/node

X Title: src: turn inspector raw pointer into unique_ptr by fhinkel · Pull Request #16974 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Use a unique pointer to make ownership clear. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affected core subsystem(s) src

X Description: Use a unique pointer to make ownership clear. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affected core subsystem(s) src

Opengraph URL: https://github.com/nodejs/node/pull/16974

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:49dbac83-609b-fd54-2c0e-904c4bba5b0c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA924:5FBC2:2AC38A8:36781A7:6991C387
html-safe-nonceaf7a35e3b8f34c8cc588705847a8badd3425acb834baa57592ea3da39f2989d3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTI0OjVGQkMyOjJBQzM4QTg6MzY3ODFBNzo2OTkxQzM4NyIsInZpc2l0b3JfaWQiOiI4ODc4NDU1MzAxMTIyMTQ3MjA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfe761d6a798c5ab3e47f91e9ef898368e6b5ebe9bf0ee0e25c6a6607e555cf22
hovercard-subject-tagpull_request:152117846
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16974/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c442e0e5b4d3ce83e6cf24f61a1e1cc3c60273cbb08d734967783aaa42583891/nodejs/node/pull/16974
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c442e0e5b4d3ce83e6cf24f61a1e1cc3c60273cbb08d734967783aaa42583891/nodejs/node/pull/16974
og:image:altUse a unique pointer to make ownership clear. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affected core subsystem(s) src
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefhinkel
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16974#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16974
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16974
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16974
Reloadhttps://github.com/nodejs/node/pull/16974
Reloadhttps://github.com/nodejs/node/pull/16974
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16974
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
fhinkelhttps://github.com/fhinkel
nodejs:masterhttps://github.com/nodejs/node/tree/master
fhinkel:nov/uniq_ptr_inspectorhttps://github.com/fhinkel/node/tree/nov/uniq_ptr_inspector
Conversationhttps://github.com/nodejs/node/pull/16974
Commits1 (1)https://github.com/nodejs/node/pull/16974/commits
Checkshttps://github.com/nodejs/node/pull/16974/checks
Files changedhttps://github.com/nodejs/node/pull/16974/files
src: turn inspector raw pointer into unique_ptrhttps://github.com/nodejs/node/pull/16974#top
fhinkelhttps://github.com/fhinkel
nodejs:masterhttps://github.com/nodejs/node/tree/master
fhinkel:nov/uniq_ptr_inspectorhttps://github.com/fhinkel/node/tree/nov/uniq_ptr_inspector
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 12, 2017https://github.com/nodejs/node/pull/16974#issue-273255518
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16974
https://github.com/fhinkel
src: turn inspector raw pointer into unique_ptrhttps://github.com/nodejs/node/pull/16974/commits/f3ba11c0453de61b662efff6e9d0bd4ce8798257
f3ba11chttps://github.com/nodejs/node/pull/16974/commits/f3ba11c0453de61b662efff6e9d0bd4ce8798257
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Nov 12, 2017https://github.com/nodejs/node/pull/16974#event-1337713607
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Nov 12, 2017 https://github.com/nodejs/node/pull/16974#pullrequestreview-75969139
View reviewed changes https://github.com/nodejs/node/pull/16974/files/f3ba11c0453de61b662efff6e9d0bd4ce8798257
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 12, 2017 https://github.com/nodejs/node/pull/16974#pullrequestreview-75970090
View reviewed changes https://github.com/nodejs/node/pull/16974/files/f3ba11c0453de61b662efff6e9d0bd4ce8798257
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 12, 2017 https://github.com/nodejs/node/pull/16974#pullrequestreview-75975429
View reviewed changes https://github.com/nodejs/node/pull/16974/files/f3ba11c0453de61b662efff6e9d0bd4ce8798257
https://github.com/eugeneo
eugeneohttps://github.com/eugeneo
Nov 13, 2017 https://github.com/nodejs/node/pull/16974#pullrequestreview-76174799
View reviewed changes https://github.com/nodejs/node/pull/16974/files/f3ba11c0453de61b662efff6e9d0bd4ce8798257
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 13, 2017https://github.com/nodejs/node/pull/16974#issuecomment-344063179
https://ci.nodejs.org/job/node-test-pull-request/11404/https://ci.nodejs.org/job/node-test-pull-request/11404/
Please reload this pagehttps://github.com/nodejs/node/pull/16974
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 14, 2017https://github.com/nodejs/node/pull/16974#issuecomment-344171912
c07d127https://github.com/nodejs/node/commit/c07d1279b230fc2c178c748b998979cca374c86b
Please reload this pagehttps://github.com/nodejs/node/pull/16974
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 14, 2017https://github.com/nodejs/node/pull/16974#event-1340275558
fhinkelhttps://github.com/fhinkel
Nov 14, 2017 https://github.com/nodejs/node/pull/16974#ref-commit-c07d127
https://github.com/fhinkel
src: turn inspector raw pointer into unique_ptrhttps://github.com/nodejs/node/commit/c07d1279b230fc2c178c748b998979cca374c86b
c07d127https://github.com/nodejs/node/commit/c07d1279b230fc2c178c748b998979cca374c86b
#16974https://github.com/nodejs/node/pull/16974
evanlucashttps://github.com/evanlucas
Nov 14, 2017 https://github.com/nodejs/node/pull/16974#ref-commit-71181b9
https://github.com/fhinkel
https://github.com/evanlucas
src: turn inspector raw pointer into unique_ptrhttps://github.com/nodejs/node/commit/71181b92500d349df594a66ab54cdb59fcf7b64e
71181b9https://github.com/nodejs/node/commit/71181b92500d349df594a66ab54cdb59fcf7b64e
#16974https://github.com/nodejs/node/pull/16974
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 15, 2017 https://github.com/nodejs/node/pull/16974#ref-pullrequest-274261031
doc: mention smart pointers in Cpp style guide #17055 https://github.com/nodejs/node/pull/17055
fhinkelhttps://github.com/fhinkel
Nov 17, 2017 https://github.com/nodejs/node/pull/16974#ref-commit-0e1abb1
https://github.com/fhinkel
doc: mention smart pointers in Cpp style guidehttps://github.com/nodejs/node/commit/0e1abb12e2b69f80c401023da6b546ad4f83d59f
0e1abb1https://github.com/nodejs/node/commit/0e1abb12e2b69f80c401023da6b546ad4f83d59f
#17055https://github.com/nodejs/node/pull/17055
#16970https://github.com/nodejs/node/pull/16970
#16974https://github.com/nodejs/node/pull/16974
#17000https://github.com/nodejs/node/pull/17000
#17012https://github.com/nodejs/node/pull/17012
#17020https://github.com/nodejs/node/pull/17020
#17030https://github.com/nodejs/node/pull/17030
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Nov 17, 2017https://github.com/nodejs/node/pull/16974#event-1347471178
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2017https://github.com/nodejs/node/pull/16974#issuecomment-345291045
Please reload this pagehttps://github.com/nodejs/node/pull/16974
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Nov 17, 2017https://github.com/nodejs/node/pull/16974#event-1347505555
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 17, 2017https://github.com/nodejs/node/pull/16974#issuecomment-345296295
Please reload this pagehttps://github.com/nodejs/node/pull/16974
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 17, 2017https://github.com/nodejs/node/pull/16974#issuecomment-345315989
Please reload this pagehttps://github.com/nodejs/node/pull/16974
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 18, 2017https://github.com/nodejs/node/pull/16974#issuecomment-345442095
Please reload this pagehttps://github.com/nodejs/node/pull/16974
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Nov 18, 2017https://github.com/nodejs/node/pull/16974#event-1348424532
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/16974#ref-commit-03803ee
https://github.com/fhinkel
https://github.com/MylesBorins
doc: mention smart pointers in Cpp style guidehttps://github.com/nodejs/node/commit/03803ee505a455131c5385a470a0691923461401
03803eehttps://github.com/nodejs/node/commit/03803ee505a455131c5385a470a0691923461401
#17055https://github.com/nodejs/node/pull/17055
#16970https://github.com/nodejs/node/pull/16970
#16974https://github.com/nodejs/node/pull/16974
#17000https://github.com/nodejs/node/pull/17000
#17012https://github.com/nodejs/node/pull/17012
#17020https://github.com/nodejs/node/pull/17020
#17030https://github.com/nodejs/node/pull/17030
gibfahnhttps://github.com/gibfahn
Dec 13, 2017 https://github.com/nodejs/node/pull/16974#ref-commit-b1802ed
https://github.com/fhinkel
https://github.com/gibfahn
src: turn inspector raw pointer into unique_ptrhttps://github.com/nodejs/node/commit/b1802ede3be1ebc3ab0f4d290c6b5eb27d503b74
b1802edhttps://github.com/nodejs/node/commit/b1802ede3be1ebc3ab0f4d290c6b5eb27d503b74
#16974https://github.com/nodejs/node/pull/16974
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Dec 13, 2017https://github.com/nodejs/node/pull/16974#event-1385964003
gibfahnhttps://github.com/gibfahn
Dec 19, 2017 https://github.com/nodejs/node/pull/16974#ref-commit-f30fcdb
https://github.com/fhinkel
https://github.com/gibfahn
doc: mention smart pointers in Cpp style guidehttps://github.com/nodejs/node/commit/f30fcdb00201281a2b4045d0cd38e36262d3cbea
f30fcdbhttps://github.com/nodejs/node/commit/f30fcdb00201281a2b4045d0cd38e36262d3cbea
#17055https://github.com/nodejs/node/pull/17055
#16970https://github.com/nodejs/node/pull/16970
#16974https://github.com/nodejs/node/pull/16974
#17000https://github.com/nodejs/node/pull/17000
#17012https://github.com/nodejs/node/pull/17012
#17020https://github.com/nodejs/node/pull/17020
#17030https://github.com/nodejs/node/pull/17030
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/16974#ref-pullrequest-283423333
v8.9.4 proposal #17772 https://github.com/nodejs/node/pull/17772
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/16974#ref-commit-706aab9
https://github.com/fhinkel
https://github.com/gibfahn
doc: mention smart pointers in Cpp style guidehttps://github.com/nodejs/node/commit/706aab9d9147e444286609878b50bdb63ced7d85
706aab9https://github.com/nodejs/node/commit/706aab9d9147e444286609878b50bdb63ced7d85
#17055https://github.com/nodejs/node/pull/17055
#16970https://github.com/nodejs/node/pull/16970
#16974https://github.com/nodejs/node/pull/16974
#17000https://github.com/nodejs/node/pull/17000
#17012https://github.com/nodejs/node/pull/17012
#17020https://github.com/nodejs/node/pull/17020
#17030https://github.com/nodejs/node/pull/17030
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/16974#ref-pullrequest-283426801
v8.9.4 proposal #17774 https://github.com/nodejs/node/pull/17774
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16974
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16974/files/f3ba11c0453de61b662efff6e9d0bd4ce8798257
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/16974/files/f3ba11c0453de61b662efff6e9d0bd4ce8798257
https://github.com/eugeneo
eugeneo https://github.com/eugeneo
https://github.com/nodejs/node/pull/16974/files/f3ba11c0453de61b662efff6e9d0bd4ce8798257
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/16974/files/f3ba11c0453de61b662efff6e9d0bd4ce8798257
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/16974
https://github.com/fhinkel
https://github.com/MylesBorins
https://github.com/bnoordhuis
https://github.com/eugeneo
https://github.com/jasnell
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/gibfahn
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.