René's URL Explorer Experiment


Title: src: use unique_ptr in platform implementation by fhinkel · Pull Request #16970 · nodejs/node · GitHub

Open Graph Title: src: use unique_ptr in platform implementation by fhinkel · Pull Request #16970 · nodejs/node

X Title: src: use unique_ptr in platform implementation by fhinkel · Pull Request #16970 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Replace raw pointers in task queues with std::unique_ptr. This makes ownership clearer. The future V8 platform interface uses smart pointers, so I figured we could change the implementation proacti...

X Description: Replace raw pointers in task queues with std::unique_ptr. This makes ownership clearer. The future V8 platform interface uses smart pointers, so I figured we could change the implementation proacti...

Opengraph URL: https://github.com/nodejs/node/pull/16970

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:24928609-2c1c-6704-da0d-8f57c9ac9007
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B38:223E3:98371F:C0BE02:6990F124
html-safe-nonce10cfbca2761ad78a7447b508c47e2baff6d96aacc2fffc2b19828fa2b5d4e573
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjM4OjIyM0UzOjk4MzcxRjpDMEJFMDI6Njk5MEYxMjQiLCJ2aXNpdG9yX2lkIjoiNDc0ODc0ODA4OTA1MDM2MDY4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac20c4c668602715654f2a05f7edcce6735bbb24222685a9d35b374904648f661e
hovercard-subject-tagpull_request:152111937
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16970/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/71bc3a30e715999e17516a1bbb873140ecb2c8b4a0584c3ac7d76aacbc737559/nodejs/node/pull/16970
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/71bc3a30e715999e17516a1bbb873140ecb2c8b4a0584c3ac7d76aacbc737559/nodejs/node/pull/16970
og:image:altReplace raw pointers in task queues with std::unique_ptr. This makes ownership clearer. The future V8 platform interface uses smart pointers, so I figured we could change the implementation proacti...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefhinkel
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16970#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16970
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16970
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16970
Reloadhttps://github.com/nodejs/node/pull/16970
Reloadhttps://github.com/nodejs/node/pull/16970
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16970
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 705 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
fhinkelhttps://github.com/fhinkel
nodejs:masterhttps://github.com/nodejs/node/tree/master
fhinkel:nov/unique_ptrshttps://github.com/fhinkel/node/tree/nov/unique_ptrs
Conversationhttps://github.com/nodejs/node/pull/16970
Commits1 (1)https://github.com/nodejs/node/pull/16970/commits
Checkshttps://github.com/nodejs/node/pull/16970/checks
Files changedhttps://github.com/nodejs/node/pull/16970/files
src: use unique_ptr in platform implementationhttps://github.com/nodejs/node/pull/16970#top
fhinkelhttps://github.com/fhinkel
nodejs:masterhttps://github.com/nodejs/node/tree/master
fhinkel:nov/unique_ptrshttps://github.com/fhinkel/node/tree/nov/unique_ptrs
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 12, 2017https://github.com/nodejs/node/pull/16970#issue-273243954
Please reload this pagehttps://github.com/nodejs/node/pull/16970
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16970
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Nov 12, 2017https://github.com/nodejs/node/pull/16970#event-1337663280
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 12, 2017 https://github.com/nodejs/node/pull/16970#pullrequestreview-75964507
View reviewed changes https://github.com/nodejs/node/pull/16970/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 12, 2017 https://github.com/nodejs/node/pull/16970#pullrequestreview-75966374
View reviewed changes https://github.com/nodejs/node/pull/16970/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 12, 2017 https://github.com/nodejs/node/pull/16970#pullrequestreview-75975617
View reviewed changes https://github.com/nodejs/node/pull/16970/files
src/node_platform.cchttps://github.com/nodejs/node/pull/16970/files#diff-78e69a909901b85513156eeca4ae6d9704a51081daa1bf9a5fd48fdf22b5170b
cjihrighttps://github.com/cjihrig
Nov 12, 2017https://github.com/nodejs/node/pull/16970#discussion_r150427708
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16970
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 13, 2017 https://github.com/nodejs/node/pull/16970#pullrequestreview-75996542
View reviewed changes https://github.com/nodejs/node/pull/16970/files
https://github.com/fhinkel
src: use unique_ptr in platform implementationhttps://github.com/nodejs/node/pull/16970/commits/edf55ea4fc4eece3f651e4e13183adc74d3ab7d8
edf55eahttps://github.com/nodejs/node/pull/16970/commits/edf55ea4fc4eece3f651e4e13183adc74d3ab7d8
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
force-pushedhttps://github.com/nodejs/node/compare/e8449e9eb2dbb74cf9960ffc5afc7752d72a9ad8..edf55ea4fc4eece3f651e4e13183adc74d3ab7d8
e8449e9https://github.com/nodejs/node/commit/e8449e9eb2dbb74cf9960ffc5afc7752d72a9ad8
edf55eahttps://github.com/nodejs/node/commit/edf55ea4fc4eece3f651e4e13183adc74d3ab7d8
Compare https://github.com/nodejs/node/compare/e8449e9eb2dbb74cf9960ffc5afc7752d72a9ad8..edf55ea4fc4eece3f651e4e13183adc74d3ab7d8
November 13, 2017 08:07https://github.com/nodejs/node/pull/16970#event-1338168622
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 13, 2017https://github.com/nodejs/node/pull/16970#issuecomment-344062971
https://ci.nodejs.org/job/node-test-pull-request/11403/https://ci.nodejs.org/job/node-test-pull-request/11403/
Please reload this pagehttps://github.com/nodejs/node/pull/16970
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 14, 2017https://github.com/nodejs/node/pull/16970#issuecomment-344170047
8101042https://github.com/nodejs/node/commit/81010421c54770f2c604ec29d192a3d2c2406ae0
Please reload this pagehttps://github.com/nodejs/node/pull/16970
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 14, 2017https://github.com/nodejs/node/pull/16970#event-1340264419
fhinkelhttps://github.com/fhinkel
Nov 14, 2017 https://github.com/nodejs/node/pull/16970#ref-commit-8101042
https://github.com/fhinkel
src: use unique_ptr in platform implementationhttps://github.com/fhinkel/node/commit/81010421c54770f2c604ec29d192a3d2c2406ae0
8101042https://github.com/fhinkel/node/commit/81010421c54770f2c604ec29d192a3d2c2406ae0
nodejs#16970https://github.com/nodejs/node/pull/16970
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 15, 2017 https://github.com/nodejs/node/pull/16970#ref-pullrequest-274261031
doc: mention smart pointers in Cpp style guide #17055 https://github.com/nodejs/node/pull/17055
fhinkelhttps://github.com/fhinkel
Nov 17, 2017 https://github.com/nodejs/node/pull/16970#ref-commit-0e1abb1
https://github.com/fhinkel
doc: mention smart pointers in Cpp style guidehttps://github.com/nodejs/node/commit/0e1abb12e2b69f80c401023da6b546ad4f83d59f
0e1abb1https://github.com/nodejs/node/commit/0e1abb12e2b69f80c401023da6b546ad4f83d59f
#17055https://github.com/nodejs/node/pull/17055
#16970https://github.com/nodejs/node/pull/16970
#16974https://github.com/nodejs/node/pull/16974
#17000https://github.com/nodejs/node/pull/17000
#17012https://github.com/nodejs/node/pull/17012
#17020https://github.com/nodejs/node/pull/17020
#17030https://github.com/nodejs/node/pull/17030
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Nov 17, 2017https://github.com/nodejs/node/pull/16970#event-1347504659
MylesBorinshttps://github.com/MylesBorins
Dec 11, 2017 https://github.com/nodejs/node/pull/16970#ref-commit-8522e24
https://github.com/fhinkel
https://github.com/MylesBorins
src: use unique_ptr in platform implementationhttps://github.com/nodejs/node/commit/8522e2420da41791a6fa64557039cc66ef27264e
8522e24https://github.com/nodejs/node/commit/8522e2420da41791a6fa64557039cc66ef27264e
#16970https://github.com/nodejs/node/pull/16970
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/16970#ref-commit-03803ee
https://github.com/fhinkel
https://github.com/MylesBorins
doc: mention smart pointers in Cpp style guidehttps://github.com/nodejs/node/commit/03803ee505a455131c5385a470a0691923461401
03803eehttps://github.com/nodejs/node/commit/03803ee505a455131c5385a470a0691923461401
#17055https://github.com/nodejs/node/pull/17055
#16970https://github.com/nodejs/node/pull/16970
#16974https://github.com/nodejs/node/pull/16974
#17000https://github.com/nodejs/node/pull/17000
#17012https://github.com/nodejs/node/pull/17012
#17020https://github.com/nodejs/node/pull/17020
#17030https://github.com/nodejs/node/pull/17030
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/16970#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
gibfahnhttps://github.com/gibfahn
Dec 19, 2017 https://github.com/nodejs/node/pull/16970#ref-commit-f30fcdb
https://github.com/fhinkel
https://github.com/gibfahn
doc: mention smart pointers in Cpp style guidehttps://github.com/nodejs/node/commit/f30fcdb00201281a2b4045d0cd38e36262d3cbea
f30fcdbhttps://github.com/nodejs/node/commit/f30fcdb00201281a2b4045d0cd38e36262d3cbea
#17055https://github.com/nodejs/node/pull/17055
#16970https://github.com/nodejs/node/pull/16970
#16974https://github.com/nodejs/node/pull/16974
#17000https://github.com/nodejs/node/pull/17000
#17012https://github.com/nodejs/node/pull/17012
#17020https://github.com/nodejs/node/pull/17020
#17030https://github.com/nodejs/node/pull/17030
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/16970#ref-commit-706aab9
https://github.com/fhinkel
https://github.com/gibfahn
doc: mention smart pointers in Cpp style guidehttps://github.com/nodejs/node/commit/706aab9d9147e444286609878b50bdb63ced7d85
706aab9https://github.com/nodejs/node/commit/706aab9d9147e444286609878b50bdb63ced7d85
#17055https://github.com/nodejs/node/pull/17055
#16970https://github.com/nodejs/node/pull/16970
#16974https://github.com/nodejs/node/pull/16974
#17000https://github.com/nodejs/node/pull/17000
#17012https://github.com/nodejs/node/pull/17012
#17020https://github.com/nodejs/node/pull/17020
#17030https://github.com/nodejs/node/pull/17030
addaleaxhttps://github.com/addaleax
May 22, 2018 https://github.com/nodejs/node/pull/16970#ref-commit-916fa14
https://github.com/fhinkel
https://github.com/addaleax
src: use unique_ptr in platform implementationhttps://github.com/addaleax/node/commit/916fa14a6a6c7968527aa7aa3232a1ff59a3b411
916fa14https://github.com/addaleax/node/commit/916fa14a6a6c7968527aa7aa3232a1ff59a3b411
nodejs#16970https://github.com/nodejs/node/pull/16970
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 22, 2018 https://github.com/nodejs/node/pull/16970#ref-pullrequest-325491899
[v8.x] backport some V8 platform changes #20901 https://github.com/nodejs/node/pull/20901
MylesBorinshttps://github.com/MylesBorins
Jun 14, 2018 https://github.com/nodejs/node/pull/16970#ref-commit-becb2df
https://github.com/fhinkel
https://github.com/MylesBorins
src: use unique_ptr in platform implementationhttps://github.com/nodejs/node/commit/becb2df8349fea6dd567bd2000633e27812997a0
becb2dfhttps://github.com/nodejs/node/commit/becb2df8349fea6dd567bd2000633e27812997a0
#20901https://github.com/nodejs/node/pull/20901
#16970https://github.com/nodejs/node/pull/16970
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 9, 2018 https://github.com/nodejs/node/pull/16970#ref-pullrequest-337147468
v8.12.0 proposal #21593 https://github.com/nodejs/node/pull/21593
rvagghttps://github.com/rvagg
Aug 16, 2018 https://github.com/nodejs/node/pull/16970#ref-commit-2148b19
https://github.com/fhinkel
https://github.com/rvagg
src: use unique_ptr in platform implementationhttps://github.com/nodejs/node/commit/2148b1921e9e71aeeb3cc46cde4c6991bafa82b2
2148b19https://github.com/nodejs/node/commit/2148b1921e9e71aeeb3cc46cde4c6991bafa82b2
#20901https://github.com/nodejs/node/pull/20901
#16970https://github.com/nodejs/node/pull/16970
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
v8 platform https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20platform%22
Feb 18, 2020https://github.com/nodejs/node/pull/16970#event-3048579924
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16970
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16970/files/e8449e9eb2dbb74cf9960ffc5afc7752d72a9ad8
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/16970/files/e8449e9eb2dbb74cf9960ffc5afc7752d72a9ad8
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/16970/files/e8449e9eb2dbb74cf9960ffc5afc7752d72a9ad8
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/16970/files/e8449e9eb2dbb74cf9960ffc5afc7752d72a9ad8
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
v8 platform https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20platform%22
Please reload this pagehttps://github.com/nodejs/node/pull/16970
https://github.com/fhinkel
https://github.com/jasnell
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/gireeshpunathil
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.