René's URL Explorer Experiment


Title: src: fix SetClientCertEngine() nullptr dereference by bnoordhuis · Pull Request #16965 · nodejs/node · GitHub

Open Graph Title: src: fix SetClientCertEngine() nullptr dereference by bnoordhuis · Pull Request #16965 · nodejs/node

X Title: src: fix SetClientCertEngine() nullptr dereference by bnoordhuis · Pull Request #16965 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Introduced in commit 6ee985f ("tls: implement clientCertEngine option") which was merged yesterday. CI: https://ci.nodejs.org/job/node-test-pull-request/11376/

X Description: Introduced in commit 6ee985f ("tls: implement clientCertEngine option") which was merged yesterday. CI: https://ci.nodejs.org/job/node-test-pull-request/11376/

Opengraph URL: https://github.com/nodejs/node/pull/16965

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:674d4280-69c8-43d1-1ff4-45ab9a02edd4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD874:DC787:4043BE:509E76:69911CFE
html-safe-nonce428a4585301478b55c67786c9569f94a097d8e1c4700ad6e3f42a51dbaf41647
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODc0OkRDNzg3OjQwNDNCRTo1MDlFNzY6Njk5MTFDRkUiLCJ2aXNpdG9yX2lkIjoiMTE4NTg4MzQzNDc1NDU3OTcxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace866e681dce13ff1d138e3efa42818dae07d41b2319d4998443a743894aa0bd3
hovercard-subject-tagpull_request:152106209
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16965/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/588a769086412f431c05ea8f4de4f3efc92203269bf11206d51c38223c4ab7c2/nodejs/node/pull/16965
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/588a769086412f431c05ea8f4de4f3efc92203269bf11206d51c38223c4ab7c2/nodejs/node/pull/16965
og:image:altIntroduced in commit 6ee985f ("tls: implement clientCertEngine option") which was merged yesterday. CI: https://ci.nodejs.org/job/node-test-pull-request/11376/
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16965#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16965
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16965
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16965
Reloadhttps://github.com/nodejs/node/pull/16965
Reloadhttps://github.com/nodejs/node/pull/16965
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16965
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-nullptr-derefhttps://github.com/bnoordhuis/io.js/tree/fix-nullptr-deref
Conversationhttps://github.com/nodejs/node/pull/16965
Commits1 (1)https://github.com/nodejs/node/pull/16965/commits
Checkshttps://github.com/nodejs/node/pull/16965/checks
Files changedhttps://github.com/nodejs/node/pull/16965/files
src: fix SetClientCertEngine() nullptr dereferencehttps://github.com/nodejs/node/pull/16965#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-nullptr-derefhttps://github.com/bnoordhuis/io.js/tree/fix-nullptr-deref
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 12, 2017https://github.com/nodejs/node/pull/16965#issue-273233952
Please reload this pagehttps://github.com/nodejs/node/pull/16965
6ee985fhttps://github.com/nodejs/node/commit/6ee985f311de14621c440377f76d0391b6b23320
https://ci.nodejs.org/job/node-test-pull-request/11376/https://ci.nodejs.org/job/node-test-pull-request/11376/
Please reload this pagehttps://github.com/nodejs/node/pull/16965
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Nov 12, 2017https://github.com/nodejs/node/pull/16965#event-1337614910
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 12, 2017 https://github.com/nodejs/node/pull/16965#ref-pullrequest-273229769
crypto: check SecureContext existence #16964 https://github.com/nodejs/node/pull/16964
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 12, 2017 https://github.com/nodejs/node/pull/16965#pullrequestreview-75960591
View reviewed changes https://github.com/nodejs/node/pull/16965/files
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 12, 2017 https://github.com/nodejs/node/pull/16965#ref-pullrequest-251089718
Openssl clientcertengine support2 #14903 https://github.com/nodejs/node/pull/14903
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 12, 2017 https://github.com/nodejs/node/pull/16965#pullrequestreview-75964297
View reviewed changes https://github.com/nodejs/node/pull/16965/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 12, 2017 https://github.com/nodejs/node/pull/16965#pullrequestreview-75966669
View reviewed changes https://github.com/nodejs/node/pull/16965/files
https://github.com/bnoordhuis
src: fix SetClientCertEngine() nullptr dereferencehttps://github.com/nodejs/node/pull/16965/commits/6c76140a7a61d0030af5e869b4c0e0b038460b05
6c76140https://github.com/nodejs/node/pull/16965/commits/6c76140a7a61d0030af5e869b4c0e0b038460b05
6ee985fhttps://github.com/bnoordhuis/io.js/commit/6ee985f311de14621c440377f76d0391b6b23320
nodejs#16965https://github.com/nodejs/node/pull/16965
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/d2bf0b1e6c4dce89a36fa80462637520537b3caa..6c76140a7a61d0030af5e869b4c0e0b038460b05
d2bf0b1https://github.com/nodejs/node/commit/d2bf0b1e6c4dce89a36fa80462637520537b3caa
6c76140https://github.com/nodejs/node/commit/6c76140a7a61d0030af5e869b4c0e0b038460b05
Compare https://github.com/nodejs/node/compare/d2bf0b1e6c4dce89a36fa80462637520537b3caa..6c76140a7a61d0030af5e869b4c0e0b038460b05
November 15, 2017 11:16https://github.com/nodejs/node/pull/16965#event-1342786416
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 15, 2017https://github.com/nodejs/node/pull/16965#event-1342786574
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
November 15, 2017 11:16https://github.com/nodejs/node/pull/16965#event-1342786576
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
6c76140https://github.com/nodejs/node/commit/6c76140a7a61d0030af5e869b4c0e0b038460b05
Nov 15, 2017https://github.com/nodejs/node/pull/16965#event-1342787596
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 15, 2017https://github.com/nodejs/node/pull/16965#issuecomment-344562881
6c76140https://github.com/nodejs/node/commit/6c76140a7a61d0030af5e869b4c0e0b038460b05
Please reload this pagehttps://github.com/nodejs/node/pull/16965
MylesBorinshttps://github.com/MylesBorins
Dec 11, 2017 https://github.com/nodejs/node/pull/16965#ref-commit-7ac760b
https://github.com/bnoordhuis
https://github.com/MylesBorins
src: fix SetClientCertEngine() nullptr dereferencehttps://github.com/nodejs/node/commit/7ac760b603e6e3f97bbf7b499b788d0d917d3969
7ac760bhttps://github.com/nodejs/node/commit/7ac760b603e6e3f97bbf7b499b788d0d917d3969
6ee985fhttps://github.com/nodejs/node/commit/6ee985f311de14621c440377f76d0391b6b23320
#16965https://github.com/nodejs/node/pull/16965
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/16965#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 19, 2017https://github.com/nodejs/node/pull/16965#event-1394808040
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 19, 2017https://github.com/nodejs/node/pull/16965#issuecomment-352861997
#14903https://github.com/nodejs/node/pull/14903
Please reload this pagehttps://github.com/nodejs/node/pull/16965
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Feb 27, 2018https://github.com/nodejs/node/pull/16965#event-1493461764
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 17, 2018https://github.com/nodejs/node/pull/16965#issuecomment-413980345
#14903https://github.com/nodejs/node/pull/14903
Please reload this pagehttps://github.com/nodejs/node/pull/16965
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Sep 19, 2019https://github.com/nodejs/node/pull/16965#event-2648187816
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16965
https://github.com/fhinkel
fhinkel https://github.com/fhinkel
https://github.com/nodejs/node/pull/16965/files/d2bf0b1e6c4dce89a36fa80462637520537b3caa
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16965/files/d2bf0b1e6c4dce89a36fa80462637520537b3caa
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/16965/files/d2bf0b1e6c4dce89a36fa80462637520537b3caa
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/16965
https://github.com/bnoordhuis
https://github.com/gibfahn
https://github.com/jasnell
https://github.com/fhinkel
https://github.com/cjihrig
https://github.com/MylesBorins
https://github.com/BethGriggs
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.