René's URL Explorer Experiment


Title: tty, test: refactor exports and add coverage by cjihrig · Pull Request #16959 · nodejs/node · GitHub

Open Graph Title: tty, test: refactor exports and add coverage by cjihrig · Pull Request #16959 · nodejs/node

X Title: tty, test: refactor exports and add coverage by cjihrig · Pull Request #16959 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR updates the tty module's exports to be more aligned with other core modules. It also adds test coverage (I believe to 100%). Checklist make -j4 test (UNIX), or vcbuild test (Windows) ...

X Description: This PR updates the tty module's exports to be more aligned with other core modules. It also adds test coverage (I believe to 100%). Checklist make -j4 test (UNIX), or vcbuild test (Windo...

Opengraph URL: https://github.com/nodejs/node/pull/16959

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e9c4435e-6f0c-b023-096b-73a46801969b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE5C:1D2AD7:A08187:CD66F3:6990F107
html-safe-noncea020bab13e3f206ab76d6773c5dda362a5899efb9ecf3a33253c1d8a30f8cb15
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTVDOjFEMkFENzpBMDgxODc6Q0Q2NkYzOjY5OTBGMTA3IiwidmlzaXRvcl9pZCI6IjQ4NTcyMzc5MjkxMDAxMTIxMzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac225542d65599ff4c7fd512ed7506c7d906c39b4913cedc6fc3a06e3b09f175bd
hovercard-subject-tagpull_request:152089402
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16959/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/39fce632c962e4cc3709efb0fd96af1ecb501aff70680a2a9b1b048e4bb1db50/nodejs/node/pull/16959
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/39fce632c962e4cc3709efb0fd96af1ecb501aff70680a2a9b1b048e4bb1db50/nodejs/node/pull/16959
og:image:altThis PR updates the tty module's exports to be more aligned with other core modules. It also adds test coverage (I believe to 100%). Checklist make -j4 test (UNIX), or vcbuild test (Windows) ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16959#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16959
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16959
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16959
Reloadhttps://github.com/nodejs/node/pull/16959
Reloadhttps://github.com/nodejs/node/pull/16959
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16959
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 705 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:ttyhttps://github.com/cjihrig/node/tree/tty
Conversationhttps://github.com/nodejs/node/pull/16959
Commits2 (2)https://github.com/nodejs/node/pull/16959/commits
Checkshttps://github.com/nodejs/node/pull/16959/checks
Files changedhttps://github.com/nodejs/node/pull/16959/files
tty, test: refactor exports and add coveragehttps://github.com/nodejs/node/pull/16959#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:ttyhttps://github.com/cjihrig/node/tree/tty
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 12, 2017https://github.com/nodejs/node/pull/16959#issue-273203588
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16959
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tty https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atty
Nov 12, 2017https://github.com/nodejs/node/pull/16959#event-1337475582
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 12, 2017 https://github.com/nodejs/node/pull/16959#pullrequestreview-75950778
View reviewed changes https://github.com/nodejs/node/pull/16959/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 12, 2017 https://github.com/nodejs/node/pull/16959#pullrequestreview-75966831
View reviewed changes https://github.com/nodejs/node/pull/16959/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 13, 2017 https://github.com/nodejs/node/pull/16959#pullrequestreview-75979275
View reviewed changes https://github.com/nodejs/node/pull/16959/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 14, 2017https://github.com/nodejs/node/pull/16959#issuecomment-344412052
https://ci.nodejs.org/job/node-test-pull-request/11438/https://ci.nodejs.org/job/node-test-pull-request/11438/
Please reload this pagehttps://github.com/nodejs/node/pull/16959
cjihrighttps://github.com/cjihrig
November 14, 2017 17:31https://github.com/nodejs/node/pull/16959#commits-pushed-8ae4e1c
https://github.com/cjihrig
tty: refactor exportshttps://github.com/nodejs/node/pull/16959/commits/8ae4e1cd7b5688b1a719d2104eef0fadfbdcacc9
8ae4e1chttps://github.com/nodejs/node/pull/16959/commits/8ae4e1cd7b5688b1a719d2104eef0fadfbdcacc9
nodejs#16959https://github.com/nodejs/node/pull/16959
https://github.com/cjihrig
test: add coverage to tty modulehttps://github.com/nodejs/node/pull/16959/commits/4b5a8160a4d624b35802616aaa5a79617cd3e8b2
4b5a816https://github.com/nodejs/node/pull/16959/commits/4b5a8160a4d624b35802616aaa5a79617cd3e8b2
nodejs#16959https://github.com/nodejs/node/pull/16959
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/3271833cd3096850cd234e2e9ecb674b3528340a..4b5a8160a4d624b35802616aaa5a79617cd3e8b2
3271833https://github.com/nodejs/node/commit/3271833cd3096850cd234e2e9ecb674b3528340a
4b5a816https://github.com/nodejs/node/commit/4b5a8160a4d624b35802616aaa5a79617cd3e8b2
Compare https://github.com/nodejs/node/compare/3271833cd3096850cd234e2e9ecb674b3528340a..4b5a8160a4d624b35802616aaa5a79617cd3e8b2
November 14, 2017 22:39https://github.com/nodejs/node/pull/16959#event-1341926256
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 14, 2017https://github.com/nodejs/node/pull/16959#issuecomment-344423812
Please reload this pagehttps://github.com/nodejs/node/pull/16959
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
4b5a816https://github.com/nodejs/node/commit/4b5a8160a4d624b35802616aaa5a79617cd3e8b2
Nov 14, 2017https://github.com/nodejs/node/pull/16959#event-1341928697
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
November 14, 2017 22:41https://github.com/nodejs/node/pull/16959#event-1341929588
MylesBorinshttps://github.com/MylesBorins
Dec 11, 2017 https://github.com/nodejs/node/pull/16959#ref-commit-4e3aa9a
https://github.com/cjihrig
https://github.com/MylesBorins
tty: refactor exportshttps://github.com/nodejs/node/commit/4e3aa9a8998c9a6835c3970ef8a317a6a875e0e3
4e3aa9ahttps://github.com/nodejs/node/commit/4e3aa9a8998c9a6835c3970ef8a317a6a875e0e3
#16959https://github.com/nodejs/node/pull/16959
MylesBorinshttps://github.com/MylesBorins
Dec 11, 2017 https://github.com/nodejs/node/pull/16959#ref-commit-f80cf5a
https://github.com/cjihrig
https://github.com/MylesBorins
test: add coverage to tty modulehttps://github.com/nodejs/node/commit/f80cf5a33d9f18376854152da65c621f8df97c45
f80cf5ahttps://github.com/nodejs/node/commit/f80cf5a33d9f18376854152da65c621f8df97c45
#16959https://github.com/nodejs/node/pull/16959
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/16959#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
gibfahnhttps://github.com/gibfahn
Dec 13, 2017 https://github.com/nodejs/node/pull/16959#ref-commit-d176073
https://github.com/cjihrig
https://github.com/gibfahn
tty: refactor exportshttps://github.com/nodejs/node/commit/d17607351153b6f7639e41e8b286ceadfc4fe66d
d176073https://github.com/nodejs/node/commit/d17607351153b6f7639e41e8b286ceadfc4fe66d
#16959https://github.com/nodejs/node/pull/16959
gibfahnhttps://github.com/gibfahn
Dec 13, 2017 https://github.com/nodejs/node/pull/16959#ref-commit-c18a450
https://github.com/cjihrig
https://github.com/gibfahn
test: add coverage to tty modulehttps://github.com/nodejs/node/commit/c18a450e9d8570f112a3b07f78a65803eb6c0fe4
c18a450https://github.com/nodejs/node/commit/c18a450e9d8570f112a3b07f78a65803eb6c0fe4
#16959https://github.com/nodejs/node/pull/16959
gibfahnhttps://github.com/gibfahn
Dec 13, 2017 https://github.com/nodejs/node/pull/16959#ref-commit-5ee05f2
https://github.com/cjihrig
https://github.com/gibfahn
tty: refactor exportshttps://github.com/nodejs/node/commit/5ee05f21870bfb29da2f15e0c99c87023ef5d8ea
5ee05f2https://github.com/nodejs/node/commit/5ee05f21870bfb29da2f15e0c99c87023ef5d8ea
#16959https://github.com/nodejs/node/pull/16959
gibfahnhttps://github.com/gibfahn
Dec 13, 2017 https://github.com/nodejs/node/pull/16959#ref-commit-ad331f2
https://github.com/cjihrig
https://github.com/gibfahn
test: add coverage to tty modulehttps://github.com/nodejs/node/commit/ad331f20bd580c983cb4797ccd72423e10aecfe3
ad331f2https://github.com/nodejs/node/commit/ad331f20bd580c983cb4797ccd72423e10aecfe3
#16959https://github.com/nodejs/node/pull/16959
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
Dec 13, 2017https://github.com/nodejs/node/pull/16959#event-1385912531
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 13, 2017https://github.com/nodejs/node/pull/16959#issuecomment-351435723
@cjihrighttps://github.com/cjihrig
8ae4e1chttps://github.com/nodejs/node/commit/8ae4e1cd7b5688b1a719d2104eef0fadfbdcacc9
4b5a816https://github.com/nodejs/node/commit/4b5a8160a4d624b35802616aaa5a79617cd3e8b2
Please reload this pagehttps://github.com/nodejs/node/pull/16959
v8.9.4 proposal #17772 https://github.com/nodejs/node/pull/17772
v8.9.4 proposal #17774 https://github.com/nodejs/node/pull/17774
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 20, 2017 https://github.com/nodejs/node/pull/16959#ref-pullrequest-283432791
v6.12.3 proposal #17776 https://github.com/nodejs/node/pull/17776
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16959
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16959/files/3271833cd3096850cd234e2e9ecb674b3528340a
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/16959/files/3271833cd3096850cd234e2e9ecb674b3528340a
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/16959/files/3271833cd3096850cd234e2e9ecb674b3528340a
tty https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atty
Please reload this pagehttps://github.com/nodejs/node/pull/16959
https://github.com/cjihrig
https://github.com/gibfahn
https://github.com/jasnell
https://github.com/addaleax
https://github.com/gireeshpunathil
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.