| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:40871011-e87a-d922-6c48-7a7df772fa87 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A5C:11E8DC:FAB83:13438B:6990F130 |
| html-safe-nonce | ee612cb71d63f411dc34ac0adb9beccaee53ba464bc8a3bdca0587784b203213 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTVDOjExRThEQzpGQUI4MzoxMzQzOEI6Njk5MEYxMzAiLCJ2aXNpdG9yX2lkIjoiOTEzNjc2OTcxNjk4ODc2NzIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4c7e9958dbfd420ea5fa48d01fa70349188170c2837b071236adc1a67017b9cd |
| hovercard-subject-tag | pull_request:152062080 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16954/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e6197d27a68a337a3447e2cac9061536d36f73d039524f1ef837f947876f5090/nodejs/node/pull/16954 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e6197d27a68a337a3447e2cac9061536d36f73d039524f1ef837f947876f5090/nodejs/node/pull/16954 |
| og:image:alt | Remove the practice of starting most error descriptions with "Used when"
or wordier variations.
Change errors of the form:
Used when the type of an asynchronous resource is invalid.
...... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/16954#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16954 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16954 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/16954 |
| Reload | https://github.com/nodejs/node/pull/16954 |
| Reload | https://github.com/nodejs/node/pull/16954 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
705
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:used-when | https://github.com/Trott/io.js/tree/used-when |
| Conversation | https://github.com/nodejs/node/pull/16954 |
| Commits6 (6) | https://github.com/nodejs/node/pull/16954/commits |
| Checks | https://github.com/nodejs/node/pull/16954/checks |
| Files changed | https://github.com/nodejs/node/pull/16954/files |
| doc: make error descriptions more concise | https://github.com/nodejs/node/pull/16954#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:used-when | https://github.com/Trott/io.js/tree/used-when |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16954#issue-273154088 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16954#event-1337269955 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16954#event-1337269964 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
|
Nov 11, 2017
| https://github.com/nodejs/node/pull/16954#pullrequestreview-75944055 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16954/files |
| maclover7 | https://github.com/maclover7 |
| https://github.com/nodejs/node/pull/16954#pullrequestreview-75944055 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| maclover7 | https://github.com/maclover7 |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r150395501 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| Trott | https://github.com/Trott |
| Nov 12, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r150411452 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| maclover7 | https://github.com/maclover7 |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r150395524 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| Trott | https://github.com/Trott |
| Nov 12, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r150411494 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| maclover7 | https://github.com/maclover7 |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r150395583 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| Trott | https://github.com/Trott |
| Nov 12, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r150411529 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| maclover7 | https://github.com/maclover7 |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r150395602 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| Trott | https://github.com/Trott |
| Nov 12, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r150411496 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 12, 2017
| https://github.com/nodejs/node/pull/16954#pullrequestreview-75946950 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16954/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/16954#pullrequestreview-75946950 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 12, 2017
| https://github.com/nodejs/node/pull/16954#pullrequestreview-75951178 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16954/files |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Nov 12, 2017
| https://github.com/nodejs/node/pull/16954#pullrequestreview-75953998 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16954/files |
| benjamingr | https://github.com/benjamingr |
| https://github.com/nodejs/node/pull/16954#pullrequestreview-75953998 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @maclover7 | https://github.com/maclover7 |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/6e1bab8614e0c1b3060d2a882c32df9ae8809cc7..37b691333c07d169c4deb3ca2a532fff6e71e307 |
| 6e1bab8 | https://github.com/nodejs/node/commit/6e1bab8614e0c1b3060d2a882c32df9ae8809cc7 |
| 37b6913 | https://github.com/nodejs/node/commit/37b691333c07d169c4deb3ca2a532fff6e71e307 |
|
Compare
| https://github.com/nodejs/node/compare/6e1bab8614e0c1b3060d2a882c32df9ae8809cc7..37b691333c07d169c4deb3ca2a532fff6e71e307 |
| November 12, 2017 14:00 | https://github.com/nodejs/node/pull/16954#event-1337608849 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Nov 12, 2017
| https://github.com/nodejs/node/pull/16954#pullrequestreview-75960055 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16954/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 12, 2017 | https://github.com/nodejs/node/pull/16954#issuecomment-343739523 |
| @benjamingr | https://github.com/benjamingr |
| @maclover7 | https://github.com/maclover7 |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| Nov 12, 2017 | https://github.com/nodejs/node/pull/16954#issuecomment-343739922 |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 12, 2017 | https://github.com/nodejs/node/pull/16954#issuecomment-343743198 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 14, 2017 | https://github.com/nodejs/node/pull/16954#issuecomment-344368364 |
| https://ci.nodejs.org/job/node-test-pull-request/11435/ | https://ci.nodejs.org/job/node-test-pull-request/11435/ |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 14, 2017
| https://github.com/nodejs/node/pull/16954#ref-pullrequest-271646898 |
|
crypto: Better docs for cases where peer's public key is invalid
#16849
| https://github.com/nodejs/node/pull/16849 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Nov 15, 2017
| https://github.com/nodejs/node/pull/16954#pullrequestreview-76737387 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16954/files |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 15, 2017
| https://github.com/nodejs/node/pull/16954#pullrequestreview-76753699 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16954/files |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/16954#pullrequestreview-76753699 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Nov 15, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r151101962 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Nov 15, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r151102036 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Nov 15, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r151102085 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Nov 15, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r151102532 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Nov 15, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r151102880 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Nov 15, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r151110427 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Nov 15, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r151110539 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Nov 15, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r151110665 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Nov 15, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r151110703 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| Trott | https://github.com/Trott |
| Nov 15, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r151273687 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/16954/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Nov 15, 2017 | https://github.com/nodejs/node/pull/16954#discussion_r151110835 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| Trott | https://github.com/Trott |
| November 15, 2017 14:38 | https://github.com/nodejs/node/pull/16954#commits-pushed-6ecae9d |
|
| https://github.com/Trott |
| doc: make error descriptions more concise | https://github.com/nodejs/node/pull/16954/commits/6ecae9d555126af3cd4c2e23b367fe79b7253cad |
| 6ecae9d | https://github.com/nodejs/node/pull/16954/commits/6ecae9d555126af3cd4c2e23b367fe79b7253cad |
|
| https://github.com/Trott |
| squash: fix errors that have landed since this opened | https://github.com/nodejs/node/pull/16954/commits/b9e372cc3be6b8d3ead4e8cb6144ba425b0dea1a |
| b9e372c | https://github.com/nodejs/node/pull/16954/commits/b9e372cc3be6b8d3ead4e8cb6144ba425b0dea1a |
|
| https://github.com/Trott |
| squash: cpuUsage nit from maclover7 | https://github.com/nodejs/node/pull/16954/commits/2edcd00706380bcbf97820d572ae13b267677772 |
| 2edcd00 | https://github.com/nodejs/node/pull/16954/commits/2edcd00706380bcbf97820d572ae13b267677772 |
|
| https://github.com/Trott |
| squash: comma nits from maclover7 | https://github.com/nodejs/node/pull/16954/commits/5fadfe0f718a5c538a0aefddac88812b01a375a7 |
| 5fadfe0 | https://github.com/nodejs/node/pull/16954/commits/5fadfe0f718a5c538a0aefddac88812b01a375a7 |
|
| https://github.com/Trott |
| squash: HTTP/2 nit from maclover7 | https://github.com/nodejs/node/pull/16954/commits/b9fd33040df0682dd10545e8fdda0b03a5f7d147 |
| b9fd330 | https://github.com/nodejs/node/pull/16954/commits/b9fd33040df0682dd10545e8fdda0b03a5f7d147 |
|
| https://github.com/Trott |
| squash: mega-nits from joyee | https://github.com/nodejs/node/pull/16954/commits/f85b90d1232d5ea1c1c538fd2c954a7fb63f6327 |
| f85b90d | https://github.com/nodejs/node/pull/16954/commits/f85b90d1232d5ea1c1c538fd2c954a7fb63f6327 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 15, 2017 | https://github.com/nodejs/node/pull/16954#issuecomment-344763890 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/cb2ece2dee82ce2857988a522fc7f6b177fb8e92..f85b90d1232d5ea1c1c538fd2c954a7fb63f6327 |
| cb2ece2 | https://github.com/nodejs/node/commit/cb2ece2dee82ce2857988a522fc7f6b177fb8e92 |
| f85b90d | https://github.com/nodejs/node/commit/f85b90d1232d5ea1c1c538fd2c954a7fb63f6327 |
|
Compare
| https://github.com/nodejs/node/compare/cb2ece2dee82ce2857988a522fc7f6b177fb8e92..f85b90d1232d5ea1c1c538fd2c954a7fb63f6327 |
| November 15, 2017 23:28 | https://github.com/nodejs/node/pull/16954#event-1344097942 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 16, 2017
| https://github.com/nodejs/node/pull/16954#pullrequestreview-77032899 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16954/files/f85b90d1232d5ea1c1c538fd2c954a7fb63f6327 |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/16954#pullrequestreview-77032899 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16954#issuecomment-345107547 |
| https://ci.nodejs.org/job/node-test-pull-request/11488/ | https://ci.nodejs.org/job/node-test-pull-request/11488/ |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| Trott | https://github.com/Trott |
|
Nov 17, 2017
| https://github.com/nodejs/node/pull/16954#ref-commit-959c425 |
|
| https://github.com/Trott |
| doc: make error descriptions more concise | https://github.com/Trott/io.js/commit/959c425a19d22b5e2dc3941bb0f0ec1fe62f45d7 |
| 959c425 | https://github.com/Trott/io.js/commit/959c425a19d22b5e2dc3941bb0f0ec1fe62f45d7 |
| nodejs#16954 | https://github.com/nodejs/node/pull/16954 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16954#issuecomment-345316889 |
| 959c425 | https://github.com/nodejs/node/commit/959c425a19d22b5e2dc3941bb0f0ec1fe62f45d7 |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16954#event-1347635918 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backport-requested-v9.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v9.x |
| Dec 11, 2017 | https://github.com/nodejs/node/pull/16954#event-1382417853 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 11, 2017 | https://github.com/nodejs/node/pull/16954#issuecomment-350874975 |
| the guide | https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| Trott | https://github.com/Trott |
|
Dec 11, 2017
| https://github.com/nodejs/node/pull/16954#ref-commit-63b7af6 |
|
| https://github.com/Trott |
| doc: make error descriptions more concise | https://github.com/Trott/io.js/commit/63b7af6761de0a07688757cb29aff24e54835f5d |
| 63b7af6 | https://github.com/Trott/io.js/commit/63b7af6761de0a07688757cb29aff24e54835f5d |
| nodejs#16954 | https://github.com/nodejs/node/pull/16954 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 11, 2017
| https://github.com/nodejs/node/pull/16954#ref-pullrequest-281204687 |
|
[v9.x backport] doc: make error descriptions more concise
#17622
| https://github.com/nodejs/node/pull/17622 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 11, 2017 | https://github.com/nodejs/node/pull/16954#issuecomment-350893883 |
| @MylesBorins | https://github.com/MylesBorins |
| #17622 | https://github.com/nodejs/node/pull/17622 |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
backport-requested-v9.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v9.x |
| Dec 11, 2017 | https://github.com/nodejs/node/pull/16954#event-1382536217 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/16954#ref-commit-ad75a7d |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: make error descriptions more concise | https://github.com/nodejs/node/commit/ad75a7da3ff99d89c15d293e66dec55c16d3488f |
| ad75a7d | https://github.com/nodejs/node/commit/ad75a7da3ff99d89c15d293e66dec55c16d3488f |
| #17622 | https://github.com/nodejs/node/pull/17622 |
| #16954 | https://github.com/nodejs/node/pull/16954 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backported-to-v9.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v9.x |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/16954#event-1382870654 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/16954#ref-commit-aebef6e |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: make error descriptions more concise | https://github.com/nodejs/node/commit/aebef6e54dd0e8a220c810165cf53ff4d2c38616 |
| aebef6e | https://github.com/nodejs/node/commit/aebef6e54dd0e8a220c810165cf53ff4d2c38616 |
| #17622 | https://github.com/nodejs/node/pull/17622 |
| #16954 | https://github.com/nodejs/node/pull/16954 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/16954#ref-commit-dcd87ac |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: make error descriptions more concise | https://github.com/nodejs/node/commit/dcd87acb7b237a8957224ea9399e94cf740b4a7a |
| dcd87ac | https://github.com/nodejs/node/commit/dcd87acb7b237a8957224ea9399e94cf740b4a7a |
| #17622 | https://github.com/nodejs/node/pull/17622 |
| #16954 | https://github.com/nodejs/node/pull/16954 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/16954#ref-pullrequest-281312309 |
|
v9.3.0 proposal
#17631
| https://github.com/nodejs/node/pull/17631 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/16954#issuecomment-352909652 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
backport-requested-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/16954#event-1395118281 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
|
backport-requested-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/16954#event-1395141610 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/16954#issuecomment-352913772 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| Trott | https://github.com/Trott |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/16954#ref-commit-5f87262 |
|
| https://github.com/Trott |
| doc: make error descriptions more concise | https://github.com/Trott/io.js/commit/5f87262981d6dde8d27fd159590383fc003de82c |
| 5f87262 | https://github.com/Trott/io.js/commit/5f87262981d6dde8d27fd159590383fc003de82c |
| nodejs#16954 | https://github.com/nodejs/node/pull/16954 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/16954#ref-pullrequest-283399648 |
|
[v8.x backport] doc: make error descriptions more concise
#17767
| https://github.com/nodejs/node/pull/17767 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 19, 2017 | https://github.com/nodejs/node/pull/16954#issuecomment-352915704 |
| @gibfahn | https://github.com/gibfahn |
| #17767 | https://github.com/nodejs/node/pull/17767 |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/16954#ref-commit-8bab2db |
|
| https://github.com/Trott |
|
| https://github.com/gibfahn |
| doc: make error descriptions more concise | https://github.com/nodejs/node/commit/8bab2db6017b5286e83f173db04b7cb62fb4404e |
| 8bab2db | https://github.com/nodejs/node/commit/8bab2db6017b5286e83f173db04b7cb62fb4404e |
| #16954 | https://github.com/nodejs/node/pull/16954 |
| #17767 | https://github.com/nodejs/node/pull/17767 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
backported-to-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v8.x |
|
backport-requested-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x |
| Dec 20, 2017 | https://github.com/nodejs/node/pull/16954#event-1395288898 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/16954#ref-pullrequest-283423333 |
|
v8.9.4 proposal
#17772
| https://github.com/nodejs/node/pull/17772 |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/16954#ref-commit-37564ea |
|
| https://github.com/Trott |
|
| https://github.com/gibfahn |
| doc: make error descriptions more concise | https://github.com/nodejs/node/commit/37564eae09c79de3d2ae8da56d54822aa672aa48 |
| 37564ea | https://github.com/nodejs/node/commit/37564eae09c79de3d2ae8da56d54822aa672aa48 |
| #16954 | https://github.com/nodejs/node/pull/16954 |
| #17767 | https://github.com/nodejs/node/pull/17767 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/16954#ref-pullrequest-283426801 |
|
v8.9.4 proposal
#17774
| https://github.com/nodejs/node/pull/17774 |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/16954#ref-commit-9a06d98 |
|
| https://github.com/Trott |
|
| https://github.com/gibfahn |
| doc: make error descriptions more concise | https://github.com/nodejs/node/commit/9a06d988fd95533eb80763ff1261e9bb7345283f |
| 9a06d98 | https://github.com/nodejs/node/commit/9a06d988fd95533eb80763ff1261e9bb7345283f |
| #16954 | https://github.com/nodejs/node/pull/16954 |
| #17767 | https://github.com/nodejs/node/pull/17767 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:47 | https://github.com/nodejs/node/pull/16954#event-5890955957 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16954 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/16954/files/6e1bab8614e0c1b3060d2a882c32df9ae8809cc7 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/16954/files/db2ed3e06d2852d37db2dc3cb16cab10e23ef8be |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/16954/files/cb2ece2dee82ce2857988a522fc7f6b177fb8e92 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/16954/files/f85b90d1232d5ea1c1c538fd2c954a7fb63f6327 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/16954/files/6e1bab8614e0c1b3060d2a882c32df9ae8809cc7 |
|
| https://github.com/maclover7 |
|
maclover7
| https://github.com/maclover7 |
|
| https://github.com/nodejs/node/pull/16954/files/6e1bab8614e0c1b3060d2a882c32df9ae8809cc7 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
| Please reload this page | https://github.com/nodejs/node/pull/16954 |
|
| https://github.com/Trott |
|
| https://github.com/maclover7 |
|
| https://github.com/benjamingr |
|
| https://github.com/MylesBorins |
|
| https://github.com/gibfahn |
|
| https://github.com/jasnell |
|
| https://github.com/tniessen |
|
| https://github.com/joyeecheung |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |