| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fcc339be-2b82-4d8c-eb55-86f2e388a37b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DCFC:2A33E:2641A:2DF96:6991525F |
| html-safe-nonce | 3cfaeedfe3b3a4cdfdc5d4507c6d7b9fb19279068300434a74b8260408bdc754 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0ZDOjJBMzNFOjI2NDFBOjJERjk2OjY5OTE1MjVGIiwidmlzaXRvcl9pZCI6IjcxMDc4NzcyMTI1NTcyMzQ3ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 62c91fc80c114181a1b629cc00b447d610a7ebd07fb23138dea2f6cbc743d36d |
| hovercard-subject-tag | pull_request:151987223 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16941/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ea40400b37a0830d71a7366af6e71413e06e39584f4a461a377db62301e980c4/nodejs/node/pull/16941 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ea40400b37a0830d71a7366af6e71413e06e39584f4a461a377db62301e980c4/nodejs/node/pull/16941 |
| og:image:alt | test-inspector-async-hook-setup-at-signal is also flaky on VS2017
Refs: #16771
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit mes... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | refack |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/16941#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16941 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16941 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/16941 |
| Reload | https://github.com/nodejs/node/pull/16941 |
| Reload | https://github.com/nodejs/node/pull/16941 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/16941 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| refack:test-inspector-async-hook-setup-at-signal-flake | https://github.com/refack/node/tree/test-inspector-async-hook-setup-at-signal-flake |
| Conversation | https://github.com/nodejs/node/pull/16941 |
| Commits1 (1) | https://github.com/nodejs/node/pull/16941/commits |
| Checks | https://github.com/nodejs/node/pull/16941/checks |
| Files changed | https://github.com/nodejs/node/pull/16941/files |
| test: test-inspector-async-hook-setup-at-signal flag as flaky | https://github.com/nodejs/node/pull/16941#top |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| refack:test-inspector-async-hook-setup-at-signal-flake | https://github.com/refack/node/tree/test-inspector-async-hook-setup-at-signal-flake |
|
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 10, 2017 | https://github.com/nodejs/node/pull/16941#issue-273038030 |
| #16771 | https://github.com/nodejs/node/issues/16771 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/16941 |
|
| https://github.com/refack |
| test: flag known flake | https://github.com/nodejs/node/pull/16941/commits/e9ec7ee9a1a9068a9d876cd3f3a687ebeb29fd7e |
| e9ec7ee | https://github.com/nodejs/node/pull/16941/commits/e9ec7ee9a1a9068a9d876cd3f3a687ebeb29fd7e |
| https://github.com/refack |
| refack | https://github.com/refack |
|
flaky-test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test |
|
inspector
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Nov 10, 2017 | https://github.com/nodejs/node/pull/16941#event-1336682946 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 10, 2017 | https://github.com/nodejs/node/pull/16941#event-1336683046 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 10, 2017
| https://github.com/nodejs/node/pull/16941#pullrequestreview-75861964 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16941/files/e9ec7ee9a1a9068a9d876cd3f3a687ebeb29fd7e |
| https://github.com/refack |
| refack | https://github.com/refack |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Nov 10, 2017 | https://github.com/nodejs/node/pull/16941#event-1336685031 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 10, 2017 | https://github.com/nodejs/node/pull/16941#issuecomment-343567663 |
| https://github.com/nodejs/node/projects/8 | https://github.com/nodejs/node/projects/8 |
| Please reload this page | https://github.com/nodejs/node/pull/16941 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 10, 2017 | https://github.com/nodejs/node/pull/16941#event-1336688698 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 11, 2017
| https://github.com/nodejs/node/pull/16941#pullrequestreview-75925157 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16941/files/e9ec7ee9a1a9068a9d876cd3f3a687ebeb29fd7e |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16941#issuecomment-343644506 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/16941 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16941#issuecomment-343645007 |
| 074a5c7 | https://github.com/nodejs/node/commit/074a5c79d42e0f29b8fd3b60ab21c52771a19078 |
| Please reload this page | https://github.com/nodejs/node/pull/16941 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16941#event-1337141987 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16941#issuecomment-343648925 |
| Please reload this page | https://github.com/nodejs/node/pull/16941 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Nov 13, 2017 | https://github.com/nodejs/node/pull/16941#issuecomment-343955617 |
| 074a5c7 | https://github.com/nodejs/node/commit/074a5c79d42e0f29b8fd3b60ab21c52771a19078 |
| Please reload this page | https://github.com/nodejs/node/pull/16941 |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16941#ref-commit-074a5c7 |
|
| https://github.com/refack |
|
| https://github.com/gireeshpunathil |
| test: flag known flake | https://github.com/nodejs/node/commit/074a5c79d42e0f29b8fd3b60ab21c52771a19078 |
|
| https://github.com/nodejs/node/commit/074a5c79d42e0f29b8fd3b60ab21c52771a19078#comments |
| 074a5c7 | https://github.com/nodejs/node/commit/074a5c79d42e0f29b8fd3b60ab21c52771a19078 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 13, 2017 | https://github.com/nodejs/node/pull/16941#issuecomment-343957241 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/16941 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 6, 2017 | https://github.com/nodejs/node/pull/16941#issuecomment-349774806 |
| Please reload this page | https://github.com/nodejs/node/pull/16941 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/16941 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Dec 6, 2017 | https://github.com/nodejs/node/pull/16941#event-1375663746 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Dec 6, 2017 | https://github.com/nodejs/node/pull/16941#event-1375669379 |
| https://github.com/refack |
| refack | https://github.com/refack |
| December 6, 2017 21:13 | https://github.com/nodejs/node/pull/16941#event-1375669442 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/16941#ref-commit-3b1db7f |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| test: flag known flake | https://github.com/nodejs/node/commit/3b1db7f54bc7dee4b40617573a77267a3f25dc1f |
|
| https://github.com/nodejs/node/commit/3b1db7f54bc7dee4b40617573a77267a3f25dc1f#comments |
| 3b1db7f | https://github.com/nodejs/node/commit/3b1db7f54bc7dee4b40617573a77267a3f25dc1f |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/16941#ref-commit-ea1efca |
|
| https://github.com/refack |
|
| https://github.com/gibfahn |
| test: flag known flake | https://github.com/nodejs/node/commit/ea1efca16a5aad22848181b52213d822b41f2e27 |
| ea1efca | https://github.com/nodejs/node/commit/ea1efca16a5aad22848181b52213d822b41f2e27 |
| #16941 | https://github.com/nodejs/node/pull/16941 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/16941#ref-pullrequest-283423333 |
|
v8.9.4 proposal
#17772
| https://github.com/nodejs/node/pull/17772 |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/16941#ref-commit-8528a5d |
|
| https://github.com/refack |
|
| https://github.com/gibfahn |
| test: flag known flake | https://github.com/nodejs/node/commit/8528a5d5f0228ca4071dcac25fb4c7e3688a5b88 |
| 8528a5d | https://github.com/nodejs/node/commit/8528a5d5f0228ca4071dcac25fb4c7e3688a5b88 |
| #16941 | https://github.com/nodejs/node/pull/16941 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 20, 2017
| https://github.com/nodejs/node/pull/16941#ref-pullrequest-283426801 |
|
v8.9.4 proposal
#17774
| https://github.com/nodejs/node/pull/17774 |
|
[Snyk] Security upgrade gatsby from 2.13.73 to 2.13.75
kissofire/node#4
| https://github.com/kissofire/node/pull/4 |
|
[Snyk] Security upgrade gatsby from 2.13.73 to 2.13.75
meghasfdc/node#5
| https://github.com/meghasfdc/node/pull/5 |
| https://github.com/snyk-bot |
| snyk-bot | https://github.com/snyk-bot |
|
Jul 15, 2022
| https://github.com/nodejs/node/pull/16941#ref-pullrequest-1305868434 |
|
[Snyk] Security upgrade gatsby from 2.13.73 to 2.13.75
kissofire/node#72
| https://github.com/kissofire/node/pull/72 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16941 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/16941/files/e9ec7ee9a1a9068a9d876cd3f3a687ebeb29fd7e |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/16941/files/e9ec7ee9a1a9068a9d876cd3f3a687ebeb29fd7e |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
flaky-test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test |
|
inspector
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Please reload this page | https://github.com/nodejs/node/pull/16941 |
|
| https://github.com/refack |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/targos |
|
| https://github.com/MylesBorins |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |