| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7384c82c-bfdf-e290-7c37-2b1cb2ea62cd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9744:A4C82:17C7BD9:1E5F87A:6991AA94 |
| html-safe-nonce | 25ee4a3dc4f4f8462f54fc41bec88e95c54c0d203bba8f911f90f51c23470ccf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzQ0OkE0QzgyOjE3QzdCRDk6MUU1Rjg3QTo2OTkxQUE5NCIsInZpc2l0b3JfaWQiOiI2MjMzMzQwNTk3NDI1NTE1MTU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 98e0086c342195f0ecfc1f2005c9091573f194c054131ed6142559e2cda38502 |
| hovercard-subject-tag | pull_request:151829153 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16912/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c735eae590e5dafce7e87ddf39ffc377b9a483a45a916cd259135c91d1331a76/nodejs/node/pull/16912 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c735eae590e5dafce7e87ddf39ffc377b9a483a45a916cd259135c91d1331a76/nodejs/node/pull/16912 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines
Affected core... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Anaweshak |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/16912#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16912 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16912 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/16912 |
| Reload | https://github.com/nodejs/node/pull/16912 |
| Reload | https://github.com/nodejs/node/pull/16912 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/16912 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
712
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Anaweshak | https://github.com/Anaweshak |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Anaweshak:test | https://github.com/Anaweshak/node/tree/test |
| Conversation | https://github.com/nodejs/node/pull/16912 |
| Commits2 (2) | https://github.com/nodejs/node/pull/16912/commits |
| Checks | https://github.com/nodejs/node/pull/16912/checks |
| Files changed | https://github.com/nodejs/node/pull/16912/files |
| Modified method console.log of loop.js; | https://github.com/nodejs/node/pull/16912#top |
| Anaweshak | https://github.com/Anaweshak |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Anaweshak:test | https://github.com/Anaweshak/node/tree/test |
|
| https://github.com/Anaweshak |
| Anaweshak | https://github.com/Anaweshak |
| Nov 10, 2017 | https://github.com/nodejs/node/pull/16912#issue-272823515 |
| Please reload this page | https://github.com/nodejs/node/pull/16912 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/16912 |
|
| https://github.com/Anaweshak |
| Modified method console.log of loop.js; | https://github.com/nodejs/node/pull/16912/commits/1283137d02637e1a406316b43785eea051d1e7d2 |
| 1283137 | https://github.com/nodejs/node/pull/16912/commits/1283137d02637e1a406316b43785eea051d1e7d2 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 10, 2017 | https://github.com/nodejs/node/pull/16912#event-1335430902 |
| https://github.com/sreepurnajasti |
| sreepurnajasti | https://github.com/sreepurnajasti |
|
Nov 10, 2017
| https://github.com/nodejs/node/pull/16912#pullrequestreview-75667349 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16912/files/1283137d02637e1a406316b43785eea051d1e7d2 |
| test/fixtures/loop.js | https://github.com/nodejs/node/pull/16912/files/1283137d02637e1a406316b43785eea051d1e7d2#diff-f724d85ec4afacdef488ecfaab48cc3c0e652920bfd7e4ed3ed6af02050e09ab |
| sreepurnajasti | https://github.com/sreepurnajasti |
| Nov 10, 2017 | https://github.com/nodejs/node/pull/16912#discussion_r150157802 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16912 |
|
| https://github.com/Anaweshak |
| Fixed the back-tick issue | https://github.com/nodejs/node/pull/16912/commits/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
| f65bb6b | https://github.com/nodejs/node/pull/16912/commits/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 10, 2017
| https://github.com/nodejs/node/pull/16912#pullrequestreview-75678069 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16912/files/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 10, 2017 | https://github.com/nodejs/node/pull/16912#event-1335530469 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Nov 10, 2017
| https://github.com/nodejs/node/pull/16912#pullrequestreview-75707502 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16912/files/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 10, 2017
| https://github.com/nodejs/node/pull/16912#pullrequestreview-75732872 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16912/files/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Nov 10, 2017
| https://github.com/nodejs/node/pull/16912#pullrequestreview-75743614 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16912/files/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 10, 2017
| https://github.com/nodejs/node/pull/16912#pullrequestreview-75763472 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16912/files/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
|
Nov 11, 2017
| https://github.com/nodejs/node/pull/16912#pullrequestreview-75927863 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16912/files/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16912#issuecomment-343652317 |
| https://ci.nodejs.org/job/node-test-pull-request/11355/ | https://ci.nodejs.org/job/node-test-pull-request/11355/ |
| Please reload this page | https://github.com/nodejs/node/pull/16912 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16912#issuecomment-343655772 |
| @Anaweshak | https://github.com/Anaweshak |
| fa86eba | https://github.com/nodejs/node/commit/fa86ebafa30f99ae385c8a952db0a701538c3477 |
| Please reload this page | https://github.com/nodejs/node/pull/16912 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16912#event-1337188178 |
| fhinkel | https://github.com/fhinkel |
|
Nov 11, 2017
| https://github.com/nodejs/node/pull/16912#ref-commit-fa86eba |
|
| https://github.com/Anaweshak |
|
| https://github.com/fhinkel |
| test: change concatenated string to template | https://github.com/nodejs/node/commit/fa86ebafa30f99ae385c8a952db0a701538c3477 |
| fa86eba | https://github.com/nodejs/node/commit/fa86ebafa30f99ae385c8a952db0a701538c3477 |
| #16912 | https://github.com/nodejs/node/pull/16912 |
| evanlucas | https://github.com/evanlucas |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16912#ref-commit-1ea546c |
|
| https://github.com/Anaweshak |
|
| https://github.com/evanlucas |
| test: change concatenated string to template | https://github.com/nodejs/node/commit/1ea546c9eeff64d064571e73bc7741ec7fbcf311 |
| 1ea546c | https://github.com/nodejs/node/commit/1ea546c9eeff64d064571e73bc7741ec7fbcf311 |
| #16912 | https://github.com/nodejs/node/pull/16912 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16912#ref-pullrequest-273462029 |
|
v9.2.0 proposal
#16992
| https://github.com/nodejs/node/pull/16992 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2017
| https://github.com/nodejs/node/pull/16912#ref-commit-91e2ed4 |
|
| https://github.com/Anaweshak |
|
| https://github.com/MylesBorins |
| test: change concatenated string to template | https://github.com/nodejs/node/commit/91e2ed4b742b46e9564e22d66d360128ff0520d6 |
| 91e2ed4 | https://github.com/nodejs/node/commit/91e2ed4b742b46e9564e22d66d360128ff0520d6 |
| #16912 | https://github.com/nodejs/node/pull/16912 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16912#event-1347428239 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2017
| https://github.com/nodejs/node/pull/16912#ref-commit-7168a7e |
|
| https://github.com/Anaweshak |
|
| https://github.com/MylesBorins |
| test: change concatenated string to template | https://github.com/nodejs/node/commit/7168a7e044f1567848b75b3d07b170f641369a46 |
| 7168a7e | https://github.com/nodejs/node/commit/7168a7e044f1567848b75b3d07b170f641369a46 |
| #16912 | https://github.com/nodejs/node/pull/16912 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Nov 21, 2017
| https://github.com/nodejs/node/pull/16912#ref-pullrequest-275888281 |
|
v8.9.2 proposal
#17204
| https://github.com/nodejs/node/pull/17204 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 21, 2017
| https://github.com/nodejs/node/pull/16912#ref-pullrequest-275653593 |
|
v6.12.1 proposal
#17180
| https://github.com/nodejs/node/pull/17180 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 21, 2017
| https://github.com/nodejs/node/pull/16912#ref-commit-b65ff6e |
|
| https://github.com/Anaweshak |
|
| https://github.com/MylesBorins |
| test: change concatenated string to template | https://github.com/nodejs/node/commit/b65ff6ecb2c9c9c86fc8b0865e54d7a6a7163d9f |
| b65ff6e | https://github.com/nodejs/node/commit/b65ff6ecb2c9c9c86fc8b0865e54d7a6a7163d9f |
| #16912 | https://github.com/nodejs/node/pull/16912 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 28, 2017
| https://github.com/nodejs/node/pull/16912#ref-commit-79dfc3f |
|
| https://github.com/Anaweshak |
|
| https://github.com/MylesBorins |
| test: change concatenated string to template | https://github.com/nodejs/node/commit/79dfc3f47559df180a9f4656954ff5079680dfd9 |
| 79dfc3f | https://github.com/nodejs/node/commit/79dfc3f47559df180a9f4656954ff5079680dfd9 |
| #16912 | https://github.com/nodejs/node/pull/16912 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16912 |
|
| https://github.com/fhinkel |
|
fhinkel
| https://github.com/fhinkel |
|
| https://github.com/nodejs/node/pull/16912/files/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/16912/files/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/16912/files/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/16912/files/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/16912/files/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
|
| https://github.com/sreepurnajasti |
|
sreepurnajasti
| https://github.com/sreepurnajasti |
|
| https://github.com/nodejs/node/pull/16912/files/1283137d02637e1a406316b43785eea051d1e7d2 |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/16912/files/f65bb6baf00c55c09aaca3831da0606d5b7f8918 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/16912 |
|
| https://github.com/Anaweshak |
|
| https://github.com/fhinkel |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/tniessen |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/sreepurnajasti |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |