René's URL Explorer Experiment


Title: deps: cherry-pick b8331cc030 from upstream V8 by danbev · Pull Request #16900 · nodejs/node · GitHub

Open Graph Title: deps: cherry-pick b8331cc030 from upstream V8 by danbev · Pull Request #16900 · nodejs/node

X Title: deps: cherry-pick b8331cc030 from upstream V8 by danbev · Pull Request #16900 · nodejs/node

Description: Original commit message: I believe the paths to the V8 include headers are incorrect. The paths to other sources seem to be relative to the parent directory. When building Node.js I get the following warning on Windows: Warning: Missing input files: deps\v8\src\..\..\include\v8-inspector-protocol.h deps\v8\src\..\..\include\v8-inspector.h This commit updates the two include paths. Bug: Change-Id: I51a057abba61e294e7811ba69db03e283b0bdc3f Reviewed-on: https://chromium-review.googlesource.com/743981 Reviewed-by: Aleksey Kozyatinskiy Commit-Queue: Aleksey Kozyatinskiy Cr-Commit-Position: refs/heads/master@{#49121} This commit also increments the v8_embedder_string version. Fixes: #16614 Refs: v8/v8@b8331cc Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affected core subsystem(s) deps cc @nodejs/v8

Open Graph Description: Original commit message: I believe the paths to the V8 include headers are incorrect. The paths to other sources seem to be relative to the parent directory. When building Node.js I get the follow...

X Description: Original commit message: I believe the paths to the V8 include headers are incorrect. The paths to other sources seem to be relative to the parent directory. When building Node.js I get the follow...

Opengraph URL: https://github.com/nodejs/node/pull/16900

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:cd94155a-c9ec-3d8e-c027-3f357a01d2aa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBEA4:234380:7C0A3A:A92388:6996CD4E
html-safe-nonce5e67dd00dfb69123058f89ce7fd7c9a2be08e78829c0fdd707ff59bcd655d831
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUE0OjIzNDM4MDo3QzBBM0E6QTkyMzg4OjY5OTZDRDRFIiwidmlzaXRvcl9pZCI6IjQyNDUwNTE1NzQ0MDQ0MzUyNzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf696ca7ee116f29fceee9be7027915960105e97be586be34d21c553994b72d33
hovercard-subject-tagpull_request:151614434
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5
twitter:imagehttps://avatars.githubusercontent.com/u/432351?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/432351?s=400&v=4
og:image:altOriginal commit message: I believe the paths to the V8 include headers are incorrect. The paths to other sources seem to be relative to the parent directory. When building Node.js I get the follow...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5513290f8d09a9ed78de519ab8316ed23b2b0ddd5e91d2420df56691d00827e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee258e32a8c50a12656030b21f3279030a774ec82
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16900%2Fcommits%2Fa15f113905c9d5034116d18500645338e2d38eb5
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16900%2Fcommits%2Fa15f113905c9d5034116d18500645338e2d38eb5
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5
Reloadhttps://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5
Reloadhttps://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.8k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:v8-fix-include-pathshttps://github.com/danbev/node/tree/v8-fix-include-paths
Conversation 4 https://github.com/nodejs/node/pull/16900
Commits 1 https://github.com/nodejs/node/pull/16900/commits
Checks 0 https://github.com/nodejs/node/pull/16900/checks
Files changed https://github.com/nodejs/node/pull/16900/files
Please reload this pagehttps://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5
deps: cherry-pick b8331cc030 from upstream V8 https://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5#top
Show all changes 1 commit https://github.com/nodejs/node/pull/16900/files
a15f113 deps: cherry-pick b8331cc030 from upstream V8 danbev Oct 30, 2017 https://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5
Clear filters https://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5
Please reload this pagehttps://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5
Please reload this pagehttps://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5
common.gypi https://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
inspector.gypi https://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5#diff-0770a9e5d7ca68f4335d4d3e7a5d85ff4a4b98ca40c6ec6787f90c35930ac8fe
https://chromium-review.googlesource.com/743981https://chromium-review.googlesource.com/743981
#49121https://github.com/nodejs/node/pull/49121
#16614https://github.com/nodejs/node/issues/16614
v8/v8@b8331cchttps://github.com/v8/v8/commit/b8331cc0303f7b5c18d84527d5951bafea9a46d9
Please reload this pagehttps://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5
https://github.com/danbev
danbevhttps://github.com/nodejs/node/commits?author=danbev
common.gypihttps://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
View file https://github.com/danbev/node/blob/a15f113905c9d5034116d18500645338e2d38eb5/common.gypi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/16900/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
https://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5#diff-9513a0c08584f4800e1461ca8c3456d1aeb899968ea14b2f6859ea462c37b5bb
deps/v8/src/inspector/inspector.gypihttps://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5#diff-0770a9e5d7ca68f4335d4d3e7a5d85ff4a4b98ca40c6ec6787f90c35930ac8fe
View file https://github.com/danbev/node/blob/a15f113905c9d5034116d18500645338e2d38eb5/deps/v8/src/inspector/inspector.gypi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/16900/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5#diff-0770a9e5d7ca68f4335d4d3e7a5d85ff4a4b98ca40c6ec6787f90c35930ac8fe
https://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5#diff-0770a9e5d7ca68f4335d4d3e7a5d85ff4a4b98ca40c6ec6787f90c35930ac8fe
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.