| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a3373f2b-8755-c02f-6de4-cf1e643935a5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8420:1113DB:E79A69:1253533:69918B18 |
| html-safe-nonce | 67b69be152091e03ae2e1fdcbde0cc1c15075c87f5d51f7b575981a353cd2e77 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDIwOjExMTNEQjpFNzlBNjk6MTI1MzUzMzo2OTkxOEIxOCIsInZpc2l0b3JfaWQiOiI1MDE1NzQ0ODQ4MjEwMjY2OTA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d0b9969cce88209a6250c1700615db0f684e443424c3a98b734690f8ff80039b |
| hovercard-subject-tag | pull_request:151614434 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16900/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/358c825f011edbd3984f962d90aa720908c83fa65134775ef83803a5f9d23caf/nodejs/node/pull/16900 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/358c825f011edbd3984f962d90aa720908c83fa65134775ef83803a5f9d23caf/nodejs/node/pull/16900 |
| og:image:alt | Original commit message:
I believe the paths to the V8 include headers are incorrect. The
paths to other sources seem to be relative to the parent directory.
When building Node.js I get the follow... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/16900#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16900 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16900 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/16900 |
| Reload | https://github.com/nodejs/node/pull/16900 |
| Reload | https://github.com/nodejs/node/pull/16900 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/16900 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:v8-fix-include-paths | https://github.com/danbev/node/tree/v8-fix-include-paths |
| Conversation | https://github.com/nodejs/node/pull/16900 |
| Commits1 (1) | https://github.com/nodejs/node/pull/16900/commits |
| Checks | https://github.com/nodejs/node/pull/16900/checks |
| Files changed | https://github.com/nodejs/node/pull/16900/files |
| deps: cherry-pick b8331cc030 from upstream V8 | https://github.com/nodejs/node/pull/16900#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:v8-fix-include-paths | https://github.com/danbev/node/tree/v8-fix-include-paths |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 9, 2017 | https://github.com/nodejs/node/pull/16900#issue-272513907 |
| #16614 | https://github.com/nodejs/node/issues/16614 |
| v8/v8@b8331cc | https://github.com/v8/v8/commit/b8331cc0303f7b5c18d84527d5951bafea9a46d9 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/16900 |
|
| https://github.com/danbev |
| deps: cherry-pick b8331cc030 from upstream V8 | https://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5 |
| a15f113 | https://github.com/nodejs/node/pull/16900/commits/a15f113905c9d5034116d18500645338e2d38eb5 |
| https://chromium-review.googlesource.com/743981 | https://chromium-review.googlesource.com/743981 |
| nodejs#49121 | https://github.com/nodejs/node/pull/49121 |
| nodejs#16614 | https://github.com/nodejs/node/issues/16614 |
| v8/v8@b8331cc | https://github.com/v8/v8/commit/b8331cc0303f7b5c18d84527d5951bafea9a46d9 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Nov 9, 2017 | https://github.com/nodejs/node/pull/16900#event-1333671658 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 9, 2017 | https://github.com/nodejs/node/pull/16900#issuecomment-343113755 |
| https://ci.nodejs.org/job/node-test-pull-request/11321/ | https://ci.nodejs.org/job/node-test-pull-request/11321/ |
| Please reload this page | https://github.com/nodejs/node/pull/16900 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Nov 9, 2017
| https://github.com/nodejs/node/pull/16900#pullrequestreview-75392139 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16900/files/a15f113905c9d5034116d18500645338e2d38eb5 |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/16900#pullrequestreview-75392139 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16900 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 9, 2017 | https://github.com/nodejs/node/pull/16900#issuecomment-343118969 |
| @bnoordhuis | https://github.com/bnoordhuis |
| e5238ed | https://github.com/nodejs/node/commit/e5238ed030a06fa94e4574eff504777e173c9351 |
| Please reload this page | https://github.com/nodejs/node/pull/16900 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 9, 2017 | https://github.com/nodejs/node/pull/16900#event-1333707523 |
| danbev | https://github.com/danbev |
|
Nov 9, 2017
| https://github.com/nodejs/node/pull/16900#ref-commit-e5238ed |
|
| https://github.com/danbev |
| deps: cherry-pick b8331cc030 from upstream V8 | https://github.com/nodejs/node/commit/e5238ed030a06fa94e4574eff504777e173c9351 |
| e5238ed | https://github.com/nodejs/node/commit/e5238ed030a06fa94e4574eff504777e173c9351 |
| https://chromium-review.googlesource.com/743981 | https://chromium-review.googlesource.com/743981 |
| #49121 | https://github.com/nodejs/node/pull/49121 |
| #16900 | https://github.com/nodejs/node/pull/16900 |
| #16614 | https://github.com/nodejs/node/issues/16614 |
| v8/v8@b8331cc | https://github.com/v8/v8/commit/b8331cc0303f7b5c18d84527d5951bafea9a46d9 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| November 13, 2017 07:54 | https://github.com/nodejs/node/pull/16900#event-1338154172 |
| evanlucas | https://github.com/evanlucas |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16900#ref-commit-28b7bf0 |
|
| https://github.com/danbev |
|
| https://github.com/evanlucas |
| deps: cherry-pick b8331cc030 from upstream V8 | https://github.com/nodejs/node/commit/28b7bf062aae29f69c9dc6648f3153f716c6ae70 |
| 28b7bf0 | https://github.com/nodejs/node/commit/28b7bf062aae29f69c9dc6648f3153f716c6ae70 |
| https://chromium-review.googlesource.com/743981 | https://chromium-review.googlesource.com/743981 |
| #49121 | https://github.com/nodejs/node/pull/49121 |
| #16900 | https://github.com/nodejs/node/pull/16900 |
| #16614 | https://github.com/nodejs/node/issues/16614 |
| v8/v8@b8331cc | https://github.com/v8/v8/commit/b8331cc0303f7b5c18d84527d5951bafea9a46d9 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16900#ref-pullrequest-273462029 |
|
v9.2.0 proposal
#16992
| https://github.com/nodejs/node/pull/16992 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backport-requested-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16900#event-1347363811 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16900#issuecomment-345275459 |
| the guide | https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md |
| Please reload this page | https://github.com/nodejs/node/pull/16900 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
|
backport-requested-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x |
| Nov 21, 2017 | https://github.com/nodejs/node/pull/16900#event-1351378505 |
| targos | https://github.com/targos |
|
Jan 15, 2018
| https://github.com/nodejs/node/pull/16900#ref-commit-68365eb |
|
| https://github.com/danbev |
|
| https://github.com/targos |
| deps: cherry-pick b8331cc030 from upstream V8 | https://github.com/targos/node/commit/68365eb67185a009fc4086b7bfa0cc5f49e26339 |
| 68365eb | https://github.com/targos/node/commit/68365eb67185a009fc4086b7bfa0cc5f49e26339 |
| https://chromium-review.googlesource.com/743981 | https://chromium-review.googlesource.com/743981 |
| nodejs#49121 | https://github.com/nodejs/node/pull/49121 |
| nodejs#16900 | https://github.com/nodejs/node/pull/16900 |
| nodejs#16614 | https://github.com/nodejs/node/issues/16614 |
| v8/v8@b8331cc | https://github.com/v8/v8/commit/b8331cc0303f7b5c18d84527d5951bafea9a46d9 |
| gibfahn | https://github.com/gibfahn |
|
Jan 16, 2018
| https://github.com/nodejs/node/pull/16900#ref-commit-13fbfa4 |
|
| https://github.com/danbev |
|
| https://github.com/gibfahn |
| deps: cherry-pick b8331cc030 from upstream V8 | https://github.com/gibfahn/node/commit/13fbfa4b1dcd0ca9d195b1d35e3faa077f15974d |
| 13fbfa4 | https://github.com/gibfahn/node/commit/13fbfa4b1dcd0ca9d195b1d35e3faa077f15974d |
| https://chromium-review.googlesource.com/743981 | https://chromium-review.googlesource.com/743981 |
| nodejs#49121 | https://github.com/nodejs/node/pull/49121 |
| nodejs#16900 | https://github.com/nodejs/node/pull/16900 |
| nodejs#16413 | https://github.com/nodejs/node/pull/16413 |
| nodejs#16614 | https://github.com/nodejs/node/issues/16614 |
| v8/v8@b8331cc | https://github.com/v8/v8/commit/b8331cc0303f7b5c18d84527d5951bafea9a46d9 |
| gibfahn | https://github.com/gibfahn |
|
Jan 22, 2018
| https://github.com/nodejs/node/pull/16900#ref-commit-2153adb |
|
| https://github.com/danbev |
|
| https://github.com/gibfahn |
| deps: cherry-pick b8331cc030 from upstream V8 | https://github.com/gibfahn/node/commit/2153adbf15e5a9d64bc3fc15d2817edbd294d4f9 |
| 2153adb | https://github.com/gibfahn/node/commit/2153adbf15e5a9d64bc3fc15d2817edbd294d4f9 |
| https://chromium-review.googlesource.com/743981 | https://chromium-review.googlesource.com/743981 |
| nodejs#49121 | https://github.com/nodejs/node/pull/49121 |
| nodejs#16900 | https://github.com/nodejs/node/pull/16900 |
| nodejs#16413 | https://github.com/nodejs/node/pull/16413 |
| nodejs#16614 | https://github.com/nodejs/node/issues/16614 |
| v8/v8@b8331cc | https://github.com/v8/v8/commit/b8331cc0303f7b5c18d84527d5951bafea9a46d9 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 7, 2018
| https://github.com/nodejs/node/pull/16900#ref-commit-dd8c994 |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
| deps: cherry-pick b8331cc030 from upstream V8 | https://github.com/targos/node/commit/dd8c994a565e200379319a088f19598d2c5271ca |
| dd8c994 | https://github.com/targos/node/commit/dd8c994a565e200379319a088f19598d2c5271ca |
| https://chromium-review.googlesource.com/743981 | https://chromium-review.googlesource.com/743981 |
| nodejs#49121 | https://github.com/nodejs/node/pull/49121 |
| nodejs#16900 | https://github.com/nodejs/node/pull/16900 |
| nodejs#16614 | https://github.com/nodejs/node/issues/16614 |
| v8/v8@b8331cc | https://github.com/v8/v8/commit/b8331cc0303f7b5c18d84527d5951bafea9a46d9 |
| gibfahn | https://github.com/gibfahn |
|
Feb 18, 2018
| https://github.com/nodejs/node/pull/16900#ref-commit-0e30ca9 |
|
| https://github.com/danbev |
|
| https://github.com/gibfahn |
| deps: cherry-pick b8331cc030 from upstream V8 | https://github.com/nodejs/node/commit/0e30ca942e54833ce0fd02e6b1dc11aa90a20dfe |
| 0e30ca9 | https://github.com/nodejs/node/commit/0e30ca942e54833ce0fd02e6b1dc11aa90a20dfe |
| https://chromium-review.googlesource.com/743981 | https://chromium-review.googlesource.com/743981 |
| #49121 | https://github.com/nodejs/node/pull/49121 |
| #16900 | https://github.com/nodejs/node/pull/16900 |
| #16413 | https://github.com/nodejs/node/pull/16413 |
| #16614 | https://github.com/nodejs/node/issues/16614 |
| v8/v8@b8331cc | https://github.com/v8/v8/commit/b8331cc0303f7b5c18d84527d5951bafea9a46d9 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16900 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/16900/files/a15f113905c9d5034116d18500645338e2d38eb5 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/16900 |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
|
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |