| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f666ae10-7778-7c59-bcf9-a3ce6acefeeb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D4AE:16C680:1DFCE65:26184CA:699189FD |
| html-safe-nonce | 6c2eb504fe3dcd8e8d585bbec402fd0b296f941bc1b768bda0617940c275758b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEFFOjE2QzY4MDoxREZDRTY1OjI2MTg0Q0E6Njk5MTg5RkQiLCJ2aXNpdG9yX2lkIjoiNTc0MDA1NjI0NjIwMDkyODc2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a82475d0562796e950e0d6ad95a3ff72fc175e9bd7e52438f447fa2358605bf3 |
| hovercard-subject-tag | pull_request:151606454 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16899/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/597028d38eaa96602b8e959873404b8b9a0f6061b95f99f2d436d61541cadf3a/nodejs/node/pull/16899 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/597028d38eaa96602b8e959873404b8b9a0f6061b95f99f2d436d61541cadf3a/nodejs/node/pull/16899 |
| og:image:alt | This reverts commit 4e769a8.
The reason for reverting this is that I forgot to increment the
v8_embedder_string in the above commit.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) pas... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/16899#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16899 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16899 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/16899 |
| Reload | https://github.com/nodejs/node/pull/16899 |
| Reload | https://github.com/nodejs/node/pull/16899 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/16899 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:revert-v8-fix-include-path | https://github.com/danbev/node/tree/revert-v8-fix-include-path |
| Conversation | https://github.com/nodejs/node/pull/16899 |
| Commits1 (1) | https://github.com/nodejs/node/pull/16899/commits |
| Checks | https://github.com/nodejs/node/pull/16899/checks |
| Files changed | https://github.com/nodejs/node/pull/16899/files |
| Revert "deps: cherry-pick b8331cc030 from upstream V8" | https://github.com/nodejs/node/pull/16899#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:revert-v8-fix-include-path | https://github.com/danbev/node/tree/revert-v8-fix-include-path |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 9, 2017 | https://github.com/nodejs/node/pull/16899#issue-272503500 |
| 4e769a8 | https://github.com/nodejs/node/commit/4e769a840bf67735e9c0e69c1d9ad3671ee086c6 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/16899 |
|
| https://github.com/danbev |
| Revert "deps: cherry-pick b8331cc030 from upstream V8" | https://github.com/nodejs/node/pull/16899/commits/df6c1ef9cb0c54bf8baa72f2affa96e70bc33a84 |
| df6c1ef | https://github.com/nodejs/node/pull/16899/commits/df6c1ef9cb0c54bf8baa72f2affa96e70bc33a84 |
| 4e769a8 | https://github.com/danbev/node/commit/4e769a840bf67735e9c0e69c1d9ad3671ee086c6 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Nov 9, 2017 | https://github.com/nodejs/node/pull/16899#event-1333616057 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Nov 9, 2017
| https://github.com/nodejs/node/pull/16899#pullrequestreview-75383791 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16899/files/df6c1ef9cb0c54bf8baa72f2affa96e70bc33a84 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Nov 9, 2017 | https://github.com/nodejs/node/pull/16899#issuecomment-343108409 |
| @danbev | https://github.com/danbev |
| Please reload this page | https://github.com/nodejs/node/pull/16899 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 9, 2017
| https://github.com/nodejs/node/pull/16899#pullrequestreview-75384441 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16899/files/df6c1ef9cb0c54bf8baa72f2affa96e70bc33a84 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 9, 2017 | https://github.com/nodejs/node/pull/16899#issuecomment-343109791 |
| Please reload this page | https://github.com/nodejs/node/pull/16899 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 9, 2017 | https://github.com/nodejs/node/pull/16899#issuecomment-343111920 |
| 3393b65 | https://github.com/nodejs/node/commit/3393b65a6ff85884f2515f94b2d83aec4dcd45ca |
| Please reload this page | https://github.com/nodejs/node/pull/16899 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 9, 2017 | https://github.com/nodejs/node/pull/16899#event-1333661180 |
| danbev | https://github.com/danbev |
|
Nov 9, 2017
| https://github.com/nodejs/node/pull/16899#ref-commit-3393b65 |
|
| https://github.com/danbev |
| Revert "deps: cherry-pick b8331cc030 from upstream V8" | https://github.com/nodejs/node/commit/3393b65a6ff85884f2515f94b2d83aec4dcd45ca |
| 3393b65 | https://github.com/nodejs/node/commit/3393b65a6ff85884f2515f94b2d83aec4dcd45ca |
| 4e769a8 | https://github.com/nodejs/node/commit/4e769a840bf67735e9c0e69c1d9ad3671ee086c6 |
| #16899 | https://github.com/nodejs/node/pull/16899 |
| evanlucas | https://github.com/evanlucas |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16899#ref-commit-2266caf |
|
| https://github.com/danbev |
|
| https://github.com/evanlucas |
| Revert "deps: cherry-pick b8331cc030 from upstream V8" | https://github.com/nodejs/node/commit/2266cafba54b2e2297f06c757e71129d227cea1f |
| 2266caf | https://github.com/nodejs/node/commit/2266cafba54b2e2297f06c757e71129d227cea1f |
| 4e769a8 | https://github.com/nodejs/node/commit/4e769a840bf67735e9c0e69c1d9ad3671ee086c6 |
| #16899 | https://github.com/nodejs/node/pull/16899 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16899#ref-pullrequest-273462029 |
|
v9.2.0 proposal
#16992
| https://github.com/nodejs/node/pull/16992 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| November 16, 2017 08:38 | https://github.com/nodejs/node/pull/16899#event-1344621172 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16899#event-1347363559 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16899 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/16899/files/df6c1ef9cb0c54bf8baa72f2affa96e70bc33a84 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/16899/files/df6c1ef9cb0c54bf8baa72f2affa96e70bc33a84 |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/16899 |
|
| https://github.com/danbev |
|
| https://github.com/bnoordhuis |
|
| https://github.com/targos |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |