René's URL Explorer Experiment


Title: src: fix UB in InternalModuleReadFile() by bnoordhuis · Pull Request #16871 · nodejs/node · GitHub

Open Graph Title: src: fix UB in InternalModuleReadFile() by bnoordhuis · Pull Request #16871 · nodejs/node

X Title: src: fix UB in InternalModuleReadFile() by bnoordhuis · Pull Request #16871 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: &vec[0] is undefined behavior when vec.size() == 0. It is mostly academic because package.json files are not usually empty and because with most STL implementations it decays to something that ...

X Description: &vec[0] is undefined behavior when vec.size() == 0. It is mostly academic because package.json files are not usually empty and because with most STL implementations it decays to something t...

Opengraph URL: https://github.com/nodejs/node/pull/16871

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8c07cf42-d292-84af-312c-cc1e801bc926
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7FE:1219ED:5A6F29:74AA94:6991E1F5
html-safe-nonce9c1461203b08a44f8f9bb65a687e14d117fcf078f8fd214fef5d771200ea3f6f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0ZFOjEyMTlFRDo1QTZGMjk6NzRBQTk0OjY5OTFFMUY1IiwidmlzaXRvcl9pZCI6IjU1MDE4MDk4MzA2MTczMzg3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca76a56b71339ab5cfab09db36f9d2fbf9b5040660bb56d0f58a13ea558b80349
hovercard-subject-tagpull_request:151219353
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16871/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e14b0b270fd9a9ec81f6149881b5c19b3a4c8652dceecab9474383684a199d17/nodejs/node/pull/16871
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e14b0b270fd9a9ec81f6149881b5c19b3a4c8652dceecab9474383684a199d17/nodejs/node/pull/16871
og:image:alt&vec[0] is undefined behavior when vec.size() == 0. It is mostly academic because package.json files are not usually empty and because with most STL implementations it decays to something that ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16871#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16871
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16871
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16871
Reloadhttps://github.com/nodejs/node/pull/16871
Reloadhttps://github.com/nodejs/node/pull/16871
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16871
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-module-ubhttps://github.com/bnoordhuis/io.js/tree/fix-module-ub
Conversationhttps://github.com/nodejs/node/pull/16871
Commits0 (0)https://github.com/nodejs/node/pull/16871/commits
Checkshttps://github.com/nodejs/node/pull/16871/checks
Files changedhttps://github.com/nodejs/node/pull/16871/files
src: fix UB in InternalModuleReadFile()https://github.com/nodejs/node/pull/16871#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-module-ubhttps://github.com/bnoordhuis/io.js/tree/fix-module-ub
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 7, 2017https://github.com/nodejs/node/pull/16871#issue-271972910
Please reload this pagehttps://github.com/nodejs/node/pull/16871
#15767https://github.com/nodejs/node/pull/15767
https://ci.nodejs.org/job/node-test-pull-request/11283/https://ci.nodejs.org/job/node-test-pull-request/11283/
Please reload this pagehttps://github.com/nodejs/node/pull/16871
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Nov 7, 2017https://github.com/nodejs/node/pull/16871#event-1330538617
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 7, 2017 https://github.com/nodejs/node/pull/16871#pullrequestreview-74897739
View reviewed changes https://github.com/nodejs/node/pull/16871/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 7, 2017 https://github.com/nodejs/node/pull/16871#pullrequestreview-74898721
View reviewed changes https://github.com/nodejs/node/pull/16871/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 8, 2017 https://github.com/nodejs/node/pull/16871#pullrequestreview-75043820
View reviewed changes https://github.com/nodejs/node/pull/16871/files
test/parallel/test-module-binding.jshttps://github.com/nodejs/node/pull/16871/files#diff-724af109b257a58445931e85e9b5989daa16d1ff1bc1691c184330043365fdf0
jasnellhttps://github.com/jasnell
Nov 8, 2017https://github.com/nodejs/node/pull/16871#discussion_r149623117
Please reload this pagehttps://github.com/nodejs/node/pull/16871
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16871
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 8, 2017 https://github.com/nodejs/node/pull/16871#pullrequestreview-75043919
View reviewed changes https://github.com/nodejs/node/pull/16871/files
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 9, 2017 https://github.com/nodejs/node/pull/16871#pullrequestreview-75334468
View reviewed changes https://github.com/nodejs/node/pull/16871/files
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/2edbadf92840cf2476652afaf29f17bd0c40e225..72e23a4de74dca631ce47cd53b62e40c649d130e
2edbadfhttps://github.com/nodejs/node/commit/2edbadf92840cf2476652afaf29f17bd0c40e225
72e23a4https://github.com/nodejs/node/commit/72e23a4de74dca631ce47cd53b62e40c649d130e
Compare https://github.com/nodejs/node/compare/2edbadf92840cf2476652afaf29f17bd0c40e225..72e23a4de74dca631ce47cd53b62e40c649d130e
November 9, 2017 10:58https://github.com/nodejs/node/pull/16871#event-1333716633
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 9, 2017https://github.com/nodejs/node/pull/16871#issuecomment-343120491
https://ci.nodejs.org/job/node-test-pull-request/11322/https://ci.nodejs.org/job/node-test-pull-request/11322/
Please reload this pagehttps://github.com/nodejs/node/pull/16871
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 9, 2017https://github.com/nodejs/node/pull/16871#event-1333809093
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/72e23a4de74dca631ce47cd53b62e40c649d130e..f823d381e700ec152575ebd2cdc4420def690833
72e23a4https://github.com/nodejs/node/commit/72e23a4de74dca631ce47cd53b62e40c649d130e
f823d38https://github.com/nodejs/node/commit/f823d381e700ec152575ebd2cdc4420def690833
Compare https://github.com/nodejs/node/compare/72e23a4de74dca631ce47cd53b62e40c649d130e..f823d381e700ec152575ebd2cdc4420def690833
November 9, 2017 11:59https://github.com/nodejs/node/pull/16871#event-1333809096
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
November 9, 2017 11:59https://github.com/nodejs/node/pull/16871#event-1333809154
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
f823d38https://github.com/nodejs/node/commit/f823d381e700ec152575ebd2cdc4420def690833
Nov 9, 2017https://github.com/nodejs/node/pull/16871#event-1333810266
evanlucashttps://github.com/evanlucas
Nov 13, 2017 https://github.com/nodejs/node/pull/16871#ref-commit-43c5726
https://github.com/bnoordhuis
https://github.com/evanlucas
src: fix UB in InternalModuleReadFile()https://github.com/nodejs/node/commit/43c57260289b4337565158a04191764ea0b42fbb
43c5726https://github.com/nodejs/node/commit/43c57260289b4337565158a04191764ea0b42fbb
#16871https://github.com/nodejs/node/pull/16871
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Nov 13, 2017 https://github.com/nodejs/node/pull/16871#ref-pullrequest-273462029
v9.2.0 proposal #16992 https://github.com/nodejs/node/pull/16992
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Nov 17, 2017https://github.com/nodejs/node/pull/16871#event-1347364566
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2017https://github.com/nodejs/node/pull/16871#issuecomment-345275657
Please reload this pagehttps://github.com/nodejs/node/pull/16871
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 17, 2017https://github.com/nodejs/node/pull/16871#issuecomment-345358511
@MylesBorinshttps://github.com/MylesBorins
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/16871
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Dec 13, 2017https://github.com/nodejs/node/pull/16871#event-1386008385
gibfahnhttps://github.com/gibfahn
Dec 13, 2017 https://github.com/nodejs/node/pull/16871#ref-commit-81970f8
https://github.com/bnoordhuis
https://github.com/gibfahn
src: fix UB in InternalModuleReadFile()https://github.com/nodejs/node/commit/81970f87edca4f0659a28c2ff74c03d1eaa6ab77
81970f8https://github.com/nodejs/node/commit/81970f87edca4f0659a28c2ff74c03d1eaa6ab77
#16871https://github.com/nodejs/node/pull/16871
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Dec 19, 2017https://github.com/nodejs/node/pull/16871#event-1394694120
v8.9.4 proposal #17772 https://github.com/nodejs/node/pull/17772
v8.9.4 proposal #17774 https://github.com/nodejs/node/pull/17774
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16871
https://github.com/fhinkel
fhinkel https://github.com/fhinkel
https://github.com/nodejs/node/pull/16871/files/2edbadf92840cf2476652afaf29f17bd0c40e225
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16871/files/2edbadf92840cf2476652afaf29f17bd0c40e225
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/16871/files/2edbadf92840cf2476652afaf29f17bd0c40e225
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/16871/files/2edbadf92840cf2476652afaf29f17bd0c40e225
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/16871
https://github.com/bnoordhuis
https://github.com/MylesBorins
https://github.com/addaleax
https://github.com/fhinkel
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/gibfahn
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.