René's URL Explorer Experiment


Title: src: make StreamBase prototype accessors more robust by joyeecheung · Pull Request #16860 · nodejs/node · GitHub

Open Graph Title: src: make StreamBase prototype accessors more robust by joyeecheung · Pull Request #16860 · nodejs/node

X Title: src: make StreamBase prototype accessors more robust by joyeecheung · Pull Request #16860 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Affected core...

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Affected core...

Opengraph URL: https://github.com/nodejs/node/pull/16860

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0f56720b-e130-4965-3470-d0395beae77a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EB6:14AE18:21E9969:2B3EC7C:6991AABD
html-safe-noncef86e1820139651a9763bd39b9abf982304b604f4af3c885af5e22a4d1b654c89
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUI2OjE0QUUxODoyMUU5OTY5OjJCM0VDN0M6Njk5MUFBQkQiLCJ2aXNpdG9yX2lkIjoiNzEwODAxNDM5ODEwNzY1ODk0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2ac0b5d0a1d1fa4fa2fa8113e104a95bd6ca9f18dd0f77f97b133f5c2eb668e5
hovercard-subject-tagpull_request:151093287
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16860/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f57e351d9e6d4dcfac4d11b9330f2f953b210fa075a7b30405203b3245e1e3e3/nodejs/node/pull/16860
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f57e351d9e6d4dcfac4d11b9330f2f953b210fa075a7b30405203b3245e1e3e3/nodejs/node/pull/16860
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Affected core...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16860#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16860
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16860
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16860
Reloadhttps://github.com/nodejs/node/pull/16860
Reloadhttps://github.com/nodejs/node/pull/16860
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16860
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:make-stream-robusthttps://github.com/joyeecheung/node/tree/make-stream-robust
Conversationhttps://github.com/nodejs/node/pull/16860
Commits2 (2)https://github.com/nodejs/node/pull/16860/commits
Checkshttps://github.com/nodejs/node/pull/16860/checks
Files changedhttps://github.com/nodejs/node/pull/16860/files
src: make StreamBase prototype accessors more robusthttps://github.com/nodejs/node/pull/16860#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:make-stream-robusthttps://github.com/joyeecheung/node/tree/make-stream-robust
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 7, 2017https://github.com/nodejs/node/pull/16860#issue-271804659
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16860
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Nov 7, 2017https://github.com/nodejs/node/pull/16860#event-1329527910
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/e8f3077a26840416c57f6fc06c9631df56010c15..d926aaa6a20c4e847da566dde25e1c7798f1c640
e8f3077https://github.com/nodejs/node/commit/e8f3077a26840416c57f6fc06c9631df56010c15
d926aaahttps://github.com/nodejs/node/commit/d926aaa6a20c4e847da566dde25e1c7798f1c640
Compare https://github.com/nodejs/node/compare/e8f3077a26840416c57f6fc06c9631df56010c15..d926aaa6a20c4e847da566dde25e1c7798f1c640
November 7, 2017 11:59https://github.com/nodejs/node/pull/16860#event-1329537016
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Nov 7, 2017https://github.com/nodejs/node/pull/16860#event-1329537216
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/d926aaa6a20c4e847da566dde25e1c7798f1c640..b7d63e83cdee7f3933b281f4ac27444bd9fa64e8
d926aaahttps://github.com/nodejs/node/commit/d926aaa6a20c4e847da566dde25e1c7798f1c640
b7d63e8https://github.com/nodejs/node/commit/b7d63e83cdee7f3933b281f4ac27444bd9fa64e8
Compare https://github.com/nodejs/node/compare/d926aaa6a20c4e847da566dde25e1c7798f1c640..b7d63e83cdee7f3933b281f4ac27444bd9fa64e8
November 7, 2017 12:00https://github.com/nodejs/node/pull/16860#event-1329538606
https://github.com/joyeecheung
src: make StreamBase prototype accessors more robusthttps://github.com/nodejs/node/pull/16860/commits/ddb12acdd13f7bb66eb03c61d449873ef4582dee
ddb12achttps://github.com/nodejs/node/pull/16860/commits/ddb12acdd13f7bb66eb03c61d449873ef4582dee
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/b7d63e83cdee7f3933b281f4ac27444bd9fa64e8..ddb12acdd13f7bb66eb03c61d449873ef4582dee
b7d63e8https://github.com/nodejs/node/commit/b7d63e83cdee7f3933b281f4ac27444bd9fa64e8
ddb12achttps://github.com/nodejs/node/commit/ddb12acdd13f7bb66eb03c61d449873ef4582dee
Compare https://github.com/nodejs/node/compare/b7d63e83cdee7f3933b281f4ac27444bd9fa64e8..ddb12acdd13f7bb66eb03c61d449873ef4582dee
November 7, 2017 12:03https://github.com/nodejs/node/pull/16860#event-1329543043
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 7, 2017 https://github.com/nodejs/node/pull/16860#pullrequestreview-74724506
View reviewed changes https://github.com/nodejs/node/pull/16860/files/ddb12acdd13f7bb66eb03c61d449873ef4582dee
test/parallel/test-stream-base-prototype-accessors.jshttps://github.com/nodejs/node/pull/16860/files/ddb12acdd13f7bb66eb03c61d449873ef4582dee#diff-e4271c6eeaf8d4d72406a8c12e19179d992b8eb29dbd39cf2a808ffce0b902ef
joyeecheunghttps://github.com/joyeecheung
Nov 7, 2017https://github.com/nodejs/node/pull/16860#discussion_r149347196
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16860
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 7, 2017 https://github.com/nodejs/node/pull/16860#pullrequestreview-74759562
View reviewed changes https://github.com/nodejs/node/pull/16860/files/ddb12acdd13f7bb66eb03c61d449873ef4582dee
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 7, 2017 https://github.com/nodejs/node/pull/16860#pullrequestreview-74774016
View reviewed changes https://github.com/nodejs/node/pull/16860/files/ddb12acdd13f7bb66eb03c61d449873ef4582dee
src/stream_base-inl.hhttps://github.com/nodejs/node/pull/16860/files/ddb12acdd13f7bb66eb03c61d449873ef4582dee#diff-15f75d5d5482fbed0b2b2dadfdc8fd42152247ae731de46c2448855387b324a0
bnoordhuishttps://github.com/bnoordhuis
Nov 7, 2017https://github.com/nodejs/node/pull/16860#discussion_r149389656
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16860
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Nov 8, 2017https://github.com/nodejs/node/pull/16860#event-1330866160
https://github.com/joyeecheung
[fixup] 4 space indentationhttps://github.com/nodejs/node/pull/16860/commits/faee4df837117cb7f14c15a30f0cfcd4eb45aa9b
faee4dfhttps://github.com/nodejs/node/pull/16860/commits/faee4df837117cb7f14c15a30f0cfcd4eb45aa9b
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 8, 2017 https://github.com/nodejs/node/pull/16860#pullrequestreview-75037766
View reviewed changes https://github.com/nodejs/node/pull/16860/files/faee4df837117cb7f14c15a30f0cfcd4eb45aa9b
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 8, 2017 https://github.com/nodejs/node/pull/16860#pullrequestreview-75102204
View reviewed changes https://github.com/nodejs/node/pull/16860/files/faee4df837117cb7f14c15a30f0cfcd4eb45aa9b
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 10, 2017https://github.com/nodejs/node/pull/16860#issuecomment-343496217
https://ci.nodejs.org/job/node-test-pull-request/11339/https://ci.nodejs.org/job/node-test-pull-request/11339/
Please reload this pagehttps://github.com/nodejs/node/pull/16860
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 11, 2017https://github.com/nodejs/node/pull/16860#issuecomment-343640840
1ee3244https://github.com/nodejs/node/commit/1ee32444ca8651131a413cfe80a3a21a67875fc7
Please reload this pagehttps://github.com/nodejs/node/pull/16860
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 11, 2017https://github.com/nodejs/node/pull/16860#event-1337112285
joyeecheunghttps://github.com/joyeecheung
Nov 11, 2017 https://github.com/nodejs/node/pull/16860#ref-commit-1ee3244
https://github.com/joyeecheung
src: make StreamBase prototype accessors robusthttps://github.com/nodejs/node/commit/1ee32444ca8651131a413cfe80a3a21a67875fc7
1ee3244https://github.com/nodejs/node/commit/1ee32444ca8651131a413cfe80a3a21a67875fc7
#16860https://github.com/nodejs/node/pull/16860
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Nov 11, 2017 https://github.com/nodejs/node/pull/16860#ref-issue-273126862
Getting ._handle through --inspect with chrome developer tools crashes Node.js #16949 https://github.com/nodejs/node/issues/16949
evanlucashttps://github.com/evanlucas
Nov 13, 2017 https://github.com/nodejs/node/pull/16860#ref-commit-5df3dc1
https://github.com/joyeecheung
https://github.com/evanlucas
src: make StreamBase prototype accessors robusthttps://github.com/nodejs/node/commit/5df3dc1169a22093f7c6a13111a938ac01a9c39d
5df3dc1https://github.com/nodejs/node/commit/5df3dc1169a22093f7c6a13111a938ac01a9c39d
#16860https://github.com/nodejs/node/pull/16860
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Nov 13, 2017 https://github.com/nodejs/node/pull/16860#ref-pullrequest-273462029
v9.2.0 proposal #16992 https://github.com/nodejs/node/pull/16992
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Nov 17, 2017https://github.com/nodejs/node/pull/16860#event-1347388704
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2017 https://github.com/nodejs/node/pull/16860#ref-commit-27f5dd6
https://github.com/joyeecheung
https://github.com/MylesBorins
src: make StreamBase prototype accessors robusthttps://github.com/nodejs/node/commit/27f5dd69116d022bbb647ec2883bfbf965076c74
27f5dd6https://github.com/nodejs/node/commit/27f5dd69116d022bbb647ec2883bfbf965076c74
#16860https://github.com/nodejs/node/pull/16860
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2017https://github.com/nodejs/node/pull/16860#issuecomment-345282051
Please reload this pagehttps://github.com/nodejs/node/pull/16860
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Nov 17, 2017https://github.com/nodejs/node/pull/16860#event-1347412699
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2017 https://github.com/nodejs/node/pull/16860#ref-commit-f7411b5
https://github.com/joyeecheung
https://github.com/MylesBorins
src: make StreamBase prototype accessors robusthttps://github.com/nodejs/node/commit/f7411b5df7f41d53917085228994b004dbb1db48
f7411b5https://github.com/nodejs/node/commit/f7411b5df7f41d53917085228994b004dbb1db48
#16860https://github.com/nodejs/node/pull/16860
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Nov 21, 2017 https://github.com/nodejs/node/pull/16860#ref-pullrequest-275888281
v8.9.2 proposal #17204 https://github.com/nodejs/node/pull/17204
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 21, 2017 https://github.com/nodejs/node/pull/16860#ref-pullrequest-275653593
v6.12.1 proposal #17180 https://github.com/nodejs/node/pull/17180
MylesBorinshttps://github.com/MylesBorins
Nov 21, 2017 https://github.com/nodejs/node/pull/16860#ref-commit-f35b93c
https://github.com/joyeecheung
https://github.com/MylesBorins
src: make StreamBase prototype accessors robusthttps://github.com/nodejs/node/commit/f35b93c408ffe0af6d8150853bd52222d18be180
f35b93chttps://github.com/nodejs/node/commit/f35b93c408ffe0af6d8150853bd52222d18be180
#16860https://github.com/nodejs/node/pull/16860
MylesBorinshttps://github.com/MylesBorins
Nov 28, 2017 https://github.com/nodejs/node/pull/16860#ref-commit-a368e5f
https://github.com/joyeecheung
https://github.com/MylesBorins
src: make StreamBase prototype accessors robusthttps://github.com/nodejs/node/commit/a368e5fa63c8f6fe47a1d80ef15cb4ee2465f130
a368e5fhttps://github.com/nodejs/node/commit/a368e5fa63c8f6fe47a1d80ef15cb4ee2465f130
#16860https://github.com/nodejs/node/pull/16860
https://github.com/jure
jurehttps://github.com/jure
Dec 8, 2017https://github.com/nodejs/node/pull/16860#issuecomment-350237579
Please reload this pagehttps://github.com/nodejs/node/pull/16860
#16949 (comment)https://github.com/nodejs/node/issues/16949#issuecomment-350215564
Please reload this pagehttps://github.com/nodejs/node/pull/16860
https://github.com/erulabs
erulabshttps://github.com/erulabs
Dec 12, 2017 https://github.com/nodejs/node/pull/16860#ref-issue-281541338
Object.getOwnPropertyDescriptor throws TypeError on process _handle #17636 https://github.com/nodejs/node/issues/17636
jurehttps://github.com/jure
Dec 13, 2017 https://github.com/nodejs/node/pull/16860#ref-commit-329e162
https://github.com/jure
Change to using SetAccessorProperty instead of SetAccessor in StreamBasehttps://github.com/jure/node/commit/329e162162366b4309e467619cff3f843fe79a79
329e162https://github.com/jure/node/commit/329e162162366b4309e467619cff3f843fe79a79
nodejs#17636https://github.com/nodejs/node/issues/17636
nodejs#16482https://github.com/nodejs/node/pull/16482
nodejs#16860https://github.com/nodejs/node/pull/16860
https://github.com/jure
jurehttps://github.com/jure
Dec 13, 2017 https://github.com/nodejs/node/pull/16860#ref-pullrequest-281923075
src,stream: use SetAccessorProperty instead of SetAccessor #17665 https://github.com/nodejs/node/pull/17665
apapirovskihttps://github.com/apapirovski
Dec 17, 2017 https://github.com/nodejs/node/pull/16860#ref-commit-efffcc2
https://github.com/jure
https://github.com/apapirovski
src: replace SetAccessor w/ SetAccessorPropertyhttps://github.com/nodejs/node/commit/efffcc262c77a58ad3c75787497df46863d1b7a6
efffcc2https://github.com/nodejs/node/commit/efffcc262c77a58ad3c75787497df46863d1b7a6
#17665https://github.com/nodejs/node/pull/17665
#17636https://github.com/nodejs/node/issues/17636
#16482https://github.com/nodejs/node/pull/16482
#16860https://github.com/nodejs/node/pull/16860
MylesBorinshttps://github.com/MylesBorins
Jan 8, 2018 https://github.com/nodejs/node/pull/16860#ref-commit-6a22186
https://github.com/jure
https://github.com/MylesBorins
src: replace SetAccessor w/ SetAccessorPropertyhttps://github.com/nodejs/node/commit/6a221869de5784c7bdfc8816434f9610eb376856
6a22186https://github.com/nodejs/node/commit/6a221869de5784c7bdfc8816434f9610eb376856
#17665https://github.com/nodejs/node/pull/17665
#17636https://github.com/nodejs/node/issues/17636
#16482https://github.com/nodejs/node/pull/16482
#16860https://github.com/nodejs/node/pull/16860
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018 https://github.com/nodejs/node/pull/16860#ref-commit-a93ed5c
https://github.com/jure
https://github.com/MylesBorins
src: replace SetAccessor w/ SetAccessorPropertyhttps://github.com/nodejs/node/commit/a93ed5c282e21b51a48aaede7c40db7a5c44c8fc
a93ed5chttps://github.com/nodejs/node/commit/a93ed5c282e21b51a48aaede7c40db7a5c44c8fc
#17665https://github.com/nodejs/node/pull/17665
#17636https://github.com/nodejs/node/issues/17636
#16482https://github.com/nodejs/node/pull/16482
#16860https://github.com/nodejs/node/pull/16860
boingoinghttps://github.com/boingoing
Jan 18, 2018 https://github.com/nodejs/node/pull/16860#ref-commit-ec2e092
https://github.com/jure
https://github.com/boingoing
src: replace SetAccessor w/ SetAccessorPropertyhttps://github.com/nodejs/node-chakracore/commit/ec2e09220f8b559c1a554df1f0731afa5f64f732
ec2e092https://github.com/nodejs/node-chakracore/commit/ec2e09220f8b559c1a554df1f0731afa5f64f732
nodejs/node#17665https://github.com/nodejs/node/pull/17665
nodejs/node#17636https://github.com/nodejs/node/issues/17636
nodejs/node#16482https://github.com/nodejs/node/pull/16482
nodejs/node#16860https://github.com/nodejs/node/pull/16860
https://github.com/g-sam
g-samhttps://github.com/g-sam
Apr 10, 2018 https://github.com/nodejs/node/pull/16860#ref-issue-312833124
Bunyan can not be supported in Node versions > 8.9.1 (119) elifesciences/elife-xpub#83 https://github.com/elifesciences/elife-xpub/issues/83
kjinhttps://github.com/kjin
Apr 28, 2018 https://github.com/nodejs/node/pull/16860#ref-commit-16a3ad0
https://github.com/jure
https://github.com/kjin
src: replace SetAccessor w/ SetAccessorPropertyhttps://github.com/kjin/node/commit/16a3ad0f7c07ce2ee5220a94b608f6a0e02945e2
16a3ad0https://github.com/kjin/node/commit/16a3ad0f7c07ce2ee5220a94b608f6a0e02945e2
nodejs#17665https://github.com/nodejs/node/pull/17665
nodejs#17636https://github.com/nodejs/node/issues/17636
nodejs#16482https://github.com/nodejs/node/pull/16482
nodejs#16860https://github.com/nodejs/node/pull/16860
MylesBorinshttps://github.com/MylesBorins
May 2, 2018 https://github.com/nodejs/node/pull/16860#ref-commit-f3e082c
https://github.com/jure
https://github.com/MylesBorins
src: replace SetAccessor w/ SetAccessorPropertyhttps://github.com/nodejs/node/commit/f3e082c4ea8c27e989b86300065149475c9bc327
f3e082chttps://github.com/nodejs/node/commit/f3e082c4ea8c27e989b86300065149475c9bc327
#20456https://github.com/nodejs/node/pull/20456
#17665https://github.com/nodejs/node/pull/17665
#17636https://github.com/nodejs/node/issues/17636
#16482https://github.com/nodejs/node/pull/16482
#16860https://github.com/nodejs/node/pull/16860
ckerrhttps://github.com/ckerr
Jun 14, 2018 https://github.com/nodejs/node/pull/16860#ref-commit-a3e6208
https://github.com/jure
https://github.com/ckerr
src: replace SetAccessor w/ SetAccessorPropertyhttps://github.com/electron/node/commit/a3e6208fc7c9488b301ee4f37fb760aadb5cba54
a3e6208https://github.com/electron/node/commit/a3e6208fc7c9488b301ee4f37fb760aadb5cba54
nodejs/node#17665https://github.com/nodejs/node/pull/17665
nodejs/node#17636https://github.com/nodejs/node/issues/17636
nodejs/node#16482https://github.com/nodejs/node/pull/16482
nodejs/node#16860https://github.com/nodejs/node/pull/16860
ckerrhttps://github.com/ckerr
Jun 15, 2018 https://github.com/nodejs/node/pull/16860#ref-commit-f2bcc6b
https://github.com/ckerr
src: replace SetAccessor w/ SetAccessorProperty (https://github.com/electron/node/commit/f2bcc6b58293287e2a6e592bd296aa55bb37b801
#38https://github.com/electron/node/pull/38
)https://github.com/electron/node/commit/f2bcc6b58293287e2a6e592bd296aa55bb37b801
f2bcc6bhttps://github.com/electron/node/commit/f2bcc6b58293287e2a6e592bd296aa55bb37b801
nodejs/node#17665https://github.com/nodejs/node/pull/17665
nodejs/node#17636https://github.com/nodejs/node/issues/17636
nodejs/node#16482https://github.com/nodejs/node/pull/16482
nodejs/node#16860https://github.com/nodejs/node/pull/16860
nodejs/node#20456https://github.com/nodejs/node/pull/20456
nodejs/node#16272https://github.com/nodejs/node/pull/16272
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16860
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/16860/files/ddb12acdd13f7bb66eb03c61d449873ef4582dee
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16860/files/faee4df837117cb7f14c15a30f0cfcd4eb45aa9b
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/16860/files/ddb12acdd13f7bb66eb03c61d449873ef4582dee
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/16860/files/faee4df837117cb7f14c15a30f0cfcd4eb45aa9b
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/16860
https://github.com/joyeecheung
https://github.com/MylesBorins
https://github.com/jure
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.