René's URL Explorer Experiment


Title: tools: make eslint work on subdirectories by silverwind · Pull Request #1686 · nodejs/node · GitHub

Open Graph Title: tools: make eslint work on subdirectories by silverwind · Pull Request #1686 · nodejs/node

X Title: tools: make eslint work on subdirectories by silverwind · Pull Request #1686 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The old pattern didn't include files in lib/internal. This changes the pattern to directories which makes eslint apply to all subdirectories as well. related: #1685 cc: @yosuke-furukawa

X Description: The old pattern didn't include files in lib/internal. This changes the pattern to directories which makes eslint apply to all subdirectories as well. related: #1685 cc: @yosuke-furukawa

Opengraph URL: https://github.com/nodejs/node/pull/1686

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5788fdf6-979e-7f22-f078-2fe8fecc0a0c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id824C:113906:47C370:62C18C:6A514626
html-safe-nonce7e2e8eef18468b2dcc2fd3448b0712b464bd0b6c65f350e6008a07e71ccd75a8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjRDOjExMzkwNjo0N0MzNzA6NjJDMThDOjZBNTE0NjI2IiwidmlzaXRvcl9pZCI6IjY5OTg1NjYxNDU5NDgyMDY2MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9818c47a8f7a2434bb316a5a1303bb8fa784112138bf7f643e2e739f25955f25
hovercard-subject-tagpull_request:35261940
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1686/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0522fe903964d743eb3a32f80e29b135fcab65ccfe6df500d4ce0f1fd8bcd57e/nodejs/node/pull/1686
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0522fe903964d743eb3a32f80e29b135fcab65ccfe6df500d4ce0f1fd8bcd57e/nodejs/node/pull/1686
og:image:altThe old pattern didn't include files in lib/internal. This changes the pattern to directories which makes eslint apply to all subdirectories as well. related: #1685 cc: @yosuke-furukawa
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesilverwind
hostnamegithub.com
expected-hostnamegithub.com
Nonee840f405b2718e8f2d55aafa9ff27dbce17e29d0c253011d05ea0fea3c78baff
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb78565f6aa43cc5323c9935ec11b22cca7bb0a62
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1686#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1686
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1686
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1686
Reloadhttps://github.com/nodejs/node/pull/1686
Reloadhttps://github.com/nodejs/node/pull/1686
Please reload this pagehttps://github.com/nodejs/node/pull/1686
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/1686
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 978 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
silverwindhttps://github.com/silverwind
nodejs:masterhttps://github.com/nodejs/node/tree/master
silverwind:lint-internalhttps://github.com/silverwind/node/tree/lint-internal
Conversationhttps://github.com/nodejs/node/pull/1686
Commits1 (1)https://github.com/nodejs/node/pull/1686/commits
Checkshttps://github.com/nodejs/node/pull/1686/checks
Files changedhttps://github.com/nodejs/node/pull/1686/files
tools: make eslint work on subdirectorieshttps://github.com/nodejs/node/pull/1686#top
silverwindhttps://github.com/silverwind
nodejs:masterhttps://github.com/nodejs/node/tree/master
silverwind:lint-internalhttps://github.com/silverwind/node/tree/lint-internal
https://github.com/silverwind
silverwindhttps://github.com/silverwind
May 12, 2015https://github.com/nodejs/node/pull/1686#issue-75711671
#1685https://github.com/nodejs/node/pull/1685
@yosuke-furukawahttps://github.com/yosuke-furukawa
Please reload this pagehttps://github.com/nodejs/node/pull/1686
https://github.com/silverwind
tools: make eslint work on subdirectorieshttps://github.com/nodejs/node/pull/1686/commits/d70fdcaf45141bf7090729d0d7afa7901c344377
d70fdcahttps://github.com/nodejs/node/pull/1686/commits/d70fdcaf45141bf7090729d0d7afa7901c344377
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
May 12, 2015https://github.com/nodejs/node/pull/1686#issuecomment-101397082
my repl PRhttps://github.com/iojs/io.js/pull/1677
Please reload this pagehttps://github.com/nodejs/node/pull/1686
https://github.com/silverwind
silverwindhttps://github.com/silverwind
May 12, 2015https://github.com/nodejs/node/pull/1686#issuecomment-101397809
@chrisdickinsonhttps://github.com/chrisdickinson
Please reload this pagehttps://github.com/nodejs/node/pull/1686
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
May 12, 2015https://github.com/nodejs/node/pull/1686#issuecomment-101400782
@silverwindhttps://github.com/silverwind
literally includedhttps://github.com/chrisdickinson/io.js/commit/46e2d6848ef33461757a4c43939c8b3adbf10784
Please reload this pagehttps://github.com/nodejs/node/pull/1686
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
May 12, 2015https://github.com/nodejs/node/pull/1686#issuecomment-101401063
Please reload this pagehttps://github.com/nodejs/node/pull/1686
silverwindhttps://github.com/silverwind
May 12, 2015 https://github.com/nodejs/node/pull/1686#ref-commit-c58264e
https://github.com/silverwind
tools: make eslint work on subdirectorieshttps://github.com/nodejs/node/commit/c58264e58bca19a6a11314629bb93c10cddac7b5
c58264ehttps://github.com/nodejs/node/commit/c58264e58bca19a6a11314629bb93c10cddac7b5
#1686https://github.com/nodejs/node/pull/1686
https://github.com/silverwind
silverwindhttps://github.com/silverwind
May 12, 2015https://github.com/nodejs/node/pull/1686#issuecomment-101403416
c58264ehttps://github.com/nodejs/node/commit/c58264e58bca19a6a11314629bb93c10cddac7b5
Please reload this pagehttps://github.com/nodejs/node/pull/1686
https://github.com/silverwind
silverwindhttps://github.com/silverwind
May 12, 2015https://github.com/nodejs/node/pull/1686#event-303183085
https://github.com/yosuke-furukawa
yosuke-furukawahttps://github.com/yosuke-furukawa
May 12, 2015https://github.com/nodejs/node/pull/1686#issuecomment-101460898
@silverwindhttps://github.com/silverwind
Please reload this pagehttps://github.com/nodejs/node/pull/1686
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
May 13, 2015 https://github.com/nodejs/node/pull/1686#ref-pullrequest-75427061
Release proposal: v2.0.2 #1679 https://github.com/nodejs/node/pull/1679
Fishrock123https://github.com/Fishrock123
May 19, 2015 https://github.com/nodejs/node/pull/1686#ref-commit-91a9c6d
https://github.com/silverwind
https://github.com/Fishrock123
tools: make eslint work on subdirectorieshttps://github.com/Fishrock123/node/commit/91a9c6d157e66e850ffa0cb5349637918f05eb97
91a9c6dhttps://github.com/Fishrock123/node/commit/91a9c6d157e66e850ffa0cb5349637918f05eb97
nodejs#1686https://github.com/nodejs/node/pull/1686
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Aug 22, 2015 https://github.com/nodejs/node/pull/1686#ref-pullrequest-75357896
"Fix" repl race condition #1677 https://github.com/nodejs/node/pull/1677
[Snyk] Security upgrade marked from 0.3.6 to 1.1.1 GregorFendt/node#6 https://github.com/GregorFendt/node/pull/6
[Snyk] Security upgrade marked from 0.3.19 to 1.1.1 s4sc/node#15 https://github.com/s4sc/node/pull/15
[Snyk] Security upgrade marked from 0.3.19 to 1.1.1 scality/node#9 https://github.com/scality/node/pull/9
[Snyk] Security upgrade marked from 0.3.6 to 1.1.1 KamilPolivka/node#8 https://github.com/KamilPolivka/node/pull/8
[Snyk] Security upgrade marked from 0.3.19 to 1.1.1 erdun/node#25 https://github.com/erdun/node/pull/25
[Snyk] Security upgrade marked from 0.3.19 to 1.1.1 enterstudio/node#15 https://github.com/enterstudio/node/pull/15
[Snyk] Security upgrade marked from 0.6.3 to 1.1.1 adamlaska/node#39 https://github.com/adamlaska/node/pull/39
[Snyk] Security upgrade marked from 0.3.19 to 1.1.1 solebox/node#16 https://github.com/solebox/node/pull/16
[Snyk] Security upgrade marked from 0.3.6 to 1.1.1 saeedahassan/node#22 https://github.com/saeedahassan/node/pull/22
[Snyk] Security upgrade marked from 0.3.6 to 1.1.1 olegnn/node#23 https://github.com/olegnn/node/pull/23
[Snyk] Security upgrade marked from 0.3.19 to 1.1.1 pmq20/node#25 https://github.com/pmq20/node/pull/25
[Snyk] Security upgrade marked from 0.3.6 to 1.1.1 saurabharch/node#9 https://github.com/saurabharch/node/pull/9
[Snyk] Security upgrade marked from 0.3.19 to 1.1.1 mkg20001/node#22 https://github.com/mkg20001/node/pull/22
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Aug 11, 2020 https://github.com/nodejs/node/pull/1686#ref-pullrequest-676513948
[Snyk] Fix for 3 vulnerabilities turkdevops/node#11 https://github.com/turkdevops/node/pull/11
https://github.com/aliscco
alisccohttps://github.com/aliscco
Apr 25, 2023 https://github.com/nodejs/node/pull/1686#ref-pullrequest-1683559680
[Snyk] Fix for 19 vulnerabilities aliscco/alisco-node#172 https://github.com/aliscco/alisco-node/pull/172
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1686
Please reload this pagehttps://github.com/nodejs/node/pull/1686
https://github.com/silverwind
https://github.com/chrisdickinson
https://github.com/yosuke-furukawa
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.